FreeBSD git weekly: 2025-12-15 to 2025-12-21

Reviewed by:  ziaee
Relnotes:       Yes
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53840

The mq_getfd_np function appeared in FreeBSD 11 with no documentation.
This function dereferences the mqd_t as a pointer to an int.

Relnotes:               yes
MFC after:              3 days
Reviewed by:            kib (previous), markj, ziaee
Differential Revision:  https://reviews.freebsd.org/D43947

These utilities can only function correctly if implemented as shell
builtins and exist only because POSIX previously required them.  As of
POSIX 2024, they have all been reclassified as intrinsic utilities and
are no longer required to exist in PATH.  We can therefore retire them.
Cf. XBD 1.7, XRAT C.1.8, Austin Group bug 854.

Note that kill(1) is also considered an intrinsic utility (because
only the shell can interpret job IDs correctly), but we have a working
standalone implementation, which we will keep.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291686
Relnotes:       yes
Reviewed by:    imp, emaste
Differential Revision:  https://reviews.freebsd.org/D54239

These utilities can only function correctly if implemented as shell
builtins and exist only because POSIX previously required them.  As of
POSIX 2024, they have all been reclassified as intrinsic utilities and
are no longer required to exist in PATH.  We can therefore retire them.
Cf. XBD 1.7, XRAT C.1.8, Austin Group bug 854.

Note that kill(1) is also considered an intrinsic utility (because
only the shell can interpret job IDs correctly), but we have a working
standalone implementation, which we will keep.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291686
Relnotes:       yes
Reviewed by:    imp, emaste
Differential Revision:  https://reviews.freebsd.org/D54239

Reported by:  Marcin Cieslak

Reviewed by:          ziaee, imp
Differential Revision:  https://reviews.freebsd.org/D54213

Quotes in roff do not work the way quotes in shell do,
remove them from the examples to hopefully lead less people astray.

MFC after:      3 days

The LIBRARY section has been deprecated by upstream.
Show the updated usage of the Lb macro in SYNOPSIS.

Fixes:  https://cgit.freebsd.org/src/commit/?id=4c07abdbacf49 (mandoc: Vendor import of upstream at 2025-06-13)

Sponsored by: The FreeBSD Foundation
MFC after:      3 days

There are delay loops, checking the BUSY status bit, before writing to
the date or time registers. Each iteration contains a 1usec delay, for a
maximum of 70 iterations.

This is frequently not enough on the D1 platform, where the message is
emitted:

  rtc0: could not set date, RTC busy

Bump the loop delay to 10usecs each, and the maximum number of
iterations to 150, for a maximum delay of 1.5msecs between each write of
the register.

In my testing this seems to be adequate.

The loop variable is renamed for clarity/simplicity.

Reviewed by:    manu
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D54180

This change fixes two checks that conflated memory mapping and memory
segment idenitifers. In both cases the code iterates over all memory
mappings but passes the index to `vm_memseg_sysmem`, which is wrong.

Fix this by passing the memory mapping's segment identifier instead.

Differential Revision:  https://reviews.freebsd.org/D54210
Reviewed by:    markj
Fixes:  https://cgit.freebsd.org/src/commit/?id=c76c2a19ae37
PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290920

So it isn't matched by devmatch(8) and automatically loaded. The PNP
info will be readded once the USB4 driver is more complete.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290827
Reported by:    fuz, Marco Siedentopf <siedentm@me.com>
Fixes:  https://cgit.freebsd.org/src/commit/?id=2ed9833791f2 (thunderbolt: Import USB4 code)
Sponsored by:   The FreeBSD Foundation

While here, replace loop copying the MAC address with memcpy() for
better readability.

Reviewed by:    markj
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D54177

Switch interrupt type to NET so that it enters net epoch during
interrupt service routine.

Sponsored by:   CHERI Research Centre

Add PNP info so the module can be matched by devmatch(8) and automatically
loaded.

Reviewed by:    adrian
Approved by:    adrian
Differential Revision:  https://reviews.freebsd.org/D54254

The netmap_ring struct starts with various const members and rencent
clang warns about leaving them uninitialized. Having them const in the
first place is highly suspicious since they are updated with various
macros but using hand-coded __DECONST(). But fixing that is a more
invasive change that I am unable to test.

```
.../freebsd/sys/dev/netmap/netmap_kloop.c:320:21: error: default initialization of an object of type 'struct netmap_ring' with const member leaves the object uninitialized [-Werror,-Wdefault-const-init-field-unsafe]
  320 |         struct netmap_ring shadow_ring; /* shadow copy of the netmap_ring */
      |                            ^
.../freebsd/sys/net/netmap.h:290:16: note: member 'buf_ofs' declared 'const' here
  290 |         const int64_t   buf_ofs;
      |                         ^
```

Test Plan: Compiles

Reviewed by:    vmaffione, jhb
MFC after:      1 week
Differential Revision: https://reviews.freebsd.org/D52568

If the kernel panics while a thread is in the middle of an SDHCI
transaction, trying to dump to a dump target on the MMC would result in
a hang.  Fix this by completing the transaction first.

Reviewed by:    imp
Obtained from:  Hewlett Packard Enterprise
Differential Revision:  https://reviews.freebsd.org/D54255

This allows adding flags in the upper 32 bits in a consistent way.
No functional change intended.

MFC after:      1 week

vtnet: expose flags via sysctl tree

Provide the flags used for a vtnet interface via the sysctl tree.
This is mostly used for debugging purposes.

Reviewed by:            Timo Völker
MFC after:              1 week
Differential Revision:  https://reviews.freebsd.org/D54283

vtnet.4: put each sentence on its own line

Reported by:    ziaee
Fixes:          https://cgit.freebsd.org/src/commit/?id=e3a0571ad74d ("vtnet: expose flags via sysctl tree")
MFC after:      1 week

If we get a random number, the NZCV is set to 0b0000.  Then
"cset %w1, ne" will test whether Z == 0 and set %w1 to 1 if so.
More specifically, "cset %w1, ne" maps to "csinc %w1, wzr, wzr, eq",
which stores 0 in %w1 when NZCV == 0b0100 and 1 otherwise.

Thus, on a successful read we expect ret != 0, so the loop condition
needs to be fixed.  In practice this means that we would end up trying
to fetch entropy up to ten times in a row.  If all attempts are
successful, the last will be returned, otherwise no entropy will be
returned.

Reported by:    Kevin Day <kevin@your.org>
Reviewed by:    andrew
Fixes:          https://cgit.freebsd.org/src/commit/?id=9eecef052155 ("Add an Armv8 rndr random number provider")
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D54259

rss_getkey function is now available even if kernel RSS option
is disabled. This makes ice_get_default_rss_key no longer needed.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Reviewed by:    gallatin
Approved by:    kbowling (mentor)
Fixes:          https://cgit.freebsd.org/src/commit/?id=012ecdde3a810 ("ice: use newly exposed RSS hash key API rather than ad-hoc hashing")
Sponsored by:   Intel Corporation
Differential Revision:  https://reviews.freebsd.org/D54281

No need for a bespoke #define.

Right now the 64-bit flags field needs to be casted to a 32-bit field,
because clang warns if more than 32-bits are used.
Once clang is fixed, this restriction will be removed and more bits
will be added.

Reviewed by:            markj, Timo Völker
MFC after:              1 week
Differential Revision:  https://reviews.freebsd.org/D54288

Use sbuf_new_for_sysctl() instead of sbuf_new_auto() when exposing
the flags via sysctl.

MFC after:              1 week

Use MTX_SYSINIT() instead of rolling our own.

If we have both af-to and min-ttl or set-tos on a single rule we didn't
apply the new ttl or tos.

That's because the scrub code still applied the change, but we
subsequently create a new header for the new address family. That's done
based on the ttl/tos saved in the struct pf_pdesc, which are the values
from the incoming packet, before the scrub modification(s).

Also update the struct pf_pdesc values when we update packets.

Reported by:    Marek Zarychta
Sponsored by:   Rubicon Communications, LLC ("Netgate")

Reviewed by:          glebius
Differential Revision:  https://reviews.freebsd.org/D54190

This makes it easier to reason about system topology, and to
potentially map applications to NIC queues by (ab)using the
mbuf flowid to select egress NIC and queue in a predictable fashion.

Differential Revision: https://reviews.freebsd.org/D54053
Reviewed by: glebius, kbowling
Sponsored by: Netflix

bpf: modularize ifnet(9) part of bpf

Imagine that bpf(9) tapping can happen at any point in the network stack,
not necessarily at interface transmit or receive.  To achieve that we need
a thin layer of abstraction defined by struct bif_methods, that defines
how generic bpf layer works with a tap point of this kind.

Implement ifnet(9) specific methods in a separate file bpf_ifnet.c.  At
this point there is 100% compatibility for all existing interfaces, there
is no KPI change, yet.  The legacy attaching KPI is layered over new ifnet
agnostic KPI.  The new KPI may change though, as we can implement multiple
DLTs per single tap point in a prettier fashion.

The new abstraction layer allows us to move all the 802.11 radio injection
hacks out of bpf.c into ieee80211_radiotap.c, so do that immediately as a
good proof of concept.

Reviewed by:            bz
Differential Revision:  https://reviews.freebsd.org/D53872

bpf: virtualize bpf_iflist

The reason the global list worked before 8774a990ee40 is that bpf_setif()
used if_unit(), which is a VNET-aware function, and then went through the
global list looking for bpf_if with matching pointer.

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291735
Fixes:  https://cgit.freebsd.org/src/commit/?id=8774a990ee4094f16d596d4b78e0f3239e5d0c88

bpf: add a crutch to support if_vmove

Fixes:  https://cgit.freebsd.org/src/commit/?id=0bf42a0a05b9c802a6d9ca4a6b8696b29a26e08b

bpf: add missing IFT_BRIDGE in the write method

Fixes:  https://cgit.freebsd.org/src/commit/?id=8774a990ee4094f16d596d4b78e0f3239e5d0c88

When copying ipfs data from user space, don't just check that the payload
length is nonzero, but also that it does not exceed the size of the stack
buffer we're copying it into.

While we're at it, use a union to create a buffer of the exact size we
need instead of guessing that 2048 will be enough (and not too much).

Finally, check the size of the payload once it gets to where it's used.

MFC after:      3 days
Reported by:    Ilja Van Sprundel <ivansprundel@ioactive.com>
Reviewed by:    cy
Differential Revision:  https://reviews.freebsd.org/D54194

When a module the environment must be explicitly fetched.

Fixes:                  https://cgit.freebsd.org/src/commit/?id=d9788eabffa4
PR:                     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291548
Noted by:               markj
Reviewed by:            markj
Differential Revision:  https://reviews.freebsd.org/D54242
MFC after:              3 days

The ac6a7f621668 enabled execution of vlan_clone_dump_nl(), which
previously was effectively disabled.  The function itself was added back
in 089104e0e01f0.  This exposed a bug when Netlink dumps info on all
interfaces using a dangerous KPI if_foreach_sleep(), which may call its
callbacks on completely detached interfaces, hanging on the last
reference.  The ifc_dump_ifp_nl_default() is able to digest such interface
without a panic, but vlan_clone_dump_nl() can't.  Neither of the above
revisions is the actual culprit, rather it is design problem of detaching
interfaces and if_foreach_sleep().

Plug the problem with removing pointer to freed memory on detach and
making a NULL check later.

Reported by:    pho

Reviewed by:          p.mousavizadeh_protonmail.com, zlei
Differential Revision:  https://reviews.freebsd.org/D54241

We use version.map in the FreeBSD MIT KRB5 build. The exports file is
a lefteover from when the version map file was created.

MFC after:      1 week

Run the original ifnet_arrival_event before linking the interface.
Otherwise there is a race window when interface is already visible, but
not all of the protocols have completed their attach. Provide a new event
handler ifnet_attached_event, that is executed when the inteface is fully
visible.  Use it in route(4) socket and netlink(4) to announce new
interface to the userland. Properly document the ifnet events in if_var.h.

Reviewed by:            zlei, melifaro
Differential Revision:  https://reviews.freebsd.org/D54085

libpfctl doesn't notice the mismatch.

Reported by:    Kevin Day <kevin@your.org>
Reviewed by:    kp
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D54199

The DIOCGETRULES ioctl handlers has taken the write lock ever since
fine-grained locking was merged to pf, but I believe it's unneeded.  Use
the read lock instead.

DIOCGETRULENV takes the write lock as well but I believe this is only
required when clearing rule counters.  Acquire the read lock if that is
not the case.

Reviewed by:    kp, allanjude
MFC after:      2 weeks
Sponsored by:   OPNsense
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D54292

These functions take the source or destintation address indirectly from
a potentially missaligned buffer.  Rename them to refect this and to
free up the copy{in,out}ptr names.

Some of the code in question is dead code and doesn't or won't compile,
but I've changed it all for consistency.

NB: If the pointers are actually stored under aligned then this code is
broken with CHERI.

Reviewed by:    cy
Effort:         CHERI upstreaming
Sponsored by:   Innovate UK
Differential Revision:  https://reviews.freebsd.org/D54232

The new function in_delayed_cksum_o() was introduced to compute
the checksum in the case the mbuf chain does not start with the
IP header. The offset of the IP header is specified by the
parameter iph_offset.
If iph_offset was positive, the function computed an incorrect
checksum.

Reviewed by:            sobomax, tuexen
Fixes:                  https://cgit.freebsd.org/src/commit/?id=5feb38e37847 ("netinet: provide "at offset" variant of the in_delayed_cksum() API")
MFC after:              1 week
Differential Revision:  https://reviews.freebsd.org/D54269

This change adds support to iflib for drivers that want to do
transmit-side NIC ktls offload. This change does 2 things:

1) Extends the pkt info to include an optional mbuf pointer.

This gives drivers the ability to find the start of a TLS record if
they need to re-DMA part of the record to re-construct TLS state on
the NIC. This mbuf pointer is only passed when CSUM_SND_TAG is
present on the pkthdr. Note that I don't bother to inspect the send
tag on purpose; this will only be present for TLS offloaded or paced
connections

2) Allows the driver to specify how much ring padding is needed
   before the ring is considered to be full using the new isc_tx_pad
   field in if_softc_ctx.

This re-uses a field that was marked spare in 2019 via d49e83eac3baf.
Iflib initializes this to the previous value of 2 slots and allows the
driver to override it. The TXQ_AVAIL() macro has been adjusted to
subtract this padding, and uses of the macro have removed +2 from the
other side of the comparison. To avoid potential cache misses from
looking at the ifc_softc_ctx in TXQ_AVAIL(), the value is mirrored in
the txq (in an alignment hole).

Reviewed by: kbowling, kgalazka, sumit.saxena_broadcom.com, shurd
Sponsored by: Netflix
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D54274

It's a 2 * 2 * 2, not 2 * 2 * 3. We only use PF_DROP and PF_PASS, so two
rows suffices.

Sponsored by:   Rubicon Communications, LLC ("Netgate")

This should provide people a chance to remove ipfw0 and ipfwlog0 from
cloned_interfaces in their rc.conf during FreeBSD 16.x lifetime.

Differential Revision:  https://reviews.freebsd.org/D53876

When building with WITHOUT_BSNMP this result in a FreeBSD-bsnmp-dev
package with only this directory and a dependency on FreeBSD-bsnmp which
doesn't exists.

Reviewed by:    ivy
Differential Revision:  https://reviews.freebsd.org/D54235
Fixes:          https://cgit.freebsd.org/src/commit/?id=436618a427b4 ("etc/mtree: Add package tags for /usr/include")
Sponsored by:   Beckhoff Automation GMbH & Co. KG

When building with WITHOUT_TESTS this result in a FreeBSD-atf-dev
package with only this directory and a dependency on FreeBSD-atf which
doesn't exists.

Reviewed by:    ivy
Differential Revision:  https://reviews.freebsd.org/D54236
Fixes:          https://cgit.freebsd.org/src/commit/?id=436618a427b4 ("etc/mtree: Add package tags for /usr/include")
Sponsored by:   Beckhoff Automation GMbH & Co. KG

Reported by:  Kevin Day <kevin@your.org>
Approved by:    so
Security:       FreeBSD-SA-25:12.rtsold
Security:       CVE-2025-14558

bhyve's exit status codes indicate how the VM was terminated.
Unfortunately, their meaning within the source code is somewhat
unclear since they are only used as magic numbers.

Fix this by defining exit status macros and using them to replace
the magic numbers in exit(3) function calls.

Differential Revision:  https://reviews.freebsd.org/D53730
Reviewed by:    markj, corvink, emaste
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
MFC after:      3 months

This change introduces "monitor mode", a mechanism for automatically
releasing virtual machine resources when bhyve dies, bringing us
closer towards making non-root bhyve viable.
Under this regime bhyve will create a transient virtual machine using
`vmmctl`'s `VMMCTL_CREATE_DESTROY_ON_CLOSE` flag and automatically
reboot said virtual machine as long as it exits with "reboot" status.

This is done by splitting bhyve into two processes. The parent process
creates the virtual machine while the child process initializes and
runs the virtual machine. When the child exits the parent inspects
its exit status and either exits or forks again. `vmmctl` automatically
destroys the underlying virtual machine once the parent process dies.

Differential Revision:  https://reviews.freebsd.org/D53731
Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
MFC after:      3 months

Some refresh functions had two layers of 'do we need to refresh now?'
checks, leading to inconsistent refreshes.
Consolidate them.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291725
Sponsored by:   Rubicon Communications, LLC ("Netgate")

Reported by:  wosch
Tested by:      wosch
MFC after:      1 week

By default, when ifconfig shows a v6 address derived from a
router-advertised prefix, it shows the initial preferred and valid
lifetimes.  When -L is specified, it is supposed to show the remaining
lifetimes, but this was broken in the conversion to netlink.

Fix that, and add a regression test which validates ifconfig output
before and after a short-lived address expires.

Reported by:    Franco Fichtner <franco@opnsense.org>
Reviewed by:    melifaro, allanjude, Seyed Pouria Mousavizadeh Tehrani
Fixes:          https://cgit.freebsd.org/src/commit/?id=4c91a5dfe483 ("ifconfig: make interface and address listing use Netlink as transport")
MFC after:      2 weeks
Sponsored by:   OPNsense
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D54294

The RB_HALT bit is always set when invoked as `halt`, so to maintain a
distinction between `halt` and `halt -p`, we must check the RB_POWEROFF
bit first.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291814
Fixes:          https://cgit.freebsd.org/src/commit/?id=4453ec5b8716 ("reboot: Default to a clean shutdown")
Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D54320

Tested on a RX7600

MFC After:      3 days

This implementation appears to be broken on some CPUs.  Disable it
until the issue can be investigated and fixed.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291720
Fixes:          https://cgit.freebsd.org/src/commit/?id=66eb78377bf1 ("libc/amd64: fix overread conditions in stpncpy()")
Fixes:          https://cgit.freebsd.org/src/commit/?id=90253d49db09 ("lib/libc/amd64/string: add stpncpy scalar, baseline implementation")

Reviewed by:  jhb, emaste
MFC after:      1 week
Differential Revision: https://reviews.freebsd.org/D52528

This defaults to an error in clang HEAD, use a char-by-char
initializer instead.

Reviewed by:    emaste, jhb
MFC after:      1 week
Differential Revision: https://reviews.freebsd.org/D52532

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871

lib/msun/tests: xfail failing invtrig_test cases on non-x86

Replace ATF_CHECK_* with ATF_REQUIRE_* to fail fast and avoid
unexpected abort.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290099
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871

lib/msun/tests: xfail failing lrint_test cases on non-x86 archs

Replace ATF_CHECK_* with ATF_REQUIRE_* to fail fast and avoid
unexpected aborts.

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290099
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871

lib/msun/tests: xfail remaining failing tests on non-x86 archs

These are the remaining trivial xfail cases where no other
test logic changes are necessary.

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290099
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871

Reported by:  Marcos Mendoza <mmendoza@netgate.com>
See also:       https://redmine.pfsense.org/issues/16588
Sponsored by:   Rubicon Communications, LLC ("Netgate")

Added libxo support to `gpart show`, also updated the man
pages for geom and gpart to show where you can expect
libxo formatted output.

PR:                     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290629
MFC after:              1 week
Sponsored by:           ConnectWise
Reviewed by:            asomers, mckusick, phil
Approved by:            asomers (mentor)
Differential Revision:  https://reviews.freebsd.org/D53950

Sponsored by: Rubicon Communications, LLC ("Netgate")

Modeled directly after the method used by the zfs/zpool commands: flag
commands with a "please log me" flag, and when there, reconstruct the
command line. On success, call the library function to add it to the
log.

(Majority of the change by Rob; minor edits by kevans@)

Signed-off-by: Rob Norris <rob.norris@klarasystems.com>
Co-authored-by: Kyle Evans <kevans@FreeBSD.org>
Sponsored by:   Modirum MDPay
Sponsored by:   Klara, Inc.

This adds support for renaming a symbolic link found on the lower fs,
which necessitates copying it to the upper fs, as well as basic tests.

MFC after:      1 week
Sponsored by:   Klara, Inc.
Sponsored by:   NetApp, Inc.
Reviewed by:    olce, siderop1_netapp.com, jah
Differential Revision:  https://reviews.freebsd.org/D54229

Sponsored by: Klara, Inc.
Sponsored by:   NetApp, Inc.

An internet draft (expected to become an RFC someday)
https://datatracker.ietf.org/doc/draft-ietf-nfsv4-posix-acls
describes an extension to NFSv4.2 to handle POSIX draft ACLs.

This is the first of several patches that implement the
above draft.

This patch should not result in a semantics change.

These two files are broken due to Linux 6.5 DTS import.
Both of these boards have support in Linux DTS tree,
please use these DTS instead.

Removed and not fixed because of commit 949efdaa1db8

Approved by: br, manu (mentor)
Differential revision: https://reviews.freebsd.org/D54216

Differential Revision:        https://reviews.freebsd.org/D53873

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291165
MFC after:      1 week

Check that the passed object indeed has the swap type.
Accept any kind of the object lock ownership, not only for read.

Reviewed by:    alc, markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D54219

Reviewed by:  alc, markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D54219

Reviewed by:  alc, markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D54219

kern: Introduce RLIMIT_VMM

This change introduces a new per-UID limit for controlling the
number of vmm instances, in anticipation of unprivileged bhyve.
This allows ut to limit the amount of kernel memory allocated
by the vmm driver and prevent potential memory exhaustion attacks.

Differential Revision:  https://reviews.freebsd.org/D53728
Reviewed by:    markj, olce, corvink
MFC after:      3 months
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.

limits: Unbreak after RLIMIT_VMM addition

Update structures and add assertions to prevent a reoccurrence.

Fixes:          https://cgit.freebsd.org/src/commit/?id=1092ec8b3375 ("kern: Introduce RLIMIT_VMM")
Reviewed by:    bnovkov, allanjude
Differential Revision:  https://reviews.freebsd.org/D54273

This change adds the ability to tie a virtual machine's lifecycle to
a /dev/vmmctl file descriptor. A user can request `vmmctl` to destroy a
virtual machine on close using the `VMMCTL_CREATE_DESTROY_ON_CLOSE` flag
when creating the virtual machine. `vmmctl` tracks such virtual machines
in per-descriptor lists.

Differential Revision:  https://reviews.freebsd.org/D53729
Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
MFC after:      3 months

LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c

Coming vmap_pfn() implementation requires is_vmalloc_addr() to be in
the same file with other vmap-related code. Move code out from the
overcrowded file. No functional changes intended.

MFC after:      1 week
Reviewed by:    bz
Differential Revision:  https://reviews.freebsd.org/D54223

LinuxKPI: Implement vmap_pfn

Required by i915kms to support recent discrete graphics cards.

MFC after:      1 week
Reviewed by:    kib
Differential Revision:  https://reviews.freebsd.org/D54225

LinuxKPI: bump __FreeBSD_version for vmap_pfn implementation

gcc complains when building libuvmem because the last two operands of ?:
in ORDER2SIZE and SIZE2ORDER have different signs.  Add explicit casts
to address this.

Reported by:    Jenkins
Reviewed by:    alc, kib
MFC after:      1 week
Fixes:          https://cgit.freebsd.org/src/commit/?id=1ecf01065b45 ("libuvmem: usermode port of vmem(9)")
Differential Revision:  https://reviews.freebsd.org/D54268

Reviewed by:    emaste, jamie
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D54271

aq(4): Add build infrastructure

Reviewed by:    adrian
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53839

aq(4): Build on x86 only for now

It fails to build on arm64.  As it is experimental and in development
just limit it to x86 until this is fixed.

Reported by:            brd
Fixes: https://cgit.freebsd.org/src/commit/?id=75177aebf039 ("aq(4): Add build infrastructure")

net: attach IPv4 and IPv6 stacks to an interface with EVENTHANDLER(9)

This change retires two historic relics: the if_afdata[] array and the
dom_ifattach/dom_ifdetach methods.

The if_afdata[] array is a relic of the era, when there was expectation
that many transport protocols will coexist with IP, e.g. IPX or NetAtalk.
The array hasn't had any members except AF_INET and AF_INET6 for over a
decade already. This change removes the array and just leaves two pointer
fields: if_inet and if_inet6.

The dom_ifattach/dom_ifdetach predates the EVENTHANDLER(9) framework and
was a good enough method to initialize protocol contexts back then.  Today
there is no good reason to treat IPv4 and IPv6 stacks differently to other
protocols/features that attach and detach from an interface.

The locking of if_afdata[] is a relic of SMPng times, when the system
startup and the interface attach was even more convoluted than before this
change, and we also had unloadable protocols that used a field in
if_afdata[].  Note that IPv4 and IPv6 are not unloadable.

Note that this change removes NET_EPOCH_WAIT() from the interface detach
sequence.  This may surface several new races associated with interface
removal.  I failed to hit any with consecutive test suite runs, though.
The expected general race scenario is that while struct ifnet is freed
with proper epoch_call(9) itself, some structures hanging off ifnet are
freed with direct free(9).  The proper fix is either make if_foo point at
some static "dead" structure providing SMP visibility of this store, or
free those structure with epoch_call(9).  All of these cases are planned
to be found and resolved during 16.0-CURRENT lifetime.

Reviewed by:            zlei, gallatin, melifaro
Differential Revision:  https://reviews.freebsd.org/D54089

in6_ifattach: include sys/eventhandler.h to unbreak NOVIMAGE builds

LINT-NOVIMAGE fails to build due to a missing eventhandler.h include
which in hte VIMAGE case is likely leaked through some other header.
Add the #include to unbreak the build.

Fixes:  https://cgit.freebsd.org/src/commit/?id=0d469d23715d6 (net: attach IPv4 and IPv6 stacks to an ...)

Reviewed by:    emaste, markj
Fixes:          https://cgit.freebsd.org/src/commit/?id=c72188d85a79 ("racct: Improve handling of the pcpu resource")
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D54284

This will be usable after clang has been extended to accept length
modifiers for %b when compiling kernel code.
But we need FreeBSD to support it first...

Reviewed by:            markj, Timo Völker
MFC after:              1 week
Differential Revision:  https://reviews.freebsd.org/D54286

Add a version of __const_bitcount<n> which can be used to get the
numbers at compile-time when __builtin_popcountg() is not available
(see sys/compat/linuxkpi/common/include/linux/bitops.h for LLVM before
19 and gcc before 14).

Obtained from:  https://reviews.freebsd.org/D50995#1174884 by obiwac
Sponsored by:   The FreeBSD Foundation
Reviewed by:    brooks, emaste
Differential Revision: https://reviews.freebsd.org/D54301

LLVM before 19 and gcc before 14 do not support __builtin_popcountg().
Use __const_bitcount<n> from sys/bitcount.h as a replacement in these
cases.  This should still allow drm-kmod to build where the size needs
to be known at compile-time.

Remove the conditional for gcc around the iwlwifi modules build,
which was collateral damage in all this.

Sponsored by:   The FreeBSD Foundation
Fixes:          https://cgit.freebsd.org/src/commit/?id=7cbc4d875971, https://cgit.freebsd.org/src/commit/?id=5e0a4859f28a
MFC after:      3 days
Reviewed by:    brooks, emaste (without the sys/modules/Makefile change)
Differential Revision: https://reviews.freebsd.org/D54297

These were added to files.x86 because they were duplicated in both
files.i386 and files.amd64, but they did not end up removed in the
latter.  Garbage collect them now.

Reviewed by:    jhibbits
Fixes:  https://cgit.freebsd.org/src/commit/?id=b9c6fa339d9c7 ("files.x86: Pull in some more duplicate [...]")
Sponsored by:   Klara, Inc.
Sponsored by:   NetApp, Inc.
Differential Revision:  https://reviews.freebsd.org/D54295

Some drivers want the TLS seqno when offload starts. Capture this
for them by adding a union for initial_seqno, sharing space with
the TLS 1.0 next_seqno.

Reviewed by: jhb
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D54275
MFC After: 1 month

Submitted and reviewed by:    alc
Fixes:  https://cgit.freebsd.org/src/commit/?id=22cce201da76a1916be5c993201f0478f3048292
MFC after:      3 days
Differential revision:  https://reviews.freebsd.org/D54335

Add a description for WITH_IPFILTER_IPFS.

Fixes:          https://cgit.freebsd.org/src/commit/?id=0ff0c19e7f70 ("ipfilter: Disable ipfs(8) by default")

Reviewed by:  mhorne
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1916

Copy the text change from the shell makeman to makeman.lua.

Fixes: https://cgit.freebsd.org/src/commit/?id=dd8c666d8b78 ("src.sys.mk: Support src.conf in SRCTOP")
Sponsored by:   The FreeBSD Foundation

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
Reviewed by: asomers
Pull request: https://github.com/freebsd/freebsd-src/pull/1929
Sponsored by:  The FreeBSD Foundation

As we have received an external box sponsored by NetActuate we can now
enable the pre-commit tasks to be run in this box.

Once we have enabled this debug if there are any errors and after
confirmation we can enable this for other tasks too.

Sponsored by:   NetActuate
Sponsored by:   The FreeBSD Foundation

Approved by:    emaste, lwhsu
Differential Revision:  https://reviews.freebsd.org/D54220

When we are using Cirrus-CI and using a PR branch it creates a filename
in the form "pull/XXXX" which becomes a path seperator and the file
creation process fails.

Fails to complete the process with the following:
/bin/sh: cannot create
/tmp/meta.hUNGUq/ci-FreeBSD-16.0-pull/1932-amd64-nullhash-GENERIC.env:
No such file or directory

For future also apply the same regex for OSRELEASE and VOLUME_LABEL.

Reviewed by:  ziaee
Relnotes:       Yes
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53840

The mq_getfd_np function appeared in FreeBSD 11 with no documentation.
This function dereferences the mqd_t as a pointer to an int.

Relnotes:               yes
MFC after:              3 days
Reviewed by:            kib (previous), markj, ziaee
Differential Revision:  https://reviews.freebsd.org/D43947

Add jrhall@ (myself) as new src committer with imp@ as
mentor.

Reviewed By:    imp (mentor)
Approved by:    imp (mentor)
Differential Revision: https://reviews.freebsd.org/D53934

This test now consistently passes (300+ consecutive runs).

Signed-off-by:  Siva Mahadevan <me@svmhdvn.name>
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244172
Sponsored by:   The FreeBSD Foundation

This testcase passes consistently (in 100+ runs) now.

Signed-off-by:  Siva Mahadevan <me@svmhdvn.name>
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244163, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251726
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation

This is now consistently passing with 100+ consecutive runs.

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244170
MFC after:      3 days
Sponsored by: The FreeBSD Foundation

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1870

For reproducing errors or test results it is important to gather
environment information. These environments are divided into two parts.
One part is in which environment the artifacts were built into and the
second part is in which environment the tests were run.

This patch collects thesee information and saves into a .env file in
the metadir. After this patch lands we will also need to change our
jenkins job where we are uploading the artifact to a central location.
This environment file should also be stored along with the artifact.
For easier location the image basename and the environment basename are
kept same.

Approved by:    lwhsu
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D54247

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1858

MFC after:    3 days
Sponsored by:   The FreeBSD Foundation

Drop not needed cast.
Group sigchld state check as single KASSERT condition.
Remove useless comment.

Reviewed by:    des, olce
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D54234

MFC after:    3 days
Reviewed by:    ziaee
Signed-off-by:  Rob Nichols <robert.nichols@dialwave.com>
Closes:         https://github.com/freebsd/freebsd-src/pull/1928

Fix the list of devices supported by the driver: RTL8125 occured
twice, should have been RTL8127 in one case.

Approved by:    adrian

Follow the style described by style.9.

Reported by:    markj
MFC after:      1 week

No functional change intended.

MFC after:      2 weeks

Differential Revision:        https://reviews.freebsd.org/D53874

Add vendor import instructions for blocklist.

It includes a "freebsd-changes.sh" script that takes care of adapting
paths and functions into FreeBSD.

Reviewed by:    emaste
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D49510

Merge commit 'bfef098f924950a085927b1e7dd6c6db4e651c5c'

Changes:

https://github.com/zoulasc/blocklist/compare/ff13526...8a4b011

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258411
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291680
MFC after:      1 week

Upstream fixed a couple of bugs:

1. Only attempt to restore the blocking rules if the database file
   exists.  Otherwise, when the service starts for the first time, it
   fails (PR 258411).

2. Revert a commit that removed a call to close(bi->bi_fd), preventing
   the descriptor from being deleted.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258411
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291680
MFC after:      1 week

libpcap: don't try to create usbusX interfaces

libpcap: disable more code related to USB pseudo-interfaces

Fixes:  https://cgit.freebsd.org/src/commit/?id=6e297e1cdff3568da19760e7e7c615ee4e8383ef

This fixes broken test reports with the following message:

lib/msun/fe_round_test:fe_round  ->  broken: Test result contains
multiple lines: expected_failure:
/usr/src/contrib/netbsd-tests/lib/libm/t_fe_round.c:95: Didn't get the
same rounding mode out!<<NEWLINE>>(index 0) fed in 64 rounding mode, got
0 out<<NEWLINE>>  [0.079s]

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871

Replace ATF_CHECK_* with ATF_REQUIRE_* to fail fast and
avoid unexpected aborts.

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290099
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871

Merge commit '5cab380e2a2644aaa920b93f1580a1cfc803a8de'

Merge commit 'eb2ccba0c11b405ac613c3046997765317cc8b5c'

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192839
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219467
MFC after:      1 week

Notable upstream pull request merges:
 #16307 1d43387dd zdb: Add -O option for -r to specify object-id
 #17965 a62c62120 ARC: Pre-convert zfs_arc_min_prefetch_ms
 #17970 d393166c5 ARC: Increase parallel eviction batching
 #17981 20f09eae4 ZIO: ZIO_STAGE_DDT_WRITE is a blocking stage
 #17983 ff47dd35e Fix ddtprune causing space leak
 #18015 86b064469 FreeBSD: Fix a potential null dereference
                  in zfs_freebsd_fsync() (already merged)
 #18020 ff47dd35e Ensure 64-bit `off_t` is used in user space
                  instead of `loff_t`
 #18028 09492e0f2 Reduce dataset buffers re-dirtying
 #18033 f72fd378c Defer async destroys on pool import
 #18043 3d76ba273 Improve async destroy processing timing
 #18044 46d6f1fe5 DDT: Move logs searches out of the lock
 #18047 ff5414406 DDT: Switch to using ZAP _by_dnode() interfaces
 #18048 3b1ff816b DDT: Add/use zap_lookup_length_uint64_by_dnode()
 #18055 22e89aca8 DDT: Fix compressed entry buffer size
 #18059 0550abd4b RAIDZ: Remove some excessive logging
 #18060 a83bb15fc Reduce minimal scrub/resilver times
 #18061 962e68865 Use reduced precision for scan times
 #18063 051a8c749 Bypass snprintf() in quota checks if no quotas set
 #18064 7ff329ac2 Fix rangelock test for growing block size

Obtained from:  OpenZFS
OpenZFS commit: 962e68865e4a569a8a51a07a45dcae7c33cdca78

This broke the human output formatting in several ways.

This reverts commit 4cf5878d27ddc9d3ca3ed870f88112c3b4f6fb69.
This reverts commit e8d6b58ef5a4afe0d155b6967c92d55f3bbd53fe.
This reverts commit c759aca606cee8352c1d739bf7a762c8a2ed2012.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291511
Reviewed by:    imp, des
Differential Revision:  https://reviews.freebsd.org/D54196