This is a display of mostly-automatically-classified git commits from 2026-10-26 to 2026-11-01.
DEBUG: This version of the report is primarily for checking the classifiers, and therefore contains extra information (in this colour).
Table of contents and commits per category:
| (3) | Highlighted commits (these are copies, not in stats) | |
| 0 | 0.0% | Userland programs |
| 21 | 8.6% | Documentation |
| 103 | 42.2% | Hardware support |
| 27 | 11.1% | Networking |
| 12 | 4.9% | System administration |
| 16 | 6.6% | Libraries |
| 8 | 3.3% | Filesystems |
| 15 | 6.1% | Kernel |
| 14 | 5.7% | Build system |
| 1 | 0.4% | Internal organizational stuff |
| 7 | 2.9% | Testing |
| 2 | 0.8% | Style, typos, and comments |
| 9 | 3.7% | Contrib code |
| 9 | 3.7% | Reverted commits |
| 0 | 0.0% | Unclassified commits |
| 244 | 100% | total |
| Technical notes about this page |
debug: info about the automatic classification
| num | % | num changed | stage |
|---|---|---|---|
| 9 | 3.7% | 0 | 00-reverts |
| 2 | 0.8% | 0 | 01-style |
| 30 | 12.3% | 0 | 02-filenames_wildcards |
| 7 | 2.9% | 0 | 02b-filenames_wildcards2 |
| 158 | 64.8% | 0 | 03-filenames_plain1 |
| 30 | 12.3% | 0 | 04-filenames_plain2 |
| 3 | 1.2% | 0 | 05-summary-prefix |
| 5 | 2.0% | 0 | Manually-classified commits |
| 0 | 0.0% | 0 | Unclassified commits |
debug: more stats
| num | % | stage |
|---|---|---|
| 0 | 0.0% | Misclassified commits |
| 239 | 98.0% | Classified commits, no corrections |
debug: groups
| 8 | 3.3% | num in revert |
| 1 | 0.4% | num in fixes |
| 65 | 26.6% | num in consecutive |
| 74 | 30.3% | Commits in groups |
For extra visibility, these are copies of commits found in
other sections. Most (if not all) come from the commit message
containing "Relnotes:", or commits modifying
UPDATING.
Remove the "NODISTSETS" option and add a "DISTSETS" option. This option will remain, disabled by default, for the duration of the 16.x branch but will be removed in 17.0. With hat: re Relnotes: yes Differential Revision: https://reviews.freebsd.org/D60945
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Enable the FreeBSD-base repository in all of the /etc/pkg/FreeBSD.conf variants, and remove code from various install paths which enabled the repository via /usr/local/etc/pkg/repos/FreeBSD.conf. Relnotes: yes Differential Revision: https://reviews.freebsd.org/D60946
debug: Commit manually moved from "unknown" to "build".
Bump new USB changes. Also, update RELNOTE and UPDATING. Sponsored by: The FreeBSD Foundation
debug: Commit manually moved from "unknown" to "build".
Commits about commands found in man section 1 (other than networking).
-- no commits in this category this week --
Man pages, release notes, etc.
manpages: Fix unusual Xr order
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
manpages: Fix unusual Xr order
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
manpages: Fix unusual Xr order
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
manpages: Fix unusual Xr order
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
manpages: Fix unusual Xr order
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
manpages: Fix unusual Xr order
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
manpages: Fix unusual Xr order
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
manpages: Fix unusual Xr order
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
In-tree Clang is unaware of the N2680 fixed-width modifier `w` and emits a warning when used. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299631 Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D60939
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Currently our man(1) utility search manages only in $lang_country.$charset, $lang.$charset and, as failover, in en.$charset which is historical behavior. But nowadays most of ported software uses only $lang subdirectories for translated manpages instead of use full locale notation, for example, share/ja/man1, share/de/man1, share/ru/man1. In such cases, our man(1) utility cannot find any translated manpages and silently fallback to english version. Add $man_lang in search path allows man(1) search and use translated manpages under historical and modern path traditions MFC after: 1 day MFC to: stable/15 stable/14 Reviewed by: ziaee, fernape Approved by: fernape Differential Revision: https://reviews.freebsd.org/D55805
debug: classified in
03-filenames_plain1 by
'usr.bin/man/'
Fix wrong usage of .Fn macro in paragraph for `memset_explicit' that caused too many commas improperly emitted into rendered manual page. Approved by: des MFC after: 1 week
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
hccontrol(8) lists "LE_Set_Scan_Parameters" as a subcommand, but it does not work on recent releases. Use the LE_Set_Scan_Param instead as that seems to be the new name according to the source file. Update the man page accordingly. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=300178 Event: Oslo Hackathon 2026
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
The command interpreter has lots of keyboard bindings documented in editline(7), the line editing interface. This is kind of arcane lore, but adding it to this listing of section 7 pages will help it get seen. MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D60854
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
The RTL8168, RTL8169 and RTL8110 are PCI/PCIe Ethernet controllers supported by re(4), and the RTL8211 is a standalone gigabit PHY. None of these are supported by ure(4). The list appears to come from rgephy(4), which drives the internal PHY on some ure-supported devices. Fixes: https://cgit.freebsd.org/src/commit/?id=76ed6f2db316 ("ure.4: add a HARDWARE section + add RTL8156BG as a compatible controller") Reviewed by: Kenneth Raplee <kenrap@kennethraplee.com> Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D61061
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Hardware drivers and architecture-specific code.
Testing on a Dell AMD Ryzen AI 5 PRO 435 laptop shows that the same diagnostic information is valid. Reviewed by: obiwac Sponsored by: The FreeBSD Foundation
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Krackan Point has the same quirks as the Phoenix SMU it would seem. Reported by: emaste Sponsored by: The FreeBSD Foundation
debug: classified in
03-filenames_plain1 by
'sys/dev/'
When the kernel is started directly by SBI firmware, locore.S maps only the 1GB region that contains the kernel, and initriscv() reads the DTB through that mapping at the physical address passed in a1. If the firmware put the DTB in another 1GB region, as QEMU does with more than 1GB of RAM, fake_preload_metadata() faults before the console is up and the kernel hangs. Also map the 1GB region that contains the DTB. This fixes direct kernel booting without FreeBSD loader(8). PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299088 Reviewed by: mhorne Fixes: https://cgit.freebsd.org/src/commit/?id=bfb857546984 ("riscv: Construct an identity map in locore.S") MFC after: 1 week Signed-off-by: Rick Richard <rick@sloservers.com>
debug: classified in
03-filenames_plain1 by
'sys/riscv/'
The diagnostics array contained expected modules to be loaded but the checking logic checked for if a devclass of that name existed instead. Have the diagnostics array contain the devclass instead as well as the module to load for the hint string. Furthermore, check tha the number of devices is greater than 0 so that leftover devclasses from unloaded modules don't skip the hint. Reported by: emaste Reviewed by: emaste Fixes: https://cgit.freebsd.org/src/commit/?id=758578370f6b ("amdsmu: Hints on what to do if IP block blocking S0i3") Sponsored by: The FreeBSD Foundation Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/70
debug: classified in
03-filenames_plain1 by
'sys/dev/'
ocs_fc: Harden ioctl, XRI lookup and FCP command validation Fix several issues found by security review of the driver. ioctl: - Require PRIV_DRIVER for all ocs ioctls and create the device node with mode 0600, group wheel. - Return the error from ocs_process_sli_config() to the caller. Previously only ENXIO was propagated, so a failed validation or a failed copyin() still issued the mailbox command, in the latter case with a descriptor pointing at freed memory. - Reject COMMON_WRITE_OBJECT when in_bytes exceeds desired_write_length, and cap WRITE_OBJECT, READ_OBJECT, READ_OBJECT_LIST and non-embedded mailbox buffers at OCS_MAX_DMA_ALLOC, returning EINVAL. - Use a 64-bit size for the non-embedded mailbox buffer to avoid truncation of a user supplied length. - Refuse to copy out more than the size of the DMA buffer allocated for the command. - Range check the BAR offset in the ECD helper ioctl. HW: - Range check the XRI in ocs_hw_io_lookup() and return NULL when it is out of range. Handle a NULL return in the auto xfer ready command and data paths (returning the RQ buffers in the former), and in ocs_hw_reclaim_xri(). - Make ocs_ref_get_unless_zero() atomic. FCP: - additional_fcp_cdb_length is in 4-byte words, but ocs_validate_fcp_cmd() added it to the expected payload length as bytes, so the length check under-validated the received frame. - Drop commands with a CDB longer than CAM_MAX_CDBLEN instead of passing a truncated CDB to CAM. MFC after: 1 week Sponsored by: Broadcom Reviewed by: ken
debug: classified in
03-filenames_plain1 by
'sys/dev/'
ocf_fc: Fix up max() usage max() truncates its parameters to 32-bit integers. Reviewed by: ram Sponsored by: The FreeBSD Foundation Fixes: https://cgit.freebsd.org/src/commit/?id=26081296b244 ("ocs_fc: Harden ioctl, XRI lookup and FCP command validation")
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Fix three unrelated problems found by security review of the driver.
ECD helper ioctl:
- OCS_ECD_HELPER_CFG_READ* and OCS_ECD_HELPER_CFG_WRITE* passed a user
supplied offset straight to pci_read_config() and pci_write_config().
Reject accesses that extend past PCIE_REGMAX, so that a wide access
starting in range cannot run past the end of config space.
- Use the real access width (1, 2 or 4 bytes) of the command for both
the BAR and the config space checks, rather than assuming 4 bytes, so
that narrow accesses at the very end of the BAR or config space are
not rejected while wider ones remain bounded.
PRLI:
- When a PRLI carries an FC-4 type other than the one the driver
supports, ocs_d_send_prli_rsp() sent an LS_RJT and started node
shutdown, but then fell through and sent a second response on the same
IO (another LS_RJT, or a PRLI LS_ACC when the initiator is accepted),
followed by a conflicting transition to __ocs_d_device_ready. The two
responses posted two WQEs for one IO and caused a double ocs_ref_put(),
a use after free of the ELS IO. Return after dispatching the LS_RJT so
that exactly one response is sent.
- __ocs_d_port_logged_in calls ocs_d_send_prli_rsp() without checking
the FC-4 type, so any port that has completed a PLOGI can trigger this
with a single PRLI, whether or not target mode is enabled.
Management:
- The active profile id is a uint32_t that is formatted as "0x%02x"
with sprintf() into a buffer of MAX_PROFILE_LENGTH (5) bytes, which
overflows for any id above 0xff. Size the buffer for the longest
possible string ("0x" plus 8 hex digits and the terminating NUL) and
use ocs_snprintf().
- Use ocs_snprintf() for nv_wwpn as well, as nv_wwnn already does.
MFC after: 1 week
Sponsored by: Broadcom
Reviewed by: ken
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Since 3107b952f534 ("sound: Merge PCM_ALIVE() with PCM_REGISTERED()"),
pcm_unregister() is gated on PCM_REGISTERED(), so it cannot run unless
pcm_register() has already succeeded, which means drivers will leak
resources if a failure happened prior to this.
Reintroduce PCM_ALIVE(), but test dev rather than the lock. pcm_init()
assigns dev before anything else, so it can tell us whether pcm_init()
has run or not. Make sure to clear it in pcm_unregister() so that a
second call to pcm_unregister() cannot double-free.
While here, publish to sndstat(4) only once pcm_register() has
succeeded.
Reported by: jah
Fixes: https://cgit.freebsd.org/src/commit/?id=3107b952f534 ("sound: Merge PCM_ALIVE() with PCM_REGISTERED()")
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Reviewed by: jah, markj
Differential Revision: https://reviews.freebsd.org/D60801
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Fixes: https://cgit.freebsd.org/src/commit/?id=6e93f5e4d693 ("amd64: FRED support") Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
Fixes: https://cgit.freebsd.org/src/commit/?id=c6d7235ac15d ("amd64: handle #AC in kernel mode") Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
amd64: do not allow to set IOPL to 3 when FRED is used SDM requires that IOPL is zero when returning to usermode with ERETU. Do not set rflags.iopl for FreeBSD io(4) open. This might be changed to disallow io(4) open for FRED at all with a knob, if there is a real need. Return ENOSYS from linux iopl(2), apparently Linux kernel can be configured without iopl(2) support, so linux programs should be prepared for this error. Return EINVAL from vt(4)/syscons(4) ioctl(KDENABIO). Fixes: https://cgit.freebsd.org/src/commit/?id=6e93f5e4d693 ("amd64: FRED support") Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by '['sys/amd64/',
'sys/dev/']'
amd64: fixes for register handling of syscall entry for FRED - Save %r10 into tf_rcx. This is the location for the 4th arg. libsys stubs do 'movq %rcx, %r10' so the fast syscall path works as is. But Go binaries directly put arg 4 into %r10. Also save %r11 into tf_r11 for the duration of syscall handler. - Somewhat improve binary compatibility with IDT SYSCALL fast return, by copying userspace return %rip into %rcx, and %rflags into %r11, emulating SYSCALL IDT delivery. Fixes: https://cgit.freebsd.org/src/commit/?id=6e93f5e4d693 ("amd64: FRED support") Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
amd64: do not pass SYSENTER frame to FRED fast syscall handler With FRED, SYSCALL is delivered as event type syscall (7) and vector 1. SYSENTER is syscall with vector 2. Handle SYSENTER in slow path, otherwise 32bit code is able to execute 64bit syscalls. Also check that SYSCALL comes from the 64bit mode. Intel already specifies that SYSCALL causes #UD in compatibility mode, but there is no AMD specification for SYSCALL under FRED yet, and SYSCALL is allowed in compatibility mode on AMD with IDT event delivery. Fixes: https://cgit.freebsd.org/src/commit/?id=6e93f5e4d693 ("amd64: FRED support") Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
amd64: Make the SYSENTER and INTn action same as for IDT case. Fixes: https://cgit.freebsd.org/src/commit/?id=6e93f5e4d693 ("amd64: FRED support") Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
MFC after: 1 week Sponsored by: The FreeBSD Foundation
debug: classified in
03-filenames_plain1 by
'sys/dev/'
For FRED SYSCALL calls, check that the LM bit is set. Note that this handler is redundant for 64bit mode since syscalls are handled by the asm fast path. Intel CPUs raise #UD for SYSCALL in the compatibility mode, and for AMD we set up the MSR_CSTAR to fast_syscall32 for IDT case, which is nop. So practically it should only matter if AMD CPUs with FRED enabled allow SYSCALL from compatibility mode. Reported and reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
Add support for the SMBus Block Process Call (bpcall) command. This command writes a block of data to a slave device and reads a block of data back in a single transaction, as defined in the SMBus 2.0 specification. Add the SMB_BPCALL ioctl to the smb(4) character device to allow userspace to issue Block Process Call transactions. Implement ichsmb_bpcall() for the ICH SMBus controller using the 32-byte block buffer mode. Older ICH variants (ICH, ICH0, ICH2, ICH3) that lack the block buffer feature will return SMB_ENOTSUPP. The PIIX4 compatible hardware (intpm) does not support Block Process Call at all and returns SMB_ENOTSUPP unconditionally. This has been tested on several Beckhoff Industrial PCs using real SMBus hardware. It has been tested on Tigerlake, Elkhart and Amstonlake Platforms. Signed-off-by: YannickV <Y.Vossen@beckhoff.com> Reviewed by: adrian, corvink, ziaee (manpages) Pull Request: https://github.com/freebsd/freebsd-src/pull/2305
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Pass #MC and #DF directly to corresponding handlers, avoiding EFI pcb_onfault case. If a fault occurs while kdb/ddb is active, handler must call kdb_reenter() and not do the normal processing, which typically ends up in panic() for kernel-mode faults. But #MC and #DF should be excluded there as well. NMI is not an exception, it is delivered as specific event. Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
%cr4 has the FRED enable bit. This only matters for NMI and #MC, and the kernel is really not ready to handle them while in resumectx(), but do it for formal correctness. Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
amd64 FRED: mark trap frame as initialized for KASAN/KMSAN Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
amd64 FRED: clear %dr6 on #DB from kernel Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
amd64 FRED: no need to store fs/gsbase on user_fred_not_syscall path The stores are only relevant for PCB_FULL_IRET return to userspace, and setting the flag stores the bases into the pcb anyway. Also, the hidden issue is that FRED already did implicit SWAPGS on entry, so stored gsbase was wrong anyway. Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
amd64 FRED: add missed newline in the diagnostic Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
amd64 FRED: re-wrap the comment Fixes: https://cgit.freebsd.org/src/commit/?id=837bb27c93a5 ("amd64 FRED: clear %dr6 on #DB from kernel") Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
Assembler accesses 'fred' as byte, ensure that any non-zero user-provided value works. This is pure cosmetics. Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
ena: Limit IO IRQ setup loop to active queues only The loop in ena_request_io_irq() iterated over adapter->msix_vecs, which reflects the maximum number of MSI-X vectors allocated at init time. When the number of IO queues is reduced at runtime via the io_queues_nb sysctl, msix_vecs is not updated, causing the driver to bind interrupts and log CPU affinity for queues that no longer exist. Replace the loop bound with ENA_IO_IRQ_IDX(adapter->num_io_queues) to iterate only over the currently active IO queues. Also replace the loop in ena_free_io_irq() the same. Reviewed by: cperciva Fixes: https://cgit.freebsd.org/src/commit/?id=56d41ad5fe9c ("Add sysctl node for ENA IO queues number adjustment") MFC after: 3 days Sponsored by: Amazon, Inc.
debug: classified in
03-filenames_plain1 by
'sys/dev/'
ena: Retrieve RSS table size from device The current driver assumes a default RSS table size of 128 entries, expecting the device's RSS table size to match this assumption. This patch allows the driver to create RSS indirection table with the size advertised by the device. Reviewed by: cperciva MFC after: 3 days Sponsored by: Amazon, Inc.
debug: classified in
03-filenames_plain1 by
'sys/dev/'
ena: Reinit RSS table on device restore when queue count shrinks When ena_restore_device() is called after a reset, pci_alloc_msix() may return fewer MSI-X vectors than requested, causing num_io_queues to shrink. When this happens, the RSS indirection table retains entries referencing queues that no longer exist, routing packets to non-existent queues and causing connectivity loss. Extract ena_set_io_queue_count() to pair the queue count update with ena_com_rss_destroy(), ensuring the RSS table is always invalidated when the queue count changes. Use it from both ena_update_io_rings() and ena_restore_device(). Reviewed by: cperciva Fixes: https://cgit.freebsd.org/src/commit/?id=e2735b095b7e ("Fix assumptions about number of IO queues in the ENA") MFC after: 3 days Sponsored by: Amazon, Inc.
debug: classified in
03-filenames_plain1 by
'sys/dev/'
ena: Fix RSS not working after driver reload When reloading the driver (kldunload/kldload), ena_rss_init_default_deferred() is called before ena_attach() completes. At this point, devclass_get_softc() returns NULL for all devices because the adapter structs have not been populated yet. As a result, ena_rss_init_default() is never called and ENA_FLAG_RSS_ACTIVE is never set. Later, in ena_up_complete(), the code checks the flag, finds it unset, and skips ena_rss_configure() entirely. RSS is never initialized, and all traffic is directed to queue 0. Remove the ENA_FLAG_RSS_ACTIVE gate in ena_up_complete() and always call ena_rss_configure(), which initialises the table when tbl_log_size is zero. The deferred SYSINIT is now redundant, so remove it. Reviewed by: cperciva Fixes: https://cgit.freebsd.org/src/commit/?id=9b8d05b8ac78 ("Add support for Amazon Elastic Network Adapter (ENA) NIC") MFC after: 3 days Sponsored by: Amazon, Inc.
debug: classified in
03-filenames_plain1 by
'sys/dev/'
In ena_sysctl_rss_indir_table(), the code dereferenced indir->sysctl_buf before checking whether indir itself is NULL. Move the NULL check above the dereference so the early-return path fires before any access through indir. Reviewed by: cperciva Fixes: https://cgit.freebsd.org/src/commit/?id=6d1ef2abd330 ("ena: Implement full RSS reconfiguration") MFC after: 3 days Sponsored by: Amazon, Inc.
debug: classified in
03-filenames_plain1 by
'sys/dev/'
The io_queues_nb sysctl is writable while the interface is down, and setting it destroys the RSS components. When the interface is not UP nothing reinitialises them, so the indirection table is left referencing queues that no longer exist until the next ifconfig up. Call ena_rss_configure() after the queue count changes when the interface is down. When it is up, this happens through ena_up(). This can configure RSS twice if the interface is brought up afterwards, costing three redundant admin commands. That is preferred over changing ena_up(), which the reset path also uses. Reviewed by: cperciva Fixes: https://cgit.freebsd.org/src/commit/?id=56d41ad5fe9c ("Add sysctl node for ENA IO queues number adjustment") MFC after: 3 days Sponsored by: Amazon, Inc.
debug: classified in
03-filenames_plain1 by
'sys/dev/'
New Features: * Retrieve RSS indirection table size from device Bug Fixes: * Limit IO IRQ setup loop to active queues only * Reinit RSS table on device restore when queue count shrinks * Fix RSS not working after driver reload * Fix NULL deref before NULL check in RSS sysctl * Reinit RSS components during queue count change flow Minor Changes: * Fix ENA_MEM_FREE_COHERENT with an expression size argument Reviewed by: cperciva MFC after: 3 days Sponsored by: Amazon, Inc.
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Do not fall back to lapic_handle_intr(). Ignore the interrupt from the range same as it is done by apic_vector.S:spuriousint. Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
Userspace INT {3, 4, 0x92} have DPL 3 gate in IDT, so enable them for
FRED as well, matching the IDT action.
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
rk_pinctrl: Fix the drive strength of the RK3568 pins The drive strength of the RK3568 pins was never programmed. The drive-strength property was tested with OF_getencprop() == 0 but that function returns the size of the property on success, so the branch was dead code and the pins kept whatever the previous stage of the boot left in the registers. The register layout was also wrong: each pin has an 8 bits wide drive field and a register holds two pins, but the value was shifted by pin % 2 bits instead of (pin % 2) * 8 and the mask only covered six bits. An odd pin would have overwritten part of the field of the even pin next to it. Test the size of the property, put the field at (pin % 2) * 8 and write the whole 8 bits, like Linux does. Tested on a Quartz64 Model A and on a NanoPi R5S. Reviewed by: mmel
debug: classified in
03-filenames_plain1 by
'sys/arm64/'
rk_pinctrl: Limit the RK3568 drive strength to the 8 bits field A drive-strength above 7 made the value wider than the 8 bits field. On an odd pin the extra bits set the write enable of the even pin next to it, which was then cleared. Limit the level to 7, where the field is full, like Linux. Reported by: markj Fixes: https://cgit.freebsd.org/src/commit/?id=e8f8b17c3018
debug: classified in
03-filenames_plain1 by
'sys/arm64/'
rk_pinctrl_parse_drive(), used for every Rockchip SoC but the RK3568, could never succeed and so the drive-strength of the pins was never programmed: - OF_getencprop() returns the size of the property, but the result was tested against 0. A present property made the function return an error. - The register offset of the matching table entry was never returned, so the caller used whatever was left in reg (the pull register or an uninitialized value). Fixing only the first problem would have written the drive value in the wrong register. - The table lookup skipped an entry only if both the bank and the subbank differed, so an entry matching only one of them could be used. Test the size of the property, skip an entry if either the bank or the subbank differs and return the offset of the entry. Tested on a Rock64 (RK3328) by clearing the drive strength of the gmac pins in U-Boot: without this change they stay at 2mA, with it they get the 4mA and 8mA of the DTS and the rest of the GRF is unchanged. On a RockPro64 (RK3399) the registers are unchanged, no pin of its default DTS is in the tables of this driver that has a drive-strength. Not tested on RK3288. Note that the RK3399 tables only cover GPIO0 and GPIO1. The other banks, which have 3 bits per pin on some groups, are still not handled. Reviewed by: mmel
debug: classified in
03-filenames_plain1 by
'sys/arm64/'
The timeout in ufshci_sim_find_periph() is uint64_t, making the comparison of timeout - ticks with zero always false. If the requested peripheral does not become available, the lookup can wait indefinitely. Use an sbintime_t deadline based on sbinuptime() and mstosbt(), and compare the current uptime directly with the deadline. Preserve the successful lookup path and existing timeout cleanup. On an HP 15-fd0118ca with Intel N150 and Samsung UFS 3.1 storage, a kernel built from stable/15 revision 84aa3cb3204d with this change logged the missing-WLUN timeout, attached da0 and mounted root in two boot trials. Signed-off-by: Denis Lemire <denis@lemire.name> Reviewed by: jaeyoon Fixes: https://cgit.freebsd.org/src/commit/?id=31407551c3d4 ("ufshci: Add a check for WLUN during driver initialization") MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/2520
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Add clknode_get_phase/clknode_set_phase (and the clk_get_phase and clk_set_phase consumer API) so that clocks which can shift their phase, such as the MMC sample and drive clocks of some SoCs, can expose it. Reviewed by: mmel Differential Revision: https://reviews.freebsd.org/D60883
debug: classified in
03-filenames_plain1 by
'sys/dev/'
clk: rockchip: Add the MMC phase clock Add a clock node type for the Rockchip MMC sample and drive clocks. These clocks have a phase in degrees controlled by a delay line and a fine-grained phase selector, and implement the new clknode phase methods. Reviewed by: mmel Differential Revision: https://reviews.freebsd.org/D60886
debug: classified in
03-filenames_plain1 by
'sys/dev/'
clk: add config(5) entry for `rk_clk_mmc.c` This is needed in order to unbreak the build on armv7. Reported by: Jenkins Fixes: https://cgit.freebsd.org/src/commit/?id=e32b082ba28b ("clk: rockchip: Add the MMC phase clock")
debug: classified in
03-filenames_plain1 by
'sys/arm/'
When VIRTIO_NET_F_MTU is negotiated, virtio_net_config.mtu specifies the maximum MTU the driver may use. vtnet_ioctl_mtu() enforces this limit for subsequent MTU changes, but ether_ifattach() unconditionally initializes the interface MTU to ETHERMTU (1500). So a device advertising a maximum below 1500 starts with an MTU above its limit. So make sure to set the initial MTU no larger than vtnet_max_mtu. That is, for vtnet_max_mtu less than 1500 interface MTU will be set to this value, otherwise the current behaviour is preserved, MTU will be set to 1500. Reviewed by: kfv, tuexen Sponsored by: The FreeBSD Foundation MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60980
debug: classified in
03-filenames_plain1 by
'sys/dev/'
amd64 FRED: get out of NMI blocking mode unconditionally When NMI interrupted userspace (ring 3), unconditionally unblock NMI, not only for the pmc backtrace sampling. Return to userspace needs to deliver ASTs and do userret(), which should not be done with NMIs blocking. Note that NMI from ring 3 is always delivered at stack level 0, i.e. the thread's kernel stack. Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
amd64 FRED: use symbolic constant for the NMI unblocking bit for ERETS Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
amd64 FRED: enable interrupts after user EXTINTs and NMIs This is needed to run userret() with interrupts enabled. Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
10BASE-T1S is a Single Pair Ethernet (SPE) standard, intended for automotive and industrial applications. It supports a multidrop "mixing segment" of at least 25m with up to 8 nodes. This driver currently does not support per-silicon-revision config or PHY-Level Collision Avoidance (PLCA), but is sufficient for establishing basic connectivity. Device details are available in the "Microchip LAN8670/1/2 10BASE-T1S Ethernet PHY Transceiver Datasheet". Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D60979
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Reviewed by: adrian Sponsored by: The FreeBSD Foundation
debug: classified in
03-filenames_plain1 by
'sys/dev/'
PMC_CLASS_PERF (0x1a) was added after PMC_CLASS_RAPL, but PMC_CLASS_LAST was left at PMC_CLASS_RAPL. Signed-off-by: Osvaldo Janeri Filho <ojanerif@amd.com> Reviewed by: Anderson Nascimento <anascime@amd.com>, mhorne Fixes: https://cgit.freebsd.org/src/commit/?id=5369f8e73eff ("hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs") Sponsored by: AMD Differential Revision: https://reviews.freebsd.org/D60546
debug: classified in
03-filenames_plain1 by
'sys/sys/pmc.h'
Commit eb7e25b22f1 ("ifmedia changes:") added SIOCGIFXMEDIA for extended
Ethernet media subtypes, but uether_ioctl() was not updated to pass it
to ifmedia_ioctl(). I believe no existing USB Ethernet devices used
extended subtypes, so this went unnoticed.
Without SIOCGIFXMEDIA ifconfig falls back to SIOCGIFMEDIA, which maps an
extended subtype to IFM_OTHER, and ifconfig reports "Ethernet Other."
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D60779
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Use rss_gethashconfig() to select MRQC hash fields in both the em and igb multiqueue paths, including kernels built without options RSS. igb previously enabled UDP four-tuple hashing unconditionally, while the stack defaults to hashing only the addresses unless net.inet.rss.udp_4tuple is enabled. Honor that setting and include the configured IPv6 extension-header address hash. Limit the 82574 mapping to its supported fields. Its TCP/IPv6 selector is bit 18, named IPV6_TCP_EX in the shared definitions; bit 21 and the UDP selectors are reserved. Its default field selection is unchanged. MFC after: 3 days Sponsored by: BBOX.io
debug: classified in
03-filenames_plain1 by
'sys/dev/'
The SIOCGIFXMEDIA ioctl is uesd to report extended Ethernet media subtypes. ure(4) commit d4cf41a99b40 added support for some newer devices and added a special case to call ifmedia_ioctl() instead of uether_ioctl() for those devices, but only for SIOCGIFMEDIA and SIOCSIFXMEDIA. Fixes: https://cgit.freebsd.org/src/commit/?id=d4cf41a99b40 ("Add support for RTL8153B, RTL8156 and RTL8156B to if_ure(4).") Reviewed by: kbowling Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D61049
debug: classified in
03-filenames_plain1 by
'sys/dev/'
tpm: Validate TIS 1.2 IRQs and quiesce delivery before teardown The TIS 1.2 driver uses the IRQ resource value directly as the four-bit LPC SIRQ selector in TPM_INT_VECTOR, without validating it before narrowing. Add the missing range check on the full resource value and use polling for routes outside 1 through 15. This restriction reflects the driver's current routing support: parent interrupt numbers need not equal LPC SIRQ channels. Attach also installs a handler when the chip's quirks select polling. Release the IRQ resource when initialization selects polling. Retain an interrupt cookie only after successful setup and require it for interrupt waits. Share verified interrupt masking across initialization, resume, and detach. Quiesce after draining cdev methods and before removing a handler, including polling devices whose failed resume left firmware delivery on. Preserve an owned locality until the existing abort path discards any pending response. Report quiesce failures while completing detach cleanup. Diagnose a failed initialization-time disable in the attach context, even when the cleanup retry succeeds. Lifecycle locality acquisition uses the bounded timeout without PCATCH so signals cannot interrupt masking; command-path acquisition remains interruptible. Cancel timed-out or interrupted locality requests, including requests made by the ISA probe, so a late grant cannot leave locality reserved. A device whose global enable does not read back cleared now fails attach instead of publishing a cdev, and fails resume instead of accepting new commands. Initialization's existing requirement to acquire locality is unchanged. The separate legacy Atmel transport is unaffected. Tested by: jrm MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59653
debug: classified in
03-filenames_plain1 by
'sys/dev/'
tpm: Validate firmware interrupt routes and fall back cleanly A host IRQ resource is not necessarily an LPC SIRQ selector. Let the frontend configure the route: ACPI uses the allocated _CRS interrupt and _SRS when present, preserving the firmware selector, while ISA supplies a separate, range-checked SIRQ. Match trigger and polarity to the host route and TPM capabilities, including opaque INTRNG resource mappings. Pass the firmware descriptor unchanged to _SRS; apply the x86 ISA polarity override only when computing the TPM mode. ISA chips without rising-edge support now poll instead of substituting a level mode for the host route. For both FIFO drivers, require a complete GetRandom transport response and a fresh DATA_AVAIL interrupt before selecting interrupt waits. Perform the test with polling before publishing the device, and repeat it after resume. During cold boot, defer the test and publication to an interrupt configuration hook so the IRQ grace wait can sleep and the handler can run. Drain the hook before teardown; failed deferred initialization remains unpublished and can be detached safely. Missing or failed routes release the handler and IRQ resource; TPM 1.2 handler-setup failure now also falls back to polling. Use monotonic deadlines for TPM 1.2 locality, status and burst polling. Keep lifecycle locality waits uninterruptible, propagate command signal errors, and terminate transfers when the burst wait expires instead of retrying a zero burst indefinitely. Check VALID with the requested status bits and retain bounded polling response retries. Interrupt waits retain their original single-timeout budget and error return. Arm only DATA_AVAIL before GO. Mask delivery on the first interrupt and before relinquishing locality, preventing idle and repeated-source storms. Bound interrupt sleeps so lost delivery can recover the current command through polling. Defer unexpected-source cleanup to a task that can acquire locality, and drain it before destroying driver locks. Preserve an unread TPM 1.2 response when quiescing an already owned locality. If the ithread cannot mask the TPM, yield for a tick with the host source masked so a level storm cannot starve the command owner or cleanup worker. Register INTR_SLEEPABLE | INTR_EXCL for both drivers, and reject firmware shared routes before installing a handler. Such routes now poll: FreeBSD does not allow sleepable shared handlers. Drain maskable events during firmware programming without letting them validate or reject the IRQ test. Retain the initial hardware-quiesce guarantee, including after _SRS: initialization fails when delivery cannot be disabled, and a later unrecoverable quiesce failure suspends command access. Known TPM 1.2 NOINTS quirks and the TPM 2.0 polling hint remain effective. Frontends without an explicit route method use polling. Tested by: jrm (tpm 1.2 tis) MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59657
debug: classified in
03-filenames_plain1 by
'sys/dev/'
tpm: Tie exclusive-open cleanup to the file lifetime Use a cdevpriv destructor to abort an unfinished TPM 1.2 transaction and release exclusive-open ownership. Register it before setting TPM_OPEN so a failed registration leaves the device available. The last reference to the successful open triggers cleanup, including after dup() or fork(). Suggested by: kevans MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59812
debug: classified in
03-filenames_plain1 by
'sys/dev/'
tpm: crb: Improve ACPI control and buffer addresses The TPM2 ControlAddress identifies the control area, not necessarily a PTP locality block. Hyper-V exposes a start-method-7 control area at the beginning of its ACPI memory resource, with command and response buffers in separate reserved memory pages. Assuming control registers are at resource + 0x40 instead writes CANCEL as LOC_CTRL and fails attach. Map the control area using ControlAddress and map buffers using their reported physical addresses. Reuse the resource mapping for contained ranges and track ownership of independent mappings for cleanup. Request locality only when the resource contains the preceding 64-byte PTP header. Keep the existing Pluton notification callbacks and locality behavior for that layout. Control, locality, and buffer accesses use their respective mappings directly, without the tpm_bus accessor class. Bound transfers by the mapped buffer sizes and TPM_BUFSIZE. Clamp an overstated buffer that starts within the ACPI resource to its remaining extent, while requiring room for a complete response header. Keep strict control-area bounds and the shared-buffer size consistency check. Write locality and state requests directly and wait for the corresponding CTRL_REQ bit to clear. The old ready wait instead tested the fatal-status bit in CTRL_STS. Enter ready state before reading buffer configuration, and check fatal status again before reading a response, while locality is still held. Retain common error cleanup and diagnose attach-time idle transition failures without replacing an earlier error. These layouts and register semantics are defined by TCG ACPI 1.5 Table 7 and PC Client PTP 1.03 sections 5.5.3.1, 5.5.3.4, and 5.5.3.5. Validation: a Windows Server 2025 Hyper-V FreeBSD guest attached and passed manufacturer queries, 700 GetRandom/PCR_Read pairs, concurrent clients, five detach/reattach cycles, and device suspend/resume with entropy harvesting active. MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59786
debug: classified in
03-filenames_plain1 by
'sys/dev/'
tpm: Harvest entropy from TPM 1.2 devices The TPM 2.0 driver periodically contributes TPM-generated random bytes to the kernel entropy pool, but the TPM 1.2 driver does not. Issue TPM_GetRandom every ten seconds and submit successful responses as RANDOM_PURE_TPM. Keep each exchange under the TPM transaction lock. Defer harvesting while the character device is open or a command is pending so the task cannot consume a user response. Drain the task for suspend and detach, rearming it after resume or a failed suspend. Document the expanded scope of RANDOM_ENABLE_TPM and update the kernel configuration comments that described it as TPM 2.0-only. Validated on a STMicroelectronics TPM 1.2 TIS device. DTrace observed periodic entropy submissions; a raw GetRandom response remained intact while the device was held open across a harvest interval; and module unload/reload deregistered and restored the entropy source cleanly. Tested by: zarychtam_plan-b.pwste.edu.pl MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59239
debug: classified in
03-filenames_plain1 by '['sys/arm/',
'sys/arm64/', 'sys/dev/', 'sys/riscv/']'
The TPM requests 16 random bytes every ten seconds, but a random harvest event retains at most eight bytes. random_harvest_queue() reduces a larger input to one 32-bit Jenkins hash, so each successful TPM request contributed only four bytes to the entropy accumulator. Split the response into harvest event sized chunks. This preserves all 16 random bytes without increasing the TPM command rate or changing its high quality source classification. MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59246
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Query each enabled eswitch vport to report its effective MAC and VLAN configuration and administrative link-state policy. Serialize the query with vport enable and disable, and hold the interface state lock so teardown joins an in-progress report. Propagate firmware errors from MAC, administrative link-state, and supported VLAN queries instead of returning a partially initialized configuration. When the hardware lacks CVLAN enforcement, report the remaining status with no imposed access VLAN. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D58740
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Derive SIOCGIFRSSHASH's TCP and UDP selections from the same boot-time hash configuration used by mlx5e_build_tir_ctx(). The query previously advertised all six IPv4/IPv6 hash types even when the transport-specific TIRs selected only the IP addresses. In particular, the default RSS configuration disables UDP four-tuple hashing. Continue reporting IPv4 and IPv6 two-tuple hashing unconditionally, matching the driver's IP-only TIRs. Do not report IPv6 extension-header variants which the query did not previously claim. Leave key selection, TIR programming, and the receive datapath unchanged. This lets consumers such as hn(4) match the VF's hash inputs instead of enabling incompatible UDP four-tuple hashes on their own receive path. Fixes: https://cgit.freebsd.org/src/commit/?id=a00718e1dfcd ("Implement SIOCGIFRSSKEY and SIOCGIFRSSHASH and mlx5en(4).") MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59807
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Expose the PF-known effective per-VF MAC, allocated transmit and receive queue counts, and policy state through the iflib VF status method. Snapshot the state under the SR-IOV lock so concurrent trust and anti-spoof sysctl updates cannot produce a torn report. Mark known queue allocations present even when their value is zero. Cache a VF-selected MAC only after firmware accepts the forwarded request. Prefer that address in status. Replay the accepted address, trust state, and MAC anti-spoof policy after firmware recovery. Record completion of the per-VF configuration callback separately from firmware resource allocation. Track successful PCI SR-IOV attachment independently of the active VF count. This lets a supported but unconfigured PF return an empty status while unsupported devices and failed attachments omit it. Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D58738
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Retain the PF-known MAC and allocated transmit and receive queue counts for each VF and expose them through the PF ifnet. Sum queues across all hardware functions rather than reporting only the first one. Publish and snapshot the VF cache under the existing hardware lock. Unpublish it before hardware teardown, and invalidate queue-allocation knowledge when error recovery releases the underlying VF resources. Initialize the cache, release it on failed initialization, and reject an out-of-range VF index instead of continuing into the array. Tested by: zlei Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D58742
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Implement the iflib RSS key and hash query methods for register-based and PF-managed RSS. Cache the programmed key and HENA selections so hn can synchronize its synthetic RSS configuration with the VF without reading hardware or issuing mailbox requests from the query path. For PF-managed RSS, publish the snapshot only after successful replies to both CONFIG_RSS_KEY and SET_RSS_HENA. Failed sends, rejected requests, and missing replies leave it unavailable. Protect the snapshot with vc_mtx and invalidate it at init, stop, mailbox loss, and reset notification. Gate queries with the existing running, reset, and mailbox state. Report the first 40 key bytes used by standard IPv4/IPv6 tuples, or the shorter key length supplied by the PF. Preserve register byte order and report the merged HENA on the direct-programming path. Translate the six representable IPv4/IPv6 TCP/UDP selections without treating fragment PCTYPEs as IPv6 extension-header selections. The single-queue register path reports RSS_FUNC_NONE. Leave RSS policy and queue distribution unchanged. Queries return ENXIO until the current configuration is confirmed, without waiting for a PF reply themselves. MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59808
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Add Tx LAN Queues commits the PQM queue and PSM leaf before returning success. ice_ena_vsi_txq() can subsequently fail to create the software scheduler node or replay its saved bandwidth configuration. Returning at that point leaves an allocated queue that the caller does not record. Later queue setup can fail until a function or PF reset removes it. Issue Disable Tx LAN Queues directly from the completed Add response before returning a post-add error. Keep the rollback buffer on the stack so the allocation failure being recovered cannot also prevent cleanup. Remove any software node and invalidate its queue context only after firmware accepts the disable. Preserve the queue context and any software node when rollback fails so active hardware state is not hidden. This follows the Add and Disable command lifecycle documented in the Intel E810 Datasheet, document 613875-003, section 10.5.5.8. MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D58907
debug: classified in
03-filenames_plain1 by
'sys/dev/'
`ISO_RRIP_ANALYZE` is constructed in four places. Two of the initializers set the `outlen` field while the other two, `cd9660_rrip_analyze` and `cd9660_rrip_offset`, leave it uninitialized. The uninitialized paths can dereference an invalid pointer on error paths which causes a kernel panic. To fix, I zero out `ISO_RRIP_ANALYZE` in all four places where it's initialized and check that `outlen` is non-null on the error path in `cd9660_rrip_loop`. While testing the above, I encountered another kernel panic due to mounting continuing after the error branch. Evidently, the ISO continued mounting through the normal ISO 9660 path then triggered a panic down the line due to a very broken file system from the ISO. To fix that, I propagate the error from the RR path then fail in the mount path. A previous iteration of this commit included the ISO from the PR. The current iteration creates an ISO with makefs then corrupts it with a small helper written in C that is a condensed version of the CD 9660 code. It checks the input ISO for a a Rock Ridge extension reference then corrupts the length byte. This triggers the early failure in cd9660_rrip_offset. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296853 Signed-off-by: Josh Megnauth <jo.sh@tutanota.com> Reviewed-by: ngie Pull-Request: https://github.com/freebsd/freebsd-src/pull/2462
debug: Commit manually moved from "unknown" to "hardware".
Submitted by: Brian Poole <brian90013@gmail.com>
debug: classified in
03-filenames_plain1 by
'sys/dev/'
DPDK iavf's per-queue stop/start operations send DISABLE_QUEUES followed by ENABLE_QUEUES without another CONFIG_VSI_QUEUES. Disabling an ice Tx queue removes its hardware scheduler leaf, so acknowledging ENABLE alone cannot restart it. Clearing the configured bitmap also prevents the VF from requesting this sequence. Track saved configuration separately from active Tx queues. Retain ring parameters and queue handles on disable, and recreate only the selected inactive queues on enable. Share the existing Tx context builder between initial VSI configuration and per-queue restart. Keep the initial Tx-at-CONFIG behavior and the existing dense-prefix CONFIG validation. Track cleanup progress per queue and publish valid configuration only after both Tx and Rx configuration succeed. If an enable fails, undo its partial setup before permitting a retry. Retain hardware ownership when cleanup fails and reject another enable of that queue rather than silently acknowledging it. A failed post-add rollback without a software scheduler node requires VF reset, not a successful no-op disable. After a verified VF reset and DMA drain, remove any remaining software scheduler leaves and invalidate the queue contexts. Treat the initial queue disable as best effort so a failed rollback cannot permanently prevent reset recovery. Retain unresolved state if the reset or drain fails. Fixes: https://cgit.freebsd.org/src/commit/?id=bc761988b724 ("ice: Add host SR-IOV support") MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59851
debug: classified in
03-filenames_plain1 by
'sys/dev/'
When pmap_clear_modify() demotes a dirty L2 block mapping, it write protects the L3 entry that maps "m", so that a subsequent write access may repromote. However, since fd6cb031f577, the L3 entries created by pmap_demote_l2_locked() may have ATTR_CONTIGUOUS set, and pmap_clear_modify() was write protecting one L3 entry within an L3C page while leaving the page's other L3 entries writeable with ATTR_CONTIGUOUS still set. A TLB entry that a processor creates from any of those other L3 entries may translate "m"'s virtual address and permit writes to "m" without a fault. To fix this issue, as in pmap_remove_write(), demote the L3C page before write protecting the L3 entry. Found by: Claude Code (Opus 5.5) Fixes: https://cgit.freebsd.org/src/commit/?id=fd6cb031f577 "arm64 pmap: Add ATTR_CONTIGUOUS support [Part 1]" MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'sys/arm64/'
The embedded switch installs local forwarding rules with loopback enabled, but their source VSI must also permit loopback. Without that permission, traffic between host-attached VFs can trigger Tx data MDD events instead of reaching the destination VSI. Set ICE_AQ_VSI_SW_FLAG_ALLOW_LB when initializing a VSI in VEB mode, matching the forwarding rules to the VSI permission. Keep MAC anti-spoof checking enabled. Validated on E810 with native iavf and DPDK VFs, together with the absolute VF number correction. Local forwarding and queue/reset recovery passed; spoofed source MACs were still rejected and isolated. Fixes: https://cgit.freebsd.org/src/commit/?id=bc761988b724 ("ice: Add host SR-IOV support") MFC after: 2 weeks Sponsored by: BBOX.io
debug: classified in
03-filenames_plain1 by
'sys/dev/'
The Add VSI AdminQ command requires an absolute hardware VF number, while vsi->vf_num is relative to its PF. Add the PF's vf_base_id, as the VF Tx queue context already does. On an E810 PF with vf_base_id 128, relative VFs 0 and 1 were associated with hardware VFs 0 and 1 instead of 128 and 129. Their receive queues became blocked and both native iavf and DPDK receivers dropped traffic. A PF whose VF base is zero hides the error. Validated the VSI-to-function mapping and receive traffic on that PF, including VF reset recovery and local PF/VF forwarding with VSI loopback enabled. Fixes: https://cgit.freebsd.org/src/commit/?id=bc761988b724 ("ice: Add host SR-IOV support") MFC after: 2 weeks Sponsored by: BBOX.io
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Some PFs reject a redundant DISABLE_QUEUES request after queues have already stopped. The historical driver retried the request but continued. The mailbox recovery change instead treated this NACK as a transport failure, tore down the Admin Queue without a VF reset, and could not recover the interface during API rediscovery. Track a PF's pre-reset warning separately from an observed reset and from exclusive ownership of polled AdminQ replies. RESET_IMPENDING leaves asynchronous AdminQ processing available so a concurrent stop can consume its DISABLE_QUEUES reply. VC_POLLING protects VERSION and GET_VF_RESOURCES rediscovery without blocking that reply. Record completed resets so subsequent stop/init operations do not issue a redundant queue-disable request. If queue disable is not confirmed, wait for an observed reset or request a VF reset and wait for completion. Give queue shutdown a separate 60-second monotonic deadline to accommodate slow PF reset recovery. Propagate reset submission failures and restore the previous RSTAT value when no request was submitted. Clear the attach-time recovery marker before the first runtime stop/init cycle, and suppress RSS status reporting during reset recovery. This implements the native recovery portion of D58904, with PCI containment and permanent failure handling deferred. If native shutdown cannot be confirmed, report the failure and leave recovery pending. Shutdown remains best effort because IFDI_STOP cannot return an error to prevent iflib from releasing queue resources. Matched hardware testing against the parent on E810 with two four-queue VFs covers 18 TCP smoke runs, 40 down/up cycles, three PF resets, and three CORE resets per kernel. The change eliminates all 12 observed "PF mailbox rediscovery failed: 60" messages and reduces the longest UDP delivery gap per CORE reset from 3.43-3.57 seconds to 2.62-2.67 seconds. MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D58904
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Add the USB 3.1 and 3.2 speeds and revisions. The speeds are in USB 3.2 rank order, so they can be compared directly. Also, move USB_*_MAX into the enums. Reviewed by: bz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57194
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Add the SuperSpeedPlus speed names. Reviewed by: bz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57197
debug: classified in
03-filenames_plain1 by
'usr.sbin/usbdump/'
usb: support SSP/SSPx2 devices in all-speed consumers Handle the new speeds wherever USB_SPEED_SUPER was checked. Most consumers treat them as SS. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57198
debug: classified in
03-filenames_plain1 by
'sys/dev/'
usb: Add usbd_bos_foreach helper Iterate the capabilities of a BOS descriptor. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57199
debug: classified in
03-filenames_plain1 by
'sys/dev/'
usb: Add extended port status struct Extended Port Status reports the speed and lane count of SS and SSP links. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57200
debug: classified in
03-filenames_plain1 by
'sys/dev/'
usb: Add get_ext_port_status helper function usbd_req_get_ext_port_status() wraps the Get Extended Port Status request. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57201
debug: classified in
03-filenames_plain1 by
'sys/dev/'
usb: Implement usbd_req_get_bos_descriptor helper Get the header or the complete BOS descriptor of SS+ devices. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57202
debug: classified in
03-filenames_plain1 by
'sys/dev/'
usb: Add SSPlus device capability descriptor Add the SuperSpeedPlus USB Device Capability descriptor and its field macros. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57203
debug: classified in
03-filenames_plain1 by
'sys/dev/'
usb: Add support for SSP and SSPx2 hubs An SSP hub reports its sublink speeds in the BOS descriptor, and Extended Port Status tells which one each port uses. Read it based on bcdUSB, since the ports of a hub can be faster than its upstream link. Without it, the ports are treated as SuperSpeed. Read the speed again in usbd_req_re_enumerate(), since a link can come back at another speed. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57204
debug: classified in
03-filenames_plain1 by
'sys/dev/'
usb: support SSP and SSPx2 xHCI Only the default PSI IDs are supported, other controllers fall back to USB 3.0. Record the speed IDs the controller has: the root hub BOS lists those, and a link without one uses the closest lower ID. Per xHCI 6.2.2, take the parent hub slot ID and port number of SS and SSP devices from the closest higher-rank hub. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52347
debug: classified in
03-filenames_plain1 by
'sys/dev/'
The ice_cfg_tx_topo function attempts to apply Tx scheduler topology configuration based on NVM parameters, selecting either a 5 or 9 layer topology. As part of this flow, the driver acquires the "Global Configuration Lock", which is a hardware resource associated with programming the DDP package to the device. This "lock" is implemented by firmware as a way to guarantee that only one PF can program the DDP for a device. Unlike a traditional lock, once a PF has acquired this lock, no other PF will be able to acquire it again (including that PF) until a CORER of the device. However, if configuration of the Tx topology fails, (i.e. ice_get_set_tx_topo returns an error code), the driver exits ice_cfg_tx_topo() immediately, and fails to trigger CORER. While the global configuration lock is held, the firmware rejects most AdminQ commands, as it is waiting for the DDP package download (or Tx scheduler topology programming) to occur. Refactor ice_cfg_tx_topo() to always trigger a CORER after acquiring the global lock, regardless of success or failure of the topology configuration. We need to re-initialize the HW structure when we trigger the CORER. Previously, this was the responsibility of the core driver to cleanup after the CORER. Instead, make it the responsibility of this function. This avoids needless re-initialization for the cases where no reset occurred. Authored-by: Jacob Keller <jacob.e.keller@intel.com> Co-Authored-by: Pawel Sobczyk <pawel.sobczyk@intel.com> Signed-off-by: Sobczyk, Pawel <pawel.sobczyk@intel.com> Reviewed by: kbowling Tested by: Mateusz Moga <mateusz.moga@intel.com> MFC after: 3 days Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D60168
debug: classified in
03-filenames_plain1 by
'sys/dev/'
On RoCE-capable Thor2, attach fails with HWRM_FUNC_BACKING_STORE_CFG_V2 returning INVALID_PARAMS, as MRAV is sized the pre-V2 way and the firmware's AV split value is sent as is. Size MRAV from the AV split entry, and move the legacy entry-count packing into bnxt_hwrm_func_backing_store_cfg(). Fixes: https://cgit.freebsd.org/src/commit/?id=d5ce906da7c5 ("bnxt_en: Add backing store V2 support") Reviewed by: gallatin Sponsored by: Broadcom Inc MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D60976
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Older Thor2 firmware serves key context allocation requests very slowly, about a second each. The driver allocates key contexts in batches of 128, so setting up 500k sessions takes roughly 3900 requests and driver load appears to hang. Enable hardware kTLS only when the firmware's HWRM interface version is 1.10.3.99 or newer. Keep the full four-part version in hwrm_spec_code_ext for the comparison. Also add a disable_hw_ktls loader tunable that turns hardware kTLS off for a device without unloading kTLS support, which helps isolate kTLS problems in the field. Reviewed by: gallatin Sponsored by: Broadcom Inc MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D60977
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Co-authored-by: Michael Osipov <michaelo@FreeBSD.org> PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=300175 Reviewed by: imp MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D60973
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Firmware controls the physical link state on E610 adapters, similarly to X700 and E800 adapters. As a result, running "ifconfig down" does not disable the physical link unless Total Port Shutdown is enabled. Read the Link Default Override TLV from NVM to detect when Total Port Shutdown was enabled for given port in system setup. In that case, force the link down when the interface is stopped and restore it during link configuration. Leave link state management unchanged when the TLV is unavailable or the feature is not enabled. Co-authored-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com> Co-authored-by: Tomasz Lichwala <tomasz.lichwala@intel.com> Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com> Tested by: Mateusz Moga <mateusz.moga@intel.com> MFC after: 1 week Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D60643
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Convert the RISC-V Interrupt Controller (INTC) device to a bus;
try to find and attach Incoming Message Signalling Interrupt Controller
(IMSIC) device.
This allows to establish parent-child relationships between two and
to propagate PIC_INIT_SECONDARY call from the INTC (parent) to the
IMSIC (child).
Reviewed by: mhorne, mmel
Sponsored by: EPSRC ("UKRI3001: CHERI Research Centre")
Differential Revision: https://reviews.freebsd.org/D59813
debug: classified in
03-filenames_plain1 by
'sys/riscv/'
Support for Incoming Message Signalling Interrupt Controller (IMSIC)
defined by the RISC-V Advanced Interrupt Architecture (AIA) specification.
This is based on early work of Himanshu Chauhan on IMSIC support for
IPI delivery. This change, however, does not include IPI delivery support,
instead it provides MSI support for peripheral devices.
IMSIC is a core-local interrupt controller with non-global interrupts,
which means that interrupt identity is effectively (hart, interrupt ID).
When IMSIC present on hart, APLIC does not trap the CPU directly,
instead it delivers the interrupt to the IMSIC instance associated with
the target hart. Upon reception of interrupt, IMSIC on hart invokes APLIC
for handling. Note that PCIe devices deliver interrupt directly to IMSIC.
Apart from IMSIC support, this includes APLIC changes:
- Obtain the interrupt trigger type from FDT and configure the interrupt
accordingly (e.g. level or edge-triggered);
- Per the AIA requirement, level-triggered MSI interrupts must be
retriggered manually after being handled. See the comment in
aplic_post_ithread();
- Reorganize APLIC register definitions to have some structure.
Reviewed by: mhorne
Sponsored by: EPSRC ("UKRI3001: CHERI Research Centre")
Differential Revision: https://reviews.freebsd.org/D59695
debug: classified in
03-filenames_plain1 by
'sys/riscv/'
Protect running-state checks and register updates with the softc lock. Drop the lock around sndbuf_resize(), which may sleep, and recheck the running state after reacquiring it. Keep the resize ahead of the latency register update so that a failed resize leaves the hardware unchanged. Reviewed by: br MFC after: 3 days Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D58371
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Protect running-state checks and register updates with the softc lock. Keep the pointer reset and the HDSP 9632 frequency rewrite in the same critical section as the latency update. Drop the lock around sndbuf_resize(), which may sleep, and recheck the running state after reacquiring it. Preserve resize error handling so that a failed resize leaves the hardware unchanged. This mirrors the locking in snd_hdspe. MFC after: 3 days Sponsored by: BBOX.io
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Program DMA pages from busdma segments and synchronize buffer ownership. Unwind partially allocated resources on failure. Reviewed by: br MFC after: 3 days Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D58372
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Program DMA buffer registers with the bus addresses returned by busdma. Require one full-size contiguous DMA segment per direction and validate its alignment and 32-bit address range. Synchronize buffer ownership around playback, capture, clearing, and teardown. Disable channels before clearing their DMA buffers, and unwind partially allocated resources on failure. This mirrors snd_hdspe's DMA handling, adapted to HDSP's single base address per direction. MFC after: 3 days Sponsored by: BBOX.io
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Release resources with the IDs used to allocate them. Rename irqid to rid to reflect that it stores a resource ID. Reviewed by: br MFC after: 3 days Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D58373
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Release resources with the IDs used to allocate them. Rename irqid to rid to reflect that it stores a resource ID. This mirrors the corresponding snd_hdspe change. MFC after: 3 days Sponsored by: BBOX.io
debug: classified in
03-filenames_plain1 by
'sys/dev/'
vioapic_update_tmr() resets all 256 vectors before rebuilding the level-triggered vector set. With Intel virtual interrupt delivery, each per-vector reset loads the VMCS, reads and writes an EOI-exit bitmap, and clears the VMCS. Add an optional bulk-reset hook so VMX can clear the four EOI-exit bitmaps with one VMCS load/clear pair. Clear the software TMR banks directly when using the hook, and retain the per-vector fallback for backends without it. Reviewed by: markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60692
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
IOAPIC redirection-table writes rendezvous all active vCPUs to rebuild their vlapic trigger-mode registers when fields other than mask or polarity change. Retargeting an edge-triggered pin incurs this cost even though it does not contribute to the TMR. vioapic_update_tmr() rebuilds the TMR from level-triggered entries only. Skip the rendezvous when the modified entry is edge-triggered both before and after the write. Check the old and new trigger modes so that edge-to-level and level-to-edge transitions still rebuild the TMR. Retain the existing all-vCPU rebuild path, mask/polarity exclusions and remote-IRR handling. Reported by: Wanpeng Qian <wanpengqian@gmail.com> Reviewed by: Wanpeng Qian <wanpengqian@gmail.com>, markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60721
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
When a receive ring is full the hardware drops the packet and counts it
in RQDPC, a per-queue register the driver never read. Such drops were
invisible: MPC counts packet buffer overflows, not descriptor
exhaustion, so an overloaded queue lost packets with nothing to show for
it. With several receive queues this is the common overload signature,
since RSS loads the queues unevenly and one saturated queue drops while
the others idle.
Read RQDPC for each queue with the other statistics and account the
drops per queue as dev.igc.N.queue_rx_M.rx_drops and in total as the
interface's input queue drop counter (netstat -d, Idrop), as ixgbe does
with QPRDC. Write the register back to zero after reading; the I210
documents it as read/write rather than read-to-clear.
Reviewed by: kbowling
MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D61004
debug: classified in
03-filenames_plain1 by
'sys/dev/'
This reverts commit 2a27dd0076c5. Changing the IO queue count destroys the RSS table, and if this is done while the device is down a new table is not rebuilt until the next ena_up(). That leaves 2 problems in the meantime: 1. A stale copy of the destroyed table is still returned via sysctl. 2. Reading the destroyed key, or writing the table, panics. That commit addressed 1 by creating a new RSS table, so that sysctl returns a fresh default table with the new number of queues. It did not set out to fix 2, but the rebuild hid it by accident. The rebuilt table is the default round-robin one, wired to no queues and unusable: a write still fails, because programming the device needs the IO queues that only exist after ena_up(). ena_up() builds that same table anyway. Rebuilding also programs the device while no IO queues exist. When the queue count grows this fails with EINVAL; when it shrinks it succeeds and points the device at completion queues that ena_down() destroyed. The following commit addresses both issues properly. Reviewed by: cperciva MFC after: 3 days Sponsored by: Amazon, Inc. Differential Revision: https://reviews.freebsd.org/D61056
debug: classified in
03-filenames_plain1 by
'sys/dev/'
ena: Fix RSS sysctl panic when the RSS table is destroyed ena_set_io_queue_count() destroys the ena-com RSS state but left ENA_FLAG_RSS_ACTIVE set. The RSS sysctl handlers gate on that flag, so they ran against state that was gone. This causes 2 types of issues: 1. Kernel panic when reading dev.ena.0.rss.key or writing to dev.ena.0.rss.indir_table 2. Returning a stale cached RSS table when reading dev.ena.0.rss.indir_table, or a bogus 1 when reading dev.ena.0.rss.indir_table_size ena_set_io_queue_count() is called in 2 cases: 1. The io_queues_nb sysctl. 2. Device restore when the device comes back with fewer MSI-X vectors than before. Clear ENA_FLAG_RSS_ACTIVE when the RSS table is destroyed. The handlers then fail with ENOTSUP until the next ena_up() rebuilds RSS. This both fixes the panics, and stops returning cached and bogus values. Note: A plain ifconfig down does not destroy the table, so the sysctls keep working across a down/up cycle. Reviewed by: cperciva Fixes: https://cgit.freebsd.org/src/commit/?id=56d41ad5fe9c ("Add sysctl node for ENA IO queues number adjustment") Fixes: https://cgit.freebsd.org/src/commit/?id=2d4d2ed3fef6 ("ena: Reinit RSS table on device restore when queue count shrinks") MFC after: 3 days Sponsored by: Amazon, Inc. Differential Revision: https://reviews.freebsd.org/D61057
debug: classified in
03-filenames_plain1 by
'sys/dev/'
ena: Set ENA_FLAG_RSS_ACTIVE only when RSS is really configured If the device does not report support for the RSS indirection table, ena_rss_init_default() destroys the RSS state and returns EOPNOTSUPP. ena_rss_configure() treats EOPNOTSUPP as success and returns 0, and ena_up_complete() sets ENA_FLAG_RSS_ACTIVE on any 0 return. Reading dev.ena.N.rss.key at this point causes kernel panic. Every current device reports the indirection table, so reaching this needs a device that is broken or misreporting. The SYSINIT removed by a6205766b300 called ena_rss_init_default() directly, saw the EOPNOTSUPP and cleared the flag. Routing the decision through ena_rss_configure(), which hides EOPNOTSUPP, lost that. Move the flag set into ena_rss_configure(), which can see whether a table exists, and clear it when tbl_log_size is 0. Reviewed by: cperciva Fixes: https://cgit.freebsd.org/src/commit/?id=a6205766b300 ("ena: Fix RSS not working after driver reload") MFC after: 3 days Sponsored by: Amazon, Inc. Differential Revision: https://reviews.freebsd.org/D61058
debug: classified in
03-filenames_plain1 by
'sys/dev/'
ena: Update driver version to v2.8.6 Bug Fixes: * Revert "Reinit RSS components during queue count change flow" * Fix RSS sysctl panic when the RSS table is destroyed * Set ENA_FLAG_RSS_ACTIVE only when RSS is really configured Reviewed by: cperciva MFC after: 3 days Sponsored by: Amazon, Inc. Differential Revision: https://reviews.freebsd.org/D61059
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Network-related commands, library, and kernel.
Since SCTP keeps fibnum in the SCTP protocol control block, the code can't just defer the processing to the IPv4 or IPv6 layer. Therefore it needs to be implemented in the the SCTP layer and it needs to call the socket layer function. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=300091 Reviewed by: tuexen Fixes: https://cgit.freebsd.org/src/commit/?id=caccbaef8e26 ("socket: Move SO_SETFIB handling to protocol layers") MFC after: 3 days MFC to: stable/14 MFC to: stable/15
debug: classified in
03-filenames_plain1 by
'sys/netinet/'
The module declaration is necessary for 'kldstat -m' to see it, and the rc(8) uses that to detect presence of ipfw_nat. NB: the module(9) KPI lacks a way to declare a module without providing an empty handler and no SYSINITs. Reported by: ambrisko Fixes: https://cgit.freebsd.org/src/commit/?id=9bcc1e97dda8e926483b81874884211bbe4f36e9
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
After deleting an item from a sorted array, bdel() moves the tail following it, but the size of the data to move was calculated with an off-by-one error, causing memmove() to read one element past the end of the array. This can happen when the table is full for ifidx or numarray algorithms. Obtained from: Yandex LLC MFC after: 1 week Sponsored by: Yandex LLC
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
pf_init_pdesc() cleared the whole structure, 336 bytes on amd64, for
every packet and twice for a forwarded one. kif, m, pf_mtag, act and
the SCTP job list are set before they are read, so move them to the end
and clear only the 240 bytes before them. On amd64 that also stays
below the 256 bytes from which memset() switches to rep stosb.
Reviewed by: kp
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D60948
debug: classified in
03-filenames_plain1 by '['sys/net/',
'sys/netpfil/']'
hashalloc(9) rounds the requested size down to a power of two and writes the result back, but pf_initialize() stored it into the mask, which the next line overwrites from the unrounded size. With a net.pf.source_nodes_hashsize that is not a power of two the mask is larger than the table: pf_hashsrc() returns rows past its end, the row walkers in pf_purge_expired_src_nodes() and the ioctl handlers run past it, and pf_cleanup() frees it with the wrong size. The key and UDP endpoint hashes already take the rounded size. Reviewed by: glebius, kp Fixes: https://cgit.freebsd.org/src/commit/?id=cd5ff4e841fb ("pf: use hashalloc(9) for key, id, src-node and udp-endpoint hashes") Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D60949
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
The module declaration is necessary for 'kldstat -m' to see it, and the rc(8) uses that to detect presence of ipfw_nat. Submitted by: markj's Post-Commit LLM Review Service Fixes: https://cgit.freebsd.org/src/commit/?id=9bcc1e97dda8e926483b81874884211bbe4f36e9
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
pf_state_key_attach() attaches the wire key first and then the stack key, setting sks to NULL before the second pass. When the stack key collides with an existing state, the error path removes the wire key again but then frees sks, which is NULL by then: the stack key leaks. pfsync hits this. A peer that gets a plain state in a bulk update before a redirected state whose stack key is the plain state's key fails to import the redirected state, leaks its stack key, and leaks another one with every later update of that state. Free sk, the key of the pass that collided (skw on the wire pass), and add a test. Reviewed by: kp Fixes: https://cgit.freebsd.org/src/commit/?id=371bd29d4b22 ("pf: fix potential state key leak") MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D60951
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
pf: convert DIOCXBEGIN, DIOCXROLLBACK, DIOCXCOMMIT to netlink
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
05-summary-prefix by 'pf:'
pf: have DIOCXBEGIN/DIOCXROLLBACK/DIOCXCOMMIT use the new functions
The netlink begin/rollback/commit code has separate functions for this.
Deduplicate the code and just use those functions.
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
pf: remove armv7-specific counter code
The armv7 specific counter code is less useful now that armv7 is
basically end-of-life.
This removes a lot of armv7-specific code.
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by '['sys/net/',
'sys/netpfil/']'
pf: fix pf_krule_item memory leak during counters:match_fail
If pf_counters_inc() did not increment the counters because the rule
failed to apply it potentially failed to free match rules (which were
not bound to a state already).
Do so.
While here explicitly hand match_rules over from the pf_test_ctx to the
state so we never list them in two places.
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
pf: fix DIOCXBEING/DIOCXROLLBACK/DIOCXCOMMIT error handling - ensure the anchor name is always 0-terminated strlcpy() won't overflow, but will walk off the end of the provided buffer looking for a 0. - don't overwrite the pf_begin()/... return value with the copyout() return value - stop on the first copyout() error Fixes: https://cgit.freebsd.org/src/commit/?id=2636cc0414fd (pf: have DIOCXBEGIN/DIOCXROLLBACK/DIOCXCOMMIT use the new functions, 2026-10-27) Reported by: markj's Post-Commit LLM Review Service Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
snl_init() calls snl_free() on its own failure paths but leaves the state marked initialised and the buffer pointers set, so a caller that also frees the state on failure, as libpfctl's pfctl_open() does, closes the descriptor twice and, on the lb_init() failure path, frees the buffer twice. Reset what snl_free() releases so a second call is a no-op. Signed-off-by: Avinash Duduskar <avinash.duduskar@gmail.com> Reviewed by: kp Pull Request: https://github.com/freebsd/freebsd-src/pull/2508
debug: classified in
03-filenames_plain1 by
'sys/netlink/'
snl_init() always creates its own socket. Split out snl_init_fd(), which initialises the state on a descriptor the caller already holds, and make snl_init() open the socket and hand it over. The state owns the descriptor either way, including when initialisation fails, and snl_free() closes it; snl_clone() remains the way to borrow one. pfctl(8) needs this to run on a socket inherited from authpf(8). PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291981 Signed-off-by: Avinash Duduskar <avinash.duduskar@gmail.com> Reviewed by: kp Pull Request: https://github.com/freebsd/freebsd-src/pull/2508
debug: classified in
03-filenames_plain1 by
'sys/netlink/'
pfsync: avoid underflow on different timeouts
If two pfsync hosts have different timeout values set it's possible for
an underflow to occor when importing a state. If the destination host
has a shorter timeout set than the exporting host it's possible for the
state to be older than the importing host's timeout value, which results
in an underflow and a state with an unreasonable expiry time.
Check for this, and avoid the underflow. While here also account for the
timeout being longer than our uptime.
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D60950
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
pfsync: improve underflow check We checked the state's expiry time to make sure it was large enough to not underflow if we subtracted the already expired time from the remote end, but we failed to account for the state's expiry time being in miliseconds and the pfsync time delta being in seconds. Take that multiplication by 1000 into account. Fixes: https://cgit.freebsd.org/src/commit/?id=78b620b781b0 (pfsync: avoid underflow on different timeouts, 2026-10-21) Reported by: markj's Post-Commit LLM Review Service Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
pfsync: improve handling of large packets On setups with pfsync over large MTUs (> 2K) we could fail to parse packets because m_pulldown() fails on packets larger than MCLBYTES. Instead use m_copydata() to copy out the individual chunks we're interested in. This should also fix the flaky pfsync:bulk test case. Depending on the hash seed states would or would not end up synced. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=297307 Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
if_pfsync: add missing unlock Fixes: https://cgit.freebsd.org/src/commit/?id=c6a520af95b2 (pfsync: improve handling of large packets, 2026-10-30) Reported by: markj's Post-Commit LLM Review Service Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
if_pfsync: fix mbuf leaks on errors Some of the pfsync input handlers freed the mbuf on errors, others did not. Unify this by having the caller free the mbuf on error. Fixes: https://cgit.freebsd.org/src/commit/?id=c6a520af95b2 (pfsync: improve handling of large packets, 2026-10-30) Reported by: markj's Post-Commit LLM Review Service Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
ip6_forward() has run the outbound hooks with pfil_mbuf_fwd() since b52b61c0b6b1, and ip_tryforward() since 1f4c3887e3fa, but ip6_tryforward() still calls pfil_mbuf_out(). pf therefore handles a packet on the IPv6 fast path as locally generated: it skips the packet-too-big error it sends with the untranslated addresses, and pf_refragment6() sends reassembled packets out through ip6_output() instead of ip6_forward(), so their fragments leave with the hop limit not decremented. Use pfil_mbuf_fwd() in ip6_tryforward() as well. The new fragmentation_pass:v6_refrag_hlim test sends a packet that pf reassembles and refragments through the fast path, and checks that its fragments leave with the hop limit decremented once; before this change they leave with it unchanged. Reviewed by: kp Fixes: https://cgit.freebsd.org/src/commit/?id=b52b61c0 ("pf: distinguish forwarding and output cases for ...") MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D61033
debug: classified in
03-filenames_plain1 by
'sys/netinet6/'
ip6_tryforward() sends time exceeded for an expiring packet before the inbound pfil hooks have seen it, whereas ip_tryforward() and ip6_forward(), which ip6_input() calls after the hooks, check it afterwards. On the fast path the router therefore answers packets the firewall blocks inbound, and pf never handles the expiry itself: a nat64 (af-to) packet with hop limit 1 gets a time exceeded error from the router, which a "block" ruleset then drops on the way out, instead of the one pf_translate_af() sends with the untranslated addresses. Check the hop limit after the inbound hooks. Reviewed by: kp Fixes: https://cgit.freebsd.org/src/commit/?id=5a1842a2 ("Add ip6_tryforward() - a run to completion ...") MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D61034
debug: classified in
03-filenames_plain1 by
'sys/netinet6/'
update_ip6() left the UDP checksum stale for most packets. Unlike update_ip(), it computed the incremental checksum delta only after the source-address wrap, so every earlier "break" (port increment, address increment, and both random paths) returned with udp_sum still 0 and no correction applied. The trailing delta block also re-read oaddr/naddr after they had been reassigned, so the source and destination deltas could not both be accounted for. Fold each delta in with new_udp_sum() before the corresponding break, mirroring the structure update_ip() already uses, and drop the stale trailing block. IPv4 was not affected. Verified by driving update_addresses() directly and recomputing every checksum from scratch over the real pseudo-header: 128 packets across six range configurations, 12 mismatches before, 0 after. IPv4 passes both before and after. Submitted by: Olivier Cochard-Labbé <olivier@cochard.me>
debug: Commit manually moved from "unknown" to "network".
If nlmsg_reply() or nlmsg_end() in pf_handle_trans() failed we did not
call pf_trans_free(), leaking the pf_trans_e elements in it.
Reported by: markj's Post-Commit LLM Review Service
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
Fall back to if_baudrate if ifmedia_baudrate() returns 0 in lacp_aggregator_bandwidth(). When lacp_aggregator_bandwidth() returns 0, lacp will never come up, due to aggregator selection starting with a 0. This is why its important for interfaces with unknown media (meaning ifmedia_baudrate() returns 0) to fall back to using if_baudrate in order to avoid this state. Differential Revision: https://reviews.freebsd.org/D61084 Reviewed by: kbowling Sponsored by: Netflix
debug: classified in
03-filenames_plain1 by
'sys/net/'
400GBase-FR4 is yet another 400G optical standard Differential Revision: https://reviews.freebsd.org/D61135 Reviewed by: kbowling Sponsored by: Netflix
debug: classified in
03-filenames_plain1 by
'sys/net/'
Convert the remaining bzero()/bcopy()/bcmp() calls in the neighbor discovery handlers to memset()/memcpy()/memcmp(). No functional change intended. Reviewed by: glebius, pouria Sponsored by: VersatusHPC Differential Revision: https://reviews.freebsd.org/D58177
debug: classified in
03-filenames_plain1 by
'sys/netinet6/'
Processing an incoming ICMPv6 we need to find just the matching inpcb and call udp_notify() on it. The call to in6_pcbnotify() at the first glance seems like a notifying sweep across the entire database, but it is not. It finds just the matching inpcb, but does that in the most inefficient way! The added test case proves that ICMPv6 processing stays the same before and after the change. This weird use of in6_pcbnotify() can be tracked down all the way to the initial KAME code. Reviewed by: tuexen, gallatin Differential Revision: https://reviews.freebsd.org/D60967
debug: classified in
03-filenames_plain1 by
'sys/netinet6/'
Stuff in man section 8 (other than networking).
debug: classified in
03-filenames_plain1 by
'libexec/'
debug: classified in
03-filenames_plain1 by
'libexec/'
sector_size is guaranteed to be non-zero here, so cast to
uint32_t to match the comparison.
This fixes the [gcc14 build in CI][0]:
/workspace/src/sbin/nvmecontrol/format.c: In function 'find_lbaf':
/workspace/src/sbin/nvmecontrol/format.c:132:60: error: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int' [-Werror=sign-compare]
132 | if (NVMEV(NVME_NS_DATA_LBAF_LBADS, format) != lbads ||
| ^~
[0] https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/5051/
Reviewed by: imp
Fixes: https://cgit.freebsd.org/src/commit/?id=b991e2dd824c ("nvmecontrol: support controller-wide sector sizes")
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
debug: classified in
03-filenames_plain1 by 'sbin/'
rtld: extract donelist heap allocation into donelist_alloc() Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'libexec/'
rtld: add RtldLockState initializer Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'libexec/'
rtld: add lockstate_rlocked() Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'libexec/'
rtld: free heap donelists abandoned by the lookup restart A symbol lookup done under the read-locked rtld_bind_lock is restarted with the write lock when it needs to load filtees. The restart is done by siglongjmp() from lock_restart_for_upgrade(), which skips donelist_free() for the heap donelists of the unwound frames. Only do_dlsym() freed one such donelist, tracked by SymLook.donelist_mem. The donelist of symlook_default() called from _rtld_bind(), the donelist of get_program_var_addr() called for dlopen(RTLD_TRACE), and the donelists of nested symlook_obj_load_filtees() calls were leaked. Link the heap donelists allocated under the read lock into the list owned by RtldLockState, which also owns the sigjmp_buf, instead of the symlook request. Fixes: https://cgit.freebsd.org/src/commit/?id=1e370f038778 ("rtld: stop using unbound alloca()") Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
03-filenames_plain1 by
'libexec/'
pf's Netlink commands are checked against the credentials of the socket, so a socket opened by a privileged process keeps its authority across a privilege drop and exec, as the /dev/pf descriptor passed as -p /dev/fd/N already does. -l takes the descriptor number of such a socket and uses it for every request instead of creating a new one. authpf(8) uses this to run pfctl as the logged-in user. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291981 Signed-off-by: Avinash Duduskar <avinash.duduskar@gmail.com> Reviewed by: kp Pull Request: https://github.com/freebsd/freebsd-src/pull/2508
debug: classified in
03-filenames_plain1 by 'sbin/'
The NULL return is used by the following memcpy() call. Fail the request instead. Unlikely to happen in practice, since the rpc.tlsservd daemon runs as root and does not allocate a lot or memory. Reviewed by: rmacklem MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60927
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
libusb has one speed for all SSP links, so print "SUPER+ (>=10Gbps)". Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57196
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
Make hastd remove its pidfile before exit after catching a signal or a stop control message, not just on failure to start. MFC after: 1 week Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D60192
debug: classified in
03-filenames_plain1 by 'sbin/'
Obtained from: OpenBSD, deraadt <deraadt@openbsd.org>, 3c04d8eee2
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by 'sbin/'
libarchive 3.8.10 ChangeLog: https://github.com/libarchive/libarchive/compare/v3.8.9...v3.8.10 Obtained from: libarchive Vendor commit: 0c48412be2d94afe1859a807ea7896a18d8900bd MFC after: 3 days
debug: classified in
05-summary-prefix by 'lib.*:'
Print the file and line number of the caller where the assert fired. Use _thread_exitf() directly for this. Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
04-filenames_plain2 by 'lib/'
Fixes: use of external filter programs, tests MFC after: together with 61c70dc16
debug: classified in
04-filenames_plain2 by 'lib/'
`cgetnext()` copies a capability record's name field into a fixed 1024 byte on-stack buffer (`nbuf[BSIZE]`) one character at a time, but never checks that the write pointer stays within the buffer. Therefore, a record name that is longer than `BSIZE` (either on a single line, or accumulated across several `\`-continued lines as the pointer is not reset amidst continuation) writes past the end of `nbuf` and smashes the stack. The name field is read directly from the capability file, so any consumer of `cgetnext()`/`cgetfirst()` that processes an untrusted `termcap(5)`- or `printcap(5)`-style database (e.g. `cap_mkdb(1)`, `lpr(1)`, or any third-party caller) can be exposed and hence made to corrupt the stack. Reviewed by: fuz, dteske Approved by: fuz (mentor), dteske (mentor) MFC after: 1 week Pull Request: https://github.com/freebsd/freebsd-src/pull/2309
debug: classified in
04-filenames_plain2 by 'lib/'
1. abstime calculation 2. rdlock flags judgement Reviewed by: kib MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60958
debug: classified in
04-filenames_plain2 by 'lib/'
libthr: Robust tryjoin test We cannot actually rely on a status (finish) before thr_exit. The thread needs the kernel signal status=1 to userspace. Before that, any tryjoin fails. The previous one works as we sleep 1 and should be enough for normal case. Reviewed by: kib, markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60832
debug: classified in
04-filenames_plain2 by 'lib/'
libthr: Add missing include header Fixes: https://cgit.freebsd.org/src/commit/?id=56a490f9c5e6 ("libthr: Robust tryjoin test") MFC after: 2 weeks
debug: classified in
04-filenames_plain2 by 'lib/'
Reviewed by: aokblast, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D60838
debug: classified in
04-filenames_plain2 by 'lib/'
The exiting thread frees the thread name in exit_thread() without holding the thread lock. This makes it possible for a thread doing pthread_getname_np() to observe the non-null thread->name and try to copy its content, accessing the memory after free. Set the thread->name to NULL under the thread lock. Note that other thread might still set the exiting thread name, until the PS_DEAD state is assigned. Since code should not call free() after _malloc_thread_cleanup(), re-check thread->name in _thr_free(). Reviewed by: aokblast, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D60838
debug: classified in
04-filenames_plain2 by 'lib/'
Reviewed by: aokblast, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D60838
debug: classified in
05-summary-prefix by 'lib.*:'
Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D60838
debug: classified in
04-filenames_plain2 by 'lib/'
pfctl_open_from_nl_fd() opens the pf device as pfctl_open() does but, when given a descriptor, adopts it as the Netlink socket instead of creating one. The handle's sequence numbers start at a random value: replies are matched by sequence number, so a random start makes it improbable that a reply an earlier owner of the socket left unread is taken for the answer to one of ours, or one of ours for theirs, however many times the socket has been handed on. pfctl_open() becomes a wrapper that passes -1. pfctl_nl_fd() returns the handle's Netlink descriptor, as pfctl_fd() does for the device, so a caller can hand it to a child process. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291981 Signed-off-by: Avinash Duduskar <avinash.duduskar@gmail.com> Reviewed by: kp Pull Request: https://github.com/freebsd/freebsd-src/pull/2508
debug: classified in
04-filenames_plain2 by 'lib/'
For an edge case at an extreme, e.g., nextafter(-DBL_MAX,-INFINITY) do not return x+x. Instead, evaluate x+x and assign it to a volatile to raise an exception, and then fall through to return the correct result in current rounding mode. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299389 MFC after: 6 days (for inclusion into releng/15.2)
debug: classified in
04-filenames_plain2 by 'lib/'
Report the new kernel speeds as LIBUSB20_SPEED_SUPER_PLUS. Reviewed by: bz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57195
debug: classified in
04-filenames_plain2 by 'lib/'
MFC after: 1 week PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299084 Reviewed by: arrowd, kevans Differential Revision: https://reviews.freebsd.org/D60901
debug: classified in
04-filenames_plain2 by 'lib/'
When the SSL handshake cannot proceed because the server is slow to respond, poll() with a timeout instead of spinning. MFC after: 1 week PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=298962 Event: Oslo Hackathon 2026 Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D60975
debug: classified in
04-filenames_plain2 by 'lib/'
The write-permission check on the destination file in
nfsrvd_copy_file_range() and nfsrvd_clone() tested
NFSVNO_EXSTRICTACCESS() on the source export instead of the destination
export.
Rick notes:
The change is harmless and mostly meaningless.
NFSVNO_EXSTRICTACCESS() is a placeholder for some site that might
not want to let the file "owner" get access despite mode bits.
The "owner override" is a hack that has existed forever in NFS,
since applications often create files with O_WRONLY, but mode 444.
This works for POSIX, but would make NFS writes fail, since they
check mode on every write, instead of just at POSIX open(). The hack
is to always allow the file owner to have write access.
Without the hack, lots of applications would break over NFS, so I
doubt anyone would enable NFSVNO_EXSTRICTACCESS().
{ No one has ever even wanted an export flag for it. }
Reviewed by: rmacklem, markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D60952
debug: classified in
03-filenames_plain1 by
'sys/fs/'
The calls to rpc_free_rdma_reduction() were cruft left over from a previous variant of the NFS over RDMA client code. They resulted in double free's of the reduction mbuf. This patch gets rid of them and makes sure that reduction is only done when an array of pages is provided, so that no anonymous pages will be allocated. The reduction mbuf is free'd with the rest of the argument mbuf list in the client side krpc. Suggested by: ferrao@versatushpc.com.br MFC after: 1 month Fixes: https://cgit.freebsd.org/src/commit/?id=884ee8d6c9b4 ("nfscl: Add some glue for client side NFS over RDMA")
debug: classified in
03-filenames_plain1 by
'sys/fs/'
The calls to rpc_free_rdma_reduction() were removed, but I forgot that newnfs_request() removes the reduction mbuf from the list upon success, so it has to be free'd separately. This patch does that. The patch also disables reduction after the first loop interation. This is necessary until nfsm_build_rdma_reduction() is patched to handle an offset within the page array. Reported by: markj MFC after: 1 month Fixes: https://cgit.freebsd.org/src/commit/?id=884ee8d6c9b4 ("nfscl: Add some glue for client side NFS over RDMA")
debug: classified in
03-filenames_plain1 by
'sys/fs/'
The NFSv4.1/4.2 session negotiates a limit to the size of an RPC reply message that can be cached for the session slot. This patch fixes the code so that it checks that limit and does not cache replies larger than the limit, even if the client requested that it be cached. This patch is slightly different than what the author submitted, but retains the check for reply cache size limit. Reviewed by: rmacklem MFC after: 1 month
debug: classified in
03-filenames_plain1 by
'sys/fs/'
When a CREATE_SESSION with the extant ClientID failed with NFS4ERR_STALE_CLIENTID within nfsc_renew of the previous full recovery, nfsrpc_setclient() returned EIO and the mount did no I/O until that window expired (about 45s). The server has discarded the ClientID, so waiting cannot help; RFC 8881 Section 8.4.2 requires a new ClientID (EXCHANGE_ID) and a state reclaim. AWS EFS discards both the session and the ClientID of clients whose lease is current whenever it resets a connection, which makes this path common there. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299221 Approved by: rmacklem@ Sponsored by: Netflix
debug: classified in
03-filenames_plain1 by
'sys/fs/'
When indexing the tarball on mount, fail if a file or directory name exceeds MAXNAMLEN. Reported by: n0ps1ed Reported by: Franz Bettag <franz@bett.ag> MFC after: 1 week Reviewed by: markj, emaste Differential Revision: https://reviews.freebsd.org/D60903
debug: classified in
03-filenames_plain1 by
'sys/fs/'
When the offset is within a block rather than at its beginning, the length should be clamped to the remaining length of the block, not its total length. Reported by: n0ps1ed MFC after: 1 week Reviewed by: markj, emaste Differential Revision: https://reviews.freebsd.org/D60904
debug: classified in
03-filenames_plain1 by
'sys/fs/'
Dropping the cached reply that is too large causes a correctness problem that is too difficult to fix, so revert this and leave it the way it was. Although there is an argument that not doing could cause resource exhaustion, it has not been reported in the field as a problem. MFC after: 1 month
debug: classified in
03-filenames_plain1 by
'sys/fs/'
Kernel stuff (other than networking, filesystems, and drivers).
rtwn: add support for the RTL8188FTV USB chipset Add support for the RTL8188FTV chipset to rtwn(4)/rtwn_usb(4). Differential Revision: https://reviews.freebsd.org/D60875
debug: classified in
04-filenames_plain2 by 'sys/'
rtwn: fix 8188f channel offset / width programming * rtwn_chan2centieee() already calculates the proper centre frequency, so it doesn't need to be further offset. * Don't program R92C_RF_CHNLBW with further 20MHz wide bits; the rest of the programming works correctly for 20/40MHz operation. Tested: * Verified against the linux rtl8xxxu/8188f.c code. * Tested w/ 20 and 40MHz 11n; 40MHz is now operating at higher speed. Fixes: https://cgit.freebsd.org/src/commit/?id=2c38dc04d6f8bc84620bb3b67c8ccd9f910c4d03
debug: classified in
03-filenames_plain1 by
'sys/dev/'
debug: moved to kernel because
'Need to be grouped with
2c38dc04d6f8bc84620bb3b67c8ccd9f910c4d03'
MFC after: 1 week Sponsored by: The FreeBSD Foundation
debug: classified in
04-filenames_plain2 by 'sys/'
min() truncates its parameters. MFC after: 1 week Sponsored by: The FreeBSD Foundation
debug: classified in
04-filenames_plain2 by 'sys/'
linux_recvmmsg_common() currently returns the error from the next recvmsg() attempt even when one or more datagrams have already been received and copied to userspace. This is especially visible with non-blocking UDP sockets. After receiving the first datagram, the next iteration commonly returns EAGAIN. The syscall then reports EAGAIN instead of the number of messages already stored in the mmsghdr array, causing applications to discard successfully received packets. This differs from Linux recvmmsg() semantics, where an error encountered after receiving at least one message is deferred and the number of received messages is returned. Return the accumulated datagram count and clear the error whenever at least one message was received. Preserve the original error when no messages were received. This fixes packet loss in applications such as wireguard-go, whose non-blocking receive path uses recvmmsg() for batches of UDP packets. In the observed failure, WireGuard handshake responses reached the UDP socket, but a subsequent EAGAIN caused recvmmsg() to hide the received response and the handshake timed out. Reviewed by: kib Pull Request: https://github.com/freebsd/freebsd-src/pull/2484 Differential Revision: https://reviews.freebsd.org/D60961
debug: classified in
04-filenames_plain2 by 'sys/'
- jump to dtrace_invop_jump_addr on kernel #BP - use ERETS instead of IRETQ when done Sponsored by: The FreeBSD Foundation MFC after: 1 week
debug: classified in
04-filenames_plain2 by 'sys/'
kmem_back() picks the domain from the address and, when that domain has
no memory, steps forward until it finds one that does:
domain = (addr >> KVA_QUANTUM_SHIFT) % vm_ndomains;
while (VM_DOMAIN_EMPTY(domain))
domain++;
Nothing stops the walk at vm_ndomains. When the empty domain is the
last one, the loop runs through the unused tail of vm_dom[] (all empty)
and on into whatever follows vm_dom[MAXMEMDOM] in memory, until a word
there happens to look like a non-zero page count; kmem_back_domain()
then allocates from that garbage domain. Ordinary allocations never
get here, because the per-domain arenas and the domainset iterators
skip empty domains. Only the direct callers of kmem_back() do: kinst
(one trampoline per thread, allocated when the module loads) and
memguard.
Signed-off-by: Wanpeng Qian <wanpengqian@gmail.com>
Reviewed by: kib, markj
Sponsored by: keelos.dev
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D60935
debug: classified in
04-filenames_plain2 by 'sys/'
RSS hash types are encoded values, not independent flags. The bitmask check in M_HASHTYPE_ISHASH_TCP() also accepts UDP, address-only and opaque hash types, causing the syncache to retain them instead of falling back to a software TCP hash. Compare against the three TCP four-tuple hash types after masking the inner-header flag. Keep the existing macro interface and use an inline helper to preserve single evaluation of its argument. Add ATF coverage for all 256 hash-type byte values, including inner-header hashes, and verify single evaluation of the mbuf argument. Reviewed by: cc, gallatin Fixes: https://cgit.freebsd.org/src/commit/?id=a485399f8834 ("tcp: restrict flowtype copying to specific RSS TCP types") Sponsored by: BBOX.io
debug: classified in
04-filenames_plain2 by 'sys/'
The same five lines to build and send an XPT_SET_TRAN_SETTINGS request to the controller were repeated for the bus timing, bus width, VCCQ and clock changes. Add sdda_set_host_ios() and use it at those places. No functional change. Reviewed by: bz Differential Revision: https://reviews.freebsd.org/D60921
debug: classified in
04-filenames_plain2 by 'sys/'
fd_freefile is maintained to fulfill the POSIX guarantee that the lowest possible file descriptor is allocated on open. If we skip copying an fd, it is a possible candidate for the lowest index. First, the file descriptor installed with a kqueue created without KQUEUE_CPONFORK missed this handling [*]. Second, fd_freefile should be updated only when the current fd index is below it. A skipped fd above fd_freefile could raise it past a free slot. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=300234 [*] Reported by: Andrea Venturoli <freebsd@netfence.it> Reviewed by: markj Fixes: https://cgit.freebsd.org/src/commit/?id=1265516c5c61 ("struct file: add DFLAG_FORK, indicate copying on fork") Fixes: https://cgit.freebsd.org/src/commit/?id=809f3121be66 ("fd: assign fd_freefile early when copying") MFC after: 1 week Differential revision: https://reviews.freebsd.org/D61054
debug: classified in
04-filenames_plain2 by 'sys/'
Reject empty keys in metadata lookups with EINVAL to prevent an infinite loop while holding allprison_lock and pr_mtx. Add tests for empty-key reads and writes with empty and populated meta/env buffers, trailing newlines, and empty final values. Reviewed by: igoro, jamie MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D61025
debug: classified in
04-filenames_plain2 by 'sys/'
COMPAT_FREEBSD8 does not exist as a kernel option, so this is dead code. No functional change intended. Fixes: https://cgit.freebsd.org/src/commit/?id=e256f71389fb ("kernel: add missed FEATUREs compat_freebsd 8-14") MFC after: 1 week Sponsored by: The FreeBSD Foundation Reviewed by: kib Pull-Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/80
debug: classified in
04-filenames_plain2 by 'sys/'
In vn_io_fault1(), the read / write length can easily exceed INT_MAX. Passing it directly to uiomove(), which expects an int, results in a negative uio_resid, which to the caller looks like we read more than was requested. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=298159 MFC after: 1 week Reviewed by: olce, kib Differential Revision: https://reviews.freebsd.org/D59412
debug: classified in
04-filenames_plain2 by 'sys/'
sosend_generic() read the TLS record type past a TLS_SET_RECORD_TYPE control message holding only a cmsghdr, and sent that stale byte. Approved by: markj Fixes: https://cgit.freebsd.org/src/commit/?id=b2e60773c6b0 ("Add kernel-side support for in-kernel TLS.") Sponsored by: Netflix
debug: classified in
04-filenames_plain2 by 'sys/'
Prior to this change, `jail_get` when called with `JAIL_USE|JAIL_GET_DESC` would fail to return a valid descriptor in the positive case because the `JAIL_USE_DESC` block jumped to `found_prison` before the descriptor was allocated. This resulted in the returned jail descriptor always being -1, despite the call being successful. This change fixes the logic so `jfd_out` is properly initialized in the aforementioned scenario. MFC after: 3 days Reviewed by: jamie, ngie, adrian Differential Revision: https://reviews.freebsd.org/D60984
debug: classified in
04-filenames_plain2 by 'sys/'
"LDFLAGS= -lutil" dropped LDFLAGS from make.conf for every test in the directory. Approved by: glebius Fixes: https://cgit.freebsd.org/src/commit/?id=c3ac06161dd5 ("nmount: Introduce the "check_fsid" option") Sponsored by: Netflix
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Makefile.inc1: Make sure mandoc bootstrap tool depends on libz It links against both libopenbsd and libz, so reflect this in the bootstrap tool's dependencies in case of races from highly-parallel builds. Reported by: jkh MFC after: 1 week
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Makefile.inc1: Make bootstrap mandoc's bootstrap libz dependency conditional We bootstrap libz unconditionally on macOS and Linux, and conditionally on FreeBSD if pre-1600029 or DISK_IMAGE_TOOLS_BOOTSTRAP is enabled, but if building on new enough -CURRENT without DISK_IMAGE_TOOLS_BOOTSTRAP then libz is not bootstrapped and so this libz dependency does not exist. Add the dependency whenever we are bootstrapping libz but not otherwise, and do so without duplicating the condition. Fixes: https://cgit.freebsd.org/src/commit/?id=1dbcc7ee92c4 ("Makefile.inc1: Make sure mandoc bootstrap tool depends on libz") MFC after: 1 week
debug: classified in
02-filenames_wildcards by
'.*Makefile'
This helps make the dependent Makefile (and the values contained within) easier to catch when upgrading atf in the future. MFC after: 1 week
debug: classified in
02-filenames_wildcards by
'.*Makefile'
The new `googletest` kyua test interface--added in 0.15.0 and fixed in
0.15.1--allows tests to be executed and handled in a more fine-grained
manner than the way it was prior to this commit.
This change deletes the `capsicum-test` ATF wrapper script,
`functional.sh`, and all supporting logic in `googletest.test.mk` as
well as this change makes that logic unnecessary.
MFC after: 1 month
MFC with: b68969979d6b ("contrib/kyua: update to 0.15.1")
debug: classified in
03-filenames_plain1 by
'share/mk/'
Some of the tests provided by GoogleTest don't play well with the kyua
GoogleTest engine available in 0.15.0, in part because they test
edgecases that the kyua GoogleTest engine does not expect or handle
gracefully.
Treat the tests as plain C++ tests to keep parity (result-wise) before
switching the testcase type from `plain` (what it is today under the
covers) to `googletest`.
MFC after: 1 month
MFC with: 3fb03fb35b20 ("[tests] switch GoogleTest tests to ...")
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Reviewed by: aokblast, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D60838
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Event: Oslo Hackaton 2026 Differential Revision: https://reviews.freebsd.org/D61040
debug: classified in
02-filenames_wildcards by
'.*Makefile'
All three of the test infrastructure components require at least C++20 in order to build. Make that version the default to better match what is required in recent versions of the projects. MFC after: 1 week
debug: Commit manually moved from "unknown" to "build".
Differential Revision: https://reviews.freebsd.org/D60943
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Distribution sets are going away, so we can't extract those into GCE images for all-source-code-included compliance purposes. Differential Revision: https://reviews.freebsd.org/D60944
debug: classified in
02-filenames_wildcards by '['.*Makefile',
'release/.*']'
Remove the "NODISTSETS" option and add a "DISTSETS" option. This option will remain, disabled by default, for the duration of the 16.x branch but will be removed in 17.0. With hat: re Relnotes: yes Differential Revision: https://reviews.freebsd.org/D60945
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Enable the FreeBSD-base repository in all of the /etc/pkg/FreeBSD.conf variants, and remove code from various install paths which enabled the repository via /usr/local/etc/pkg/repos/FreeBSD.conf. Relnotes: yes Differential Revision: https://reviews.freebsd.org/D60946
debug: Commit manually moved from "unknown" to "build".
Bump new USB changes. Also, update RELNOTE and UPDATING. Sponsored by: The FreeBSD Foundation
debug: Commit manually moved from "unknown" to "build".
Modify the existing code to permit setting a prefix via the `PREFIX` make variable, similar to what `--prefix` provides in autotools-based projects. Add the required compatibility glue in order to function with vanilla bmake, which enables installing the commands with Linux and macOS: - vanilla bmake requires `scripts.mk` to install `SCRIPTS`. - vanilla bmake does not tack `/man` on to the end of `MANDIR`, like with FreeBSD. While here, make the origins for various packages more generic, and encourage end-users to install the package via the package/port instead of installing it directly from source. NOTE: - regarding Linux support: this should now function out of the box with Linux as long as the host has access to an appropriate `arc` binary. - regarding macOS support: the arcanist/phorge packages do not yet exist in Homebrew or [MacPorts][1], but are being added soon. MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60995 [1]: https://github.com/macports/macports-ports/pull/36217
debug: classified in
03-filenames_plain1 by
'tools/tools/git/'
While here, remove two munmap(2) calls on mappings the tests require to have failed, since they are practically dead. MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D60800
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
This fixes the flaky testcase in CI[0]. While here: * fix a typo in a comment * remove an unnecessary import * fix this deprecation warning: /usr/local/lib/python3.12/site-packages/scapy/contrib/igmp.py:12: DeprecationWarning: scapy.contrib.igmp is deprecated. Please use scapy.layers.igmp instead ! [0] https://ci.freebsd.org/job/FreeBSD-main-amd64-test/29813/testReport/junit/sys.netpfil.pf.igmp/py/TestIGMP__test_ip_opts/ Reviewed by: kp MFC after: 3 days Sponsored by: The FreeBSD Foundation
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
This fixes a [CI failure][0]. [0] https://ci.freebsd.org/job/FreeBSD-main-amd64-test/29813/testReport/sbin.dhclient.functional/py/__test_cases_list__/ PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299641 Reviewed by: markj, ngie MFC after: 3 days Sponsored by: The FreeBSD Foundation Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/83
debug: classified in
02b-filenames_wildcards2 by
'sbin/.*/tests/.*'
Fixes: https://cgit.freebsd.org/src/commit/?id=a143197801c6 ("dhclient: Add some regression tests")
debug: classified in
02b-filenames_wildcards2 by
'sbin/.*/tests/.*'
Open /dev/pf and a generic Netlink socket as root, drop to nobody and exec pfctl with both inherited, the way authpf(8) runs it. Without -l the load is refused with EPERM; with it the rules land in the anchor. An unusable descriptor is an error, not a fallback to a new socket. Skips when fdescfs is not mounted, which -p /dev/fd/N needs. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291981 Signed-off-by: Avinash Duduskar <avinash.duduskar@gmail.com> Reviewed by: kp Pull Request: https://github.com/freebsd/freebsd-src/pull/2508
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
This test could fail under load due to lack of no_dad before. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299448 Reported by: siva Fixes: https://cgit.freebsd.org/src/commit/?id=aa9f669d09a7 ("geneve: Add tests for geneve")
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
fdcopy() skips plain kqueues and close-on-fork descriptors when it
copies the table into the child. Check that dup(2) in the child still
returns the lowest unused descriptor, both when the skipped descriptor
is the lowest free slot and when it sits above an existing hole.
Test cases:
kqueue_no_hole a plain kqueue is the lowest descriptor; the
child's dup() reuses its slot
kqueue_two two adjacent plain kqueues; the child's dup()
returns the lower one
kqueue_above_hole a plain kqueue sits above a closed descriptor;
the child's dup() returns the hole
kqueue_cponfork a KQUEUE_CPONFORK kqueue is copied; the child's
dup() returns the next slot
clofork_no_hole an O_CLOFORK descriptor is the lowest one; the
child's dup() reuses its slot
clofork_above_hole an O_CLOFORK descriptor sits above a closed
descriptor; the child's dup() returns the hole
Without 99a58803f9a3, kqueue_no_hole, kqueue_two and
clofork_above_hole fail.
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=300234
Reviewed by: kib
MFC after: 1 week
MFC with: 99a58803f9a3
Co-authored-by: Claude Code Opus 5.5
Differential Revision: https://reviews.freebsd.org/D61124
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
These could go in other categories, but it's more clear if they're here instead.
'man 3 gethostbyaddr_r' was incorrectly showing 9 arguments.
debug: classified in 01-style
by '[tT]ypo'
debug: classified in 01-style
by '[sS]tyle'
Changes: https://github.com/eggert/tz/blob/2026f/NEWS MFC after: 3 days
debug: classified in
03-filenames_plain1 by
'contrib/'
This new release contains multiple bugfixes. Please see the release notes mentioned in the merge commit for more details. MFC after: 2 weeks Merge commit '3e05143b80d1537cdd51a5dcf742da31f400507e'
debug: classified in
03-filenames_plain1 by
'contrib/'
Merge commit 'c51345cf234c029abf8b5f1655f65f6c2ffaaec9' Reviewed by: cperciva MFC after: 3 days Sponsored by: Amazon, Inc.
debug: classified in
03-filenames_plain1 by
'sys/contrib'
asn_get_ipaddress_raw() meant to pad the 4-byte buffer after a short copy, but the loop bound was the already-reached len and never ran, leaving addr[len..3] uninitialised. Pad to 4. This is harmless for the in-tree consumers (bsnmpd(1) and libbsnmpclient) which zero the PDU before decoding it. Reviewed by: harti, maxim Approved by: harti MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60923
debug: classified in
03-filenames_plain1 by
'contrib/'
authpf opens its pf handle as root and drops privileges before it runs pfctl to load the per-user ruleset. The child inherits the /dev/pf descriptor through -p /dev/fd/N, but since pf's control path moved to Netlink, pfctl opens a Netlink socket of its own, which carries the unprivileged credentials, and the first privileged command on it fails: every authpf login ends with "pfctl exited abnormally" on 15.x. Pass the socket authpf already holds with the new -l flag, next to the device. Clear FD_CLOEXEC on both descriptors before the exec so the handoff does not depend on how libpfctl happened to open them. The socket already reached the child: neither libpfctl nor snl opens its descriptors close-on-exec and authpf closes nothing before the exec, so since pf moved to Netlink the unprivileged pfctl has inherited it unused. Passing its number makes the handoff deliberate. The socket carries root's credentials for every generic Netlink family, so the child could reach pflow, carp and the kernel RPC family through it, not only pf; it already had full control of pf through /dev/pf. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291981 Signed-off-by: Avinash Duduskar <avinash.duduskar@gmail.com> Reviewed by: kp Pull Request: https://github.com/freebsd/freebsd-src/pull/2508
debug: classified in
03-filenames_plain1 by
'contrib/'
The child runs pfctl as the user with authpf's root-opened /dev/pf and Netlink descriptors. Its real and effective ids match at the exec, so the kernel clears P_SUGID and any other process of the user could attach to it and take both descriptors. Deny tracing across the exec; root can still attach, and core dumps are not affected. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291981 Signed-off-by: Avinash Duduskar <avinash.duduskar@gmail.com> Reviewed by: kp Pull Request: https://github.com/freebsd/freebsd-src/pull/2508
debug: classified in
03-filenames_plain1 by
'contrib/'
MFC after: 1 week Event: Oslo Hackathon 2026
debug: classified in
03-filenames_plain1 by
'contrib/'
libarchive 3.8.11 ChangeLog: https://github.com/libarchive/libarchive/compare/v3.8.10...v3.8.11 Obtained from: libarchive Vendor commit: 03036ffa409a2aa1c5bbad35be2202641a040fda MFC after: 3 days
debug: classified in
03-filenames_plain1 by
'contrib/'
The document does not reflect current reality with how updates/releases should be managed with contrib/atf . Update it to a state that better reflects current practices with git, as well as information about where the latest version of the project can be found, etc. This change will be used as a template for adding instructions on how to update contrib/kyua and contrib/lutok in future commits. MFC after: 1 month Reviewed by: ziaee, carlavilla Differential Revision: https://reviews.freebsd.org/D59879
debug: classified in
03-filenames_plain1 by
'contrib/'
bind_all_fibs: Disable bind_all_fibs by default
net.inet.{tcp,udp,raw}.bind_all_fibs was set to 1 for backward
compatibility. Set to 0 by default to drop them all unless an inpcb
bound to the same FIB exists.
While here, Add an UPDATING entry for behaviour change.
Relnotes: yes
Reviewed by: markj
Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/73
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
Revert "bind_all_fibs: Disable bind_all_fibs by default" This reverts commit 714433a6772b346723341735ef9547f672d9d2a3. There were issues reported by markj I will hold this commit until those are fixed.
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
style.Makefile(5): update recommendations - Mention `CXXFLAGS` and `CXXSTD`, in addition to `CFLAGS` and `CSTD`. - Mention `LIBADD`, in addition to the legacy (in-tree) variables, `DPADD` and `LDADD`. - Mention the other option types, e.g., `MK_FOO`, `WITHOUT_FOO`, etc, added as part of `src.opts.mk` in the past couple releases. Bump .Dd for the change. MFC after: 1 week
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
Revert "style.Makefile(5): update recommendations" This has not been reviewed yet - revert the change so it can be reviewed properly first. This reverts commit 68aebfa28a17189e1e697e612c0a1a2220b9fa2b.
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
git-arc: add initial non-FreeBSD and `$HOME` install support Modify the existing code to permit setting a prefix via the `PREFIX` make variable, similar to what `--prefix` provides in autotools-based projects. Add the required compatibility glue in order to function with vanilla bmake, which enables installing the commands with Linux and macOS: - vanilla bmake requires `scripts.mk` to install `SCRIPTS`. - vanilla bmake does not tack `/man` on to the end of `MANDIR`, like with FreeBSD. Adjust the sysctl calls to instead look for `arc` in `$PATH` using `command -v` instead of hardcoding the path to the `arc` binary. This allows the command to invoke `phorge` as well as the legacy `arcanist` tool. While here, update the origin for `arcanist` as the former is the non-phorge fork is no longer supported (nor needed). NOTE: - regarding Linux support: this should now function out of the box with Linux as long as the host has access to an appropriate `arc` binary. - regarding macOS support: the arcanist/phorge packages do not yet exist in Homebrew or MacPorts, but are being added soon. MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60995
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
Revert "git-arc: add initial non-FreeBSD and `$HOME` install support" This was in review and should not have been committed. This reverts commit 010e53f7c6908bee93d1bd32fb4b1658b0f19eef.
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
Apparently this device might need a separate driver altogether. This reverts commit 8dac0bdb4df0815e14db219e9a7fb5d0be5737b8.
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
bhyve/riscv: correctly handle empty masks and broadcast in SBI IPI/RFNC Bhyve treats an empty cpu set as an error which triggers MPASS panic in the guest. As per the SBI spec, empty masks should return SBI_SUCCESS, and a base of -1UL specifies a broadcast to all harts. Fix both in vmm_sbi.c, clear a1 on return, and skip the SBI ecall in sbi_ipi_pic_ipi_send() if the mask is empty. Also add a NULL check in riscv_send_ipi(). Signed-off-by: Doongar Singh <doonbsd@gmail.com> Reviewed by: br Differential Revision: https://reviews.freebsd.org/D61126
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
Revert "bhyve/riscv: correctly handle empty masks and broadcast in SBI IPI/RFNC" This reverts commit ada1f577cc291336cbb69782075dbbf9fe746872.
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
Not classified automatically, and waiting for manual attention.
-- no commits in this category this week --
Dates:
cgit.freebsd.org/src. Git accurately records the
order of commits, but not their dates.Automatic grouping:
This reverts commit \\b([0-9a-fA-F]{40})\\b
and the hash was found in this week's commits.
Automatic categories:
Source code:
Generated with commits-periodical 0.21 at 2026-11-03 03:23:55+00:00.
This work is supported by Tarsnap Backup Inc.
Alternate version: 2026-10-26 (release)