FreeBSD git weekly: 2025-09-22 to 2025-09-28

Nearly everyone wants powerd to manage CPU frequency scaling on real
hardware, even if -utilities isn't installed.  Conversely, very small
jails might want -utilities but don't need powerd.

Move it to its own package and add it to the minimal set.

MFC after:      1 day
Reviewed by:    manu, imp
Differential Revision:  https://reviews.freebsd.org/D52645

Due to the size of libpmc.so.5, this reduces the size of the -utilities
package by 10%.

MFC after:      1 day
Reviewed by:    manu, adrian, emaste
Differential Revision:  https://reviews.freebsd.org/D52662

Currently libbz2 is in the libbz2 package, while bzip2 itself is in
-utilities, which is inconsistent.  Move both the library and the
utility to a new -bzip2 package, and use LIB_PACKAGE to create a
separate -bzip2-lib package for runtime dependencies.

Add the bzip2 package to the minimal set, and since newsyslogd uses
bzip2 for logfile compression, add a dependency from there.

MFC after:      1 day
Reviewed by:    manu
Differential Revision:  https://reviews.freebsd.org/D52663

Sponsored by: The FreeBSD Foundation
Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D52583

The timeout parser would check the first character after the number and
ignore any subsequent ones.

While here, switch to bool for booleans and fix some style nits.

MFC after:      1 week
Reviewed by:    0mp, markj
Differential Revision:  https://reviews.freebsd.org/D52612

blackhole.4: Describe better

Rewrite the document description to fit cleanly on one line and omit
crossreferences, to clean up apropos results.

MFC after:              3 days
Reviewed by:            tuexen, cperciva
Differential Revision:  https://reviews.freebsd.org/D52695

blackhole.4: Describe even better

Rewrite the document description to omit ficticious "UDP connections".

Fixes:                  https://cgit.freebsd.org/src/commit/?id=38f6a4467419 (blackhole.4: Describe better)
MFC after:              3 days
Reviewed by:            tuexen
Reported by:            tuexen, zi
Differential Revision:  https://reviews.freebsd.org/D52696

A predicate cannot be used without an action.

MFC after:      3 days
Event:          EuroBSDCon DevSummit 2025

Approved by:  bcr, ziaee
MFC after:      1 week
MFC to:         stable/14, stable/15
Sponsored by:   Rubicon Communications, LLC ("Netgate")
Differential Revision:  https://reviews.freebsd.org/D52620

I meant to change this to tuexen's suggestion upon commit but failed.

MFC after:      3 days
Fixes:          https://cgit.freebsd.org/src/commit/?id=9e02de4ad6c3 (blackhole.4: Describe even better)

While here, remove whitespaces at end of lines.

Event:  EuroBSDcon 2025 Devsummit

Consolidate examples to build the system in the build(7) manual where
the details about the syntax involved is documented. Remove them from
development(7), instead adding examples for patching the trees. They
are left in UPDATING for now, to hopefully be removed eventually.

Reduce documentation proliferation and create consistent, maintainable
doc about building the system, eventually removing the COMMMON ITEMS
section of UPDATING so there is a single source of truth in the cannon
and well-integrated location, the in-band system reference manual.

+ Example 1: Build and upgrade system in place
+ Example 2: Build and upgrade a custom kernel in place
+ Example 3: Build and upgrade a single piece of userspace
+ Example 4: Build and upgrade a loadable kernel module
+ Example 5: Quickly rebuild a kernel in place
+ Example 6: Cross-compiling for different architectures

The examples section of development(7) now contains examples for
applying patches to the trees.

There is certainy much more to do here, but it needs to be chunked.

MFC after:              3 days
Reviewed by:            imp (previous version), ivy (previous version)
Discussed with:         emaste, imp, jhb, ivy
Differential Revision:  https://reviews.freebsd.org/D48693

Reviewed by:          bcr
Differential Revision:  https://reviews.freebsd.org/D52698

ok henning, mcbride, jmc

Obtained from:  OpenBSD, mikeb <mikeb@openbsd.org>, 355f9a50c1
Sponsored by:   Rubicon Communications, LLC ("Netgate")

- use imperative tense in the pf.conf(5) "once" part
- leave printing implementation details to pfctl(8)'s "-s rules" part
- use more markup
- debug mode also prints expired rules

OK jmc sashan

Obtained from:  OpenBSD, kn <kn@openbsd.org>, 1f1797aba7
Sponsored by:   Rubicon Communications, LLC ("Netgate")

Update man page to account for chnage in timeout representation
(sbintime_t vs power-of-2 nanoseconds), and addition of new
WDIOC_CONTROL ioctl.

Reviewed by:    ziaee
MFC after:      3 days
Sponsored by:   Juniper Networks, Inc.
Differential Revision:  https://reviews.freebsd.org/D52479

MFC after:    3 days
Reviewed by:    ziaee
Signed-off-by:  Minsoo Choo <minsoochoo0122@proton.me>
Closes:         https://github.com/freebsd/freebsd-src/pull/1853

The packages target was previously listed under kernel, move it to the
general source make targets listing. Add the update-packages target as
well. Adjust the release building targets with package in their names
to clarify they are unrelated to pkgbase. Add the OBJROOT and REPODIR
variables to ENVIRONMENT.

MFC after:              3 days
Reviewed by:            ivy, markj (both previous versions)
Suggestions by:         des, emaste, ivy, kevans, markj
Fixes:                  https://cgit.freebsd.org/src/commit/?id=1d26746cfd4a (Document the packages target)
Fixes:                  https://cgit.freebsd.org/src/commit/?id=0ac8aa55da1c (Add incremental packages)
Fixes:                  https://cgit.freebsd.org/src/commit/?id=26490d9b74f0 (allow update-packages for first)
Differential Revision:  https://reviews.freebsd.org/D50289

It's the same as lockmgr(9), which the man page already refers to.

While here, use Ev for TMPDIR consistently.

MFC after:      3 days
Event:          EuroBSDCon 2025

+ Rewrite SYNOPSIS for consistency
+ Rewrite HARDWARE for HW Relnotes, and add some stragglers
+ Correct mdoc grammar, making sysctls aproposable and linking xrefs
+ Clean up TODO, cannonicalize to CAVEATS, a standard section
+ Editorial pass, tag SPDX

MFC after:              3 days
Reviewed by:            imp
Differential Revision:  https://reviews.freebsd.org/D52125

Reported by:  bcr
Reviewed by:    bcr
MFC after:      3 days
Event:          EuroBSDCon 2025
Fixes:  https://cgit.freebsd.org/src/commit/?id=5eb1caa8c845 Updated SYSCTL manual pages
Differential Revision:  https://reviews.freebsd.org/D52768

Sponsored by: The FreeBSD Foundation
Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D52583

MFC after:      3 days
Event:          EuroBSDCon 2025
Sponsored by:   The FreeBSD Foundation

Lower values may result in non-acknowledged interrupts. E.g. ITE5570 device
found in ASUS TUF. Greater values may result in read failures. E.g. GXTP7863
device found on MateBookPro 2023.

Investigated by:        huanghwh@gmail.com
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289353
MFC after:      1 week
fixes:          36027361f9cf ("iichid: Stop using split I²C bus transactions")

It is required since "iichid(4): Always use wMaxInputLength bytes
as input report length" commit.

MFC after:      1 week

MFC after:    1 week
fixes:          36027361f9cf ("iichid: Stop using split I²C bus transactions")

arm64/vmm: Add a feature flag and use it for HCRX

Add a field to hold the features the hardware supports that need to be
handled when switching to a guest and use it to handle FEAT_HCX that
adds the HRX_EL2 register.

This reduces the number of times we read ID registers in guest
switching which may be trapped when running under nested virtualisation.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D51816

arm64/vmm: Clean up enabling guest timer access

Clean up the name of CNTHCTL_EL2 field macros and expand to include
more fields. This makes it easier to see which accesses are trapped or
not trapped.

While here set the register directly. We already set it in locore.S so
there is no need to read that and modify it.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D51817

arm64/vmm: Remove support for reading CNTHCTL_EL2

This is now unused as we just set the register value directly.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D51818

These will be used to support the Enhanced Counter Virtualization
Extensions: FEAT_ECV and FEAT_ECV_POFF. The former adds
Self-Synchronized registers, and the latter adds support for an offset
for the physical counter.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D51819

When FEAT_ECV is implemented on arm64 a Self-Synchronized view of the
counter registers are available. These don't need an isb before reading
the count as they are not able to be speculatively executed.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D51820

Support guest access to the physical timer when FEAT_ECV_POFF is
supported. In this case we can set an offset for the physical timer.
We can reuse the virtual timer support to also support the physical
timer, with a few more registers needing to be handled when switching
to a guest.

As it is not clear how this will affect performance when the guest
doesn't use it hide enabling it behind a sysctl.

It is expected this will be useful when Nested Virtualisation is
supported as guests are expected to use the physical timer registers.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D51821

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216568
MFC after:      1 week
Reviewed by:    christos, kib
Differential Revision:  https://reviews.freebsd.org/D52509

Reviewed by:  markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52607

The variant of wrmsr_safe(9) that might work before IDT and curpcb are
initialized.  Assumes BSP, and that all APs are parked.

Before calling wrmsr_early_safe(), the wrmsr_early_safe_start() should
be called, afterward wrmsr_early_safe_end() restores the bootenv IDT.

Reviewed by:    markj
Tested by:      glebius
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52607

to avoid recursion on u2f mutex and taking of hidbus sleepable lock.

Tested by:      emaste
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289494
MFC after:      2 days

Not all registers have a write mask with high/low register on rk3568.

Reviewed by:    vexeduxr
MFC after:      5 days
Differential Revision:  https://reviews.freebsd.org/D52512

The code is based on bcm2835_gpio.c. This enables allocating gpio
interrupts via interrupts property in fdt.

Reviewed by:    vexeduxr
MFC after:      5 days
Differential Revision:  https://reviews.freebsd.org/D52513

Include VLAN tag in policy and SA outbound rules so that rules from
VLAN interfaces differ from physical interface rules, preventing
duplicate rule creation in VLAN configurations.

Sponsored by:   Nvidia networking
MFC after:      1 week

Enable the handling of the IFCAP_RXCSUM_IPV6 handling by handling
IFCAP_RXCSUM and IFCAP_RXCSUM_IPV6 as a pair. Also make clear, that
software and hardware LRO require receive checksum offload.

Reviewed by:            Timo Völker
MFC after:              3 days
Differential Revision:  https://reviews.freebsd.org/D52682

FEAT_PAN3 adds the SCTLR_EL1.EPAN field. This tells the hardware to
raise a permission abort when userspace could execute a page, i.e. the
ATTR_S1_UXN field is clear in the page table.

This causes issues for the EFI runtime as we only mark non-executable
pages with this flag leading to a permission fault when accessing it.

Fix this by marking all EFI mappings with ATTR_S1_UXN. The kernel
already had this field set so was already safe.

Reported by:    tuexen
Reviewed by:    tuexen
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52750

Use table attributes to also limit unprivileged access to the EFI
runtime mappings. This is mostly for parity with pmap as this is never
mapped while userspace could execute.

Reviewed by:    tuexen
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52751

This is as opposed to using ACPI sleep states directly
(`ACPI_STATE_S*`). We now use `POWER_STYPE_*` added in D52036.

This is in preparation for adding support for s2idle, which is not an
ACPI sleep state, but needs to be handled specially by
`acpi_EnterSleepState`.

Reviewed by:    cy
Approved by:    cy
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52705
Event:          EuroBSDcon 2025 Devsummit

When writing an ACPI S-state to it it will set kern.power.suspend to the
appropriate sleep type, and when reading from it it will return the
corresponding ACPI S-state to the sleep type in kern.power.suspend.

This is deprecated and kern.power.suspend should be used directly
instead, but add this back because zzz(1) makes use of this and we can't
easily rewrite it just now.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289634
Reviewed by:    cy, markj
Approved by:    cy, markj
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52600
Event:          EuroBSDcon 2025 Devsummit

Use the new method for wrmsr that is able to set up fault handler even at
the very early stage of kernel boot.  This prevents panic with new
microcode for some new AMD EPYCs, that requires certain patchlevel of
microcode to be already present in the CPU.  If BSP patching failed, we
print the message and we don't try to patch APs.

This has been tested only on AMD booted in EFI mode.

Reviewed by:            stas, kib
Differential Revision:  https://reviews.freebsd.org/D52643

Add initial USB4 code written by Scott Long and originally passed on to
HPS (source: https://github.com/hselasky/usb4), minus the ICM code and
with some small fixes.

For context, older TB chips implemented the connection manager in
firmware (ICM) instead of in the OS (HCM), but maintaining the ICM code
would be a huge burden for not many chips.

Mostly completed work:

- Debug/trace framework.
- NHI controller driver.
- PCIe bridge driver.
- Router and config space layer handling (just reading in this commit).

Link to the email where Scott shared details about the initial USB4
work:

https://lists.freebsd.org/archives/freebsd-hackers/2024-July/003411.html

Glanced at by:  emaste, imp
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D49450
Event:          EuroBSDcon 2025

Keep the hwassist flags for transmit checksum offload and transmit
segment offload in sync with the enabled capabilities.

Reported by:            Timo Völker
Reviewed by:            Timo Völker
MFC after:              3 days
Differential Revision:  https://reviews.freebsd.org/D52765

virtual_oss: Port to base

This patch diverges quite a bit from the current upstream [1] in a few
ways:

1. virtual_oss(8), virtual_bt_speaker(8) and virtual_oss_cmd(8) are
   actually separate programs.
2. Backends (lib/virtual_oss) are built as separate shared libraries and
   we dlopen() them in virtual_oss(8) and virtual_bt_speaker(8) on
   demand.
3. virtual_equalizer(8) and the sndio and bluetooth backends are built
   as ports, because they depend on third-party libraries.
4. Use newer libav API in bluetooth backend (see HAVE_LIBAV ifdefs) to
   address compiler errors.

[1] https://github.com/freebsd/virtual_oss

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D52308

virtual_bt_speaker(8): Fix aarch64 build

Reported by:    fuz, otis
Fixes:          https://cgit.freebsd.org/src/commit/?id=9cab9fde5eda ("virtual_oss: Port to base")
Sponsored by:   The FreeBSD Foundation

commit 31ec8b6407fdd5a87d70265762457c67ce618283 added a `dad_failures`
variable to `struct nd_ifinfo`, which broke the netowrking ABI.

This commit fixes it by moving such variable to `struct in6_ifextra`
which is not a public interface, while `struct nd_ifinfo` is back
in its original state.

Thanks to kib, markj and glebious for their help and suggestions
in solving this problem.

Reported by:    "Herbert J. Skuhra" <herbert@gojira.at>
Tested by:      "Herbert J. Skuhra" <herbert@gojira.at>
Approved by:    glebius
Fixes:          https://cgit.freebsd.org/src/commit/?id=31ec8b6407fdd5a87d70265762457c67ce618283

States created by inbound af-to rules bypass outbound filtering and span
both the inbound and outbound interfaces. When the first packet for such rule
creates a state, this state has st->orig_kif set the original inbound interface
and kif set to V_pfi_all. When the outbound interface is eventually
known st->kif is updated to that interface. When not using route-to,
the outbound route and its interface are determined for the new address family
and st->kif is set to that interface. However when using route-to, ifp
is explicitely given and the code for updating st->kif is not run for
the first packet. When the returning packet matches the state, the code is
run but updates st->kif to the original inbound interface, which is now
the outbound interface. The state ends up with st->kif == st->orig_kif
and won't forward any more returning packets.

There is another block of code performing such update, but only for reply-to.

Perform the update of st->kif in a single place no matter if ifp was
explicitely given or found by routing lookup. For checks using pings
check if really all pings have been replied to, because a single reply
is enough to have ping exit with a successful exit code.

Reviewed by:    kp
Sponsored by:   InnoGames GmbH
Differential Revision:  https://reviews.freebsd.org/D52445

A new version of pfsync packet is introduced: 1500. This version solves
the issues with data alignment introduced in version 1400 and adds syncing
of information needed to sync states created by rules with af-to (original
interface, af and proto separate for wire and stack keys), of rt_af
needed for prefer-ipv6-nexthop, and of tag names.

Reviewed by:    kp
Sponsored by:   InnoGames GmbH
Differential Revision:  https://reviews.freebsd.org/D52176

Take endpoint parameters into account when available.

Fixes:          https://cgit.freebsd.org/src/commit/?id=463b5aed0d62 ("tcp: retire rstreason")
MFC after:      3 days
Sponsored by:   Netflix, Inc.

Remove a check which is also done in tcp_lro_rx_common().

Reviewed by:            gallatin
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52683

A jailed process, `sysctl -j foo` or `jexec foo sysctl`, do not have
privilege to write to non-vnet sysctls but only to those marked as jail
writable, aka sysctls those marked with CTLFLAG_VNET flag.

Without this change we will get EPERM when trying to expire and purge
hostcache entries of vnet jails via the net.inet.tcp.hostcache.purgenow
sysctl. Fix that by adding a CTLFLAG_VNET flag.

Reviewed by:    tuexen, #transport, #network
Fixes:  https://cgit.freebsd.org/src/commit/?id=264563806496 Add a new sysctl net.inet.tcp.hostcache.purgenow=1 to expire ...
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52692

The two sysctls net.inet.tcp.hostcache.list and net.inet.tcp.hostcache.histo
are readonly and are to operate hostcache of vnet jails. Add CTLFLAG_VNET
flag to them since they are per-vnet sysctls.

This change does not have any impact on reading the two sysctls, but
`sysctl -ANV net.inet.tcp.hostcache` will report them correctly.

Reviewed by:    tuexen, #transport, #network
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52693

It's possible for interface groups to not have had a pfi_kkif assigned to
them, so before we pass that pointer to pfi_kkif_update() we must check if it's
actually set.

We've seen panics such as this, where we get an address update for an interface
that belongs to a group without associated pfi_kkif:

        Tracing pid 12 tid 100034 td 0xfffff80100d2a000
        kdb_enter() at kdb_enter+0x33/frame 0xfffffe0067eed340
        panic() at panic+0x43/frame 0xfffffe0067eed3a0
        trap_pfault() at trap_pfault+0x3c9/frame 0xfffffe0067eed3f0
        calltrap() at calltrap+0x8/frame 0xfffffe0067eed3f0
        --- trap 0xc, rip = 0xffffffff8102ebd5, rsp = 0xfffffe0067eed4c0, rbp = 0xfffffe0067eed500 ---
        pfi_kkif_update() at pfi_kkif_update+0x15/frame 0xfffffe0067eed500
        pfi_kkif_update() at pfi_kkif_update+0x1fc/frame 0xfffffe0067eed550
        pfi_ifaddr_event() at pfi_ifaddr_event+0x82/frame 0xfffffe0067eed5a0
        srcaddr_change_event() at srcaddr_change_event+0xa7/frame 0xfffffe0067eed610
        in6_update_ifa() at in6_update_ifa+0xd52/frame 0xfffffe0067eed790
        in6_ifadd() at in6_ifadd+0x29a/frame 0xfffffe0067eed8b0
        nd6_ra_input() at nd6_ra_input+0xf65/frame 0xfffffe0067eeda90
        icmp6_input() at icmp6_input+0x3c8/frame 0xfffffe0067eedc10
        ip6_input() at ip6_input+0xa15/frame 0xfffffe0067eedcf0
        sppp_input() at sppp_input+0x502/frame 0xfffffe0067eedd80
        pppoe_data_input() at pppoe_data_input+0x1e7/frame 0xfffffe0067eeddf0
        swi_net() at swi_net+0x128/frame 0xfffffe0067eede60
        ithread_loop() at ithread_loop+0x239/frame 0xfffffe0067eedef0
        fork_exit() at fork_exit+0x7b/frame 0xfffffe0067eedf30
        fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0067eedf30

Note that pf doesn't assign pfi_kkif objects to groups created before pf has
fully started (see V_pf_vnet_active check in pfi_attach_group_event()), which is
one possible way for this to happen.

Reported by:    garga
Sponsored by:   Rubicon Communications, LLC ("Netgate")

When we're NAT-ing give dummynet (via its struct ip_fw_args) the pre-NAT source
and destination addresses.
That's what we used to do, but that got unintentionally changed during the nat64
work.

The pre-NAT addresses make somewhat more sense, in that it enables limiting
based on specific LAN clients.

See also:       https://redmine.pfsense.org/issues/15770
Sponsored by:   Rubicon Communications, LLC ("Netgate")

Stop incrementing m_data so the callee can read the mbuf.

MFC after:      3 days
Reviewed by:    glebius
Differential Revision:  https://reviews.freebsd.org/D52702

Add support for one shot rules that remove themselves from an active
ruleset after match.
This is an extremely handy technique for firewall proxies.

ok henning, mcbride

Note that the FreeBSD implementation differs significantly from the OpenBSD
version due to locking differences. We do not remove the rule, but mark it as
having fired previously so we can skip it.

Obtained from:  OpenBSD, mikeb <mikeb@openbsd.org>, c981122504
Obtained from:  OpenBSD, sashan <sashan@openbsd.org>, a21b78cad0 (partial)
Sponsored by:   Rubicon Communications, LLC ("Netgate")

Obtained from:        OpenBSD, sashan <sashan@openbsd.org>, 8cf23eed7f
Sponsored by:   Rubicon Communications, LLC ("Netgate")

time_t has a different size on different platforms (i.e. 32-bit on i386, 64-bit
on others). Rather than always exporting it as 64-bits use the platform-native
size.
This means we can safely write directly into a time_t variable, which we can't
do on i386 eif we export 64 bits.

Sponsored by:   Rubicon Communications, LLC ("Netgate")

memcpy should copy to the current mbuf, otherwise we're copying to the
first mbuf in the chain over and over.

Reported by:    kevans
Reviewed by:    glebius
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52713

Refactor tcp_send_challenge_ack() such that the logic checking whether
a challenge ACK is sent or not is available in the separate function
tcp_challenge_ack_check(). This new function will also be used for
sending challenge ACKs in the SYN-cache code, which will be added in
upcoming commits.
No functional change intended.

Reviewed by:            cc, Nick Banks, Peter Lei
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52717

pf: Always skip outbound filtering for inbound af-to rules

The af-to rules on inbound direction create a single state spanning both
the inbound and the outbound interface. Calling pf_test() for the
outbound direction in pf_route() makes the packet pass through state
search, match the existing state, never evaluate the ruleset, and increase
state counters.

Check that the state comes from an af-to rule in inbound direction, and
if yes, skip outbound testing.

Reviewed by:    kp
Sponsored by:   InnoGames GmbH
Differential Revision:  https://reviews.freebsd.org/D52446

pf: Fix rule and state counters

Increasing counters on "match" rules causes the 1st packet making a
connection to be double-counted, but only for rule counters, not rules'
tables, because those are not increased at all during rule parsing.
Remove "match" rule counter handling during rule parsing, do it only in
pf_counters_inc().

NAT can be performed either by "nat" rules in the  NAT ruleset or by "match"
rules. Rules before the NAT rule, and the NAT rule itself match on pre-NAT
addresses, and later rules match on post-NAT addresses. When increasing
counters go over rules in the same order as a packet would and use
source and destination addresses for updating table counters from
appropriate state key, taking into consideration on which rule NAT
happens.

Use AF from state key, so that table counters can be properly updated for
af-to rules.

Synchronize match rule updating behaviour to that of OpenBSD: if rules
match, but state is not created, don't update counters.

Reviewed by:    kp
Sponsored by:   InnoGames GmbH
Differential Revision:  https://reviews.freebsd.org/D52447

pf: Fix interface counters for af-to rules

An inbound af-to rule creates a state bypassing outbound pf_test().
In such case increase counters of the outbound interface directly in
pf_route() for post-af-to address family.

For outbound af-to rules ensure that post-af-to address family is used
to increase interface counters.

Reviewed by:    kp
Sponsored by:   InnoGames GmbH
Differential Revision:  https://reviews.freebsd.org/D52448

This fixes "usage: basename string [suffix]" message.

Reported by:    cy
MFC after:      1 day

Instead of sleeping while constructing the list of PIDs to wait for,
sleep briefly after pwait to give init a chance to reap the processes
that just terminated before we loop around and start probing them.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289630
Reviewed by:    allanjude
Differential Revision:  https://reviews.freebsd.org/D52619

Fix "run-under-chroot" workaround by replacing strlcpy(2) with
memmove(2) since strings overlap.

MFC after:      1 week
Reviewed by:    arrowd
Differential Revision:  https://reviews.freebsd.org/D52670

Upgrading from 14.x to 15.x with freebsd-update broke because libc
depends on the new libsys library; freebsd-update installed the new
libc before creating libsys, and every step after that failed because
all the tools (including gunzip and install) are dynamically linked
and need a working libc.

Enforce ordering when installing shared objects: First libsys, then
libc, then libthr, and then all the rest of the shared object files.

This is a candidate for an Errata Notice since the issue this fixes
breaks upgrades.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289769
Reported by:    Graham Perrin
Reviewed by:    kib
MFC after:      3 days
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D52688

Now that the pkg package is shipped on the pkgbase release media,
install it by default for a pkgbase install if it's present.

If it's not available (e.g., when running bsdinstall from a repository
built from src alone, without ports), skip it and assume the user will
install it another way.

MFC after:      1 day
Reviewed by:    ifreund_freebsdfoundation.org, cperciva
Differential Revision:  https://reviews.freebsd.org/D52639

c99bb5747f5e changed ( ) grouping into { }, but in these cases we chdir
and depended on the subshell not changing it for the caller. Restore the
old behavior. It seems to work w/o this change, true, but the old code
was intentionally like this.

Fixes: https://cgit.freebsd.org/src/commit/?id=c99bb5747f5e
Sponsored by:           Netflix

Reviewed by:          bapt
Differential Revision:  https://reviews.freebsd.org/D52697

ok henning, mcbride

Obtained from:  OpenBSD, mikeb <mikeb@openbsd.org>, 44b1b5a8a9
Sponsored by:   Rubicon Communications, LLC ("Netgate")

ok henning

Obtained from:  OpenBSD, mikeb <mikeb@openbsd.org>, 47068a62ee
Sponsored by:   Rubicon Communications, LLC ("Netgate")

* Merge `once' handling from `anchorrule' and `pfrule'
* Remove/shorten duplicate code block

OK sashan

Obtained from:  OpenBSD, kn <kn@openbsd.org>, d114b77333
Sponsored by:   Rubicon Communications, LLC ("Netgate")

parse.y revision 1.682 from 16.07.2018 errornously allowed `match once' and
`anchor "a" once'.

Fix both by checking for PF_DROP not PF_MATCH and creating anchors in the
parser already such that they can be used to distinguish anchor rules in
the same check as well.

Found and fixed by Petr Hoffmann <petr.hoffmann at oracle dot com>, thanks!

While here, remove an unneeded cast and make pfctl_add_rule() void as it
always returned 0.

OK sashan

Obtained from:  OpenBSD, kn <kn@openbsd.org>, 6da84b37b3
Sponsored by:   Rubicon Communications, LLC ("Netgate")

After the refactoring in 'pfctl: fix once rules' we broke nat/rdr/binat rules.
These no longer exist on OpenBSD, so were not considered in that patch. Factor
out the common code and call it from all anchor types.

Sponsored by:   Rubicon Communications, LLC ("Netgate")

We already track this in the kernel and pass it to userspace, we may as well
show users.

Sponsored by:   Rubicon Communications, LLC ("Netgate")

The 'rule_numbers' is used for more than just displaying rule numbers.
Rename it and move the actual opts checking into the relevant functions.

Sponsored by:   Rubicon Communications, LLC ("Netgate")

In cloud-init, when a group specified in the 'users.{index}.groups' parameter
does not exist, it is ignored, but the user is created anyway. In the case of
nuageinit, it exits with an exception, since pw(8) expects each group to exist.

Reviewed by:            bapt@
Approved by:            bapt@
Differential Revision:  https://reviews.freebsd.org/D52718

After f99f0ee14e3a ("rc.d: add a service jails config to all base system
services"), the FTP service ignores the flags configured in ftpd_flags:

    # sysrc ftpd_flags=-B
    ftpd_flags:  -> -B
    # service ftpd enable
    ftpd enabled in /etc/rc.conf
    # service ftpd start
    Starting ftpd.
    # pgrep -fl ftpd
    1234 /usr/libexec/ftpd -D

Notice the absence of the "-B" flag.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285600
Reviewed by:    0mp, emaste
Approved by:    emaste (mentor)
Fixes:  https://cgit.freebsd.org/src/commit/?id=f99f0ee14e3a ("rc.d: add a service jails config to all base system services")
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D52745

virtual_oss is part of base as of 9cab9fde5eda ("virtual_oss: Port to
base").

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D52322

Useful when used with syslog-ng, which uses SIGUSR1.  Instead of adding
signal number to every new entry, just set it via command line option.

Reviewed by:            bcr, delphij
Differential Revision:  https://reviews.freebsd.org/D52701

If a newsyslog.conf(5) has an entry that is configured to be rotated every
hour, and crontab(8) is set to execute newsyslog several times per hour,
the logic of age_old_log() is broken and it would rotate the entry too
often.  AFAIU, the extra 1800 seconds were added to allow some leeway for
the previous newsyslog invocation, that could have been too slow and the
timestamp on the old file is newer than actual time of the previous
newsyslog invocation.  But 30 minutes of leeway is way to much.  Reduce
this down to 3 minutes, which would be a compromise between a potential
need to run newsyslogd every 5 minutes and a situation when newsyslog
takes a significant time to rotate the logs.

Provide a test case for that.

Reviewed by:            delphij
Differential Revision:  https://reviews.freebsd.org/D52700

by forwarding the reference to libsys syscall symbol, for the libc.so
case.

Reviewed and tested by: kevans
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52672

There are no symbols that needs to be namespaced in the header, and it
would not allow to use proper raw syscall names later, where they are
needed.

Reviewed by:    olce
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52687

same as it was done for setgroups@FBSD_1.0.
Switch from weakref to symver, since GNU as cannot handle version spec
with weakref.

Reviewed by:    olce
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52687

after libc is switched to use public symbols for pre-ino64 syscalls.

Reviewed by:    olce
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52687

Looks like a copy and paste error.
The ELF size of 0 prevents Valgrind from redirecting this function.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289845
Reviewed by:    fuz
Fixes:          https://cgit.freebsd.org/src/commit/?id=3f224333af163d5fcd7547a20993dcf18f19076c
See also:       https://bugs.kde.org/show_bug.cgi?id=509406
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1854
MFC after:      1 day
Event:          EuroBSDcon 2025

Commit c5d671b added netlink support to
server side rpcbind. However it did not add
a case for AF_NETLINK to __rpc_taddr2uaddr_af().
(Reported as PR#289625.)

As such, without this patch the r_addr field of the
netlink rbllist is NULL, which causes a crash in
svc_sendreply() for a Dump query (what rpcinfo
does).

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289625
Reviewed by:    glebius
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52651
Fixes:  https://cgit.freebsd.org/src/commit/?id=c5d671b711c3 ("libc/rpc: add userland side RPC server over netlink(4)")

It is defined as a plain use of vref.

Churn generated with coccinelle:
@@
expression vp;
@@

- VREF(vp)
+ vref(vp)

Implements pipe_destroy as a counterpart to pipe_create, no functional
changes.

Arguably code could be refactored so that ino allocation only happens
after bufs are allocated.

These files include a vmm_hyp equivalent file but don't have a
dependency recorded. Fix this by manually adding this dependency.

This is only a problem in a non-GENERIC configuration as normally vmm
is loaded as vmm.ko.

Reviewed by:    imp
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D51822

nfc

This makes non-GENERIC kernel configs easier to maintain.

Requested by:   glebius
MFC after:      2 days

The flag is guarded by proc lock which is already held.

After tracing poudriere for over 4 hours like so:
dtrace -n 'fbt::do_fork:entry { @[curthread->td_proc->p_flag & 0x2] = count(); }':

    2         15605151
    0         20074116

Over 56% of cases did not have P_CONTROLT set and could have avoided the
lock.

This reduces hold time of the proctree lock.

Allow PM backends to report supported sleep types when registering
through `power_pm_register`. Expose this information through
`kern.power.supported_stype` sysctl, and set defaults for
`power_standby/suspend/hibernate_stype` based on this.

Implement this in ACPI PM backend.

Reviewed by:    cy
Approved by:    cy
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52727
Event:          EuroBSDcon 2025 Devsummit

There is precisely one place using it and even that should probably go
away.

The kernel was already mostly using plain NULL, just whack it and be
doen with the legacy.

Churn generated with coccinelle:
@@
@@

- NULLVP
+ NULL

No point after hot patching was introduced.

This was retained for KPI compatibility, but I can't find anything which
needs it.  Just get rid of it.

Reported by:    rwatson
Reviewed by:    alc, kib
Differential Revision:  https://reviews.freebsd.org/D52708

MFC After:            3 day
Reviewed by:            ivy
Differential Revision:  https://reviews.freebsd.org/D52689

Nearly everyone wants powerd to manage CPU frequency scaling on real
hardware, even if -utilities isn't installed.  Conversely, very small
jails might want -utilities but don't need powerd.

Move it to its own package and add it to the minimal set.

MFC after:      1 day
Reviewed by:    manu, imp
Differential Revision:  https://reviews.freebsd.org/D52645

MFC after:    1 day
Reviewed by:    manu, imp, emaste
Differential Revision:  https://reviews.freebsd.org/D52648

MFC after:    1 day
Reviewed by:    manu
Differential Revision:  https://reviews.freebsd.org/D52650

This was moved to -acct along with the rest of the accounting tools.
While it does work with accounting data, it's also a core Unix tool
that users would expect to be installed without having to install
the whole accounting system.

Move it back to -utilities, which is also where w(1) lives.

MFC after:      1 day
Reviewed by:    manu
Differential Revision:  https://reviews.freebsd.org/D52653

Due to the size of libpmc.so.5, this reduces the size of the -utilities
package by 10%.

MFC after:      1 day
Reviewed by:    manu, adrian, emaste
Differential Revision:  https://reviews.freebsd.org/D52662

Currently libbz2 is in the libbz2 package, while bzip2 itself is in
-utilities, which is inconsistent.  Move both the library and the
utility to a new -bzip2 package, and use LIB_PACKAGE to create a
separate -bzip2-lib package for runtime dependencies.

Add the bzip2 package to the minimal set, and since newsyslogd uses
bzip2 for logfile compression, add a dependency from there.

MFC after:      1 day
Reviewed by:    manu
Differential Revision:  https://reviews.freebsd.org/D52663

Development versions of pkg have a version like "2.3.0-d8bbde1c3-dirty",
which is not handled by PKG_BIN_VERSION, so PKG_EXT ends up being "tar"
and this breaks update-packages.

Fix the PKG_BIN_VERSION logic, and while here, remove backwards compat
for pkg versions prior to 2.0, which no one should be using to build
main or stable/15.  This means nothing is left to use PKG_BIN_VERSION,
but continue to set it, since we might need it again in the future.

MFC after:      1 day
Reviewed by:    manu, kevans
Differential Revision:  https://reviews.freebsd.org/D52666

I didn't add this originally since many jails don't require devd, but
it's very small (~90kB) and has no dependencies other than clibs and
runtime, so we may as well include it for parity between minimal and
minimal-jail.

While here, improve the package description.

Requested by:   imp
MFC after:      1 day
Differential Revision:  https://reviews.freebsd.org/D52679

atf.7 should be in -atf, and tests.7 should be in -tests.

MFC after:      1 day
Differential Revision:  https://reviews.freebsd.org/D52661

rc(8), as well as rc scripts themselves, require /bin/sh and basic
shell utilities to work.  Currently -rc has an implicit dependency
on -runtime because of libutil, but this might change in the future
if libutil were moved to a different package.  Add an explicit dep
to ensure -runtime is installed.

MFC after:      1 day
Differential Revision:  https://reviews.freebsd.org/D52654

To be specific, set NO_ROOT=1 WITHOUT_QEMU=1 (those options go
together and it is an error to specify one without the other) if
NO_ROOT is defined in release.conf.

MFC after:      3 days
Sponsored by:   https://www.patreon.com/cperciva

package-pkg (via make-pkg-package.sh) passes CONFIGURE_ARGS to make when
building ports-mgmt/pkg, which overrides the port's default configure
args that are supposed to set --prefix.  This means that pkg is always
built with the default prefix of /usr/local, which then fails when ports
tries to package it from LOCALBASE.

Work around this by explicitly adding --prefix to CONFIGURE_ARGS.

MFC after:      1 day
Reviewed by:    bapt
Differential Revision:  https://reviews.freebsd.org/D52634

If we can't install pkg(8) on the media, instead of ignoring the error,
fail the build.  This avoids silently creating media which doesn't have
pkg(8) on, and therefore can't be used for a pkgbase install.

Installing pkg(8) can still be entirely disabled by setting NOPKG.

MFC after:      1 day
Reviewed by:    ifreund_freebsdfoundation.org, cperciva
Differential Revision:  https://reviews.freebsd.org/D52635

We need a pkg package on the media so we can install it for offline
installations; copy this package from the staging repository to the
pkgbase offline repository on the media.

MFC after:      1 day
Reviewed by:    ifreund_freebsdfoundation.org, cperciva
Differential Revision:  https://reviews.freebsd.org/D52636

If we're building pkgbase media, install the pkg package from the
pkgbase repository we already created, not from pkg.freebsd.org.
Aside from being more desirable, this also fixes make release for
version/architecture combinations which are missing repository
on pkg.f.o (which is nearly all of them at the time of writing).

This doesn't yet work for bootonly, since we don't build the pkgbase
repository there.  For now, restore the old behaviour of attempting
to install pkg from pkg.freebsd.org for bootonly.

MFC after:      1 day
Reviewed by:    ifreund_freebsdfoundation.org, cperciva (previous version)
Differential Revision:  https://reviews.freebsd.org/D52637

Although support for PowerPC kernels (GENERIC64 and GENERIC64LE) was
added to pkgbase-stage.lua, the equivalent support was missing from
bsdinstall, so the installer would fail at runtime since it wouldn't
find a kernel package.

Improve the pkgbase-stage logic to have a specific list of kernels
we want to support (which avoids breaking if multiple kernels are
available), and use the same logic in both bsdinstall and pkgbase-stage.

MFC after:      1 day
Reviewed by:    cperciva
Differential Revision:  https://reviews.freebsd.org/D52638

There are still some minor breakage with NO_ROOT (aka WITHOUT_QEMU)
builds but turning all the cloudware on unconditionally will allow
for more testing of the build process concurrently with the final
bug fixes landing.

Discussed with: markj
MFC after:      1 week
Sponsored by:   https://www.patreon.com/cperciva

* at requires cron, since atrun is started by cron and won't work
  without it, and also requires runtime because at runs jobs under
  /bin/sh.

* bluetooth requires ppp for rfcomm_pppd (a very common use case).

* bsdconfig and bsdinstall are written in shell script and therefore
  require /bin/sh.

* devd requires /bin/sh to invoke its hooks.

While here, document the policy for adding dependencies in the README.
This will hopefully ensure we end up with consistent dependencies.

MFC after:      1 day
Reviewed by:    bapt
Differential Revision:  https://reviews.freebsd.org/D52699

Provide at least a basic description of every package we build.
Where possible, the description is taken from a relevant manpage;
when there was no suitable text in the manpage, I wrote a new
description.

Since the UCL files now contain a significant amount of English
prose which is almost certainly subject to copyright in at least
some jurisdictions, add a copyright header to every file.  Where
the text was taken from a manpage, the copyright and license are
also taken from the manpage.  A few files don't have copyright
headers added because the origin of the text is unclear, or because
the files were written by someone else.

While here, remove some orphaned UCL files for packages we no
longer ship.

MFC after:      1 day
Reviewed by:    bapt
Differential Revision:  https://reviews.freebsd.org/D52690

When NO_INSTALLKERNEL and NO_INSTALLEXTRAKERNELS are set, or when
BUILDKERNELS is empty, we can fail to define the create-kernel-packages
make target, which we call unconditionally. So if do not have a kernel
staging dir, go ahead and provide an empty create-kernel-packages so
that when it's used elsewhere, the build succeeds.

This lets me build a tree and package it when I don't have a kernel, for
jails and other similar environments. There's no change if any kernels
are built, since that will provide the necessary make target that does
useful things for that case.

Sponsored by:           Netflix

This also indirectly addresses the lack of FreeBSD-lldb package on
the riscv64 platform by relying on that package being part of the
FreeBSD-set-devel set iff it exists.

A subsequent commit will adjust the "notoolchain" OCI container image
to also use a package set, which will indirectly affect the contents
of the "toolchain" container (which is an explicit superset of the
"notoolchain" container).

MFC after:      1 day
Co-authored-by: dch

This will allow the VM image build scripts to use the same repository
config file for installing base system packages at build time.

Reviewed by:    emaste
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D51482

VM and cloud images are now built as packaged base systems by default,
matching the default for installation media.

Setting -DNOPKGBASE allows building as non-pkgbase systems.

Reviewed by:    emaste
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D51483

Although inetd is widely used, none of the base daemons which require
or support inetd (e.g. fingerd, tftpd, sshd) are in the minimal set,
and it's fairly uncommon to enable inetd's built-in servers nowadays.

MFC after:      6 hours
Reviewed by:    manu, bapt, emaste
Differential Revision:  https://reviews.freebsd.org/D52715

This is base, but without packages which are not generally useful
in jails.  The following packages are excluded:

* Support for hardware not present in a jail:
  acpi, apm, bluetooth, ccdconfig, console-tools, cxgbe-tools,
  efi-tools, fd, hostapd, mlx-tools, nvme-tools, wpa

* Kernel facilities that don't work in a jail:
  dtrace, dwatch, ggate, hast, iscsi, libcuse, smbutils

All library packages are included in base-jail, even if they might not
work, because the user may have executables linked with them.

While here, remove the set-minimal dependency from set-devel, since
this will cause unnecessary packages to be installed in jails.  This
means users will need to install set-devel in addition to their base
set (minimal or base), which bsdinstall already handles correctly.

Add a license to all the set UCL files, so people can redistribute them.

MFC after:      6 hours
Reviewed by:    manu
Differential Revision:  https://reviews.freebsd.org/D52719

This covers the basic structure of pkgbase, how packages are
distributed, how package sets work, and provides a few example
of actually using pkgbase.

MFC after:      6 hours
Approved by:    re (cperciva)
Reviewed by:    ziaee, cperciva
Differential Revision:  https://reviews.freebsd.org/D52644

Prior to this commit, pkgbase-stage.lua used a hard-coded PKG_DBDIR
"./pkgdb"; unfortunately this creates a race condition if we start
building disc1.iso and dvd1.iso at the same time

  pkg: sqlite error while executing CREATE TABLE licenses [...]
  in file pkgdb.c:2330: table licenses already exists

since pkg checks to see if the pkgdb is initialized and initializes
it if not.

Use separate pkgdb-disc1 and pkgdb-dvd directories.

MFC after:      1 minute
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D52755

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289653
Reported by:    Trond Endrestøl <Trond.Endrestol@ximalas.info>
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D52676

This is required to manage the firmware on amd64 and aarch64 systems.

MFC after:      3 days
Reviewed by:    imp, emaste
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52742

These manpages are broadly applicable to all systems, even jails,
since they describe kernel facilities which are available in jails.

MFC after:      3 days
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52743

The garbage left would prevent subsequent tests to succeed.  Note that
currently this is the last test to execute.

At the moment all tests need forced rotation, but future tests may not, so
let the tests themselves decide if -F is needed.  Should be no functional
change.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Sponsored by: Rubicon Communications, LLC ("Netgate")

Sponsored by: Rubicon Communications, LLC ("Netgate")

The problem is that fullsocket() creates a socket that has both send and
receive buffers full and as we process messages from the receive buffer we
allow the kernel to continue processing of the send buffer and a new
message may arrive while the test expects that no new messages arrive.
Fix that by creating a socket that has several messages in the receive
buffer, but don't have any in the send buffer.

Spotted by: lme@

No functional change intended.

MFC after:      3 days
Sponsored by:   Netflix, Inc.

This change updates the sources for crypto/openssl. The subsequent
commit will update the build artifacts to match the 3.5.3 release.

More details about the update can be found in the related vendor branch
commits.

MFC after:      1 week
Merge commit 'aed904c48f330dc76da942a8ee2d6eef9d11f572'

tzcode: Use -00 only for invalid time zones

As of tzcode 2025a, if we are unable to load a time zone, we set tzname
to "-00" to indicate an error.  This penalizes users who simply don't
set TZ or create /etc/localtime as a faster way of setting the time zone
to UTC (pointing /etc/localtime at /usr/share/zoneinfo/UTC forces us to
parse it every time for no real benefit).  To rectify this, use "-00"
only if TZ was set or zoneinit() returned something else than ENOENT.

MFC after:      3 days
Fixes:          https://cgit.freebsd.org/src/commit/?id=967a49a21a27 ("Update tzcode to 2025b")
Reviewed by:    philip
Differential Revision:  https://reviews.freebsd.org/D52680

tzcode: Fix issues when TZ is an absolute path

* If TZ starts with TZDIR, strip any additional slashes so relname
  does not end up looking like an absolute path.  For instance,
  TZ=/usr/share/zoneinfo//UTC should result in UTC, not /UTC.

* In the setugid case, we were incorrectly passing name rather than
  relname to fstatat().

* Modify the tz_env and tz_env_setugid test cases to exercise both
  of these scenarios.

* Also add test cases for invalid values of TZ, which I wrote
  earlier but forgot to include in a5f14e4f9069.

Reported by:    Paul Eggert <eggert@cs.ucla.edu>
MFC after:      3 days
Fixes:          https://cgit.freebsd.org/src/commit/?id=967a49a21a27 ("Update tzcode to 2025b")
Fixes:          https://cgit.freebsd.org/src/commit/?id=a5f14e4f9069 ("tzcode: Use -00 only for invalid time zones")
Reviewed by:    philip
Differential Revision:  https://reviews.freebsd.org/D52753

tzcode: Really fix issues when TZ is an absolute path

This was accidentally left out of the previous commit.

Fixes:          https://cgit.freebsd.org/src/commit/?id=df8bc705eb04 ("tzcode: Fix issues when TZ is an absolute path")

Notable upstream pull request merges:
 #17705 545d66204 Fix a printf format specifier on FreeBSD/i386
 #17708 3387d3409 Fix atomic-alignment warnings in libspl on FreeBSD/i386
 #17719 f319ff357 vdev_disk_close: take disk write lock before destroying it
 #17732 1d2d81298 Refactor `zhack label repair` and fix `-c` regression on
                  nonzero TXG
 #17764 ea37c30fc zdb: Fix asize overflow in verify_livelist_allocs()

Obtained from:  OpenZFS
OpenZFS commit: b2196fbedf5dbfb8593288f5f9ba712e31429a84

This hasn't been needed in years and is a maintenance headache.

MFC after:      1 week
Reviewed by:    philip
Differential Revision:  https://reviews.freebsd.org/D52694

The display of IFCAP_NV is handled by SIOCGIFCAPNV ioctl. The kernel
composes a nvlist of capabilities and the userland unpack them and
display. So this "NV" in IFCAPBITS is meaningless but rather misleading.

This reverts commit 0c1684dd456e3df306b359b04e61f9f2048d9ff2.

Setting ACPI D-states is generally broken on FreeBSD and this change
surfaced an issue. So reverting for the time being whilst I write a
proper fix for this.

This reverts commit 02a8fadd2c4dc4b78d6d93d9d8b70e9348a6de6d.

Reported by:    glebius, phk
Tested by:      glebius
Sponsored by:   The FreeBSD Foundation