FreeBSD git weekly: 2025-10-13 to 2025-10-19

Add an UPDATING entry about the renaming of blocklist.

Approved by:    emaste (mentor)
Fixes:  https://cgit.freebsd.org/src/commit/?id=7238317403b9 ("blocklist: Rename blacklist to blocklist")
MFC after:      1 day

This more accurately reflects its purpose, and its contents, since
everything in the package is prefixed with "local-".

While here, add a message on upgrade about regenerating the config.

MFC after:      3 seconds
Requested by:   des
Reviewed by:    des
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53056

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52665

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240378
Reviewed by:    otis (mentor), glebius (src committer)
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D52991

Reviewed by:  imp, kp
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52906

Don't duplicate the last component.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290362
Reported by:    John F. Carr <jfc@mit.edu>
Fixes:          https://cgit.freebsd.org/src/commit/?id=d06a00963b7
MFC after:      3 days
Reviewed by:    jilles, Goran Mekić <meka@tilda.center>
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1878

The pam_xdg module does set the XDG_RUNTIME_DIR in the environment, it's actually
its main purpose.

Reported by:    arrowd

This command doesn't accept a vlan-id.

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290141
MFC after:      3 days
Reported by:    Paul Procacci <pprocacci@gmail.com>
Reviewed by:    ziaee (manpages)
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53049

Document how bridge implements VLANs, and provide an example of
configuring a bridge with VLAN filtering.

MFC after:      3 days
Reviewed by:    ziaee, pauamma_gundo.com (previous version)
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D51185

We've been mostly POSIX-conforming since r236400 and fully since r240410,
which fixed a corner case where a missing non-leaf directory would be
reported as ENOTDIR instead of ENOENT.

Sponsored by:   Klara, Inc.
Fixes:          https://cgit.freebsd.org/src/commit/?id=7877ed7ce33e ("Avoid mapping ENOENT to ENOTDIR for non-existent path components.")
Reviewed by:    ziaee, markj
Differential Revision:  https://reviews.freebsd.org/D53027

Add an UPDATING entry about the renaming of blocklist.

Approved by:    emaste (mentor)
Fixes:  https://cgit.freebsd.org/src/commit/?id=7238317403b9 ("blocklist: Rename blacklist to blocklist")
MFC after:      1 day

- Fix a typo.
- Provide the default path.

Reviewed by:    des
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53001

Create a chapter on every important socket type: stream, datagram,
seqpacket.  Always list what protocol families do support what kinds of
sockets.  Improve some statements possessing language from the
specification [1].  Reduce some statements that are mostly specific to
TCP.  Provide more external links and references to various important
syscalls that can be used on sockets.

Add a paragrph on non-blocking mode.

The big factual change is documentation of SOCK_SEQPACKET.  In FreeBSD 15
this socket now fully follows the specification and is a stream socket
with record boundaries.

[1] https://pubs.opengroup.org/onlinepubs/9799919799/functions/V2_chap02.html#tag_16_10_06

Differential Revision:  https://reviews.freebsd.org/D52771

MFC after:    3 days
Reviewed by:    dab
Differential Revision:  https://reviews.freebsd.org/D52867

+ arm/RPI-B.conf no longer exists, adjust for arm64/RPI.conf
+ document default CHROOTDIR, also add to FILES list
+ tag SPDX

MFC after:      3 days
Reviewed by:    cperciva
Differential Revision:  https://reviews.freebsd.org/D53078

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52665

The manpages of linprocfs(5) and linsysfs(5) document incomplete names without
"fs" suffix. Make them identical to other filesystems.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283079
MFC after:      3 days
Reviewed by:    ziaee, markj
Differential Revision:  https://reviews.freebsd.org/D53155

MFC after:    3 days
Reviewed by:    asomers, olce
Differential Revision:  https://reviews.freebsd.org/D53137

Reviewed by:  markj
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

nvme: use nitems() rather than hard coded value

Suggested by: jhb@
Sponsored by: Netflix

nvme: Use unsigned

CI complains about signed/unsigned comparisons, but normal build does
not. Fix this by transitioning to unsigned and using a loop-scoped
variable.

Fixes: https://cgit.freebsd.org/src/commit/?id=d714732b598b
Sponsored by: Netflix

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

The only possible return value of function xen_intr_init() is 0. Make
it return void to match the prototype of SYSINIT.

MFC after:      1 week

The only possible return value of function module_info_init() is 0. Make
it return void to match the prototype of SYSINIT.

MFC after:      1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

Reported by:  GCC -Wmaybe-uninitialized, -Wtautological-compare
Reviewed by:    kp
Differential Revision:  https://reviews.freebsd.org/D45919

Port the BP hardening and SSBD workaround from cpu_quirks to the
CPU_FEAT framework.

Reviewed by:    andrew
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53112

This change reapplies the improvements from commit 89e7335 and adds
additional fixes and code optimizations on top of it.

The ixl driver supports up to 128 multicast filters in hardware. When this
limit is exceeded, the driver should enable multicast promiscuous mode.
When the count drops below 128, it should disable promiscuous mode and
restore individual filters.

The driver previously had problems that could corrupt multicast filters list.
The main issue was that ixl_dis_multi_promisc() would attempt to disable
promiscuous mode without checking if it was actually enabled, potentially
corrupting existing filters. There was also no state tracking across driver
functions, leading to redundant operations.

This change adds an IXL_FLAGS_MC_PROMISC flag to track the multicast
promiscuous mode state. The flag is set when enabling promiscuous mode and
cleared when disabling it. Early return checks prevent redundant operations
when the mode is already in the desired state, avoiding filter corruption
and unnecessary hardware calls.

Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283820
Approved by:    kbowling (mentor)
Tested by:      gowtham.kumar.ks_intel.com
MFC after:      2 weeks
Sponsored by:   Intel Corporation
Differential Revision:  https://reviews.freebsd.org/D52549

We bump the object reference count prior to mapping it into the kernel
map, at which point the vm_map_entry owns the reference.  Then, if
vm_map_wire() fails, vm_map_remove() will release the reference, so we
should avoid decrementing it in the error path.

Reported by:    Ilja van Sprundel <ivansprundel@ioactive.com>
Reviewed by:    vmaffione
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53066

vm_smp_rendezvous() invokes a callback on all vCPUs, blocking the
initiator until all vCPUs have responded.  vcpu_lock_all() blocks each
vCPU by waiting for it to go idle and setting the vCPU state to frozen.
These two operations can deadlock on each other, particularly when
booting a Windows guest, when vcpu_lock_all() blocks waiting for a
rendezvous initiator, and the initiator is blocked waiting for the vCPU
thread which called vcpu_lock_all() to invoke the rendezvous callback.

Implement vcpu_lock_all() in a way that avoids deadlocks with
vm_smp_rendezvous().  In particular, when traversing vCPUs, invoke the
rendezvous callback on the vCPU's behalf to help the initiator finish.
We can only safely do so when the vCPU is IDLE or we have already locked
it, otherwise we may be racing with the target vCPU thread.  Thus:
- Use an exclusive lock to serialize vcpu_lock_all() callers, which lets
  us lock vCPUs out of order without fear of deadlock with parallel
  vcpu_lock_all() callers.
- If a rendezvous is pending, lock all idle vCPUs and invoke the
  callback on their behalf.  If the vcpu_lock_all() caller is itself a
  vCPU thread, this will handle that thread.
- Block waiting for all non-idle vCPUs to idle, or until one of them
  initiates a rendezvous, in which case we go back and invoke callbacks
  on behalf of already-locked vCPUs.

Note that on !amd64 no changes are needed since there is no rendezvous
mechanism, so there is a separate vcpu_set_state_all() for them based on
the previous vcpu_lock_all().  These will be merged together once vcpu
state handling is consolidated into sys/dev/vmm.

Reviewed by:    corvink (previous version)
MFC after:      3 weeks
Differential Revision:  https://reviews.freebsd.org/D52968

Work around an issue when HotPlug is enabled where pcib3 and pcib5
continuously report the following:

pcib3: HotPlug interrupt: 0x30
pcib3: Command Completed
pcib3: HotPlug interrupt: 0x30
pcib3: Command Completed
...

As a workaround disable HotPlug on the N1SDP as it's unlikely anyone
will depend on it.

Reviewed by:    br
Fixes:  https://cgit.freebsd.org/src/commit/?id=1f5c50a86173 ("pci_host_generic:Add pcib_request_feature on ACPI")
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53134

As found on RTEMS the argument to if_foreach_llmaddr() was wrong
causing crashes.

Fixes:          https://cgit.freebsd.org/src/commit/?id=51e80820552e0
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290314
MFC after:      3 days

Remove the single 8822CU entry in all three places.
It seems the only entry referencing a USB device.  The same device is
listed with the 8822CE devices.

MFC after:      3 days
Reviewed by:    wulf
Differential Revision: https://reviews.freebsd.org/D52324

The pt hwt(4) backend uses NMIs to receive updates about the latest t
racing buffer offsets from the tracing hardware. However, it uses
taskqueue(9) to schedule the bottom-half handler. This can lead to
a panic since the taskqueue(9) code isn't aware it's being called
from an NMI context and uses the regular scheduling interfaces.

Fix this by scheduling the bottom-half handler using swi(9) and the
SWI_FROMNMI flag.

Fixes:  https://cgit.freebsd.org/src/commit/?id=310162ea218a
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52491

gcc complains about accessing the byte as ads->common.bytes[3] as that
field is declared as being one byte.

Reviewed by:    mav
Differential Revision:  https://reviews.freebsd.org/D53152

Reviewed by:  markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

The only possible return value of function ipfw_init() is 0. Make it
return void to match the prototype of SYSINIT.

MFC after:      1 week

MFC after:    1 week

MFC after:    1 week

tcp: Initial ktest for HPTS

Reviewed by:            rrs, tuexen
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52979

tcp: simplify tcp_hpts_insert signature

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: remove notion of ticks from HPTS

To improve consistency of the code, don't use slots and ticks,
just use slots.

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: fix KASSERT in HPTS

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: fix a bug in HPTS

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: use time instead of slots in the HPTS API

This makes slots an internal concept of HPTS.

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: remove unused argument in HPTS

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: add missing header file

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

Note, it looks like this code may be unused since commit 4a77657cbc01
("ipfw: migrate ipfw to 32-bit size rule numbers").  In particular, it
looks like the ipfw_nat_*_ptr pointers are unused now.

Reviewed by:    ae
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53068

Only suppress the path state column when producing traditional text
output. When generating html output, always include the column.
Please note that when generating json or xml output, optional fields
like the path state are only generated if they is applicable. This
has not been changed.
The changes in this patch were suggested by asomers.

Reviewed by:            asomers
Fixes:                  https://cgit.freebsd.org/src/commit/?id=746eadecaa7d ("sockstat: show path state column only when useful")
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53005

BLOCKLIST_NOTIFY() is called within a signal handler for the alarm after
the grace period has expired that may only take async-signal safe
actions.

Reviewed by:    emaste
Fixes:          https://cgit.freebsd.org/src/commit/?id=e02003bce726 ("openssh: blocklist: Use NetBSD probes")
MFC after:      1 day
Differential Revision:  https://reviews.freebsd.org/D53109

This will close a panic on test run when kernel is compiled without HPTS
KTEST support.

The code to do the route lookup was already there, but was used only for
the legacy IP_ADD_MEMBERSHIP when called without index.  Do same lookup
for IP_ADD_MEMBERSHIP with index and what is more important for
MCAST_JOIN_GROUP, if the supplied index is 0.  This is a neat feature and
Linux does that, so this should make a few applications easier portable to
FreeBSD.

Differential Revision:  https://reviews.freebsd.org/D52918

This allows in higher throughput values with default settings.
In the review I was proposing using 16 MB, but in the transport
call today we settled on a more conservative value of 8.
Bumping it further will be done in combination with mitigations
for mbuf exhaustion attacks.

Reviewed by:            rscheff, cc, glebius, Nick Banks, Peter Lei, jtl, thj, rrs
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52872

This allows in higher throughput values with default settings.
In the review I was proposing using 16 MB, but in the transport
call today we settled on a more conservative value of 8.
Bumping it further will be done in combination with mitigations
for mbuf exhaustion attacks.

Reviewed by:            rscheff, Peter Lei, jtl, thj
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52871

* Consistently free the string after unlocking the sch, if possible.
* Remove the failure handling in case of sc != NULL, since this is
  not possible anymore.
* Remove the use of goto and instead return 0 in the three cases.
The only change in behavior is that in three out of the four cases,
where 0 is returned, *lsop is not set to NULL anymore. So the behavior
is now consistent and also documented in a comment. The current in
tree callers only look at *lsop, if and only if syncache_expand()
returns 1.

Reviewed by:            Peter Lei
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52948

Reviewed by:  phk
Differential Revision:  https://reviews.freebsd.org/D53151

This is a small cleanup to consolidate the considered lost reduction and marking to an
inline function. There are two places where we are using hookery in SACK processing where
we can't use it. All other places we move to the function. This code in theory changes nothing
and just makes things a bit more readable and consistent.

Reviewed by:tuexen
Differential Revision:  <https://reviews.freebsd.org/D53021>

Ensure we always have a non-NULL rule pointer (ctx.rm).
It might have gotten set to NULL by pf_get_translation().

While here also restore the previous rdr behaviour be re-adding the incorrectly
removed 'break' in pf_match_translation_rule.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290177
MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")
Differential Revision:  https://reviews.freebsd.org/D53191

The port is called wifi-firmware-mt76-kmod not "mediatek" in the
moddle.

Reported by:    Lars Tunkrans (drsnx60 gmail.com)
MFC after:      3 days
Reviewed by:    emaste, jrm, imp
Differential Revision: https://reviews.freebsd.org/D53067

Submitted-by: Johan Söllvander
MFC-after:    1 week
Differential Revision: https://reviews.freebsd.org/D37615

table_do_modify_record() already uses errno value on error.
Also this fixes problem when `ipfw table add` returns ENOTTY that
is unrelated to operation.

Tested by:      dhw
Fixes:          https://cgit.freebsd.org/src/commit/?id=09025a714708
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53050

calcsb is unused since the logic moved to sbsearch / ffs_sbsearch in
e68866164212 ("Move the ability to search for alternate UFS superblocks
from fsck_ffs(8) into ffs_sbsearch() to allow use by other parts of the
system.")

Reviewed by:    mckusick
Differential Revision:  https://reviews.freebsd.org/D53038

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251993
Reviewed by:    cperciva
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53106

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290232
Reported by:    David Marker <dave@freedave.net>
Fixes:          https://cgit.freebsd.org/src/commit/?id=aa34b1d20e44 ("vmrun.sh: Add arm64 support")
MFC after:      3 days

Reviewed by:  emaste
MFC after:      1 hour
Differential Revision:  https://reviews.freebsd.org/D34598

Tests that fail are in
/root/.kyua/store/results.usr_tests_sys_geom_class_multipath.20251015-085403-959737.db

Submitted-by: Johan Söllvander
MFC-after:    1 week
Differential Revision: https://reviews.freebsd.org/D53110

The old rtsock implementation used in-kernel workaround to do so.
When route to specified destination address used P2P interface, the
kernel did the search with ifa_ifwithnet() for most suitable network
and then add proxy entry to this interface.

Use similar approach with netlink implementation. We already have
get_ether_addr() function that does almost the same thing as
ifa_ifwithnet(). Use it when we find that destination route uses
P2P interface and then try to guess suitable interface. This should
fix the use of netlink-based arp(8) in mpd5.

Rename get_ether_addr() to get_ifinfo(), since now it is used to find
only ifindex in case when hwaddr is specified by user.
Also make set_nl() and delete_nl() prototype similar to rtsock.
And allow '-i' to be used with '-S', since we already allow the same
for '-s'.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290221
Reported by:    eugen
Reviewed by:    eugen
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53113

quot: Fix benign buffer overflow

If it encounters an inode whose owner does not have a pw entry, quot
allocates a 7-byte buffer (8 in practice, since that is the minimum
allocation size) and uses it to store the numeric uid preceded by a
hash character.  This will overflow the allocated buffer if the UID
exceeds 6 decimal digits.  Avoid this by using asprintf() instead.

While here, simplify the common case as well using strdup().

Reported by:    Igor Gabriel Sousa e Souza <igor@bsdtrust.com>
MFC after:      3 days
Reviewed by:    obiwac, emaste
Differential Revision:  https://reviews.freebsd.org/D53129

quot: Clean up

* Fix numerous style violations.
* Modernize somewhat.
* Don't bother examining errno after calling get_inode(), as it always
  exits on error.
* Fix confusing wording in the manual page.

The code remains somewhat idiosyncratic, e.g. in its insistance on
counting down rather than up in simple for loops, but in the absence
of comprehensive automated tests, the risk of introducing bugs exceeds
the benefit of rewriting these into more idiomatic forms.

Reviewed by:    obiwac
Differential Revision:  https://reviews.freebsd.org/D53130

quot: Drop the COMPAT version

We've had this code for 30 years, but there has never been a way to
build it.  We have no idea if it still works, or if it ever worked.

Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D53131

quot: Drop the -h option

There was probably a time, more than 30 years ago, when the actual
size of a file had to be calculated and this option saved time, but
all it does today is give incorrect results for no benefit.

Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D53132

Sponsored by: The FreeBSD Foundation
MFC after:      1 day
Differential Revision:  https://reviews.freebsd.org/D53175

Sponsored by: The FreeBSD Foundation
MFC after:      1 day
Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D53174

Allow umask to be configurable.

Being able to set the umask via an rc variable is useful when setting:

    security.bsd.unprivileged_read_msgbuf=0

As it allows a user to configure:

    dmesg_umask="066"

Without modifying the rc script, and preventing the contents of the
$dmesg_file (/var/run/dmesg.boot) from being publicly readable.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272552
Reviewed by:    netchild
MFC after:      2 days
Differential Revision:  https://reviews.freebsd.org/D53169

If lstat() fails with EACCES or ENOTDIR, the path we need to return in
the caller-provided buffer is that of the parent directory (which is
either unreadable or not a directory; the latter can only happen in the
case of a race) rather than that of the child we attempted to stat.

Sponsored by:   Klara, Inc.
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53025

ISO 8601 allows use of "Z" as the time zone designator. Update the
strptime parser to allow this usage.

While we are at it, update the manpage to reflect that both UTC and Z
are now valid options.

Reviewed by:    des
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53083

by removing the cast to _Bool.  The _Bool type is not defined for C++,
and the specification from the gcc info doc states that the return
type of the  __builtin_{add,sub,mul}_overflow() is bool already.

This is done instead of including stdbool.h to avoid namespace
pollution, since defining bool from stdckdint.h simingly is not
sanctioned by ISO/IEC 9899:2024.

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290299
Reviewed by:    des
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D53149

Our versions of these functions (originally taken from BIND) simply
don't work correctly for AF_INET6.  These were removed from BIND itself
quite a while ago, but OpenBSD has made several fixes in the mean time,
so import their code.

Add tests for both functions.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289198
Reported by:    Nico Sonack <nsonack@herrhotzenplotz.de>
MFC after:      1 week
Reviewed by:    des
Obtained from:  OpenBSD (lib/libc/net)
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52629

MFC after:    1 week

Approved by: asomers
Differential Revision: https://reviews.freebsd.org/D53082

If the last reference to an open file is contained in an SCM_RIGHTS
message in a UNIX domain socket, and that message is discarded without
being read out by the receiver, VOP_CLOSE will ultimately be called
with ap->a_td == NULL.

Change unionfs_close() to check for this condition instead of blindly
passing the thread to unionfs_find_node_status() which will try to
dereference it.  Also add relevant asserts on the node status lookup
paths.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289700
Reported by:    asomers
Reviewed by:    asomers, olce
MFC after:      3 days
Differential Revision: https://reviews.freebsd.org/D53079

Reported by:  GCC -Warray-bounds
Reviewed by:    mckusick
Differential Revision:  https://reviews.freebsd.org/D53037

unionfs_lock() unconditionally calls vdrop() on the target vnode
after locking it, but it's possible this vnode may be doomed.
In that case, vdrop() may free the vnode, which in certain cases
requires taking the vnode lock.  Commit a7aac8c20497d added an
assert to this effect, which unionfs_lock() now trips over.

Fix this by lightly reworking the flow of unionfs_lock() so that
the target vnode is vdrop()ed after being unlocked in the case
where the unionfs lock operation needs to be restarted (which
will happen if the unionfs vnode has been doomed, which is a
prerequisite for the target vnode in the underlying filesystem
to have been doomed).

While here, get rid of a superfluous vhold/vdrop sequence in
unionfs_unlock() that was probably inherited from nullfs and whose
nullfs equivalent was recently removed.

MFC after:      1 week
Reviewed by:    kib, markj, olce
Tested by:      pho
Differential Revision: https://reviews.freebsd.org/D53107

The variable is simply a long series of flags.  Mark as boolean to allow
the compiler to use smaller types.

Convert to designated initializer to better indicate which operations it
is set for.  Without this the array is kind of long and sparse.

nfsv4_setsequence() is no longer used outside nfs_commonsubs.c, so now
mark it as static.  The fourth argument is true/false, so convert to
boolean.

No semantics change is made by this commit.

Discussed with: jrtc27
MFC after:      2 weeks

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

The function shared_page_init() already has the right prototype.

MFC after:      1 week

The only possible return value of function jm_sysinit() and jm_sysuninit()
is 0. Make them return void to match the prototype of SYSINIT.

MFC after:      1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

The function exec_sysvec_init() already has the right prototype.

While here, remove an extra semicolon from the macro INIT_SYSENTVEC.

MFC after:      1 week

MFC after:    1 week

Improve the HPTS API to allow testing and add several tests.

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

sys/rpc: UNIX auth: Rename 'ngroups' => 'supp_ngroups' for clarity

MFC after:      2 days
Sponsored by:   The FreeBSD Foundation

sys/rpc: UNIX auth: Fix OOB accesses, notably writes on decode

When the received authentication message had more than XU_NGROUPS, we
would write group IDs beyond the end of cr_groups[] in the 'struct
xucred' being filled (as 'ngroups_max' is always greater than
XU_NGROUPS).

For robustness, prevent various OOB accesses that would result from
a change of value of XU_NGROUPS or a 'struct xucred' with an invalid
'cr_ngroups' field, even if these cases are unlikely.

Reviewed by:    rmacklem
Fixes:          https://cgit.freebsd.org/src/commit/?id=dfdcada31e79 ("Add the new kernel-mode NFS Lock Manager.")
MFC after:      2 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52960

sys/rpc: Define AUTH_SYS_MAX_{GROUPS,HOSTNAME}

As, respectively, the maximum number of "supplementary" groups and the
maximum hostname size allowed in the credentials structure for AUTH_SYS
(aka, AUTH_UNIX).

Will be used in subsequent commits.

Reviewed by:    rmacklem
MFC after:      2 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52961

sys/rpc: UNIX auth: Use AUTH_SYS_MAX_{GROUPS,HOSTNAME} as limits (1/2)

Consistently with the XDR_INLINE() variant of xdr_authunix_parms()
(_svcauth_unix() in 'svc_auth_unix.c'), reject messages with credentials
having a machine name length in excess of AUTH_SYS_MAX_HOSTNAME or more
than AUTH_SYS_MAX_GROUPS supplementary groups, which do not conform to
RFC 5531.  This is done mainly because we cannot store excess groups
anyway, even if at odds with the robustness principle ("be liberal in
what you accept").

While here, make sure the current code is immune to AUTH_SYS_MAX_GROUPS
changing value (in future RFCs?) even if that seems improbable.

Reviewed by:    rmacklem
Fixes:          https://cgit.freebsd.org/src/commit/?id=dfdcada31e79 ("Add the new kernel-mode NFS Lock Manager.")
MFC after:      2 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52962

sys/rpc: UNIX auth: Use AUTH_SYS_MAX_{GROUPS,HOSTNAME} as limits (2/2)

Remove local defines from 'svc_auth_unix.c' and use the new limit
macros instead.

Reviewed by:    rmacklem
MFC after:      2 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52963

sys/rpc: UNIX auth: Fix OOB reads on too short message

In the inline version (_svcauth_unix()), fix multiple possible OOB reads
when the credentials part of a request is too short to contain mandatory
fields or with respect to the hostname length or number of groups it
advertises.  The previously existing check was arriving too late and
relied on possibly wrong data coming from earlier OOB reads.

While here, use 'uint32_t' as the length/size type, as it is more than
enough and removes the need for conversions, explicit or implicit.
While here, factor out setting 'stat' to AUTH_BADCRED and then jumping
to 'done' on error, through the new 'badcred' label.  While here,
through comments, refer to what the non-inline version is doing
(xdr_authunix_parms() in 'authunix_prot.c') and the reasons.

Reviewed by:    rmacklem
Fixes:          https://cgit.freebsd.org/src/commit/?id=dfdcada31e79 ("Add the new kernel-mode NFS Lock Manager.")
MFC after:      2 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52964

sys/rpc: UNIX auth: Support XDR_FREE

xdr_authunix_parms() does not allocate any auxiliary memory, so we can
simply support XDR_FREE by just returning TRUE.

Although there are currently no callers passing XDR_FREE, this makes us
immune to such a change in a way that doesn't cost more but is more
constructive than a mere KASSERT().

Suggested by:   rmacklem
MFC after:      2 days
Sponsored by:   The FreeBSD Foundation

Remove the printf() stances added in commit d4cc791f3b2e ("sys/rpc: UNIX
auth: Fix OOB reads on too short message").

Even if it can be helpful to know why an authentication message is
rejected, printing explanatory messages on each request attempt is
a remote log filler that could be triggered by accident, and the generic
RPC code generally does not do that.  These printf() calls should be
restored only after some limiting or configuration mechanism is devised.

MFC with:       d4cc791f3b2e ("sys/rpc: UNIX auth: Fix OOB reads on too short message")
Sponsored by:   The FreeBSD Foundation

No functional change intended.

Reviewed by:    olce, kib, emaste
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53062

In the non-ASLR case, there is no check for an error from
vm_map_fixed().  Restore it, it was dropped in commit 939f0b6323e0a.
This bug could result in a refcount leak of the object used to map the
VDSO page.

Reviewed by:    kib
Reported by:    Ilja Van Sprundel <ivansprundel@ioactive.com>
MFC after:      1 week
Fixes:  https://cgit.freebsd.org/src/commit/?id=939f0b6323e0 ("Implement shared page address randomization")
Differential Revision:  https://reviews.freebsd.org/D53065

Just make it like all other sockets that have PF_FOO -> AF_FOO alias.

Enable the kernel build option TCP_HPTS_KTEST on debug builds and
disable it on non-debug builds.

PR:                     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290234
Reviewed by:            Nick Banks, glebius
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53108

The send operations are waiting on the peer's socket buffer, but we shall
use our timeout value.  Provide a test for that.

Reported by:            phk
Reviewed by:            asomers
Differential Revision:  https://reviews.freebsd.org/D53081
Fixes:                  https://cgit.freebsd.org/src/commit/?id=d15792780760ef94647af9b377b5f0a80e1826bc

Rework internal RB macros to avoid assignments via type punned pointers.
RB uses low order pointer bits to encode information (whether children
are red), and was manipulating those values via (*(__uintptr_t *)&elm),
which leads to strict aliasing warnings.

In the kernel we use -fno-strict-aliasing, but this isn't necessarily
the case in user space.  This quiets thousands of -Wstrict-aliasing
warnings in the user space build.

Reported by:    GCC -Wstrict-aliasing
Reviewed by:    dougm
Discussed with: kib
Differential Revision:  https://reviews.freebsd.org/D52939

No functional change.

Differential Revision:  https://reviews.freebsd.org/D52936

Differential Revision:        https://reviews.freebsd.org/D52937

In parse_notes we validate that the note name fits within the note
buffer, but we do not do the same for the note data, so there is some
potential for an OOB read in the note handler.  Add a bounds check.

Reported by:    Ilja Van Sprundel <ivansprundel@ioactive.com>
Reviewed by:    kib, emaste
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53063

Just like we do with copyin() and copyout().

Reviewed by:    glebius
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53114

while peer has closed its end.

Reported by:    syzbot+ffcc3612ea266e36604e@syzkaller.appspotmail.com

Bump the socket buffer limit from 2 MB to 8MB.
In particular, this allows to use larger values for TCP sockets,
which may result in higher throughput values with default settings.
In the review I was proposing using 16 MB, but in the transport
call today we settled on a more conservative value of 8.
Bumping it further will be done in combination with mitigations
for mbuf exhaustion attacks.

Reviewed by:            rscheff, Peter Lei, jtl, thj
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52873

After commit 7a79d0669761 we no longer hold the VM object lock when
initializing or advancing the domainset iterator in
vm_thread_stack_create().

We could lift the lock out of vm_thread_stack_back() but that poses
complications since we cannot allocate KVA with a VM object lock held.

Instead of overridding the object's iterator, just borrow that of the
current thread.  Kernel stacks are basically always allocated with a
DOMAINSET_POLICY_PREFER policy, so it's not very important to maintain a
global iterator for round-robin allocation.

As a part of this, fix up flag handling: make sure we handle
M_NOWAIT/M_WAITOK from the caller.  Delete a comment in vm_thread_new()
which refers to a non-existent consideration (stack swapping has been
removed).  I suspect vm_thread_new() can use M_WAITOK but opted not to
make that change here.

Reported by:    olce
Reviewed by:    olce, alc, kib
Fixes:          https://cgit.freebsd.org/src/commit/?id=7a79d0669761 ("vm: improve kstack_object pindex calculation to avoid pindex holes")
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D52982

These map directly onto sysctls under vfs.inotify of the same name.

Reviewed by:    olce, des
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53142

All iterators that rely on an object's 'struct domainset_ref' (field
'domain' on 'struct vm_object'), which is the case for page allocations
with objects, are used with the corresponding object locked for writing,
so cannot lose concurrent iterator index's increases even if those are
made without atomic operations.  The only offender was thread stack
allocation, which has just been fixed in commit 3b9b64457676 ("vm: Fix
iterator usage in vm_thread_stack_create()").

However, the interleaved policy would still reset the iterator index
when restarting, losing track of the next domain to allocate from when
applying round-robin, which all allocation policies do if allocation
from the first domain fails.

Fix this last round-robin problem by not resetting the shared index at
iterator's phase init on DOMAINSET_POLICY_INTERLEAVE.

Add an assertion to check that, when passed, an object is write-locked
in order to prevent the problem mentioned in the first paragraph from
reappearing.

Reviewed by:    markj
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52733

instead of referencing or ignoring.

The pass to handle copying is performed after all passable files are
installed into the new file descriptor's table, since one of the future
consumers of this interface (kqueue) needs all passable file descriptors
already valid. After all fds are installed, the additional call for each
copyable file is done to copy the underlying object.

[MFC note: use fo_spares for fo_fork]

Reviewed by:    markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

The proc is the owner of the copied filedesc.

Reviewed by:    markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

Reviewed by:  markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

The new helper function allows to allocate a kqueue and its file,
without also allocating file descriptor.

Reviewed by:    markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

Reviewed by:  markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

The created kqueue is copied on fork, together with the registered
events. This means that a new kqueue is created at the same fd index
as the parent' kqueue, and all registered events are copied into the
new kqueue (when possible). The current active events list is also
duplicated.

Reviewed by:    markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

Reviewed by:  markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

Reviewed by:  markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

Reviewed by:  markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

No functional change intended.

Reviewed by:    kib
MFC after:      10 days
MFC with:       80336636b6b9f7a3bdad007c400e85eae017d2a2
Differential Revision:  https://reviews.freebsd.org/D53173

Previously, blacklist man pages were just a symlink to their blocklist
counterpart, this in turn installed blocklist man pages twice, and
resulted in a duplicate error when running metalog_reader.lua -c.

Take advantage of the duplication to document nuances in blacklist, such
as the fact that it uses the new database and socket name (blocklist).
Also, note that it has been renamed to blocklist.  In the future, it
will help to document its deprecation.

Approved by:    emaste (mentor)
Fixes:  https://cgit.freebsd.org/src/commit/?id=7238317403b9 ("blocklist: Rename blacklist to blocklist")
MFC after:      2 days

To build set-src, we first need to build the source packages.  Add a
.ORDER to ensure this happens.  Otherwise, in a parallel build, sets
might be built before the src-* packages have finished building, and
set-src will be mysteriously missing.

MFC after:      3 seconds
Reported by:    cperciva
Actually diagnosed by:  jrtc27
One-line fix by:        ivy
Reviewed by:    cperciva
Differential Revision:  https://reviews.freebsd.org/D53076

The FreeBSD-base pkg repository is currrently dominated by a handful of
large packages: Out of a compressed repository size of ~960 MB, about
160 MB is taken up by the FreeBSD-src package, 128 MB (on amd64) is
used by the FreeBSD-kernel-generic-dbg package, and 91 MB is used by
the FreeBSD-src-sys package.  Consequently, running 'make packages -jN'
provides less benefit than one might hope, as most of the packages
finish building quickly, ultimately leaving the FreeBSD-src package
building by itself for a couple minutes while all the other CPUs are
idle.

Pass -T${PKG_CTHREADS} to the 'pkg create' commands (with a default
of -T0) in order to instruct pkg's zstd compression to use multiple
threads.

Testing on an EC2 r7i.48xlarge instance with -j192, this reduces the
time taken by 'make packages' from 6m17s to 1m39s; package creation
time itself (excluding the initial process of installing into world
and kernel staging directories) dropped from 5m37s to 59s.

Reviewed by:    ivy
MFC after:      3 days
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D53053

As recently fixed in sockstat (9934558460e4), having tests/Makefile
include files from the parent directory with SRCS= ../foo.c results
in a race condition as the parent build and the tests build try to
produce the same object file but contain different paths.

Use .PATH to tell make to find sockstat.c in the parent directory
but place the object file in the current object directory.

Reviewed by:    emaste, jrtc27, kevans
MFC after:      3 days
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D53075

This more accurately reflects its purpose, and its contents, since
everything in the package is prefixed with "local-".

While here, add a message on upgrade about regenerating the config.

MFC after:      3 seconds
Requested by:   des
Reviewed by:    des
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53056

Set LIB_PACKAGE= in lib/ncurses/Makefile.inc so the ncurses libraries
go into the ncurses-lib subpackage rather than the base package. This
means applications that depend on ncurses can be installed without
needing to install the various utilities and manpages.

This removes a dependency from runtime to ncurses (it now depends on
ncurses-lib instead).

MFC after:      3 seconds
Reviewed by:    kevans
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53060

Include /packages in the METALOG used to create dvd1.iso.  Previously
we used an expression ^./packages/ (with a trailing /) which did not
match /packages itself, and then with no METALOG entry /packages on
dvd1.iso ended up with mode d---------.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290222
Reviewed by:    cperciva
MFC after:      1 minute
Sponsored by:   The FreeBSD Foundation

GCC has started to warn about memory accesses under address 0x1000.
Tweak it to 0x400 for stand/i386 to avoid warnings for access to BIOS
data area memory and above but still retain most of the warning value.

Reviewed by:    dab, imp
Differential Revision:  https://reviews.freebsd.org/D53036

Similar to SUBDIR and CONFGROUPS, this allows the use of
MANGROUPS.${MK_FOO}, simplifying Makefile logic for optional
manpages.

MFC after:      3 seconds
Reviewed by:    emaste
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53126

tar(1) is not a core runtime utility; in particular, nothing in
/etc/rc.d/* requires it.  Move it to utilities, which is also
where cpio(1) lives.

This removes the dependency from runtime to libarchive.

MFC after:      3 days
Reviewed by:    manu, emaste
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53059

igc(4) seems to work fine on arm64 for as much as I could test with
a 2.5Gbit/s interface on a mPCIe card.
Enable the module build so it is available.

MFC after:      3 days

Theoretically METALOG should include everything which needs to go
into disk images; unfortunately there are still a few bugs which
are resulting in directories not being listed -- and if METALOG
has files in unrecorded directories, the directories end up being
created with 000 permissions.

Oddly enough, systems where / has 000 permissions are not very
usable.

As a temporary hack, compare the staging tree against METALOG and
add entries for any unrecorded directories.  This will hopefully
be reverted before 15.0-RELEASE.

Reviewed by:    bapt, emaste, ivy
Sponsored by:   https://www.patreon.com/cperciva
MFC after:      5 minutes
Differential Revision:  https://reviews.freebsd.org/D53153

MFC after:    3 days
Reviewed by:    manu, kevans
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53163

Using these targets on a pkgbase system will cause the installed system
to become out of sync with the package database, which is almost certain
to cause issues the next time pkg(8) is used.

To prevent users doing this accidentally, disallow install* if we detect
that FreeBSD-runtime is installed in the target.  The check can be
overridden with DESTDIR=/ for users who are sure they want to do this.

MFC after:      3 days
Reviewed by:    emaste
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52879

We only need to check for unMETALOGed directories and sort the METALOG
file if we're using it, i.e. if we're doing a NO_ROOT build.  This
non-NO_ROOT builds by no longer bogusly writing to /METALOG*.

We only need to add databases (spwd.db etc) to METALOG if we're doing
a pkgbase-enabled NO_ROOT build; but we should always do this before
creating the filesystem, not only if we installed extra packages (in
vm_extra_install_packages, where that code was erroneously placed).
This fixes non-cloud VM images, which in 15.0-BETA2 shipped without
password databases.

Reviewed by:    ivy
MFC after:      3 days
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D53194

Reported by:  emaste (srcmgr)

The bank no longer uses this information as a security question.

Add -F fmt option to give a free format string to git show --pretty=.
It can be used, for example, as:
  ./tools/tools/git/mfc-candidates.lua -F "%h %cD %s"
to see which commits have passed the minimum 3 days of waiting before
MFCing, or to see which group of commits belong together.

MFC after:      3 days
Reviewed by:    emaste
Differential Revision: https://reviews.freebsd.org/D53172

* Passing NULL should result in EINVAL
* Passing an empty path should result in ENOENT
* Failure with a non-null buffer should leave a partial result.  As
  pointed out in a comment in the test case, this reveals a discrepancy
  between the documentation and reality.

Sponsored by:   Klara, Inc.
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53024

Sponsored by: Netflix
Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D52736

Sponsored by: Netflix
Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D52735

This test implicitly depended on the order in which two threads
completed.  If the test thread finished first, the test would pass.  But
if the mock file system thread did, it would attempt to read from an
unmounted file system, and fail.  As a result, the test would randomly
fail once out of every several thousand executions.  Fix it by telling
the mock file system's event loop to exit without attempting to read any
more events.

Reported by:    Siva Mahadevan <me@svmhdvn.name>
MFC after:      1 week
Reviewed by:    Siva Mahadevan <me@svmhdvn.name>
Differential Revision: https://reviews.freebsd.org/D53080

The receiver is run as a background job, so we need a wait loop to
make sure it has been fully functional before launching sender.

Reported by:    Siva Mahadevan <me svmhdvn.name>
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290210

Otherwise routed logs a warning:

"MCAST_LEAVE_GROUP ALLROUTERS: Can't assign requested address"

that may be misinterpreted as a problem.

glabel: add a basic test

Reviewed by:    asomers
MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")
Differential Revision:  https://reviews.freebsd.org/D53178

Add glabel tests to mtree

Fixes:          https://cgit.freebsd.org/src/commit/?id=e868a2026635: glabel: add a basic test.
Submitted by:   Siva Mahadevan
Pointy hat to:  brd
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1877

Approved by:  emaste (mentor)
Fixes:          https://cgit.freebsd.org/src/commit/?id=86edb11e7491 ("Always install llvm-objdump as objdump")
MFC after:      1 day

Reported by:  matteo

MFC after:      2 days
Sponsored by:   The FreeBSD Foundation

in for() loops.  Also, use 'while', where only the
conditional test of 'for' was used.

Reviewed by: sjg

Reviewed by:  emaste
MFC after:      2 days
Differential Revision:  https://reviews.freebsd.org/D53168

Reviewed by:  emaste
MFC after:      2 days
Differential Revision:  https://reviews.freebsd.org/D53170

Reviewed by:  kib
Differential Revision:  https://reviews.freebsd.org/D53193

A string array is represented by a set of nul-terminated strings
concatenated together.  For each string, we check to see if there's a
nul terminator at the end, taking care to avoid going past the end of
the buffer.  However, the code fails to handle the possibility that
size == 0 at the end of an iteration, leading to underflow.

Fix the length check.

Reported by:    Ilja van Sprundel <ivansprundel@ioactive.com>
Reviewed by:    emaste
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53069

The introduction of OpenZFS moved some sysctls, and legacy compat shims
were added.  For example:

Old (legacy) name: vfs.zfs.min_auto_ashift
New name:          vfs.zfs.vdev.min_auto_ashift

Upstream OpenZFS removed these, but we've temporarily restored them in
FreeBSD.

Note that l2arc sysctls use generic sysctl functions (e.g. SYSCTL_UQUAD)
and thus cannot trivially have warnings added, so they are not handled.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266374
Reviewed by:    jlduran
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53033

These files contain build host paths and other configuration details
that can be regenerated via the standard vendor import process. Don't
clutter up the FreeBSD tree with these files.

Add the paths to .gitignore to prevent them from accidentally being
added in a future update.

MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53044

The .pc files generated in the root directory are used as part of the
build; they should never be installed. Use the versions from the
exporters subdirectory--which should be installed--as the .pc files
which are distributed with FreeBSD. This avoids the need for "fixing up"
these files after the fact (see `crypto/openssl/BSDmakefile` for more
details as part of this change).

Garbage collect `secure/lib/libcrypto/Makefile.version`, et al,
as they're orphaned files. They were technically unused prior to this
change as the vendor process properly embeds the version numbers in
various files, but this commit formalizes the removal.

This correction/clarification on the .pc files will be made in an
upcoming release of OpenSSL [1].

References:
1. https://github.com/openssl/openssl/issues/28803

Suggested by:   Richard Levitte (OpenSSL project)
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53043

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259971
Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
Sponsored by: The FreeBSD Foundation

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259971
Obtained from:  NetBSD 7753bf0b705a
Sponsored by:   The FreeBSD Foundation