FreeBSD git weekly: 2025-10-01 to 2025-12-31

Put virtual_oss, /etc/devd/snd.conf and the other audio-related tools
into a new "sound" package.  Don't create a separate -lib package,
since it's unlikely someone will want mixer(3) without mixer(8).

Put the sound package in the optional set rather than minimal, since
it's not actually required for audio hardware support, and many systems
(including nearly all servers) won't want it installed.

MFC after:      3 seconds
Reviewed by:    christos
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52823

Add an UPDATING entry about the renaming of blocklist.

Approved by:    emaste (mentor)
Fixes:  https://cgit.freebsd.org/src/commit/?id=7238317403b9 ("blocklist: Rename blacklist to blocklist")
MFC after:      1 day

This more accurately reflects its purpose, and its contents, since
everything in the package is prefixed with "local-".

While here, add a message on upgrade about regenerating the config.

MFC after:      3 seconds
Requested by:   des
Reviewed by:    des
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53056

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52665

The size of an embedded struct has changed and might possibly be a
problem.  Allow this change to be detected by bumping __FreeBSD_version.

MFC after:      3 days

With this patch UDP-Lite endpoints are also show per default.

Reviewed by:            Peter Lei, Nick Banks
MFC after:              3 days
Relnotes:               yes
Differential Revision:  https://reviews.freebsd.org/D53230

flua is a standalone third-party component that deserves its own
package.  In particular, this means things can use flua without
having to depend on FreeBSD-utilities, which will be useful as
more base utilities use flua.

This saves ~500kB in FreeBSD-utilities for systems which don't
need flua.

MFC after:      3 days
Reviewed by:    kevans
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53161

MFC after:    3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")

OpenPAM is a discrete, largely self-contained system component.
Users may not need PAM for many use-cases (e.g. jails, containers),
so move it to its own package.

Use LIB_PACKAGE to create a separate pam-lib package for libpam,
so that applications that support PAM don't need to bring in all
the PAM modules if PAM isn't actually in use.

Add pam to the minimal sets, since this is a core system component that
people expect to be installed.  This means all supported installation
methods will install the PAM modules by default, so don't add explicit
dependencies on the PAM modules from things that use PAM (e.g. runtime),
allowing custom/embedded systems to omit these easily.

This change adds a new package to the system so, until we have a proper
policy on how to handle this in release/stable branches, it should not
be MFC'd.

MFC after:      never
Reviewed by:    des, bapt
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53602

This new function computes the alignment of a pointer.
It is part of ISO/IEC 9899:2024, the new C standard.
If the pointer is a null pointer, null is returned.
I have tried to write an implementation that can cope
with traditional address-based architectures, even if
size_t and uintptr_t are of different length.  Adjustments
may be needed for CHERI though.

A man page is provided, too.  No unit test for now.

Reviewed by:    kib, imp, ziaee (manpages), pauamma@gundo.com
Approved by:    markj (mentor)
MFC after:      1 month
Relnotes:       yes
Differential Revision:  https://reviews.freebsd.org/D53673

Reminded by:  yasu

This is the *pi family of trigonometric functions. Quite a few C23
functions are still missing.  These seem to be:
acospi, acospif, acospil, asinpi, asinpif, asinpil, atan2pi, atan2pif,
atan2pil, atanpi, atanpif, atanpil, canonicalize, canonicalizef,
canonicalizel, compoundn, compoundnf, compoundnl, daddl, ddivl, dfmal,
dmull, dsqrtl, dsubl, exp10, exp10f, exp10l, exp10m1, exp10m1f,
exp10m1l, exp2m1, exp2m1f, exp2m1l, fadd, faddl, fdiv, fdivl, ffma,
ffmal, fmaximum, fmaximum_mag, fmaximum_mag_num, fmaximum_mag_numf,
fmaximum_mag_numl, fmaximum_magf, fmaximum_magl, fmaximum_num,
fmaximum_numf, fmaximum_numl, fmaximumf, fmaximuml, fminimum,
fminimum_mag, fminimum_mag_num, fminimum_mag_numf, fminimum_mag_numl,
fminimum_magf, fminimum_magl, fminimum_num, fminimum_numf,
fminimum_numl, fminimumf, fminimuml, fmul, fmull, fromfp, fromfpf,
fromfpl, fromfpx, fromfpxf, fromfpxl, fsqrt, fsqrtl, fsub, fsubl,
iscanonical, iseqsig, issignaling, issubnormal, iszero, nextdown,
nextdownf, nextdownl, nextup, nextupf, nextupl, pown, pownf, pownl,
powr, powrf, powrl, rootf, rootl, rootn, roundeven, roundevenf,
roundevenl, rsqrt, rsqrtf, rsqrtl, ufromfp, ufromfpf, ufromfpl,
ufromfpx, ufromfpxf, ufromfpxl.

Reviewed by:    imp
Approved by:    markj (mentor)
MFC after:      1 month
Relnotes:       yes
Differential Revision:  https://reviews.freebsd.org/D53783

This new header complies with ISO/IEC 9899:2024 (C23).

Contrary to glibc, we do not provide inline definitions in
<stdbit.h> as we expect our system compiler to soon recognise
these as builtins anyway.

Relnotes:       yes
MFC after:      1 month
Reviewed by:    adrian
Approved by:    markj (mentor)
Differential Revision:  https://reviews.freebsd.org/D53657

* If invoked as fasthalt or fastboot, behavior is unchanged.

* If not invoked as fasthalt or fastboot, we simply signal init(8),
  just like shutdown(8) does, instead of taking the system down
  ourselves.

* Since only init can handle the RB_REROOT case, the -r flag is not
  supported in fast mode.

* Update the usage string to correctly reflect the program being run
  (fast or normal; halt, boot, or nextboot) and the options available
  in each case.

* Update the manual page to make the distinction between normal and
  fast mode clear, better explain what shutdown(8) still does that
  reboot(8) does not, and add a historical note explaining what the
  difference between the two used to be.

MFC after:      1 month
Relnotes:       yes
Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D54117

Currently, we have very long timeouts for the initial probing
commands. However, these are not appropriate for modern (post 2010) SCSI
disks. Sandards since SPC3 state that these commands should not wait for
media access. Since we retry them several times during the initial bus
scan, these delays can delay the boot by minutes (5 minutes per errant
disk in our expereince). These delays don't help and only hurt, so
reduce the TESTUNITREADY, INQUIRY and MODESENSE commands (during the
initial probe). Provide sysctl/tuneables to change the time for these
and also the REPORTLUNS commands for people that might need to adjust
them for devices that violate this belief but none-the-less work with
longer timeouts.
        kern.cam.tur_timeout            (default was 60s, now 1s)
        kern.cam.inquiry_timeout        (default was 60s, now 1s)
        kern.cam.reportluns_timeout     (default is 60s)
        kern.cam.modesense_timeout      (default was 60s, now 1s)
This can be partially merged: the sysctls can, but the new defaults likely
shouldn't.

Sponsored by:           Netflix
Differential Revision:  https://reviews.freebsd.org/D52427

Differential Revision:        https://reviews.freebsd.org/D54195

Reviewed by:  emaste, imp
Differential Revision:  https://reviews.freebsd.org/D54197

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289717
Reviewed by:    jhb

Signed-off-by: Faraz Vahedi <kfv@kfv.io>

Reviewed by:    asomers, markj
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1498

Reviewed by:  alc, kib
MFC after:      1 week
Sponsored by:   Modirum MDPay
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53008

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240378
Reviewed by:    otis (mentor), glebius (src committer)
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D52991

Reviewed by:  imp, kp
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52906

Don't duplicate the last component.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290362
Reported by:    John F. Carr <jfc@mit.edu>
Fixes:          https://cgit.freebsd.org/src/commit/?id=d06a00963b7
MFC after:      3 days
Reviewed by:    jilles, Goran Mekić <meka@tilda.center>
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1878

Summary: UBSAN complains about p[signed - unsigned] wrapping around.

Reviewed by:    kevans
Differential Revision: https://reviews.freebsd.org/D53226

* On startup, insert all valid PIDs into a tree.
* In our main loop, whenever a process terminates, remove its PID
  from the tree.
* On exit, if the -p flag was specified, print the remaining PIDs.

MFC after:      3 days
Reviewed by:    bcr, markj
Differential Revision:  https://reviews.freebsd.org/D53293

id: Clean up

No functional change intended.

Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D53300

id: Fix WITHOUT_AUDIT build

Rather than add more ifdefs, trust the compiler to optimize Aflag away.

Fixes:          https://cgit.freebsd.org/src/commit/?id=70b72ede982f ("id: Clean up")
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290740
MFC after:      3 days

These options may not be combined with any other options and print the
current or specified user's home directory and shell respectively.

Reviewed by:    imp, bcr
Differential Revision:  https://reviews.freebsd.org/D53301

The first argument to nmount(2) is an nvlist in the form of an iovec,
which truss already knows how to decode.  Set the correct flag so
this happens automatically.

MFC after:      1 week
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290667

Add a missing break statement to avoid falling through to the '+'
case.

Fixes:          https://cgit.freebsd.org/src/commit/?id=96f4be881e8e ("ktrace(1): teach about KTR_EXTERR")

This change follows a localized approach within getprompt() and avoids
full parser reentry. While this means we don't support advanced
expansions like ${parameter#pattern}, it provides POSIX-compliant basic
parameter expansion without the complexity of making the parser
reentrant. This is sufficient for the vast majority of use cases.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=46441

Commit 2ed053cde5 changed UFS' VOP_RMDIR() behavior to no longer
ignore whiteouts when determining whether a directory is empty,
unless explicitly requested by the caller.  However, this also
necessitates a change to rm(1) to avoid breaking the expected
behavior when forcibly removing directory hierarchies via `rm -fr`.
I neglected to make this follow-on change despite discussing it
in the review for the breaking commit (D45987).

Finally address the breakage by making `rm -fr` imply FTS_WHITEOUT
when rm(1) reads directory contents via fts_read(3).  While here,
also fix a logic error which produces a spurious 'No error' warning
message on stdout for each deleted whiteout.

Reported by:    csjp
Reviewed by:    csjp, kib, olce
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53640

Add support for a field width, which defaults to 9 if unspecified or
zero.  If the width is not exactly 9, we have to either cut off digits
or append zeroes to make up the difference.  If the width is a dash,
we pick a width based on the clock's reported resolution.  This brings
us in line with GNU coreutils.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287080
MFC after:      1 week
Reviewed by:    0mp
Differential Revision:  https://reviews.freebsd.org/D53667

In the manual page:
- Fix synopsis and use better argument names
- Improve description of flags.
- In EXAMPLES, list the contents of iguana and chameleon files.
- Use Rs to reference The Cartoon Guide to Statistics
- Fix misc indentation and style issues
- Tag SPDX

MFC after:      1 week
Reviewed by:    bcr, ziaee
Differential Revision:  https://reviews.freebsd.org/D53710

Historically, lam(1) closes stdin once we've hit EOF the first time,
which would stop it from doing anything else on subsequent gatherline()
calls with another openfile.  However, this doesn't seem to be strictly
necessary- the EOF flag on FILEs is quite sticky, so we can assume that
a subsequent fgetc(stdin) will flag EOF properly.

This 'fixes' the below-referenced commit in the sense that it surfaced
this problem as a fatal error, but the issue was pre-existing.  If we
do `lam - -`, then one gatherline() will fclose(stdin) and set `ip->eof`
for *that* openfile, while the next one will then observe that
STDIN_FILENO has been closed and turn it into an EBADF.

Add a few tests that were easy to snipe while I'm here, but I haven't
aimed for anything close to exhaustive because I think re@ would prefer
this fix go in sooner rather than later to land in 15.0.

Minor style adjustment for the previous commit while we're here.

Reported by:    cperciva
Discussed with: jrtc27
Reviewed by:    des, jlduran
Fixes:  https://cgit.freebsd.org/src/commit/?id=4472fd66d006 ("lam: fail on I/O errors")
MFC after:      3 days (tentative)
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53750

MFC after:            3 days
Reviewed by:            pauamma_gundo.com
Differential Revision:  https://reviews.freebsd.org/D53748

The command
  sh -c 'sleep 3 | sleep 2 & sleep 3 & kill %1; wait %1'
crashes (with appropriate sanitization such as putting
MALLOC_CONF=abort:true,junk:true in the environment or compiling with
-fsanitize=address).

What happens here is that waitcmdloop() calls dowait() with a NULL job
pointer, instructing dowait() to freejob() if it's a non-interactive
shell and $! was not and cannot be referenced for it. However,
waitcmdloop() then uses fields possibly freed by freejob() and calls
freejob() again.

This only occurs if the job being waited for is identified via % syntax
($! has never been referenced for it), it is a pipeline with two or more
elements and another background job has been started before the wait
command. That seems special enough for a bug to remain. Test scripts
written by Jilles would almost always use $! and not % syntax.

We can instead make waitcmdloop() pass its job pointer to dowait(),
fixing up things for that (waitcmdloop() will have to call deljob() if
it does not call freejob()).

The crash from
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290330#c2 appears to
be the same bug.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290330
Reported by:    bdrewery
Reviewed by:    bdrewery
Differential Revision:  https://reviews.freebsd.org/D53773

While waiting for input in the read builtin, if select() is interrupted
but there is no pending signal, we act like we timed out, and return the
same status as if we had been interrupted by SIGALRM, instead of looping
until we actually do time out.

* Replace the single select() call with a ppoll() loop.

* Improve validation of the timeout value.  We now accept things like
  "1h30m15s", which we used to silently truncate to "1h".  The flip side
  is that we no longer accept things like "1hour" or "5sec".

* Modify the existing `read -t 0` test case to verify that read returns
  immediately when there is input and fails immediately when there isn't.

* Add a second test case which performs the same tests with a non-zero
  timeout value.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290844
MFC after:      1 week
Fixes:          https://cgit.freebsd.org/src/commit/?id=c4539460e3a4 ("sh: Improve error handling in read builtin:")
Reviewed by:    jilles, bdrewery
Differential Revision:  https://reviews.freebsd.org/D53761

Calling dotrap() can do almost anything, including reallocating the
jobtab array. Convert the job pointer to an index before calling
dotrap() and then restore a proper job pointer afterwards.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290330
Reported by:    bdrewery
Reviewed by:    bdrewery
Differential Revision:  https://reviews.freebsd.org/D53793

When the source of the copy operation is the root directory, we should
neither append it to the destination path on FTS_D nor trim it back off
on FTS_DP.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291132
MFC after:      3 days
Fixes:          https://cgit.freebsd.org/src/commit/?id=82fc0d09e862 ("cp: Partly restore symlink folllowing.")
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53863

Sort usage and man page options, mention possible minimum and maximum
values, fix punctuation marks, and cleanup the man page.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291092
Reviewed by:    pauamma_gundo.com, christos
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53827

If the basis for supplementary groups are the current ones, we do not
need to fetch them when they are to be replaced entirely (which we
already have been doing), as in the '!start_from_current_groups' case,
but specifically also when they are not going to be touched at all.

This change in passing makes the modified code block's comment saying
that SETCREDF_SUPP_GROUPS need not be set here correct.

MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D53771

This avoids blocking forever when invoked on a fifo.

MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D54084

@bdrewery reported D48873 broke "bzgrep -q '1 2' /var/log/messages.0.bz2"
The mistake was in using $* instead of "$@" (I suspect $* is never right).

Reported by:    bdrewery
Reviewed by:    markj
Approved by:    markj
Fixes:          https://cgit.freebsd.org/src/commit/?id=1070477cc8b7 ("Fix remaining zgrep(1) wrapper script regressions")
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D54217

MFC after:    3 days

This is a minor bug, since the kernel ignores imr_address and applications
are not supposed to initialize it.

AFACT, this was never accurate.  When there was support (such as it was)
for PDP endian it seems to have been spelled PDP_ENDIAN.

Reviewed by:    imp, kib, emaste
Sponsored by:   Innovate UK
Differential Revision:  https://reviews.freebsd.org/D52817

Only i386 lays out structures with weak (4-byte) alightment.  It may be
that access works when weakly aligned, but from an ABI perspective, it's
all about struct layout.

Reviewed by:    kib, emaste
Sponsored by:   Innovate UK
Differential Revision:  https://reviews.freebsd.org/D52818

This manual only describes a tiny amount suitable for the HW Relnotes.
Remove the description section and replace it with a hardware section
which will appear there.

MFC after:      3 minutes
Reported by:    ivy
History Ref:    5bcb64f20afff21be511cc5 (Add mmc and mmcsd)

Also add cross-references to hkbd.4 and hms.4.

Sponsored by:   The FreeBSD Foundation

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280377
Sponsored by:   The FreeBSD Foundation

umass.4: Add HISTORY, HARDWARE, and SPDX

While here, break a long line that agitates the linter.

Fixes:          https://cgit.freebsd.org/src/commit/?id=cc16f1b9d9261f18 (Add umass.c)
MFC after:      1 hour
Discussed with: imp, ivy

diff --git a/sys/dev/usb/FILES b/sys/dev/usb/FILES

umass.4: Remove some extra lines which snuck in

Fixes:          https://cgit.freebsd.org/src/commit/?id=70993c2fbe1ac (umass.4: Add HISTORY, HARDWARE, and SPDX)
MFC with:       70993c2fbe1ac (umass.4: Add HISTORY, HARDWARE, and SPDX)

Reported by:  Bruno Silvestre

MFC after:            1 hr
Discussed with:         ivy, olce
Co-authored-by:         ziaee (typed up imps suggestion, tagged spdx)
Differential Revision:  https://reviews.freebsd.org/D52860

The description likely also needs some love.

MFC after:              1 hour
Co-authored-by:         ziaee (typed up imps suggestion, tagged spdx)
Differential Revision:  https://reviews.freebsd.org/D52866

MFC after:    3 days
Sponsored by:   Klara, Inc.
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D52828

Approved by:  ziaee
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52896

Replace CD-ROMs with "discs, USBs, or network boot environments"
to both modernize aesthetic and also nudge youths to think at scale.
Since I'm disrupting the flow of these lines anyway, expand the VM
acronym because I think this is one of the first manuals people will
be looking at.

Reset list alignment to seven characters. It was at 19 characters,
and that was not enough to align them all, wasting many extra lines
by crunching all the words over. Seven actually bought us some lines
from six due to avg item size. Tag SPDX.

MFC after:      3 days
Discussed with: ivy, zi

Document descriptions for device drivers always contain registered
trademarks of the manufacturers, but this is not a place for the
registered mark symbol. While here, remove another useless symbol,
the hyphen in the first line comment.

MFC after:      3 days

MFC after:    3 days

Remove prose from synopsis, adding sysctls and tunables.

MFC after:              3 days
Reviewed by:            kbowling
Differential Revision:  https://reviews.freebsd.org/D52913

Suggested by: cyric@mm.st

Adjust the BNF, and don't claim it is optional in the text.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290059
MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")

* Add subsections for the three functions that didn't already have one.
* Add a RETURN VALUES section.
* Improve the grammar somewhat.
* Clarify that fts_read() will not set errno to 0 if called again after
  having already returned NULL.

Sponsored by:   Klara, Inc.
Reviewed by:    bcr, markj
Differential Revision:  https://reviews.freebsd.org/D52925

The .Fl macro implicitly adds a '-', so only use a single '-' in the
--jail option.

Fixes:  https://cgit.freebsd.org/src/commit/?id=8d0a90512ee3 ("bsdinstall: Improve pkgbase handling for jails")
MFC after:      1 day
Reported by:    Mark Millard <marklmi@yahoo.com>
Sponsored by:   https://www.patreon.com/bsdivy

With CHERI there now more options than __ILP32__ and __LP64__ so lack of
one does not imply the other.  Encourage the use of __SIZEOF_*__ macro
tests in their place.

Effort:         CHERI upstreaming
Reviewed by:    kib, markj, emaste
Sponsored by:   Innovate UK
Differential Revision:  https://reviews.freebsd.org/D52820

Don't claim void* or (u)intptr_t are the same size as long.  This isn't
true for CHERI.

Effort:         CHERI upstream
Reviewed by:    kib, markj, jhb, emaste
Sponsored by:   Innovate UK, DARPA, AFRL
Differential Revision:  https://reviews.freebsd.org/D52821

Effort:               CHERI upstreaming
Co-authored-by: Brooks Davis <brooks@FreeBSD.org>
Reviewed by:    kib, markj, jhb, emaste
Sponsored by:   Innovate UK, DARPA, AFRL
Differential Revision:  https://reviews.freebsd.org/D52822

The vnet.interface parameter allows defining multiple interfaces,
separated by commas. Mention this in the man page.
While here, fix some other style nits that mandoc complained about.

PR:                     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206353
Approved by:            ziaee
Differential Revision:  https://reviews.freebsd.org/D52965

To improve HW relnotes

MFC after:      3 days

The document description previously just stated the name of the driver.
Replace this with the name of the controller families and specs that
it supports, in a similar fashion to other RAID drivers.

MFC after:      3 days

Emphasize the peculiar treatment of 'ngroups', through which the
effective group list's size is returned, even if the passed allocated
size is not big enough, in which case the output 'groups' array is
completely filled with the effective group list's first elements.

Use the precise POSIX term for the group associated to the user in the
password database ("initial numerical group ID"), consistently with what
was done in initgroups.3.

Use "length" instead of "size" to refer to the number of elements of an
array (in contrast with its actual size in bytes).

Perform some minor simplifications on top of the last rework.

MFC after:      1 hour
Sponsored by:   The FreeBSD Foundation

The current phrasing could be interpreted as meaning that initgroups(3)
could return ENOMEM instead of -1, which it actually did until I fixed
it in commit 0b018cfd81d8 ("initgroups(3): Fix return value on
allocation failure").

While here, mention setgroups(2) as a system call rather than a library
function.

MFC with:       0b018cfd81d8 ("initgroups(3): Fix return value on allocation failure")
Sponsored by:   The FreeBSD Foundation

Be explicit that newaliases for sendmail
(Upstream sendmail.org commit 3084151d898)

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289259
MFC after:      1 hour

+ consolidate kernel configuration in SYNOPSIS
+ explain driver autoloading in DESCRIPTION
+ s/port/interface/ because of internal USBs
+ fix flow of remaining example

MFC after:      1 day

Reflow comments in literal text blocks
so this manual is legible at MANWIDTH 78.

MFC after:      1 day

Reviewed by:  markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52983

In the STANDARDS section, stop mentioning behavior that is not
prescribed by POSIX and make sure to specify which alternative we
implement (as POSIX allows to return or not the effective group ID).

Say more clearly that programs treating specially the first slot of the
returned array must be modified.

Consistently use "group ID" instead of "GID".

These changes are going to be MFCed into stable/14 as part of MFCing
commit 4be38acc826f ("getgroups.2: Clarify, mention ascending order, add
SECURITY CONSIDERATIONS"), so the current commit will be MFCed to
stable/15 only.

MFC after:      1 hour
MFC to:         stable/15
Sponsored by:   The FreeBSD Foundation

The pam_xdg module does set the XDG_RUNTIME_DIR in the environment, it's actually
its main purpose.

Reported by:    arrowd

This command doesn't accept a vlan-id.

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290141
MFC after:      3 days
Reported by:    Paul Procacci <pprocacci@gmail.com>
Reviewed by:    ziaee (manpages)
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53049

Document how bridge implements VLANs, and provide an example of
configuring a bridge with VLAN filtering.

MFC after:      3 days
Reviewed by:    ziaee, pauamma_gundo.com (previous version)
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D51185

We've been mostly POSIX-conforming since r236400 and fully since r240410,
which fixed a corner case where a missing non-leaf directory would be
reported as ENOTDIR instead of ENOENT.

Sponsored by:   Klara, Inc.
Fixes:          https://cgit.freebsd.org/src/commit/?id=7877ed7ce33e ("Avoid mapping ENOENT to ENOTDIR for non-existent path components.")
Reviewed by:    ziaee, markj
Differential Revision:  https://reviews.freebsd.org/D53027

Add an UPDATING entry about the renaming of blocklist.

Approved by:    emaste (mentor)
Fixes:  https://cgit.freebsd.org/src/commit/?id=7238317403b9 ("blocklist: Rename blacklist to blocklist")
MFC after:      1 day

- Fix a typo.
- Provide the default path.

Reviewed by:    des
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53001

Create a chapter on every important socket type: stream, datagram,
seqpacket.  Always list what protocol families do support what kinds of
sockets.  Improve some statements possessing language from the
specification [1].  Reduce some statements that are mostly specific to
TCP.  Provide more external links and references to various important
syscalls that can be used on sockets.

Add a paragrph on non-blocking mode.

The big factual change is documentation of SOCK_SEQPACKET.  In FreeBSD 15
this socket now fully follows the specification and is a stream socket
with record boundaries.

[1] https://pubs.opengroup.org/onlinepubs/9799919799/functions/V2_chap02.html#tag_16_10_06

Differential Revision:  https://reviews.freebsd.org/D52771

MFC after:    3 days
Reviewed by:    dab
Differential Revision:  https://reviews.freebsd.org/D52867

+ arm/RPI-B.conf no longer exists, adjust for arm64/RPI.conf
+ document default CHROOTDIR, also add to FILES list
+ tag SPDX

MFC after:      3 days
Reviewed by:    cperciva
Differential Revision:  https://reviews.freebsd.org/D53078

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52665

The manpages of linprocfs(5) and linsysfs(5) document incomplete names without
"fs" suffix. Make them identical to other filesystems.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283079
MFC after:      3 days
Reviewed by:    ziaee, markj
Differential Revision:  https://reviews.freebsd.org/D53155

MFC after:    3 days
Reviewed by:    asomers, olce
Differential Revision:  https://reviews.freebsd.org/D53137

Reviewed by:  markj
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

MFC after:    3 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52586

Sponsored by: The FreeBSD Foundation
MFC after:      4 days
Reviewed by:    ziaee
Differential Revision:  https://reviews.freebsd.org/D53257

The direction of the data transfer in uio(9) can be confusing,
so state explicitly the difference between UIO_READ and UIO_WRITE.

Reviewed by:    ziaee
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52996

Reviewed by:  ziaee
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D52992

fdisk: Bump removal to FreeBSD 16.0

Removal did not happen prior to 15.0.

Sponsored by:   The FreeBSD Foundation

fdisk: Bump deprecated version in warning message as well

Fixes: https://cgit.freebsd.org/src/commit/?id=f817f6e7f4a8 ("fdisk: Bump removal to FreeBSD 16.0")
Sponsored by:   The FreeBSD Foundation

Add 14.2, as this was cherry-picked prior to release.

Reported by:    Harald Eilertsen
Reviewed by:    kib
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53320

We live in the SPDX world now and our example manual pages should
reflect that.

Also, fix the order of the SPDX and copyright lines as per style(9).

Reviewed by:    ziaee
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53335

The ffs() function conforms to IEEE Std 1003.1-2008 ("POSIX.1").
The ffsl() and ffsll() functions conform to IEEE Std 1003.1-2024 ("POSIX.1").

Reviewed by:    ziaee
MFC after:      5 days
Differential Revision:  https://reviews.freebsd.org/D53352

We use a pkg(8) trigger to run makewhatis for /usr/share/man when
manpages are updated, but this doesn't cover /usr/share/openssl/man.

Rewrite the trigger to process a list of directories instead of a
single directory, and include /usr/share/openssl/man in the list.

MFC after:      3 days
Reviewed by:    emaste
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53064

mac_text(3) as-written would seem to indicate that a `mac_t` should be
freed with free(3), but this isn't the case.  One can derive from
context from when the change was introduced and COMPATIBILITY that this
was intended to talk about *text in `mac_to_text`, so move the comment
there.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=179832
Co-authored-by: Priit Järv <priit cc ttu ee>
MFC after:      3 days

MFC after:    3 days

Also provide the pointer to the latest POSIX standard that justifies the
requirement.

Reviewed by:    emaste
Discussed with: rmacklem
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D53361

Fixes:        https://cgit.freebsd.org/src/commit/?id=01addd846c64fc2c8be610d83bfdc84ddb57f2ec

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53240

The comment in sys/vnode.h describes
the v_op member as "vnode operations vector",
so use "operations" instead of "operation" here.

Reviewed by:    bcr
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53333

It was not actually removed prior to FreeBSD 15.0.

Sponsored by:   The FreeBSD Foundation

It was not actually removed prior to FreeBSD 15.0.

Sponsored by:   The FreeBSD Foundation

MFC after:    3 days

MFC after:    3 days

MFC after:    3 days
Reviewed by:    ziaee
Differential Revision:  https://reviews.freebsd.org/D53411

The examples only show the usage of `-c <numcpus>`, as did the flag
description, however the -c flag supports more complex cpu topology
specifiers. These were documented correctly in SYNOPSIS, add them to
the body of the DESCRIPTION as well. Someone could go further and do
and example with using them.

MFC after:      3 days
Event:          OpenZFS Developer Summit '25
Reported by:    Levi Worley <levi@gainframe.com>

MFC after:    3 days

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289113
MFC after:      3 days

Block devices are a thing of a past in FreeBSD.

Reviewed by:    ziaee
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53332

MFC after:    1 month
MFC to:         stable/15
Approved by:    mhorne, markj (mentor)
Sponsored by:   Google LLC (GSoC 2024)
Differential Revision:  https://reviews.freebsd.org/D46023

MFC after:    1 month
MFC to:         stable/15
Approved by:    mhorne, markj (mentor)
Reviewed by:    fuz
Sponsored by:   Google LLC (GSoC 2024)
Differential Revision:  https://reviews.freebsd.org/D45730

MFC after:    1 month
MFC to:         stable/15
Approved by:    mhorne, markj (mentor)
Reviewed by:    fuz
Sponsored by:   Google LLC (GSoC 2024)
Differential Revision:  https://reviews.freebsd.org/D45693

MFC after:    1 month
MFC to:         stable/15
Approved by:    mhorne, markj (mentor)
Reviewed by:    fuz
Sponsored by:   Google LLC (GSoC 2024)
Differential Revision:  https://reviews.freebsd.org/D46139

MFC after:    1 month
MFC to:         stable/15
Approved by:    mhorne, markj (mentor)
Reviewed by:    fuz, Jari Sihvola <jsihv@gmx.com>
Sponsored by:   Google LLC (GSoC 2024)
Differential Revision:  https://reviews.freebsd.org/D46230

index() and strchr() are implemented by calling strchrnul(), so they
also get to be marked as platform-specific.

MFC after:      1 month
MFC to:         stable/15
Approved by:    markj (mentor)
Reviewed by:    fuz
Sponsored by:   Google LLC (GSoC 2024)
Differential Revision:  https://reviews.freebsd.org/D46047

Event:                Google Summer of Code 2024
MFC after:      1 month
MFC to:         stable/15
Approved by:    markj (mentor)
Differential Revision:  https://reviews.freebsd.org/D53248

Tracing bio_bcount makes little sense for some devices like for example
md(4), as it is set to "0" instead of to the actual I/O length.

markj@ suggested the following DTrace one-liner to identify some cases
where bio_length is set but bio_bcount is not:

    dtrace -n 'io:::start /args[0]->bio_length != args[0]->bio_bcount/{printf("%d %d", args[0]->bio_length, args[0]->bio_bcount); stack();}'

For future reference in the context of bio_length vs bio_bcount,
phk@ mentioned in the code review that:

> the original intent was to get rid of of bio_bcount

Reviewed by:    markj
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53365

Sponsored by:         Netflix

Commit d6864221d8 added support for the _PC_CASE_INSENSITIVE
name for pathconf, to indicate if case insensitive lookups
are configured.

This patch documents this new name and also updates
the description for _PC_HAS_HIDDENSYSTEM to also
include UF_ARCHIVE.

This is a content change.

Reviewed by:    kib
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53508

Reviewed by:  markj
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53417

The ordering point is not the atomic operation itself, but the load for
acquire or store for release done as part of the atomic.  This does not
matter for atomic_load_acq and atomic_store_rel, but does matter for RWM
operations.

Noted by:       alc
Reviewed by:    markj
Discussed with: alc
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52744

Reviewed by:  markj
Discussed with: alc
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52744

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290705
MFC after:      1 week
Sponsored by:   Rubicon Communications, LLC ("Netgate")

MFC after:    3 days

I did not bump the date here as the manual page looks more like a draft
and I'm not sure if it is actually up-to-date considering that it's
current Dd dates back to 1998.

MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52770

These were previously somewhat safe to call destroy_dev(9), but will now
also cause a deadlock in the same fashion that d_close doing so would
previously.  Amend the note to point it out, in case it's useful for
someone.

Reviewed by:    imp, kib, markj
Differential Revision:  https://reviews.freebsd.org/D53439

ZFS has since been changed to use EOPNOTSUPP instead of EINVAL, and
fusefs/nfs are following suit.  POSIX Issue 8 had also made this move,
so it makes sense for us to standardize on EOPNOTSUPP.

Note in the HISTORY section where we're diverging from our previous
versions to align with the new standard.

Reviewed by:    asomers, imp (both previous version), kib
Differential Revision:  https://reviews.freebsd.org/D53537

Specifically, remove Tn macors, replace Li with Ql, and escape %N to
address date.1's rendering issues on man.freebsd.org.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290801
Reported by:    jinwookjeongg@gmail.com
MFC after:      1 week
Sponsored by:   Klara, Inc.

MFC after:    3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")

This manual is large enough and well structured enough that we can have
a clickable table of contents. Use that to move some subsections which
should not appear in Hardware Release Note to the description section.
Adjust subsection names so this will work, preserving parentheticals
for search by moving them to the bodies just below.

Strip unnecessary copyright symbols and escaped hyphens. Copyright
symbols never appear in the content of manual pages, including other
Intel manual pages, and appear to break the Hardware Release Notes.
Escaped hyphens were necessary decades ago for manual pages written
in man(7), but this page is written in mdoc(7). Also misc touchups.

Add the recently added E835 devices to the supported HARDWARE list.
Add the speed ranges to description like the other ethernet drivers.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290778
MFC after:      1 day
Fixes:          https://cgit.freebsd.org/src/commit/?id=09b48f811b4b (Add support for E835-XXV-4 adapter)
Fixes:          https://cgit.freebsd.org/src/commit/?id=b202176dc76d (Add PCI IDs for E835 devices)
Reviewed by:    kgalazka (previous version)
Reported by:    kgalazka (additional hardware has been added)
Reported by:    bigsneaky@duck.com (HW Relnote is truncating)

The user can trivially see the list of examples in /etc/inetd.conf
by looking at the file, so there's no need to include an entire
paragraph in the manual enumerating the examples which are provided.

MFC after:      3 days
Reviewed by:    0mp
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52740

mpr.4: Add Broadcom LSI 3808 to HARDWARE

The product brief "MegaRAID 9500 PCIe Gen 4.0 Tri-Mode Storage Adapters"
confirms that the LSI 3808 are supported in FreeBSD.

https://docs.broadcom.com/doc/MegaRAID-9500-Tri-Mode-Storage-Adapters

MFC after:              3 days
Reviewed by:            imp, ziaee
Differential Revision:  https://reviews.freebsd.org/D52760

mpr.4: Remove Broadcom LSI 3908 from support list

"This one is my fault due to incorrect merging" ~ziaee

MFC after:              3 days
Reviewed by:            ziaee
Fixes:                  https://cgit.freebsd.org/src/commit/?id=744c8d554453 (mpr.4: Add Broadcom LSI 3808)
Differential Revision:  https://reviews.freebsd.org/D53634

While here, change "N" to "X" to match sndctl.8's notation.

Sponsored by:   The FreeBSD Foundation
MFC after:      4 days
Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D53503

Document debug.minidump and machdep.dump_retry_count sysctl variables.

PR:                     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259393
MFC after:              3 seconds
Reviewed by:            gbe (previous), markj, ziaee
Differential Revision:  https://reviews.freebsd.org/D32618

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290425
MFC after:      3 seconds, this fixes the HW relnotes
Reported by:    jwb

Bump .Dd too while I am here.

Tag SPDX while here. This is not a content change, so do not bump date.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274164
MFC after:      3 seconds

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272426
MFC after:      3 days
Co-authored-by: Piotr Smyrak <ps.ports@smyrak.com>

There should be no space between -x's "arg" and "=value".

MFC after:      3 days

PR:                   https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200803
MFC after:              3 days
Reviewed by:            jamie
Differential Revision:  https://reviews.freebsd.org/D53631

For some people "Ed" is a first name, but for mandoc it is a
macro (end of display block) and needs to be escaped.

Reviewed by:  markj
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53627

MFC after:            3 days
Reviewed by:            ziaee
Fixes:                  https://cgit.freebsd.org/src/commit/?id=dea5f973d0c8 (new Intel Ethernet E610 family)
Differential Revision:  https://reviews.freebsd.org/D52990

This updates the nuageinit man page by aligning mentions of the
cloud-config header line with the cloud-init documentation[0], removing
an unwanted "!" character.

[0] https://docs.cloud-init.io/en/latest/explanation/about-cloud-config.html#how-do-i-create-a-cloud-config-file

Signed-off-by: Jonathan Matthews <freebsd@hello.jonathanmatthews.com>
Differential Revision:  https://reviews.freebsd.org/D53706

Explain how to collect E610 device debug dump data with sysctl for
troubleshooting with Intel Customer Support.

Fixes:                  https://cgit.freebsd.org/src/commit/?id=2170400142b9 (Add support for debug dump)
Reviewed by:            bcr, erj (previous version), ziaee
Signed-off-by:          Yogesh Bhosale <yogesh.bhosale@intel.com>
Differential Revision:  https://reviews.freebsd.org/D52990

+ tag SPDX
+ add sysctl to apropos database
+ fix markup of examples and reflow a overly long line
+ add a hardware section for hw relnotes

MFC after:      3 days

MFC after:    3 days

MFC after:    3 days
Fixes:          https://cgit.freebsd.org/src/commit/?id=76735c74398923a (flash: Add "n25q64" to mx25l driver)

Explain driver loading and application access in the body of the manual.
Crossreference other game controller driver manuals, and devfs.rules to
hint about how to configure application access. Add a common dongle to
supported hardware. Add evdev a few places to make it really clear how
it works.

MFC after:              immediately for inclusion in 15.0R
Reviewed by:            wulf
Differential Revision:  https://reviews.freebsd.org/D53290

MFC after:            immediately for inclusion in 15.0R
Reported by:            ivy
Differential Revision:  https://reviews.freebsd.org/D53745

* Rewrite the first paragraph to clarify that quot(8) only supports FFS.

* Document which options can or cannot be combined with each other.

MFC after:      1 week
Reviewed by:    ziaee
Differential Revision:  https://reviews.freebsd.org/D53727

console=comconsole is for the loader and boot_serial is for the kernel.

I think we should centralize documentation on the loader settings in one
manual, such a loader.8. The current proliferation is not obvious where
to find the documentation. To the user, these are all set in loader.conf
or at the loader prompt.

MFC after:              3 days
Differential Revision:  https://reviews.freebsd.org/D53695

Begin documenting module loader commands in loader(8), where the reader
would look for them. Segregate them by their availability in individual
loader implementations, like build(7) targets.
These details were graciously donated by kevans.

MFC after:              3 days
Reviewed by:            kevans
Co-authored-by:         Kyle Evans <kevans@freebsd.org>
Differential Revision:  https://reviews.freebsd.org/D50727

iwx.4: Fix SYNOPSIS

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290812
MFC after:      3 days
Fixes:          https://cgit.freebsd.org/src/commit/?id=27c41b28b1d7 (iwx.4: Initial manual page)
Reported by:    Dimitry Lukhtionov <dimitryluhtionov@gmail.com>

iwx.4: Follow the established style

Fixes:          https://cgit.freebsd.org/src/commit/?id=b0c1ead2b9be ("iwx.4: Fix SYNOPSIS")
Reviewed by:    ziaee
Differential Revision:  https://reviews.freebsd.org/D53760

Reviewed by;  ziaee
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52460

Reminded by:  yasu
MFC after:      3 days

Reminded by:  yasu

Sponsored by: The FreeBSD Foundation

Floppies have been obsolete for over a decade.  Add a deprecation note
now and plan to remove fdc(4) support in 16.

Reviewed by:    ziaee
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D41549

The deprecation notice should indicate that the driver or feature will
be removed in a future release, not one that's nearly EOL.

Sponsored by:   The FreeBSD Foundation

Approved by:  markj (mentor)
MFC after:      1 month
Differential Revision:  https://reviews.freebsd.org/D53784

 - also use new .St -ieee754-2008 request in *pi.3

Reviewed by:    imp
Approved by     markj (mentor)
See also:       D53784
Differential Revision:  https://reviews.freebsd.org/D53783

Reviewed by:  pauamma_gundo.com
Sponsored by:   The FreeBSD Foundation
Differential revision:  https://reviews.freebsd.org/D53798

Release notes are generated using this text.

I used "interfaces" not "adapters" in these pages as the listed devices
are the controller ICs, not end-user projects.

Reviewed by:    ziaee
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53846

This is the only place this important debugging tunable is documented.
Mark it up with the Va macro according to style.mdoc(5) so that people
can find it via `apropos Va=kern.msg`, the standard syntax to search
the FreeBSD manual for sysctls and tunables.

Fixes:  https://cgit.freebsd.org/src/commit/?id=6910fee62e77 (dmesg: Document kern.msgbuf_show_timestamp)

MFC:                  immediately as 2 llms say this is impossible
Reviewed by:            adrian, emaste
Differential Revision:  https://reviews.freebsd.org/D53860

- Add several missing .Pp after lists and literal blocks.

- Fix the column widths for the console table and use a shorter indent
  so that it doesn't wrap on an 80-col display.

Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D53866

Document the nosymfollow mount option in more details.
Forgotten in 5ddc8ded1dbe650b7d83240a1f86a1eb6e2b9b5a

Signed-off-by: Ricardo Branco <rbranco@suse.de>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1891

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1890

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1890

This is a manual page update describing the functionality that was added
to mdo(1) in commit 3ca1e69028ac ("mdo(1): Add support and shortcuts for
fully specifying users and groups").  Please either refer to that commit
or the new manual page's content for more information.

While here:
- Add to the introduction a description of process credentials and some
  specific vocabulary that is used throughout the page, as well as the
  relationship between mdo(1) and mac_do(4).
- Update the HISTORY section.
- Add AUTHORS and SECURITY CONSIDERATIONS sections.

Reviewed by:    ziaee
MFC after:      1 minute
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Google LLC (GSoC 2025)
Co-authored-by: Kushagra Srivastava <kushagra1403@gmail.com>
Differential Revision:  https://reviews.freebsd.org/D53905

It has not been installed since commit cdc37953165c ("In preparation for
the removal of the roff toolchain, disconnect the") and turned up in
a search for outdated MALLOC_OPTIONS settings.

The rendered paper is available at
https://papers.freebsd.org/1998/phk-malloc

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287357
Reviewed by:    bapt
Event:          Kitchener-Waterloo Hackathon 202506
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D50908

Some time ago, the boot loader stopped polling for a key press during
the kernel and module loading prior to the transition to lua. Inspection
of the code shows the polling is no longer there. Document the change.

Sponsored by:           Netflix

Realtek changed how it styled its name 25 or so years ago, but the old
style persisted in many places. These products use the new styling in
their datasheets.

Signed-off-by: ykla yklaxds@gmail.com
Sponsored by: Chinese FreeBSD Community
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1901

umass(4), while much improved, still sometimes need quirks. Add a
pointer to usb_quirk(4) and usbconfig(8).

Sponsored by:           Netflix

Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1903

Add cross references to relevant stdbit man pages

Approved by:    markj (mentor)
MFC after:      1 month
Differential Revision: https://reviews.freebsd.org/D53661

Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>

Reviewed by:    markj
MFC after:      1 week
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1907

mse(4) was removed long ago.

MFC after:      1 month

Signed-off-by:        polyduekes-git <polyduekes@proton.me>
Reviewed by:    cperciva, emaste, ziaee
Closes:         https://github.com/freebsd/freebsd-src/pull/1913

The table is not playing nicely with
https://man.freebsd.org/freebsd-base

MFC after:              3 days
Reviewed by:            pauamma@gundo.com
Differential Revision:  https://reviews.freebsd.org/D54036

f_copy controls whether and how a knote is inherited by the child
process.

Sponsored by:           Netflix
Reviewed by:            kib
Differential Revision:  https://reviews.freebsd.org/D53845

Fixes:                https://cgit.freebsd.org/src/commit/?id=1f4442f71fa3 (be explicit that -p and -P are sc(4) only)
MFC after:      3 days
Reviewed by:    ziaee
Differential Revision:  https://reviews.freebsd.org/D53878

MFC after:    3 days
Reviewed by:    ziaee, emaste
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D54065

With the reimplementation in C of certctl, the environment variable
previously known as CERTDESTDIR was renamed to TRUSTDESTDIR for
consistency.

Although the previous variable is still valid, prefer the new one, as it
is described in the manual page, while the old one is not.

Reviewed by:    des
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D54044

MFC after:    1 week

Further explain that trim(8) is not for trimming free blocks
in populated file systems/ZFS pools, as people still take it wrong sometimes.

MFc after:      1 week

Grammar fix after previous commit.

MFC after:      1 week
X-MFC-with:     dbc4a1c69191909a7210cad6da46b755557d0d34

Reported by:  ziaee

+ Adjust document description matching another terabit driver
+ Add BCM576XX family to DESCRIPTION, switch to XX notation
+ Add some model names, additional models, and improvements to HARDWARE

MFC after:              3 days
Reviewed by:            sumit.saxena_broadcom.com (previous)
Differential Revision:  https://reviews.freebsd.org/D54028

Differential Revision:        https://reviews.freebsd.org/D54195

Reviewed by:  emaste, imp
Differential Revision:  https://reviews.freebsd.org/D54197

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291649
Fixes: https://cgit.freebsd.org/src/commit/?id=905571c03119 ("Remove copyright strings printed at login time via login(1) or sshd(8).")

If ath_tx_tag_crypto() returns an error, then ath_tx_normal_setup()
should consume the mbuf and return an error, so the caller knows to
free the ath_buf.  But it wasn't.

This fixes issues I've seen locally where a an AP VAP constantly hits
error conditions (due to other RF/PHY/MAC chipset issues which I haven't
yet figured out) and encryption fails because the station goes away
whilst something's being queued.

Locally tested:

* AR9380, AP mode (2G HT20, 5G HT20, 5G HT40)

Sponsored by: Rubicon Communications, LLC ("Netgate")

devd: Remove SND package

This was done by accident, build snd.conf always.

Reported by:    ivy
Fixes:          https://cgit.freebsd.org/src/commit/?id=2ffaca551eaf ("snd_hda: Implement automatic redirection between associations")
Sponsored by:   The FreeBSD Foundation
MFC after:      1 day

arm64/vmm: Clear all pmc fields

When clearing pmcntenclr_el0, pmintenclr_el1, and pmovsclr_el0 clear
all bits as new fields may be added in the upper 32-bits.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52801

arm64/vmm: Save more PMU registers

These were missed in the initial vmm.ko change.

While here keep the order the same in all locations we handle these.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52802

arm64/vmm: Save dbgclaimset_el1

It may be used by the guest.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52803

To be consistent within the register prefix all fields with MDCR_EL2_.

Reviewed by:    emaste
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52804

Move the MDCR_EL2 macros into the correct alphabetical location.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52805

These are features we don't support or advertise to the guest so can
safely be trapped.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52806

Keeping cumulative MCA statistics in the kernel provides a way for
users to get an accurate count of various kinds of errors reported
by the CPU.

After ca8929d2a3e9b9df31d2e487377f99d7c39aa01d, it is possible that
the kernel will drop the record of some MCA interrupts. Moreover, this
provides a cheaper interface to obtain statistics if that is the only
reason a user is processing MCA logs.

Reviewed by:    markj
Sponsored by:   Netflix
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D52709

iwx: add some missed beacon debugging

I'm seeing random disconnects in iwx without any useful information
as to why.  I'll start by adding missed beacon debugging here; hopefully
they're generally useful.

Differential Revision:   https://reviews.freebsd.org/D52524
Reviewed by:    bz

iwx: add some lock assertions in the TX start path

The locking paths into these routines LOOK correct, but I figured
it'd be good to at least enforce we're not doing concurrent entry
into iwx_start() / iwx_tx() without the lock held.

Differential Revision:  https://reviews.freebsd.org/D52655
Reviewed by:    thj

iwx: don't log VHT rate lookups in iwx_tx_fill_cmd() for data frames

iwx is now logging a lot of stuff to the kernel when associated at VHT
rates.  It's my fault; the replacement tx rate APIs print out a warning
when you're handing the legacy rate /HT rate APIs a VHT rate.

However all of the supported chipsets in iwx will be pushing the
rate control entirely into firmware.  We don't need to do per-frame
TX rate control like in previous chips.

So for now, just put in an if (rate == VHT) into the path and
a TODO comment.  A few lines later the function will just skip the
rate assignment stuff for data frames, thus saving us the logging.
The other paths (control traffic, multicast traffic) uses legacy
rates / HT rates by default and won't trigger a warning log.

Yes, iwx_tx_fill_cmd() really does deserve a rate control logic
rewrite, but I want to fix this particular issue first.

Locally tested:

* AX210, STA mode, HT and VHT associations

Differential Revision:  https://reviews.freebsd.org/D52766
Reviewed by:    thj

iwx: rewrite iwx_rs_update() to be VHT aware, refactor it a bit

The current iwx_rs_update() code doesn't handle setting VHT rates
at all.

So:

* write a routine - iwx_rs_update_node_txrate() - which will update
  the given node txrate info with the given notification
* .. which is based on the print_ratenflags() logic and decoding
* migrate iwx_rs_update() to use this routine, only on the STA BSS node.

This only handles decoding the version 2 rate_n_flags format response -
same as print_ratenflags() - so print if someone somehow sees a version
1 response.

It's shown a few things that deserve some later follow-up work:

* I really should have net80211 APIs that operate on the txrate struct
  itself, not on the ieee80211_node, but I'll use what I have.
  Changing it later is easy.

* the current net80211 txrate API doesn't include channel width,
  LDPC/STBC and such.  I didn't need it for the earlier tx rate
  representation migration, but it would be nice to add it.
  (The reason is that those choices are currently made in the drivers
  using rate control, rather than the rate control module, which is
  again what the older code did as well.)

  This means that the displayed rate isn't EXACTLY what the NIC has
  chosen - eg the NIC could quite happily decide to transmit a 20MHz
  or 40MHz frame to an 80MHz STA if that actually works out better.
  So just add TODOs for those.

Locally tested:

* AX210, STA mode

Differential Revision:  https://reviews.freebsd.org/D52767
Reviewed by:    thj

iwx: clean up debugging around key add/set; comments on delete

* Add IWN_DEBUG_KEYMGMT as a debug flag
* Convert DPRINTF(()) in key add/set to IWN_DPRINTF()
* printf() -> net80211_vap_printf()
* add braces around return value

Differential Revision:  https://reviews.freebsd.org/D53703
Reviewed by:    thj

iwx: fix and clean up suspend/resume path

I noticed a couple of things were happening:

* during suspend, I'd get a timeout in the NIC lock path (which
  sets a bit on the NIC to say that the host wants to talk to it);
* resume wouldn't come back - scan commands would fail, and you'd have
  to reinit the NIC again for it to work.

The thing is:

* the suspend path should already shut down the NIC by shutting down all
  the VAPs (and the last VAP should call ic_parent to bring it down), and
* the resume path should already bring up the NIC by bringing up each VAP,
  and the first VAP to be brought up calls ic_parent to bring it up.

So instead, I've shuffled around the code to just double check the
hardware state is consistent /before/ ieee80211_suspend_all() and
ieee80211_resume_all() is called.

This both fixes the errant hardware timeout during suspend, and it
fixes resume to work.

Locally tested:

* AX210, STA mode, both hardware ACPI suspend/resume and devctl suspend
  and devctl resume

Differential Revision:  https://reviews.freebsd.org/D53721
Reviewed by:    thj

iwx: clean up TX AMPDU session establishment and checking

* Send a TX A-MPDU exchange successfully; we were allocating the
  A-MPDU TX queue but returning 0 to net80211 was telling it
  to not establish the TX A-MPDU session and none of the BA session
  tracking stuff would work.

* Clean up the TX A-MPDU queue lookup in the transmit path - only
  QoS data frames are allowed, not qos null-data, cf/ack/etc frames;
  only send them if the A-MPDU session is established.

* Tell net80211 that we've established the TX A-MPDU session once
  the firmware queue has been created.

* Check to make sure we're not double (or more) creating TX AMDPU
  sessions - only allocate a qid if we're not doing A-MPDU yet.

* Delete IWX_FLAG_A-MPDUTX - it's now being properly tracked!

Locally tested:

* AX210, STA mode - gets 50/50mbit on 2GHz HT20, and 100/100mbit on
  5GHz VHT/40.

Differential Revision:  https://reviews.freebsd.org/D53725
Reviewed by:    thj

MediaTek mt76 WiFi cards are advertising FLR support but after issuing
a FLR the chipset is gone.  Add a quirk so we can disable FLR.  The
current reset code will automatically fall back to a power reset.

This makes the card show up under bhyve where before it would just not
be discovered at all. That should make wifibox work for it and will help
development for a LinuxKPI based mt76 driver as found in framework laptops
as no dedicated machine and constant reboots are needed anymore.
We will likely need to add more PCI vendor/device IDs once we can test
the other device IDs.

Event:                  EuroBSDCon Devsummit 2025
After a lot of help from: jhb
Really implemented by:  jhb (I just typed and tested)
GH issue:               github.com/pgj/freebsd-wifibox/issues/73
MFC after:              3 days
Reviewed by:            imp, emaste
Differential Revision: https://reviews.freebsd.org/D52728

Just like vmxnet3_intr_disable_all, iflib may invoke this routine
before vmxnet3_attach_post() has run, which is before the top-level
shared data area is initialized and the device made aware of it.

MFC after:      1 week
Sponsored by:   Dell Inc.

swi_remove expects a void *, but we were passing void **.

MFC after:      1 week
Sponsored by:   Dell Inc.

Currently, the CMCI handler checks the cold variable to determine
whether it can schedule a task. The task queue is setup as part of the
mca_startup() function, which is run well after the configure_final()
function sets the cold variable to 0. Therefore, if an MCA arrives
in the window between configure_final() and mca_startup() running,
the code could try to schedule a task on an unintitalized task queue.

Close the race by specifically checking whether the mca_startup()
function has run.

Reviewed by:    markj
MFC after:      1 week
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D12276

When processing recoverable MCA events in a hardware interrupt context,
defer logging the messages to a task queue.

Reviewed by:    markj
MFC after:      2 weeks
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D12275

Reported by:  avg
Reviewed by:    avg, imp
Differential Revision:  https://reviews.freebsd.org/D52888

If the MSI-X table and/or PBA live in separate BAR(s) and those BAR(s)
cannot be allocated, fall back to using MSI or INTx instead of failing
attach.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289748
Reported by:    Vitalij Satanivskij <satan@Ukr.net>
Reviewed by:    avg, imp
Differential Revision:  https://reviews.freebsd.org/D52889

Sponsored by: Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52930

This is enough to boot FreeBSD again.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290044
Reported by:    Siva Mahadevan <me@svmhdvn.name>
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52931

The MCA spin lock is acquired in the hardware interrupt context to
record MCA messages. It is also acquired by a task handler to emit
those messages.

Reduce the amount of time the task handler holds the lock to reduce
the maximum amount of time the hardware interrupt handler may need to
spin on the lock.

Reviewed by:    glebius, markj
MFC after:      2 weeks
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D52938

Reviewed by:  glebius
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D52942

* Rename delta_t to avoid misleading simplistic syntax highlighters
* Simplify the increment calculation

Sponsored by:   Klara, Inc.
Sponsored by:   NetApp, Inc.
Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D52973

Always print the first 50 messages of each type. After that, optionally
rate-limit the messages. This provides a way to limit the overhead of
processing excessive messages without suppressing the first few of any
type.

As part of this change, we are switching from direct printf() calls to
collecting data in an sbuf(9). In POLLED mode (run from a task queue),
we dynamically allocate the buffer. In the other modes (which are
likely called from a hardware interrupt), we use a buffer allocated
from the BSS segment and guarded by a lock. In normal operation,
most calls to mca_log() should come from the POLLED mode, so there
should be no contention for the new lock. If there is an interrupt
storm which exceeds the capacity of the free list, there will be new
contention for this lock; however, overall lock contention should
still be lower than it was prior to e770e32aa3a0, when the mca_lock
was almost always held for the entirety of the mca_log() call.

This commit is partly based on a patch proposed by Loic Prylli
<lprylli@netflix.com>.

Reviewed by:    markj, glebius (previous version)
MFC after:      2 weeks
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D52946

Currently, all MCA messages are logged to the console. However, this
can have performance implications which can turn a storm of correctable
errors into a disruptive event.

Provide an option to direct non-fatal messages to syslog. Note that
we will always log to the console for fatal errors.

Reviewed by:    markj
MFC after:      2 weeks
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D12278

Older versions of the standard were limited to 16, but the actual limit
is 64. Bump the limit to 64. This should be a #define, but there's no
good standardized name, so I'm punting on that. All the places that use
it, apart from the byte swapping code, do the right thing and use the
nlbaf field to limit what to access.

Sponsored by:           Netflix

This is part 2 of the support for the new Intel Ethernet E610 family of devices.

Intel E610 Ethernet Controller devices feature a debug dump capability
that allows you to capture runtime register values directly from the
hardware, with assistance from the firmware. These registers are
organized into clusters based on their function, enabling targeted
debugging. This information is consolidated into a single dump file,
facilitating the debugging of complex issues encountered in the field.
The debug dump provides a snapshot of the device's current hardware
configuration, including switch tables, transmit scheduler tables, and
other relevant data. It captures the state of specified clusters and
serves as a stateless snapshot of the entire device.

This update introduces ioctl and sysctl support for the debug dump feature.

Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com
Co-developed-by: Krzysztof Galazka krzysztof.galazka@intel.com

Approved by:    kbowling (mentor), erj (mentor)
Tested by:      gowtham.kumar.ks_intel.com
Sponsored by:   Intel Corporation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D50934

Add device IDs and branding strings for E835 adapters.
This is a follow up for E830 adapters with Security Protocol
and Data Model (SPDM) support and RDMA support available
on 100 and 200Gbps links.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Approved by:    kbowling (mentor), erj (mentor)
Sponsored by:   Intel Corporation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D52782

vmm: Unify implementations of vcpu_cleanup()

Different vmm implementations were freeing the per-vCPU structure in
different places.  Make the implementations consistent.  No functional
change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53010

vmm: Make vmmops declarations more consistent

- On amd64, make vmmops_* functions globally visible, as some will be
  called from machine-independent code in the future.
- On arm64 and riscv, move declarations to vmm.h, since they're supposed
  to be generic across different VMM backends (only amd64 has more than
  one backend).
- Make the declaration macros consistent with each other.
- On amd64, make the function typedef names consistent with the
  corresponding ifunc names.

No functional change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53011

vmm: Move the guest vmspace into the generic vm_mem structure

This further consolidates handling of guest memory into MI code in
sys/dev/vmm.

No functional change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53012

vmm: Remove some unused macros

No functional change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53013

vmm: Improve register get/set handling a bit

On non-amd64 platforms, check for negative register indices.  This isn't
required today since we match against individual register indices, but
we might as well check it.  On amd64, add a comment explaining why we
permit negative register indices.

Use mallocarray() for allocating register arrays in the ioctl layer.

No functional change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53143

vmm: Add PRIV_DRIVER checks for passthru ioctls

In preparation for allowing non-root users to create and access bhyve
VMs, add privilege checks for ioctls which operate on passthru devices.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53144

vmm: Move local variables into ioctl handlers

Make the ioctl handlers easy to read by moving local variables into
per-ioctl blocks.  No functional change intended.

Reviewed by:    corvink, emaste
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53145

nvme: use nitems() rather than hard coded value

Suggested by: jhb@
Sponsored by: Netflix

nvme: Use unsigned

CI complains about signed/unsigned comparisons, but normal build does
not. Fix this by transitioning to unsigned and using a loop-scoped
variable.

Fixes: https://cgit.freebsd.org/src/commit/?id=d714732b598b
Sponsored by: Netflix

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

The only possible return value of function xen_intr_init() is 0. Make
it return void to match the prototype of SYSINIT.

MFC after:      1 week

The only possible return value of function module_info_init() is 0. Make
it return void to match the prototype of SYSINIT.

MFC after:      1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

Reported by:  GCC -Wmaybe-uninitialized, -Wtautological-compare
Reviewed by:    kp
Differential Revision:  https://reviews.freebsd.org/D45919

Port the BP hardening and SSBD workaround from cpu_quirks to the
CPU_FEAT framework.

Reviewed by:    andrew
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53112

This change reapplies the improvements from commit 89e7335 and adds
additional fixes and code optimizations on top of it.

The ixl driver supports up to 128 multicast filters in hardware. When this
limit is exceeded, the driver should enable multicast promiscuous mode.
When the count drops below 128, it should disable promiscuous mode and
restore individual filters.

The driver previously had problems that could corrupt multicast filters list.
The main issue was that ixl_dis_multi_promisc() would attempt to disable
promiscuous mode without checking if it was actually enabled, potentially
corrupting existing filters. There was also no state tracking across driver
functions, leading to redundant operations.

This change adds an IXL_FLAGS_MC_PROMISC flag to track the multicast
promiscuous mode state. The flag is set when enabling promiscuous mode and
cleared when disabling it. Early return checks prevent redundant operations
when the mode is already in the desired state, avoiding filter corruption
and unnecessary hardware calls.

Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283820
Approved by:    kbowling (mentor)
Tested by:      gowtham.kumar.ks_intel.com
MFC after:      2 weeks
Sponsored by:   Intel Corporation
Differential Revision:  https://reviews.freebsd.org/D52549

We bump the object reference count prior to mapping it into the kernel
map, at which point the vm_map_entry owns the reference.  Then, if
vm_map_wire() fails, vm_map_remove() will release the reference, so we
should avoid decrementing it in the error path.

Reported by:    Ilja van Sprundel <ivansprundel@ioactive.com>
Reviewed by:    vmaffione
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53066

vm_smp_rendezvous() invokes a callback on all vCPUs, blocking the
initiator until all vCPUs have responded.  vcpu_lock_all() blocks each
vCPU by waiting for it to go idle and setting the vCPU state to frozen.
These two operations can deadlock on each other, particularly when
booting a Windows guest, when vcpu_lock_all() blocks waiting for a
rendezvous initiator, and the initiator is blocked waiting for the vCPU
thread which called vcpu_lock_all() to invoke the rendezvous callback.

Implement vcpu_lock_all() in a way that avoids deadlocks with
vm_smp_rendezvous().  In particular, when traversing vCPUs, invoke the
rendezvous callback on the vCPU's behalf to help the initiator finish.
We can only safely do so when the vCPU is IDLE or we have already locked
it, otherwise we may be racing with the target vCPU thread.  Thus:
- Use an exclusive lock to serialize vcpu_lock_all() callers, which lets
  us lock vCPUs out of order without fear of deadlock with parallel
  vcpu_lock_all() callers.
- If a rendezvous is pending, lock all idle vCPUs and invoke the
  callback on their behalf.  If the vcpu_lock_all() caller is itself a
  vCPU thread, this will handle that thread.
- Block waiting for all non-idle vCPUs to idle, or until one of them
  initiates a rendezvous, in which case we go back and invoke callbacks
  on behalf of already-locked vCPUs.

Note that on !amd64 no changes are needed since there is no rendezvous
mechanism, so there is a separate vcpu_set_state_all() for them based on
the previous vcpu_lock_all().  These will be merged together once vcpu
state handling is consolidated into sys/dev/vmm.

Reviewed by:    corvink (previous version)
MFC after:      3 weeks
Differential Revision:  https://reviews.freebsd.org/D52968

Work around an issue when HotPlug is enabled where pcib3 and pcib5
continuously report the following:

pcib3: HotPlug interrupt: 0x30
pcib3: Command Completed
pcib3: HotPlug interrupt: 0x30
pcib3: Command Completed
...

As a workaround disable HotPlug on the N1SDP as it's unlikely anyone
will depend on it.

Reviewed by:    br
Fixes:  https://cgit.freebsd.org/src/commit/?id=1f5c50a86173 ("pci_host_generic:Add pcib_request_feature on ACPI")
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53134

As found on RTEMS the argument to if_foreach_llmaddr() was wrong
causing crashes.

Fixes:          https://cgit.freebsd.org/src/commit/?id=51e80820552e0
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290314
MFC after:      3 days

Remove the single 8822CU entry in all three places.
It seems the only entry referencing a USB device.  The same device is
listed with the 8822CE devices.

MFC after:      3 days
Reviewed by:    wulf
Differential Revision: https://reviews.freebsd.org/D52324

The pt hwt(4) backend uses NMIs to receive updates about the latest t
racing buffer offsets from the tracing hardware. However, it uses
taskqueue(9) to schedule the bottom-half handler. This can lead to
a panic since the taskqueue(9) code isn't aware it's being called
from an NMI context and uses the regular scheduling interfaces.

Fix this by scheduling the bottom-half handler using swi(9) and the
SWI_FROMNMI flag.

Fixes:  https://cgit.freebsd.org/src/commit/?id=310162ea218a
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52491

gcc complains about accessing the byte as ads->common.bytes[3] as that
field is declared as being one byte.

Reviewed by:    mav
Differential Revision:  https://reviews.freebsd.org/D53152

Reviewed by:  markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Differential revision:  https://reviews.freebsd.org/D52045

Reviewed by:  markj
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53158

Reviewed by:  markj
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53158

Reviewed by:  markj
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53158

Reviewed by:  markj
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53158

Reviewed by:  markj
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53158

Reviewed by:  markj
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53158

When interrupt remapping (IR) is enabled, the device table entry
(DTE) for a given device will likely be initialized by
amdiommu_ir_find() during MSI configuration.  This function directly
calls amdiommu_get_ctx_for_dev() with id_mapped=false, which means that
any attempt to disable DMA remapping for the device (e.g. by setting
hw.busdma.pciD.B.S.F='bounce' in the loader tunables) will effectively
be ignored as the paging mode field in the DTE will not be set to
0 as required for identity mapping.  This will ultimately produce
an unusable device, because busdma will later observe the bounce
configuration through iommu_instantiate_ctx() and will employ the
non-translated 'bounce' busdma methods for the device, while the DTE
remains configured to enable translation.

Fix this by tweaking iommu_instantiate_ctx() to always return the
relevant per-device context object even if translation is disabled,
and adopt it in amdiommu_ir_find() instead of directly calling
amdiommu_get_ctx_for_dev().

Reviewed by:    kib
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53209

These are known to work if loaded manually by loader(8) (for VF2 at
least). If nothing else, it is useful to provide a DTB closely tied to
the kernel version.

MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D53117

These are known to work if loaded manually by loader(8) (for the Nezha
board at least). If nothing else, it is useful to provide a DTB closely
tied to the kernel version.

MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D53118

modules: enable allwinner kmods on riscv

While here, standardize the place they are enabled in the Makefile. For
armv7 the module subdirectory was added explicitly in the config file,
but this is not idiomatic.

MFC after:      3 days
Sponsored by:   The FreeBSD Foundation

modules/allwinner: add nvmem_if.h to SRCS

Ensure the header is generated; it is a dependency for these drivers.
This fixes standalone module builds and riscv LINT.

Reported by:    zlei
Sponsored by:   The FreeBSD Foundation
Fixes:  https://cgit.freebsd.org/src/commit/?id=5522519731b7 ("modules: enable allwinner kmods on riscv")

Add the subdirectory in the Makefile, not the config.

No functional change intended.

MFC after:      3 days
Sponsored by:   The FreeBSD Foundation

Now under sys/contrib/device-tree.

Sponsored by: The FreeBSD Foundation
MFC after:      4 days
Reviewed by:    emaste, ziaee
Differential Revision:  https://reviews.freebsd.org/D53237

It seems like _QUAD_LOWWORD was incorrectly expanded into 1,
which is correct for big endian but not little endian.  This
means we always grab the padding word for the syscall number,
which is usually 0, causing SIGSYS to be delivered to the caller.
Reintroduce _QUAD_LOWWORD to fix the syscall.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290411
MFC after:      1 week
Discussed with: jrtc27
Reviewed by:    cognet, emaste
Approved by:    markj (mentor)
Fixes:          https://cgit.freebsd.org/src/commit/?id=8c9c3144ccfa3061879b8cec015ee7d1010e4766
Differential Revision:  https://reviews.freebsd.org/D53250

We have provided implementations for hard float of these for
a while now.  Add them to the header to make things official.
This is required for a bunch of legacy programs in ports.

Approved by:    markj (mentor)
MFC after:      1 week
Differential Revision: https://reviews.freebsd.org/D53156

Add support for the DIOCGIDENT ioctl to both nvme controller device
nodes and namespace device nodes.

This information was already available via the nda(4) device node.
However, mapping /dev/nvmeX to /dev/ndaY device nodes is not
straightforward, so it's better to get it directly from the /dev/nvme
device node.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290259
MFC after:      2 weeks
Sponsored by:   ConnectWise
Submitted by:   imp (mostly)
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1875

fvp-base-revc.dtb works with the kernel now interrupt-maps are
supported in more cases.

Reviewed by:    mhorne
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D51258

Reviewed by:  andrew
Sponsored by:   Arm Ltd

Reviewed by: cem
Fixes: https://cgit.freebsd.org/src/commit/?id=1492c8c0d qcom_rnd: add initial qualcomm prng driver.
Fixes: https://cgit.freebsd.org/src/commit/?id=9eecef052 Add an Armv8 rndr random number provider
Fixes: https://cgit.freebsd.org/src/commit/?id=b2f8b2dc8 sys: Add an SMCCC Random Number Generator driver
Differential Revision:  https://reviews.freebsd.org/D53292

Reviewed by: khng
Differential Revision:  https://reviews.freebsd.org/D53309

Suggested by: arrowd
Sponsored by:   The FreeBSD Foundation
MFC after:      3 days

This driver was in fact not removed prior to FreeBSD 15.0.

Sponsored by:   The FreeBSD Foundation

Submitted by: Austin Shafer <ashafer@nvidia.com>
Reviewed by:    imp, jhb
Fixes:  https://cgit.freebsd.org/src/commit/?id=5c039412a2823
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D53336

Virtual Functions have access to a limited number of registers,
and their bus space size is lower. Use KASSERT to detect out-of-bounds
access and eliminate them to avoid kernel panics in production
environment.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Reviewed by:    jmg
Tested by:      mateusz.moga_intel.com
Approved by:    kbowling (mentor), erj (mentor)
Sponsored by:   Intel Corporation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D52976

Otherwise we go out of bounds and keep incrementing endlessly.

Sponsored by:   The FreeBSD Foundation
MFC after:      4 days
Differential Revision:  https://reviews.freebsd.org/D53337

Reviewed by:  imp
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53321

arm64: Include armreg.h in db_disasm.c

It is needed for INSN_SIZE. Include it directly rather than depending
on header pollution.

Reviewed by:    imp
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53322

arm64: Remove armreg.h from db_machdep.h

There is nothing in this file that needs armreg.h

Reviewed by:    imp
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53323

arm64: Split out accessing special registers

We shouldn't need to include armreg.h just to access special registers
that are not defined in this file. Split out the parts that should be
common with arm64.h and hypervisor.h.

Reviewed by:    emaste
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53324

arm64: Use _armreg.h in cpu.h

We only needed armreg.h for the *_SPECIALREG macros. Use the new
_armreg.h directly.

Reviewed by:    emaste
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53325

Move ofw_cpu to BUS_PASS_CPU + BUS_PASS_ORDER_MIDDLE so it can be used
by other devices.

Reviewed by:    jhibbits
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53328

This allows it to be referenced by other devices.

Reviewed by:    jhibbits
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53329

Add subdevice ID and branding string for E835-XXV-4
adapter.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Approved by:    kbowling (mentor), erj (mentor)
Sponsored by:   Intel Corporation
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53319

Once an interrupt source is registered it's never deregistered.
However, when an MSI is released the pointer for it becomes NULLed out,
resulting in a NULL pointer dereference when attempting to disable the
now-released MSI source.  Add NULL check to avoid this.

Reviewed by:    kib
Sponsored by:   Juniper Networks, Inc.
Differential Revision:  https://reviews.freebsd.org/D51624

This works on older arm64 platforms, but may not work with arm64 devices
using GICv3, due to a quirk in the GICv3, where some registers are
write-once.

Most of the kexec reboot work on arm64 can be done entirely in C code,
by disabling the MMU, as the kernel is carved out of the vm_phys_segs
array, so cannot be overwritten.

Reviewed by:    andrew
Sponsored by:   Juniper Networks, Inc.
Differential Revision:  https://reviews.freebsd.org/D51621

The biggest difference between this and arm64 kexec is that we can't
disable the MMU for amd64, we have to instead create a new "safe" page
table that the trampoline and "child" kernel can use.  This requires a
lot more work to create identity mappings, etc.

Reviewed by:    kib
Sponsored by:   Juniper Networks, Inc.
Differential Revision:  https://reviews.freebsd.org/D51623

kexec hasn't been ported to these architectures, yet, so appease the
build with dummy headers.

Sponsored by:   Juniper Networks, Inc.
Differential Revision:  https://reviews.freebsd.org/D51625

Otherwise we allow to trigger an MPASS() by a userland sysctl, e.g.
hw.acpi.power_button_state=NONE.  This does not bring fully compatibility,
where as before 97d152698f483 setting to 'NONE' actually meant disabling
any action on a power or sleep button.  Now sysctl will fail, but with
this change it won't at least panic.

Aymeric may come with a better fix.

Fixes:  https://cgit.freebsd.org/src/commit/?id=97d152698f4831db5a94d55c15233330c188feda

- Add a compatible string;
- Fix build.

Tested on Codasip X730 64-bit RISC-V CHERI Application CPU using
onboard nvme(4) device.

Differential Revision:  https://reviews.freebsd.org/D53295

Remove twice included but unneeded explicit sys/param.h.  Sort.

Sponsored by:   The FreeBSD Foundation
MFC after:      3 days

In vm_mmap_memseg(), use vm_map_insert() instead of vm_map_find().
Existing callers expect to map the GPA that they passed, whereas
vm_map_find() merely treats the GPA as a hint.  Also check for overflow
and remove a test for first < 0 since "first" is unsigned.

In vmm_mmio_alloc(), return an error number instead of an object
pointer, since the sole caller doesn't need the pointer.  As in
vm_mmap_memseg(), use vm_map_insert() instead of vm_map_find() and
validate parameters.  This function is not directly reachable via
ioctl(), but we ought to be careful anyway.

Reviewed by:    corvink, kib
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53246

The storage subsystem really wants one of a very small number of I/O
errors. And since we started to do this I/O, EIO is the right error to
return. Other errors may get different and weirder treatment up the
stack, or even converted to just EIO. So remove this TODO comment that's
been there since the initial nvme driver commit. It wouldn't be helpful
to do this, and could likely hurt.

Sponsored by:           Netflix

Use bus_generic_detach instead of bus_detach_children so the children
actually get deleted.

Reviewed by:    jhb
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52305

Implement bus_child_deleted and attach the gpio_aei dev to it's ACPI
handle.

Reviewed by:    wulf
Differential Revision:  https://reviews.freebsd.org/D51585

When nhi fails to attach on one of my systems (X1 Carbon 6th gen), an
interrupt races with the teardown code such that the rings have been
freed by nhi_detach() before an interrupt triggers.  At the time of
the crash, the thread invoking nhi_attach() is blocked in
bus_teardown_intr() from nhi_pci_free() waiting for the interrupt
thread to finish executing the handler.

To fix, don't just disable the interrupts in nhi_detach(), but
actually tear the handlers down and disable MSI-X before freeing the
rings.

Reviewed by:    obiwac
Differential Revision:  https://reviews.freebsd.org/D53201

* Create macros for error, info, warn, trace / debug
* Migrate existing printf() logging to use the above macros
* Add a sysctl knob to control it at runtime

This is based on work done in https://reviews.freebsd.org/D37878 .

Submitted by: Marco Devesas Campos <devesas.campos@gmail.com>
Differential Revision:  https://reviews.freebsd.org/D53371

Spotted while examing this driver.  Remove some end of line spaces/tabs.
Replace some spaces which should instead be tabs.

Reviewed by:    jhibbits
MFC after:      2 weeks

intr/powerpc: create openpic_class kobj

Using kobj allows implementing most PIC functions merely by inheriting
from the parent class.  As there are multiple OpenPIC implementations,
this ensures all common hooks go through by default.

Note, this adds the suspend/resume functions to other PICs.  This should
be harmless as suspend/resume isn't working on the devices anyway.

Reviewed by:    jhibbits
MFC after:      2 weeks

powerpc: Move openpic_intr, since it's hidden now

Last minute change by me (diff reduction), that I didn't build.  This
was in the original commit.

Fixes:          https://cgit.freebsd.org/src/commit/?id=8fb1789612 ("intr/powerpc: create openpic_class kobj")
MFC after:      2 weeks
X-MFC-with:     8fb1789612

The NVMe spec allows the Table BIR (TBIR) and PBA DIR (PBIR) to
be 0, 4, or 5. The existing NVMe driver basically only has support
for 4, perhaps under the assumption that BAR4 is 64-bit and also
occupies BAR5.

This change adds support for BAR5, covering the case where BAR4
and BAR5 might both be present and 32-bit, where the Table BIR
might be 4 and the PBA BIR might be 5, or vice versa.

The NVMe spec (in the SR-IOV section) also permits VFs to use BIR=2,
so I haven't added stricter checks on which BIR will be permitted
by the driver.

This enables FreeBSD on Google Compute Engine C4 Machines.

MFC after:              3 days
Reviewed by:            imp
Sponsored by:           Google
Co-authored-by:         Matt Delco <delco@google.com>
Signed-off-by:          Jasper Tran O'Leary <jtranoleary@google.com>
Differential Revision:  https://reviews.freebsd.org/D53140

The contents of the memory is an output, but the pointer to that memory
is an input. This was correct in the original version of D45697, but
when adding appropriate clobbers, the pointer operand was incorrectly
switched to an output rather than left an input for fpe_store.

Reviewed by:    jrtc27
Obtained from:  CheriBSD
Fixes:          https://cgit.freebsd.org/src/commit/?id=44d4ee7f3dad ("riscv: add FPE code.")
MFC after:      1 day
Sponsored by:   AFRL, DARPA
Differential Revision:  https://reviews.freebsd.org/D53441

aplic_max_cpu_count() just returns the VM's max vCPU count, and
vm_alloc_vcpu() already checks that.  Just remove this check so that
it's easier to merge vm_alloc_vcpu() into MI code.

If the APLIC really does require us to lower the limit, we should
instead adjust vm->maxcpu in vm_create().

No functional change intended.

Reviewed by:    br
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53496

A regression in the u-boot-provided JH7110 device tree leaves the uart
incorrectly configured.

The issue arises when a baud rate is specified ('current-speed'
property), but the rclk value is not ('clock-frequency'). Previous
releases, e.g. v2025.04, provided both.

The alternative way to retrieve this value is to query the parent clock,
but our clk framework is not available during early console probing and
configuration.

In this instance, we end up defaulting to DEFAULT_RCLK in ns8250_init(),
which is the wrong value. The relevant uart class (uart_snps) should
provide a default rclk in its definition, but it does not. Add a new
variant class with the correct default rclk of 24000000.

Finally, uart_cpu_fdt_probe() needs to be updated to actually query this
default value when it does not find a 'clock-frequency' property. This
was simply missing; the ACPI uart bus behaves identically, see
uart_acpi_probe().

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289978
Reported by:    rdunkle@smallcatbrain.com
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D53119

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290421
MFC After: 3 days

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290688
MFC After: 3 days

Ensure that the number of elements of random_source_descr[]
and fxrng_ent_char[] matches that of enum random_entropy_source.

Reviewed by:    cem
Differential Revision: https://reviews.freebsd.org/D53255

This driver is a subclass of the normal PCI bus driver that is
intended to be used for the logical child bus of a Thunderbolt PCI-PCI
bridge device.  To determine if a given PCI bus's parent is a TB
bridge, it examines the PCI device IDs of the parent pcibX device.
However, this only works for pcibX devices that are actual PCI-PCI
bridges and panics for PCI buses that are children of host bridges
such as the pci0 child of pcib0.

Probably this should not be reading device IDs (as that doesn't tell
you if the device driver for the PCI-PCI bridge is actually a TB
driver).  Instead, the TB PCI-PCI driver should be exporting a new
IVAR (with a globally unique number as we do for ACPI handles) that
returns the TB generation and the probe routine for this PCI bus
driver should be checking for that IVAR (the way acpi_pci.c checks for
the presence of an ACPI handle).

This fixes a panic on boot if tb.ko is loaded at boot time (which the
driver recommends for certain chipsets).

Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D53202

We can free the mask earlier, simplifying some error paths.  No
functional change intended.

Reviewed by:    corvink, jhb, emaste
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53418

vcpu_notify_event() previously took a boolean parameter which determines
whether the implementation should try to use a posted interrupt.  On
arm64 and riscv, the implementation of vcpu_notify_event() is otherwise
identical to that of amd64.

With the aim of deduplicating vcpu state management code, introduce a
separate amd64-only function which tries to use posted interrupts.  This
requires some duplication with vcpu_notify_event_locked(), but only a
little bit.

Then, fix up callers.  No functional change intended.

Reviewed by:    corvink, jhb
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53419

No functional change intended.

Reviewed by:    corvink, jhb, emaste
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53420

Move the vmm_initialized check out of vm_create() and into the legacy
sysctl handler.  If vmm_initialized is false, /dev/vmmctl will not be
available and so cannot be used to create VMs.

Introduce new MD vmm_modinit() and vmm_modcleanup() routines which
handle MD (de)initialization.

No functional change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53421

vm_create() is only called from one place.  Rather than having similar
checks everywhere, move them to vmmdev_create().

We can safely assume that the name is nul-terminated, the vmmctl ioctl
handler and the legacy sysctl handler ensure this.  So, don't bother
with strnlen().

Finally, make sure that the name buffers are the same size on all
platforms.  VM_MAX_NAMELEN is supposed to be the maximum, not including
the nul terminator.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53422

Reviewed by:  corvink, emaste
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53423

No functional change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53477

The access of vq->vq_ring.used->idx needs to be volatile-qualified,
otherwise the compiler may optimize virtqueue_poll() into an infinite
loop if there is no data available upon the first poll.

Prior to commit ad17789a8569 this wasn't a problem since an external
function call after each poll inhibited the optimization.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289930
MFC after:      3 days
Sponsored by:   Klara, Inc.
Fixes:          https://cgit.freebsd.org/src/commit/?id=ad17789a8569 ("virtio: Remove the unused poll method")

vm_alloc_vcpu() is called quite frequently, and we don't need to apply
the vgic limit unless we're actually allocating a vcpu structure for the
first time.

No functional change intended.

Reviewed by:    andrew
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53580

The documented properties [1] for card-detection are one of:
 - cd-gpios
 - non-removable
 - broken-cd

In cd_setup() we handle the first two, but not the latter, resulting in
a silently undetected card on an affected system.

To work around this, force cd_disabled when broken-cd is specified, so
that the card detect helper function gets to run. A more complete
solution would implement some kind of polling mechanism to detect the
card's presence or removal.

Some variants of the Allwinner D1, such as the Lichee Rv, specify this
property in the mmc0 device node.

[1] sys/contrib/device-tree/Bindings/mmc/mmc-controller.yaml

Reported by:    Haowu Ge <gehaowu@bitmoe.com>
Tested by:      Haowu Ge <gehaowu@bitmoe.com>
Reviewed by:    imp, manu, mmel
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D53546

Change tag preallocation to happen asynchronously when an interface is
brought up, so as to reduce boot times when preallocating tags.

- A new mlx5-tls-prealloc_wq is allocated when preallocation is
  desired, and started when an interface is opened

- The bulk of the prealloc code remains the same, except the
  allocations are now M_NOWAIT. M_NOWAIT is needed because, since the
  preallocation is done asynchronously, and since tag allocation is
  not instant, we could race with a real TLS session trying to
  allocate a tag. Note that in this case, we take allocation failure
  as a sign that we were unable to obtain the entire zone due to there
  being other consumers.  This was suggested by @markj as a way to
  keep things simple, after discussing why uma_zone_get_cur() didn't
  immediately report a fully allocated zone.  If this turns out to be
  problematic, we could use uma_zone_set_maxaction() to stop
  pre-allocations (also suggested by Mark)

Reviewed by: glebius, kib, markj
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D53570

safe(4): add gone_in 16.0

Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D53426

safe(4): fix api used

Fixes: https://cgit.freebsd.org/src/commit/?id=9b7d2cee

According to section 5.1.6.2.1 of version 1.3 of the virtio
specification, the driver MUST NOT set VIRTIO_NET_HDR_F_DATA_VALID in
the flags. So don't do that.

Reviewed by:            Timo Völker
MFC after:              3 days
Differential Revision:  https://reviews.freebsd.org/D53650

Transmit segment offloading depends on transmit checksum offloading.
Enforce that constraint. This also fixes a bug, since if_hwassist bits
are from the CSUM_ space, not from the IFCAP_ space.

PR:                     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290773
Reviewed by:            Timo Völker
Tested by:              lg@efficientip.com
MFC after:              3 days
Differential Revision:  https://reviews.freebsd.org/D53629

nvmf: Add a transport hook to limit the size of host data transfers

Smart NIC offload transports may have a cap on the size of the largest
data PDU that can be received.  Allow these transports to enforce a
cap on the size of an I/O request submitted by the nvmf(4) host.

NB: The controller is able to advertise a maximum-supported PDU size
during TCP negotiation, but there is no way in the protocol to
advertise a maximum size that the host can receive.

Sponsored by:   Chelsio Communications

nvmf: Honor any data transfer limit imposed by the transport

If the transport has a data transfer limit, restrict I/O transfers to
the largest multiple of MPS that fits within the limit.

Sponsored by:   Chelsio Communications

nvmf: Add a transport hook to limit the maximum command capsule size

NVMe controllers advertise the largest supported size of a command
capsule in the controller data (IOCCSZ).  Smart NIC offload transports
may have a cap on the size of the largest data PDU that can be
received.  These transports can implement this hook to limit the
advertised IOCCSZ to limit the in-capsule-data payload sent by remote
hosts.

Sponsored by:   Chelsio Communications

Sponsored by: Chelsio Communications

- Default to enabling all NVMe capabilities.  Currently, NVMe/TCP PDU
  offload is supported by T7 adapters.

- Fetch relevant parameters from the firmware if NVMe support is
  enabled.  A few parameters are shared with RDMA support, so the RDMA
  parameters section is now split into handling for parameters used by
  both vs parameters used only by RDMA.

Sponsored by:   Chelso Communications

NVMe/TCP offload depends on TOE similar to iSCSI and iWARP offloads.

Sponsored by:   Chelsio Communications

These work requests are largely similar to the same work requests for
iSCSI offload but use a newer tx_data work request structure.

This includes initial support for ISO where a large C2H_DATA or
H2C_DATA PDU is split into multiple PDUs on the wire.

Sponsored by:   Chelsio Communications

- Adds various per-queue counters similar to iSCSI PDU offload as well
  as a hook in the adapter softc for a reference to the NVMe/TCP softc.

- Instruct the firmware to include a DDP indicator in the status field
  for NVMe/TCP PDU completion messages.  This flag indicates if the
  payload data for a PDU has been received in the free list or if it
  was placed directly into a kernel I/O data buffer via DDP.

Sponsored by:   Chelsio Communications

Similar to iSCSI on T6+, additional DDP data might have been received
without a completion posted if a connection was closed in the middle
of a transfer.

Sponsored by:   Chelsio Communications

nvmf_che: NVMe-TCP offload support for Chelsio T7 adapters

This provides an alternative NVMe over TCP transport which uses PDU
offload for TOE connections on a T7.

Similar to iSCSI offload via cxgbei.ko, nvmf_che uses DDP when
possible to enable the NIC to DMA received data directly into I/O data
buffers (pages from a struct bio on the host side, pages from a CTL
I/O requests on the controller side) to avoid copying data on the host
CPU.  nvmf_che is also able to receive a stream of C2H or H2C PDUs for
a single data transfer when using DDP without processing the header of
each PDU.

Unlike cxgbei, nvmf_che aims to be mostly transparent to end users.
Notably, neither nvmecontrol or ctld have to be explicitly asked to
use an offload.  Instead, TCP queue pairs are claimed by this driver
whenever they are eligible (e.g., using TOE).

The main restriction of nvmf_che compared to the software TCP
transport is that Chelsio adapters have a restriction on the largest
PDU that can be sent and received.  When sending data, nvmf_che is
able to split large C2H or H2C data requests across multiple PDUs
without affecting nvmf(4) or nvmft(4).

To avoid overly large PDUs when using nvmf(4), nvmf_che reports a data
transfer limit that is honored by nvmf(4).  This ensures that the
remote controller's PDUs will never be too large (since the command
transfer size is limited to one PDU) and also ensures that nvmf(4)
will never to try to send a command PDU with ICD that is too large.

For nvmft(4), overly large command PDUs due to ICD are avoided by
clamping the size of the reported IOCCSZ in the controller data.
However, to ensure that H2C PDUs are sufficiently small, nvmf_che will
only claim queue pairs which advertised a suitable MAXH2CDATA
parameter during queue negotiation.  For ctld(8), this can be achieved
by setting the MAXH2CDATA option in a transport-group, e.g. for T7:

transport-group tg0 {
        discovery-auth-group no-authentication
        listen tcp 0.0.0.0
        listen tcp [::]
        listen discovery-tcp 0.0.0.0
        listen discovery-tcp [::]
        option MAXH2CDATA 32488
}

Sponsored by:   Chelsio Communications

nvmf_che: Fix amd64 LINT-NOVIMAGE build

Fixes:  https://cgit.freebsd.org/src/commit/?id=ec0cd287f55f nvmf_che: NVMe-TCP offload support for Chelsio T7 adapters
Sponsored by:   Chelsio Communications

cxgbe(4): fix nvmf_che module build

Fixes: https://cgit.freebsd.org/src/commit/?id=ec0cd28

When vchans are enabled, the primary channels do not interact with
userland, but with the vchans.

With vchans enabled:

$ sndctl feederchain
dsp0.play.0.feederchain=[vchans -> [...] -> hardware]
dsp0.record.0.feederchain=[hardware -> [...] -> vchans]

With vchans disabled:

$ sndctl feederchain
dsp0.play.0.feederchain=[userland ->  [...] -> hardware]
dsp0.record.0.feederchain=[hardware -> [...] -> userland]

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53504

Co-authored by:       meka@tilda.center
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53029

sound: Retire unused snd_dbuf->dir

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53518

sound: Retire snd_dbuf->dev

Redundant, and if we at some point really need this, we can fetch it
from snd_dbuf->channel->dev.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53519

sound: Re-arrange sndbuf_create() arguments

Since we always use the channel name as the "drv" argument, we can just
get rid of it and fetch it in sndbuf_create(). Also, put the "channel"
argument first, as it is more intuitive.

No functional change intended.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53520

sound: Define SNDBUF_F_MANAGED as 0x00000001

It's the only flag anyway.

No functional change intended.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj, emaste
Differential Revision:  https://reviews.freebsd.org/D53521

sound: Retire unused sndbuf_dump()

Fixes:          https://cgit.freebsd.org/src/commit/?id=e4e61333ffa4e90360de2dd1e4e0146f7cbf0afb
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj, emaste
Differential Revision:  https://reviews.freebsd.org/D53522

sound: Retire unused sndbuf_getflags() and sndbuf_setflags()

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53525

sound: Simplify sndbuf_clear() loop

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53526

sound: Remove redundant sndbuf_free() in chn_kill()

If b exists, it will get destroyed by sndbuf_destroy() (which calls
sndbuf_free()) a few lines below, so the additional sndbuf_free() here
is redundant.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53527

sound: Get rid of useless sndbuf getters and setters

No functional change intended.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53528

sound: Add to pcm/buffer.* copyright

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week

sound: Retire unused {pcm_feederdesc,feedertab_entry}->idx

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53547

sound: Retire MAXFEEDERS and feedercnt

Apart from the fact that it's unrealistic to reach MAXFEEDERS (256),
since sound(4) comes with maximum 7 feeders (including feeder_root),
there is also no reason to cap it.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53549

sound: Remove unnecessary pcm/vchan.h include from pcm/feeder.c

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53550

sound: Simplify pcm_feederdesc initialization

Currently we initialize a pcm_feederdesc array for every feeder, which
is then used by FEEDER_DECLARE(). However, there is no reason for this
to be an array, as each feeder has only one description. Additionally,
since the only thing we define in that array is the feeder type, remove
the pcm_feederdesc definitions altogether, and instead pass their type
to FEEDER_DECLARE() directly, which will then initialize the
pcm_feederdesc.

This also simplifies feeder_register().

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53551

sound: Retire unused pcm_feederdesc->flags

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53552

sound: Simplify feeder_getclass()

With the parameters we provide feeder_getclass(), the only thing we
really care about is the feeder's class type. We can simplify (and make
the code more readable) that by simply passing the type to
feeder_getclass(). Apart from being simpler, we can now also retire
feedertab_entry->desc and cmpdesc().

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53553

sound: Retire feedertab_entry

Have an SLIST of feeder_class directly. This way we simplify the code,
and also avoid the additional malloc()/free() for each entry.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53554

sound: Retire feeder_class->data

It's always NULL. No functional change intended.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53555

sound: Retire feeder_class->desc

The only field we care about is pcm_feederdesc->type, so keep that one
only and do not embed the whole pcm_feederdesc.

While here, make the feeder type enum into a named one and use it as
feeder_class->type's type.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53556

sound: Retire pcm_feederdesc->type

This is always accessed from pcm_feeder->desc->type. Instead of
duplicating this field, we can remove it from pcm_feederdesc, and access
it through pcm_feeder->class->type.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53557

sound: Remove unnecessary initializations in feeder_create()

We do not need to zero out fields since the struct is allocated with
M_ZERO. Also we no longer need to have a special case for the root
feeder.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53558

sound: Retire unused feeder_printchain()

We can print it with "sndctl feederchain".

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53559

sound: Retire feeder_register_root()

We can now use feeder_register().

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53560

sound: Retire DSP_DEFAULT_SPEED

Only a few drivers use this, but this is not really our "default" speed.
And even those drivers most likely override that value at some point
once CHANNEL_SETSPEED() has been called.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53562

sound: Retire unused SCF_SYNTH

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week

sound: Simplify logic in dsp_io_ops()

Use CHN_LOCK()/CHN_UNLOCK() directly, instead of
dsp_lock_chans()/dsp_unlock_chans(). These functions are useful when we
want to potentially lock both channels. Here we know which channel we
are locking, so we can just lock it directly. This way we get rid of the
prio variable as well.

Related to runpid again, there is no reason to assign it when
CHN_F_RUNNING is not set. channel->pid (as well as channel->comm) is
always assigned in dsp_chn_alloc().

Get rid of runpid. I do not see how we can end up with channel->pid
(td->td_proc->p_pid) not matching buf->uio_td->td_proc->p_pid.

Also improve errno values.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53736

sound: Clean up midi/ includes

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53841

sound: Merge PCM_ALIVE() with PCM_REGISTERED()

PCM_ALIVE() is used only in pcm_unregister(), but it does not hurt to
use PCM_REGISTERED(), which uses PCM_ALIVE() internally. In fact, it's
more robust this way.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week

In preparation for further MFP key work, migrate iwx away from using
IEEE80211_KEY_GROUP and pointer arithmetic.  This is a hold over from
ye olde days.

Locally tested:

* (STA mode, CCMP/CCMP network)
* iwx0: <Wi-Fi 6 AX210> mem 0x84c00000-0x84c03fff at device 0.0 on pci4

Differential Revision:  https://reviews.freebsd.org/D52523

Add this so it can be consumed/graphed.

Differential Revision:  https://reviews.freebsd.org/D53633
Reviewed by:    gallatin, imp

The driver communicates with the AMD IOMMU by writing to the tail of a
fixed length command ring buffer. After issuing cmd_max commands, the
tail pointer wraps back to the beginning of the ring buffer. Now, each
command buffer entry will contain content from previous commands which
may set bits in fields marked as Reserved for the current command. In
some cases, the hardware will return an ILLEGAL_COMMAND_ERROR event when
this occurs.

Fix is to memset the command buffer prior to use.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270966
Reviewed by:    corvink, kib, markj
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D53692

When VHE mode is enabled, this results in a hang on the host.  In
particular, when MDSCR_EL2.KDE is set to 1 and the CPU is executing at
EL_D, i.e., EL2, debug exceptions are enabled. In non-VHE mode, we call
into the guest by trapping to EL2, which implicitly masks debug
exceptions by setting PSTATE.D. However, in VHE mode, PSTATE.D remains
clear, so when the guest's MDSCR_EL1 value is loaded, we immediately
begin single-stepping.

In non-VHE mode there is no need to set KDE either, so just stop setting
it.

Reviewed by:    andrew
MFC after:      3 days
Sponsored by:   CHERI Research Centre (EPSRC grant UKRI3001)
Differential Revision:  https://reviews.freebsd.org/D48965

TDE (make EL2 the target EL for debug exceptions) is set both when
setting guest breakpoints and when single-stepping the guest.  In some
cases we may configure both capabilities, and when subsequently
disabling one of them we need to take care to avoid clearing TDE if the
other is still configured.

MFC after:      3 days
Fixes:          https://cgit.freebsd.org/src/commit/?id=75cb949228bb ("arm64/vmm: Add breakpoint and single-stepping support")
Sponsored by:   CHERI Research Centre (EPSRC grant UKRI3001)

Retire pccard(4)

pccard has been declared obsolete for a long time and also the
support has been removed but the man page still exists. It mentions
being scheduled to be removed before 13.0 but it still exists in the
tree.

[Extracted from review D53434]

Reviewed by: emaste
Fixes: https://cgit.freebsd.org/src/commit/?id=31b35400c ("pccard: Remove more of the PC Card infrastructure")

pccard.4: Really remove

Fixes:          https://cgit.freebsd.org/src/commit/?id=5b9fba1cb (Retire pccard(4))
Fixes:          https://cgit.freebsd.org/src/commit/?id=31b35400c (Remove more of the PC Card infrastructure)
Discussed with: emaste, jhb

This will be used by the SPE driver.

(commit message by andrew@)

Reviewed by:    andrew
Sponsored by:   Arm Ltd

This will be used by the SPE driver.

(commit message by andrew@)

Reviewed by:    andrew
Sponsored by:   Arm Ltd

arm64: Add Arm SPE support

Add support for the Arm Statistical Profiling Extension (SPE). This
is an optional extension added in Armv8.1 to provide profiling of
software using randomised instruction sampling.

This adds the initial driver, and attached it to the hardware tracing
framework, hwt(4), in CPU mode to allow tracing of all threads on
a given CPU.

(commit message by andrew@)

Co-authored-by: Sarah Walker <sarah.walker2@arm.com>
Co-authored-by: Andrew Turner <andrew@FreeBSD.org>
Reviewed by:    andrew
Sponsored by:   Arm Ltd
Sponsored by:   The FreeBSD Foundation (early driver)
Differential Revision:  https://reviews.freebsd.org/D46241

arm64/spe: Fix the GENERIC-NODEBUG build

Fixes:  https://cgit.freebsd.org/src/commit/?id=68f185ccc9f8 ("arm64: Add Arm SPE support")

If the connection flowid is available then the replies are requested on
the rx queue that is receiving wire traffic for the connection.  This
reduces contention for the txq lock.

Reviewed by:    jhb
MFC after:      3 days
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D53385

- Simplify directory and file structure.
- Clean up and improve code. Add more comments.
- Add polling examples.

MFC after:      1 week
Reviewed by:    christos
Differential Revision:  https://reviews.freebsd.org/D53353

No functional change intended.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj, emaste
Differential Revision:  https://reviews.freebsd.org/D53696

Tested with SR8 and DR4 transceivers.

MFC after:      1 week
Sponsored by:   Chelsio Communications

- Avoid some more registers with read side-effects during regdump.
- mps_tcam_size is 3x the size of T6/T5.
- Update rss_rd_row to work with T7.

Obtained from:  Chelsio Communications
MFC after:      1 week
Sponsored by:   Chelsio Communications

apmconf(8) was merged into apm(8) back in 2000 and this note and MLINK
were added as a transition aid, but that aid is no longer needed.

Sponsored by: The FreeBSD Foundation
MFC after:      1 week

sound: Retire unused mixer functions

No functional change intended.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week

sound: Move mixer->modify_counter to more appropriate place

No functional change intended.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week

sound: Retire OLDPCM_IOCTL

It is defined by default, and there is no reason to have a switch for
it. While here, also get rid of some unnecessary comments and ioctl
definitions.

No functional change intended.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week

sound: Remove unnecessary uio checks in dsp_io_ops()

uiomove_faultflag() takes care of that already.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    kib
Differential Revision:  https://reviews.freebsd.org/D53733

sound: Do not use double pointer in dsp_io_ops()

No reason to do so.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    kib
Differential Revision:  https://reviews.freebsd.org/D53734

sound: Retire SND_DIAGNOSTIC PCM locking macros

Disabled by default, but also redundant, since most of the errors they
catch will be caught anyway by WITNESS and the locking subsystem.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    kib
Differential Revision:  https://reviews.freebsd.org/D53735

Cast &end to vm_offset_t before subtracting VM_MIN_KERNEL_ADDRESS to
ensure the resulting size is correct for PRELOAD_PUSH_VALUE.
Previously the correct size was effectively divided by sizeof(void *).

Reviewed by:    andrew
Obtained from:  CheriBSD
Differential Revision:  https://reviews.freebsd.org/D53699

cxgbe(4): Expanded interrupt handling for T7

- Catch up with the new cause/perr registers.  The high level approach
  is the same but the T7 has an extra top level INT_CAUSE concentrator
  and a PERR_CAUSE concentrator with a changed layout.

- Add various flags to control the interrupt handlers' behavior.

- Implement a t4_intr_clear that internally use the slow handler as an
  iterator over known cause/perr registers.  This lets the driver clear
  all of the interrupt sources that it knows about.  The firmware sets
  up the interrupt enables and clears the causes normally so this call
  should be redundant.

MFC after:      1 week
Sponsored by:   Chelsio Communications

cxgbe(4): Skip non-existent blocks in the interrupt handler

Fixes:  https://cgit.freebsd.org/src/commit/?id=7b80c8b7d8d9 cxgbe(4): Expanded interrupt handling for T7
MFC after:      1 week
Sponsored by:   Chelsio Communications

Reported by: np
Fixes: https://cgit.freebsd.org/src/commit/?id=9349214a2815 mlx5: Preallocate ktls tags asynchronously
Sponsored by: Netflix

Migrate to the ieee80211_crypto_key_*() routines.
Should be no functional change.

Locally tested:

* RTL8821AU, STA mode

Differential Revision:  https://reviews.freebsd.org/D52712

* constify mtw_write_region_1()'s data field
* convert to use ieee80211_crypto_get_*()
* .. note that rx/tx mic data routines are explicitly being called,
  as this NIC is doing TKIP + MIC offload

Differential Revision:  https://reviews.freebsd.org/D53704
Reviewed by:    bz

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289121
Reported by:    Qiu-ji Chen
MFC after:      1 week
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D52199

Some TPM implementations have a different start method that requires
an additional notification for some state changes; for instance, the
"Pluton" start method.  Just factor these transitions out for now, and
the coming commits will introduce points that the start method can hook
in at.

Reviewed by:    obrien
Differential Revision:  https://reviews.freebsd.org/D53682

Reviewed by:  imp, jhb
Differential Revision:  https://reviews.freebsd.org/D53759

Create efi-freebsd.h, which is safe to include from the FreeBSD context
(all of userland, except the small bits we share with edk2 and the
kernel). This defines anything that we need. At the moment, it just
includes NULL definitions.

Create efi-edk2.h, which is approximately ProcessorBind.h from edk2 that
we can include in FreeBSD compontents that are re-using edk2 components
(bits of the boot laoder, and libefi*). Update the efi_gid definitions
to match edk2 better. Add this file to badfiles.inc, since we can't
write it in a way that's compatible. This is copied from the old
efi-osdep.h.

This has to be done in one commit that's bigger than I like since we
can't easily move things piecemeal around they are so inter-related.

Sponsored by:           Netflix
Differential Revision:  https://reviews.freebsd.org/D53651

Virtual Functions are considered untrusted and have no control
over VLAN filtering configuration in HW. To allow using
VLANs on VF intreface driver has to assume that VLAN HW Filtering
is always enabled and pass requests for adding or removing VLAN
tags to Physical Function driver using Mailbox API.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Approved by:    kbowling (mentor)
Reviewed by:    erj (previous version)
Tested by:      gowtham.kumar.ks_intel.com
MFC after:      1 week
Sponsored by:   Intel Corporation
Differential Revision:  https://reviews.freebsd.org/D53245

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290496
Tested by:      adrian
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week

nvme: Abstract out function to obtain a disk ident string from cdata

This will permit sharing the code with nvmf(4).

Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D53338

nvme: Include <sys/systm.h> explicitly for memmove

Reported by:    andrew, rpokala
Fixes:          https://cgit.freebsd.org/src/commit/?id=8d2a50bb3805 ("nvme: Abstract out function to obtain a disk ident string from cdata")
Sponsored by:   Chelsio Communications

This mirrors commit 6d0001d44490becdd20d627ce663c72a30b9aac3 but for
nvmf(4).

Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D53339

Use the midr value to ensure we find the correct PCPU pointer on arm64.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53327

Some non-PCI devices can send interrupts, e.g. the Arm SMMU or GICv5
Interrupt Wire Bridge. Add support for these by implementing pci_get_id
and pci_alloc_msi and the MSI/MSI-X parts of the PCIB interface.

Only the MSI parts of the PCI interface are added as that is all I am
able to test.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53330

Add the arm64 parts to support for non-PCI MSI and MSI-X interrupts.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53331

We don't have a GICv2 vgic so can just return 0.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53662

GICv5 will need this too, so move to the GIC_IVAR namespace.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53663

The old gicv3_get_support_lpis will be removed.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53664

It's no longer used after moving to gic_get_support_lpis.

Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D53665

Our recent changes to iichid.c has caused us to attempt to read a
full REPORT instead, and at least one keyboard hangs solid when we
do that.

This patch changes us to be spec-compliant.

Differential Revision: https://reviews.freebsd.org/D53803
MFC after: 1 day
Approved by: re(ccperciva)

b21e67875bf0c tested for the good condition, not the error condition, so
we'd never do anything else in this function. This was causing certain
logging not to happen, and also prevented forthcoming namespace size
change code from working as well.

Fixes: https://cgit.freebsd.org/src/commit/?id=b21e67875bf0c
Sponsored by: Netflix

When we get a namespace notification, we have to reconstrut the
namespace to get the new identification data from the namespace. For
each namespace in the AEN, we will reconstrict it before we call the
notification. We also flag it as changed for the duration of the change
callback (prior versions of the patch needed to keep track, but we no
longer do, so this bit may be removed). Note when we've seen the
namespace so we can notify when it goes away.

Co-authored-by: imp
Differential Revision: https://reviews.freebsd.org/D33032

Signal the new media size when the namespace changes size.

Reviewed by:            imp
Differential Revision:  https://reviews.freebsd.org/D33032

Signal when the namespace is gone so we can tear down the disk when a
nvme drive is removed.

Reviewed by:            imp
Differential Revision:  https://reviews.freebsd.org/D33032

pmap_zero_page() may be called on uncached pages, so using the cache to
zero uncached pages may trigger a fault.

MFC after:      2 weeks

39d4094173f9 ("epair: add support for checksum offloading") revealed
that HW checksum offloading is not enabled when the dpaa2_ni driver
is attached despite being declared and enabled on the dpni interface.

I modified dpaa2_ni_setup_if_caps to take into account both IPv4 and
IPv6 checksum offloading capabilities and added a call to re-configure
interface capabilities on attach to fix it.

Reviewed by:    bz
Fixes:          https://cgit.freebsd.org/src/commit/?id=39d4094173f9 ("epair: add support for checksum offloading")
MFC after:      1 week
Differential Revision: https://reviews.freebsd.org/D53436

INVARIANTS kernels may trigger a KASSERT panic from sndbuf_acquire(),
when fuzzing write(2) using stress2, because of a race in chn_write().

In the case of chn_write(), what sndbuf_acquire() does is extend the
ready-to-read area of the buffer by a specified amount of bytes. The
KASSERT in question makes sure the number of bytes we want to extend the
ready area by, is less than or equal to the number of free bytes in the
buffer. This makes sense, because we cannot extend the ready area to
something larger than what is available (i.e., free) in the first place.

What chn_write() currently does for every write is; calculate the
appropriate write size, let's say X, unlock the channel, uiomove() X
bytes to the channel's buffer, lock the channel, and call
sndbuf_acquire() to extend the ready area by X bytes. The problem with
this approach, however, is the following.

Suppose an empty channel buffer with a length of 1024 bytes, and 2
threads, (A) and (B), where (B) is a higher-priority one. Suppose thread
(A) wants to write 1024 bytes. It unlocks the channel and uiomove()s
1024 bytes to the channel buffer. At the same time, thread (B) picks up
the lock, and because it is higher priority, it keeps dominating the
lock for a few iterations. By the time thread (A) picks up the lock
again, it tries to call sndbuf_acquire() with a size of 1024 bytes,
which was calculated before it performed the uiomove(). In this case,
there is a very high chance that the buffer will not be empty, that is,
have a free area of 1024 bytes, as was the case when thread (A) started
executing, and so the KASSERT will trigger a panic because the condition
(bytes <= free) is not met.

Another scenario that can trigger a panic is the following: suppose a
buffer with a size of 4 bytes, and two threads: (A) and (B). In the
first iteration, thread (A) wants to write 2 bytes, while the buffer is
empty, BUT the pointer (sndbuf_getfreeptr()) is at the end (i.e.,
buf[3]). In the first iteration of the loop, because of the way we
calculate t, we'll end up writing only 1 byte, so after sz -= t, sz will
be 1, and so we'll need one more iteration in the inner loop, to write
the remaining 1 byte. Now we're at the end of the first loop, thread (A)
unlocks the channel, it has written 1 byte, it needs to write 1 more,
and the buffer is left with 3 empty slots. Now thread (B) picks up the
lock, and it wants to write 3 (or more) bytes. Eventually it writes the
3 bytes, and it leaves the buffer with 0 free slots. By the time thread
(A) picks up the lock again, and continues with the second iteration of
the inner loop, it will try to write the last byte, but sndbuf_acquire()
will panic because there is no free space anymore.

To fix this, get rid of the inner loop and calculate the write size on
each iteration. Also, call sndbuf_acquire() before unlocking the
channel. In the scenarios explained above, we'll end up entering the
chn_sleep() case. Modify it as well, so that we do not kill the channel
if we need to sleep more.

Do the same for chn_read() to avoid possible similar panics from
sndbuf_dispose().

Reported by:    pho
Tested by:      christos, pho
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    pho, kib
Differential Revision:  https://reviews.freebsd.org/D53666

Unused and confusing.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week

The reporter contacted me with packet loss and throughput fluctuations
on a low power machine (Intel J1900) that got worse with the recent AIM
algorithm in FreeBSD 14.2+.

32K RX PBA matches Linux default.  Add a conditional path since we don't
otherwise do a fixup for jumbo frames to retain space for two frames in
Tx.

With this change and an additional errata change, the throughput meets
line rate for the reporter.

Reported by:    Codin <codin@nagi.ftp.sh>
Tested by:      Codin <codin@nagi.ftp.sh>
MFC after:      2 weeks

Reporter noted packet loss with 82583.  NVM is down level.  The
errata docs mention disabling this, which should be the firmware
default, so I am not sure why we were enabling this bit.  Linux and
OpenBSD have the same issue, while NetBSD got it right.

Reported by:    Codin <codin@nagi.ftp.sh>
Tested by:      Codin <codin@nagi.ftp.sh>
MFC after:      2 weeks

* tag packets for 11n/11ac associated nodes with A_MPDU so they
  get passed into the reordering logic

* tag A-MSDU frames with AMSDU and AMSDU_MORE so they don't get
  dropped due to duplicate sequence numbers.

Note: I haven't yet elicited A-MSDU in A-MPDU to fully test this,
but I do see the net80211 reordering logic kick in (which you can
see via wlanstats -i wlan0 -o ampdu 1).

I've checked with Johannes Berg at Intel (who maintains the linux
iwlwifi stuff); he replied saying none of the firmware versions are
doing AMPDU reorder offloading.

Differential Revision:  https://reviews.freebsd.org/D53781

Locally tested:

 * AX210, STA mode, > 200mbit bidirectional traffic testing on
   5GHz VHT/40.

Do not create mutexes with snd_mtxcreate(). It doesn't provide any
value, plus it first allocates the mutex with malloc(9). Allocate
mutexes in the stack and use mtx_* functions directly instead of the
snd_mtx* wrappers.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    kib, markj
Differential Revision:  https://reviews.freebsd.org/D53855

Differential Revision:        https://reviews.freebsd.org/D53092
Reviewed by: np (outside of differential)
Sponsored by: Netflix

Differential Revision:        https://reviews.freebsd.org/D53093
Reviewed by: kbowling
Sponsored by: Netflix

Differential Revision:        https://reviews.freebsd.org/D53094
Sponsored by: Netflix

Differential Revision:        https://reviews.freebsd.org/D53095
Sponsored by: Netflix

Differential Revision:        https://reviews.freebsd.org/D53096
Sponsored by: Netflix

Differential Revision:        https://reviews.freebsd.org/D53097
Reviewed by: kbowling
Sponsored by: Netflix

Differential Revision:        https://reviews.freebsd.org/D53098
Reviewed by: tuexen
Sponsored by: Netflix

Differential Revision:        https://reviews.freebsd.org/D53099
Sponsored by: Netflix

Differential Revision:        https://reviews.freebsd.org/D53100
Reviewed by: akiyano_amazon.com

Differential Revision:        https://reviews.freebsd.org/D53101
Reviewed by: zlei
Sponsored by: Netflix

Differential Revision:        https://reviews.freebsd.org/D53102
Reviewed by: arybchik, zlei
Sponsored by: Netflix

Differential Revision:        https://reviews.freebsd.org/D53103
Reviewed by: markj
Sponsored by: Netflix

Fixes:                https://cgit.freebsd.org/src/commit/?id=9d18115ca0ab ("sound: Retire snd_mtx* wrappers")
Reported by:    CI
Sponsored by:   The FreeBSD Foundation
MFC after:      4 days

Sponsored by: The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    christos
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1887

Differential Revision:        https://reviews.freebsd.org/D53091
Reviewed by: kib
Sponsored by: Netflix

Tweak a couple of comments and fix a spelling error.

Sponsored by:           Netflix

When "options RSS" is configured, opt_rss.h defines the "RSS" token.

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291068
Fixes:  https://cgit.freebsd.org/src/commit/?id=17b4a0acfaf5 ("cxgbe(4): T7 related updates to shared code")

It was found that in some circumstances when launching
non-waiting create qhash cqp operation the refcount on
the cqp_request may be not properly decremented leading to a memory
leak.

Signed-off-by: Bartosz Sobczak <bartosz.sobczak@intel.com>

Reviewed by:    anzhu_netapp.com
Tested by:      mateusz.moga_intel.com
Approved by:    kbowling (mentor)
MFC after:      1 week
Sponsored by:   Intel Corporation
Differential Revision:  https://reviews.freebsd.org/D53732

.../sys/dev/cxgbe/t4_main.c:7197:1: warning: unused function 'hashen_to_hashconfig' [-Wunused-function]
 7197 | hashen_to_hashconfig(int hashen)
      | ^~~~~~~~~~~~~~~~~~~~
1 warning generated.

Reported by:    bz
Fixes:  https://cgit.freebsd.org/src/commit/?id=d381a6b4a552 cxgbe: use newly exposed RSS hash key API rather than ad-hoc hashing

The NVME controller in Crucial P310 disk does not accept 16-byte aligned
host memory buffer on Codasip Prime platform, but works fine on PAGE_SIZE
aligned memory.

Instead of adding a quirk, just increase alignment for everyone.

Reviewed by:    jhb
Discussed with: imp
Sponsored by:   CHERI Research Centre
Differential Revision:  https://reviews.freebsd.org/D53296

Ensure the offp capability bounds cover entire struct with checksum fields.

This is needed for CHERI systems to avoid bounds violation trap, as
otherwise offp allowed to dereference 4 bytes of csum_flags field only
so bzero failed.

Tested on ARM Morello.

Reviewed by:    kbowling
Discussed with: jrtc27
Sponsored by:   CHERI Research Centre
Differential Revision:  https://reviews.freebsd.org/D53903

Signed-off-by: ykla yklaxds@gmail.com
Sponsored by: Chinese FreeBSD Community
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1900

FIB_ALGO modular FIB lookups have been enabled by default on
amd64 and arm64 since 2021, so enable it on riscv as well.

Reviewed by:    melifaro
MFC after:      1 month

MFC after:    1 week
Sponsored by:   Chelsio Communications

It's our preferred style. No functional change.

Noticed by: avg
Sponsored by: Netflix

Due to performance constraints on a synthesized CHERI RISC-V core,
remove usage of xdma(4) scatter-gather framework.  Instead, provide
a minimalistic interface between two drivers.

This increases performance ~4-5 times.
Tested using scp(1) and nc(1) on Codasip Prime.

Sponsored by:   CHERI Research Centre
Differential Revision:  https://reviews.freebsd.org/D53932

The buffer in struct config should be allocated or mmap'ed. The code
without this patch allocates the buffer unconditionally, even for mmap
configs.

MFC after:      1 week
Reviewed by:    christos
Differential Revision:  https://reviews.freebsd.org/D53939

Linux does not check that any of the signals in vt_mode VT_SETMODE ioctl
(relsig, acqsig, frsig) are valid, but FreeBSD required that all three
are valid.  frsig is unusued in both Linux and FreeBSD, and software
typically leaves it unset.  To improve portability, allow frsig to be
set to zero.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289812
Reported by:    Dušan Gvozdenović
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52835

Realtek changed how it styled its name 25 or so years ago, but the old
style persisted in many places. These products use the new styling in
their datasheets.

Signed-off-by: ykla yklaxds@gmail.com
Sponsored by: Chinese FreeBSD Community
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1901

This is used on Codasip Prime.

Sponsonred by: CHERI Research Centre

Add a device_has_children() function which can be used to check if a
device has children without allocating a list of them which we aren't
going to use, or even counting them.

Also modify device_get_children() so it can be used to query the count
without allocating a list.

MFC after:      1 week
Sponsored by:   Klara, Inc.
Sponsored by:   NetApp, Inc.
Reviewed by:    imp, markj
Differential Revision:  https://reviews.freebsd.org/D53918

Does not really serve any real purpose. It gets set on mixer_open() and
unset on mixer_close(), so it essentially tells us whether the mixer is
open or not.

mixer_close() uses it to return EBADF in case the mixer is not busied,
as in, the mixer has not been open()'d yet. This is redundant. The other
place where this is used is to decide whether to serve an ioctl issued
by userland, in which case it won't if, again, the mixer has not been
busied (i.e., opened). Again, seems redundant.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D53859

This restores the functionality as it was pre-97d152698f48.

A stopgap was committed by glebius@ in 34dfccc64f47 ("acpi: in
acpi_stype_sysctl() use same logic as in acpi_sleep_state_sysctl()").

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290651
Reviewed by:    thj, emaste
Approved by:    thj
Fixes:  https://cgit.freebsd.org/src/commit/?id=97d152698f48 ("acpi: Use sleep types defined in sys/power.h")
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D53909

sys: remove comment for armv5/6

Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1903

sys: remove armv6/6.1 support from debug monitor

Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1903

sys: update comment for removal of armv6

Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1903

arm: Remove unused variable in dbg_arch_supported

Removed unused dbg_didr which had been used prior to f42421307b11 to
detect qemu unsupported debugger. I'm unsure how this slipped through my
testing.

Fixes: https://cgit.freebsd.org/src/commit/?id=f42421307b11
Sponsored by: Netflix

Obtained from https://github.com/Aquantia/aqtion-freebsd commit
c61d27b1d94af72c642deefa0595884481ea7377.

This is not using a vendor branch.  The formerly-upstream repo is
abandoned and I do not believe it will receive updates.  This initial
import serves as a snapshot of the vendor code, but from here we will
iterate on it in the tree as our own code.

Bug fixes, code cleanup, and build infrastructure will follow.

NetBSD and OpenBSD have derivatives of this driver (with additional
hardware support).  We can look to changes in those drivers, and the
Linux driver, to add support here.

Reviewed by:    adrian
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53813

pause() has 2 different definition in unistd.h and sys/systm.h

Direct access to struct ifnet members is not possible in FreeBSD 15;
accessors must be used.  These exist in all supported FreeBSD versions,
so we do not need to make this conditional.

aq_if_priv_ioctl and aq_if_debug have prototypes but are not yet
implemented.  Just remove the commented-out DEVMETHODs and the unused
prototypes, to clear a build-time warning; the DEVMETHODs and prototypes
can be readded if / when they are implemented.

Previously emitted a compiler warning "warning: bitwise comparison
always evaluates to false."

Looking at the OpenBSD driver (which is based on this code) it looks
like the VLAN flag should be set if either of these bits is.  In the
OpenBSD driver these are AQ_RXDESC_TYPE_VLAN and AQ_RXDESC_TYPE_VLAN2
rather than a magic number 0x60.

Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53836

Reviewed by:          imp (mentor)
Sponsored by:           Samsung Electronics
Differential Revision:  https://reviews.freebsd.org/D53919

QEMU ufs device does not implement WLUN, so QUIRK is added.

Reviewed by:            imp (mentor)
Sponsored by:           Samsung Electronics
Differential Revision:  https://reviews.freebsd.org/D53921

This patch adds a power_condition parameter to the
scsi_start_stop() function and sets the power condition via SSU.

Reviewed by:            imp (mentor)
Sponsored by:           Samsung Electronic
Differential Revision:  https://reviews.freebsd.org/D53922

This patch checks whether wlun is registered as a periph device.
It also implements a function to issue an SSU.

Reviewed by:            imp (mentor)
Sponsored by:           Samsung Electronics
Differential Revision:  https://reviews.freebsd.org/D53923

by device driver. That is required as game pad and joystick events have
to be accessible by ordinary users.

MFC after:      1 month

Their events have to be accessible by unprivileged users via e.g. libsdl.

MFC after:      1 month

Fix an issue where a three finger tap would generate additional events
when fingers moved slightly during the tap.

Signed-off-by:  Robert Wahlberg <freebsd@robertwahlberg.se>
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1792
Reviewed by:    wulf
MFC after:      1 month

MFC after:    1 month

Driver for Feature Integration Technology Inc. (aka Fintek)
F81232 USB to serial driver.

Reviewed by:    thj,adrian,UB
Approved by:    adrian
Differential Revision:  https://reviews.freebsd.org/D53893

On powerpc/powerpc64, sig_atomic_t is an int, but was treated as if
it was a long by <machine/_stdint.h>.  This was finally caught by the
unit test added with 4a1c752 / D53831.

Reported by:    kib
Reviewed by:    kib, imp
Approved by:    markj (mentor)
Fixes:          https://cgit.freebsd.org/src/commit/?id=c3e289e1ce8c9af8d14e9f727632e22b3bf901f9
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D54026

These buffers should not overlap.

Reviewed by:    imp
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D53842

ufshci: Support suspend/resume

Handle system power events and issue START STOP UNIT (SSU) to the
UFS Device WLUN (0x50).

Reviewed by:            imp (mentor)
Sponsored by:           Samsung Electronics
Differential Revision:  https://reviews.freebsd.org/D54002

ufshci: Support UIC hibernation enter/exit

Add helpers to issue DME_HIBERNATE_ENTER/DME_HIBERNATE_EXIT and
call them during suspend/resume.

Reviewed by:            imp (mentor)
Sponsored by:           Samsung Electronics
Differential Revision:  https://reviews.freebsd.org/D54003

ufshci: Support UIC Auto Hibernation

Automatically transition the UniPro link to Hibernate when it is idle
for the duration configured by the Auto-Hibernate Idle Timer (AHIT).
This reduces link power while the device is inactive.

Reviewed by:            imp (mentor)
Sponsored by:           Samsung Electronics
Differential Revision:  https://reviews.freebsd.org/D54004

ufshci: Add a Auto Hibernate quirk to Intel Alder Lake-N

Alder Lake-N supports Auto Hibernate, but it does not work.

Reviewed by:            imp (mentor)
Sponsored by:           Samsung Electronics
Differential Revision:  https://reviews.freebsd.org/D54006

Fixes: https://cgit.freebsd.org/src/commit/?id=42421307b115 (sys: remove armv6/6.1 support from debug monitor)
Suggested by:   jhb
Sponsored by:   Netflix

We need a quick way to identify a given machine (SoC), mainly when
implementing quirks for a given SoC.

MFC after:      2 weeks
Reviwed by:     imp
Differential Revision:  https://reviews.freebsd.org/D53992

Due to an implementation bug, the GICv3 and ITS master ports may be connected
to a non-coherent bus. The new DT resolves this issue by marking these ports
with the "dma-nocoherent" attribute. The older DT does not have this attribute,
so we must match the affected SoC.
Additionally, the RK356x family has GIC master ports on a 32-bit bus.
Therefore, we must limit the address range for all tables and command buffers
allocated for it. In this case, the DT does not have an attribute for this
case, so the quirk should only be applied by SoC matching.

MFC after:      4 weeks
Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D47488

MFC after: 3 weeks

Without this change, vm_fault_quick_hold_pages() falls back to the slow
fault handler when it encounters a superpage mapping.

Reviewed by:    alc, kib
Reported and tested by: br
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D54022

Obtained from:        Hewlett Packard Enterprise
Rebiewed by:    jhb, jhibbits

Remove extra arg so that we have type=SMART_ERROR rather than an invalid
message. Also log all aens.

Sponsored by:           Netflix

pmc: add alderlake model

The commit 601925180df4 added the models 6-B7, 6-BA, 6-BF to libpmc, but
they must also be added to the hwpmc module to allow pmc to work on
those CPUs.

Reviewed by:    mhorne
MFC after:      1 week
Fixes:          https://cgit.freebsd.org/src/commit/?id=601925180df4 ("libpmc: add more alderlake models")
Sponsored by:   Stormshield
Differential Revision:  https://reviews.freebsd.org/D49255

pmc: add emerald rapids model

This commit adds emerald rapids CPU model to hwpmc/libpmc. JSON event
definitions are imported from Intel perfmon version 1.06.

Reviewed by:    mhorne
MFC after:      1 week
Sponsored by:   Stormshield
Differential Revision:  https://reviews.freebsd.org/D49228

pmc: add alderlaken model

This commit adds alderlaken CPU model to hwpmc/libpmc. JSON event
definitions are imported from Intel perfmon version 1.16.

Reviewed by:    mhorne
MFC after:      1 week
Sponsored by:   Stormshield
Differential Revision:  https://reviews.freebsd.org/D49229

xhci: Add some Alder lake device ids

Reviewed By:    aokblast
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52994

xhci: Correct name of HCCPARAMS Register

On inital import the name of HCCPARAMS1 was misnamed as HCSPARAMS0.
HCCPARAMS1 is defined in section 5.3.6 of xHCI Specification 1.2b (April
2023).

Reviewed by:    adrian
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53895

xhci: Add header values for Debug Capability (DbC)

Add header values for xHCI debug capability. These values are defined in
section 7.6 of xHCI Specification 1.2b (April 2023).

Reviewed by: imp
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53897

E823 backplane devices may support 40G as maximal PMD speed.
Extend port topology reading logic to handle this case.
While at that fix indentation according to FreeBSD style(9).

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Tested by:      gowtham.kumar.ks_intel.com
Approved by:    kbowling (mentor), erj (mentor)
Sponsored by:   Intel Corporation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53587

Improve the wording of the invalid namespace value. Reword the comment
and move a line of code to the block it logically belongs to.

No functional changes intended.

Sponsored by:           Netflix
Differential Revision:  https://reviews.freebsd.org/D51393

NVME_NS_ADDED will conflict with a later change, so change it here.
Likewise NVME_NS_CHANGED.

Sponsored by:           Netflix

MFC after:    1 week
Reviewed by:    christos
Differential Revision:  https://reviews.freebsd.org/D54038

Reviewed by:  np, imp
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D53030

Reviewed by:  imp
Differential Revision:  https://reviews.freebsd.org/D53405

Reviewed by:  imp
Differential Revision:  https://reviews.freebsd.org/D53406

Reviewed by:  imp
Differential Revision:  https://reviews.freebsd.org/D53407

Reviewed by:  imp
Differential Revision:  https://reviews.freebsd.org/D53408

Reviewed by:  imp
Differential Revision:  https://reviews.freebsd.org/D53409

Remove type and rid arguments from
bhnd_bus_(activate|deactivate|release)_resource.  This should have
been done earlier to match the changes made to bus_release_resource,
etc.

While fixing up the callers, remove rid members from softc structures
since the only time a value is needed is as a constant input to
bhnd_bus_alloc_resource*.

Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D53410

These were a doodle that escaped into my staging tree. Remove them.

Sponsored by:           Netflix

Interface for the nvme driver notifying its children of different
events: async notifications, namespace events and device failure. These
aren't yet connected.

Sponsored by:           Netflix
Reviewed by:    dab
Differential Revision:  https://reviews.freebsd.org/D51386

Step 1 in the move from registering consumers for NVMe drives to newbus
nvme drives:

Add a child device and attach them for each controller that we
initialize. Detach them when we detach the main device.

Sponsored by:           Netflix
Reviewed by:            dab
Differential Revision:  https://reviews.freebsd.org/D51383

Rather than registering as a consumer of the nvme controller, hook into
the child device and use that.

This is a small regression at the moment: we don't fail the device when
that happens at runtime, and we don't handle new namespaces when they
arrive (though that feature is currently fragile).

Sponsored by:           Netflix
Differential Revision:  https://reviews.freebsd.org/D51384

Rather than registering as a consumer of the nvme controller, hook into
the child device and use that.

This is a small regression at the moment: we don't fail    the device when
that happens at runtime.

Sponsored by:           Netflix
Differential Revision:  https://reviews.freebsd.org/D51385

Connect up the nvme_ns_* events. Copy code from old ways, as needed, and
refactor a little.

Sponsored by:           Netflix
Reviewed by:            dab
Differential Revision:  https://reviews.freebsd.org/D51387

Conenct methods to manage namespaces explicitly to replace the old
consumer interface.

Sponsored by:           Netflix
Differential Revision:  https://reviews.freebsd.org/D51388

nvme: Use new method to do async notifications

Nothing uses these at the moment, but it would be useful to use in the
future so convert this functionality to an newbus function dispatch.

Sponsored by:           Netflix
Reviewed by:            dab
Differential Revision:  https://reviews.freebsd.org/D51390

nvme: Notify failure with newbus call

Sponsored by:           Netflix
Reviewed by:            dab
Differential Revision:  https://reviews.freebsd.org/D51391

nvme: remove now-redundant consumer interface

Now that we've moved to newbus methods, we can delete this...

Sponsored by:           Netflix
Reviewed by:            dab
Differential Revision:  https://reviews.freebsd.org/D54095

And remove some unused definitions.

Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D54152

Sponsored by: CHERI Research Centre

This is useful when dev.netmap.port_numa_affinity is set to 1.  When
interfaces attach, they get a memory allocator that is copied from
nm_mem.  Parameters in nm_mem can be set using sysctls, but this happens
after their values are copied.

To work around this, we can make it possible to set these memory
parameters as tunables.

Reviewed by:    vmaffione
MFC after:      1 week
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D54178

There are delay loops, checking the BUSY status bit, before writing to
the date or time registers. Each iteration contains a 1usec delay, for a
maximum of 70 iterations.

This is frequently not enough on the D1 platform, where the message is
emitted:

  rtc0: could not set date, RTC busy

Bump the loop delay to 10usecs each, and the maximum number of
iterations to 150, for a maximum delay of 1.5msecs between each write of
the register.

In my testing this seems to be adequate.

The loop variable is renamed for clarity/simplicity.

Reviewed by:    manu
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D54180

This change fixes two checks that conflated memory mapping and memory
segment idenitifers. In both cases the code iterates over all memory
mappings but passes the index to `vm_memseg_sysmem`, which is wrong.

Fix this by passing the memory mapping's segment identifier instead.

Differential Revision:  https://reviews.freebsd.org/D54210
Reviewed by:    markj
Fixes:  https://cgit.freebsd.org/src/commit/?id=c76c2a19ae37
PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290920

Only validate SEG.SEQ and SEG.ACK when processing a real SYN-cache
entry. In the SYN-cookie case, these conditions are always true, since
the SYN-cache entry on the stack is constructed from the incoming
TCP segment.
While there, fix the logging messages.

Reviewed by:            Nick Banks
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52816

On some iflib drivers, the txd reclaim routine can be fairly expensive
at high packet rates.  Iflib was designed with the intent of only
reclaiming tx descriptors above a configurable threshold, but this
logic was left unimplemented.

This change:

   - implements 2 new knobs, iflib.tx_reclaim_thresh and
      iflib.tx_reclaim_ticks.
   - moves tx reclaim thresh from the if_shared_ctx and into the
      iflib_ctx as drivers don't need to see it, and it needs to be
      changed, so it can't be const
   - tx_reclaim_thresh and ticks are replicated into the txq to
      improve cache locality of data accessed in the hot path
    - ticks is used rather than more expensive timekeeping mechanism so
       as to keep things simple and cheap

This change substantially improves packet rates on bnxt. It has been
tested on bxnt and ixl

Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D52561
Reviewed by: markj (initial version)

Don't drop a SYN-cache entry just because a challenge ACK couldn't
be sent. This might only be a temporary failure.

Reviewed by:            Nick Banks, glebius, jtl
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52840

It's only used in this file.

Sponsored by:   Rubicon Communications, LLC ("Netgate")

The routine allocates the wrong size and then passes it to in6_get_ifid.

At the same time it violates invariants by issuing malloc with M_WAITOK
while within net epoch section.

Sponsored by:   Rubicon Communications, LLC ("Netgate")

The validation of SEG.SEQ (first step in SEGMENT ARRIVES of RFC 9293)
should be done before the validation of SEG.ACK (fifth step in
SEGMENT ARRIVES in RFC 9293).
Furthermore, when the SEG.SEQ validation fails, a challenge ACK
should be sent instead of sending a RST-segment and moving the
endpoint to CLOSED.

Reported by:            Tilnel on freebsd-net
Reviewed by:            Nick Banks
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52849

While processing SCTP packets we can enqueue work for later, in the
sctp_multihome_jobs queue. This deferred job includes a copy of the current
struct pf_pdesc, which must contain a valid pcksum pointer (in case of NAT).

However, jobs could be enqueued before we'd actually set this pointer in
pf_setup_pdesc(). Set this pointer before we scan the SCTP chunk headers (and
could enqueue deferred jobs.)

While here sprinkle in a few more assertions to ensure we got this right.

Reported-by: syzbot+974d0fb7e53c9aa31b90@syzkaller.appspotmail.com
MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")

We returned 'PF_DROP' instead of '-1' in one case, which would lead to us
continuing the processing for an invalid packet.
This also aligns us closer to OpenBSD, and reduces the odds of future similar
mixups.

MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")

The syncache entry is locked by the hash bucket lock. After running
SCH_UNLOCK(), we have no guarantee that the syncache entry still
exists.

Resolve the race by moving SCH_UNLOCK() after the log() call which
reads variables from the syncache entry.

Reviewed by:    rrs, tuexen, Nick Banks
Sponsored by:   Netflix
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D52868

If an rdr (or nat) rule specifies 'pass' we don't run the filter rules, we just
pass the traffic. Or at least, we did until that got unintentionally broken.
Restore that behaviour and add a test case.

While here also fix nat:dummynet_mask, which relied on the broken behaviour.

MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")
Differential Revision:  https://reviews.freebsd.org/D52838

* use ND_NA_FLAG_ROUTER flag in carp_send_na() when we work as router.
* use in6addr_any as destination address for nd6_na_output(), then it
  will use ipv6-all-nodes multicast address.
* add in6_selectsrc_nbr() function that accepts additional argument
  ip6_moptions. Use this function from ND6 code to avoid cases when
  nd6_na_output/nd6_ns_output can not find source address for
  multicast destinations.
* add some comments from RFC2461 for better understanding.
* use tlladdr argument as flags and use ND6_NA_OPT_LLA when we need
  to add target link-layer address option, and ND6_NA_CARP_MASTER when
  we know that target address is CARP master. Then we can prepare
  correct CARP's mac address if target address is CARP master.
* move blocks of code where multicast options is initialized and
  use it when destination address is multicast.

Reviewed by:    kp
Obtained from:  Yandex LLC
MFC after:      2 weeks
Sponsored by:   Yandex LLC
Differential Revision: https://reviews.freebsd.org/D52825

Replace counter(9) usage with more lightweight atomic(9) in the
code handling RFC 7217 SLAAC address generation.

Also, use `u_int` types with this. Leaving `dad_failures` local to
`in6_get_stableifid()` as a `uint64_t` to avoid changing the generated
addresses from previous code; this also gives some headroom for
future changes.

While here, moved some `#include` lines to adhere to style(9).

Reviewed by:            glebius, jhibbits, jtl, zlei
Approved by:            glebius, jtl, zlei
Differential Revision:  https://reviews.freebsd.org/D52731

sdl_data isn't always NULL terminated

Signed-off-by: nreilly@qnx.com

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288958
Reviewed by:    markj
MFC after:      1 week

According to the fifth step in SEGMENT ARRIVES, send a RST segment in
response to an ACK segment which fails the SEG.ACK check, but leave
the endpoint state unchanged.
FreeBSD handles this correctly when entering the SYN-RECEIVED state via
the SYN-SENT state, but not in the SYN-cache code, which handles the
SYN-RECEIVED state via the LISTEN state.

This also fixes a panic reported by Alexander Leidinger.

Reviewed by:            jtl, glebius
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52934

PR:   https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290050

Save prefix length in unused field in6_ifaddr->ia_plen, then on remove
check if an address has 128 prefix length, and if so, we don't need to
complain that there is none of related prefixes.

Reviewed by:    kp
Obtained from:  Yandex LLC
MFC after:      1 week
Sponsored by:   Yandex LLC
Differential Revision:  https://reviews.freebsd.org/D52952

Add a -b option to print the BBLog state for TCP sockets.

Reviewed by:            jtl, rrs
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52944

This documents the following functions:

* ieee80211_is_key_global()
* ieee80211_is_key_unicast()
* ieee80211_crypto_get_key_wepidx()
* ieee80211_crypto_get_keyid()
* ieee80211_crypto_get_txkey()
* ieee80211_crypto_encap()
* ieee80211_crypto_decap()

Differential Revision:  https://reviews.freebsd.org/D52649

No functional changes intended.

MFC after:      3 days
Sponsored by:   Netflix, Inc.

When a packet is provided to LRO using tcp_lro_queue_mbuf(), a
sequence number is computed based on the m_pkthdr.flowid provided
by he driver. The implicit assumption is that the m_pkthdr.flowid
has hash properties.
The recent use of tcp_lro_queue_mbuf() in iflib exposed a bug in at
least one driver (igc) , which
* reports always that is uses M_HASHTYPE_OPAQUE.
* sets in some cases m_pkthdr.flowid not consistently for packets
  belonging to the same TCP connection.
This results in severe performance problems for the base TCP stack,
since it handles the packets in the wrong sequence, although they were
received in the correct sequence.
To protect against such misbehaving drivers, just take the
m_pkthdr.flowid only into account, if it has hash properties.
The performance problems were observed by gallatin@ and analyzed
together with rrs@.

Reviewed by:            gallatin
Tested by:              gallatin
MFC after:              5 Minutes
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52989

Fix the format when the output for a socket spans multiple lines.

Reviewed by:            rrs
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52984

Showing the path state column is only useful, if there is at least one
SCTP endpoint shown, which is not in the state CLOSED or LISTEN.
Don't show it when it is not useful.

Reviewed by:            rrs
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52986

Wait until all of the configuration has been parsed before creating
associations for NVMe portals.  This ensures that any options
specified in a transport group are honored when creating associations.

To enable this, add a new virtual method portal::prepare invoked when
applying a configuration prior to opening a socket (or reusing an
existing socket) for a portal.

Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D52844

Add static probe points to track where we increment io_pkt_drop. This is
intended to assist in debugging dummynet, allowing us to work out when and
hopefully why packets get dropped.

Sponsored by:   Rubicon Communications, LLC ("Netgate")

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

MFC after:    1 week

The only possible return value of function ipfw_init() is 0. Make it
return void to match the prototype of SYSINIT.

MFC after:      1 week

MFC after:    1 week

MFC after:    1 week

tcp: Initial ktest for HPTS

Reviewed by:            rrs, tuexen
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52979

tcp: simplify tcp_hpts_insert signature

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: remove notion of ticks from HPTS

To improve consistency of the code, don't use slots and ticks,
just use slots.

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: fix KASSERT in HPTS

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: fix a bug in HPTS

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: use time instead of slots in the HPTS API

This makes slots an internal concept of HPTS.

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: remove unused argument in HPTS

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

tcp: add missing header file

Reviewed by:    tuexen
Sponsored by:   Netflix, Inc.

Note, it looks like this code may be unused since commit 4a77657cbc01
("ipfw: migrate ipfw to 32-bit size rule numbers").  In particular, it
looks like the ipfw_nat_*_ptr pointers are unused now.

Reviewed by:    ae
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53068

Only suppress the path state column when producing traditional text
output. When generating html output, always include the column.
Please note that when generating json or xml output, optional fields
like the path state are only generated if they is applicable. This
has not been changed.
The changes in this patch were suggested by asomers.

Reviewed by:            asomers
Fixes:                  https://cgit.freebsd.org/src/commit/?id=746eadecaa7d ("sockstat: show path state column only when useful")
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53005

BLOCKLIST_NOTIFY() is called within a signal handler for the alarm after
the grace period has expired that may only take async-signal safe
actions.

Reviewed by:    emaste
Fixes:          https://cgit.freebsd.org/src/commit/?id=e02003bce726 ("openssh: blocklist: Use NetBSD probes")
MFC after:      1 day
Differential Revision:  https://reviews.freebsd.org/D53109

This will close a panic on test run when kernel is compiled without HPTS
KTEST support.

The code to do the route lookup was already there, but was used only for
the legacy IP_ADD_MEMBERSHIP when called without index.  Do same lookup
for IP_ADD_MEMBERSHIP with index and what is more important for
MCAST_JOIN_GROUP, if the supplied index is 0.  This is a neat feature and
Linux does that, so this should make a few applications easier portable to
FreeBSD.

Differential Revision:  https://reviews.freebsd.org/D52918

This allows in higher throughput values with default settings.
In the review I was proposing using 16 MB, but in the transport
call today we settled on a more conservative value of 8.
Bumping it further will be done in combination with mitigations
for mbuf exhaustion attacks.

Reviewed by:            rscheff, cc, glebius, Nick Banks, Peter Lei, jtl, thj, rrs
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52872

This allows in higher throughput values with default settings.
In the review I was proposing using 16 MB, but in the transport
call today we settled on a more conservative value of 8.
Bumping it further will be done in combination with mitigations
for mbuf exhaustion attacks.

Reviewed by:            rscheff, Peter Lei, jtl, thj
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52871

* Consistently free the string after unlocking the sch, if possible.
* Remove the failure handling in case of sc != NULL, since this is
  not possible anymore.
* Remove the use of goto and instead return 0 in the three cases.
The only change in behavior is that in three out of the four cases,
where 0 is returned, *lsop is not set to NULL anymore. So the behavior
is now consistent and also documented in a comment. The current in
tree callers only look at *lsop, if and only if syncache_expand()
returns 1.

Reviewed by:            Peter Lei
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52948

Reviewed by:  phk
Differential Revision:  https://reviews.freebsd.org/D53151

This is a small cleanup to consolidate the considered lost reduction and marking to an
inline function. There are two places where we are using hookery in SACK processing where
we can't use it. All other places we move to the function. This code in theory changes nothing
and just makes things a bit more readable and consistent.

Reviewed by:tuexen
Differential Revision:  <https://reviews.freebsd.org/D53021>

Ensure we always have a non-NULL rule pointer (ctx.rm).
It might have gotten set to NULL by pf_get_translation().

While here also restore the previous rdr behaviour be re-adding the incorrectly
removed 'break' in pf_match_translation_rule.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290177
MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")
Differential Revision:  https://reviews.freebsd.org/D53191

The computation of the length was not taking into account that IPv6
endpoints, which are not IPv6 only, have a suffix of 46.
For UDP and TCP this bug was not relevant, since tcp46 and udp46
has the same length as PROTO, but sctp46 is longer. Upcoming
udplite support will also be affected.

Reviewed by:            asomers
MFC after:              3 days
Differential Revision:  https://reviews.freebsd.org/D53212

This is a small change as suggested by Gleb to move all __inline -> inline aka C99 style. This
covers both BBR and Rack and makes no real changes to the code functionality

Reviewed by:    tuexen
 Differential Revision: <https://reviews.freebsd.org/D53197>

Provide the IPPROTO_UDP in the arg2 parameter of udp_pcblist() and use
this to determine the inpcbinfo. This allows the same function to be
used in an upcoming commit to provide the list of pcbs for UDP-Lite
just by providing IPPROTO_UDPLITE in the arg2 parameter.

Reviewed by:            rrs
MFC after:              3 days
Differential Revision:  https://reviews.freebsd.org/D53218

Fix the htons byteorder of vxlan packets after
`vxlan_pick_source_port` picks a source port during encapsulation.

Reviewed by:    zlei, kp, adrian
Differential Revision:  https://reviews.freebsd.org/D53022

While TCP disallows connect()ing a socket with SO_REUSEPORT_LB, UDP does
not.  As a result, a connected UDP socket can be placed in the lbgroup
hash and thus receive datagrams from sources other than the connected
host.

Reported by:    Amit Klein <amit.klein@mail.huji.ac.il>
Reported by:    Omer Ben Simhon <omer.bensimhon@mail.huji.ac.il>
Reviewed by:    glebius
Approved by:    so
Security:       FreeBSD-SA-25:09.netinet
Security:       CVE-2025-24934

krb5: Fix -Wint-conversion when bootstrapping on GNU/Linux

This shows up in GitHub Actions as a warning, and some compilers can
default to it being an error.

krb5: Include <features.h> on Linux so __GLIBC__ can be checked

__GLIBC__ is not pre-defined by the toolchain, it comes from features.h,
so we need to make sure that's included by this point.

Fixes:  https://cgit.freebsd.org/src/commit/?id=4dd2b869cd07 ("krb5: Fix -Wint-conversion when bootstrapping on GNU/Linux")

Export the list of pcbs for UDP-Lite to be consumed by sockstat and
netstat.

Reviewed by:            Peter Lei, Nick Banks
MFC after:              3 days
Differential Revision:  https://reviews.freebsd.org/D53229

With this patch UDP-Lite endpoints are also show per default.

Reviewed by:            Peter Lei, Nick Banks
MFC after:              3 days
Relnotes:               yes
Differential Revision:  https://reviews.freebsd.org/D53230

With this patch UDP-Lite endpoints are also shown per default.

Reviewed by:            Nick Banks
MFC after:              3 days
Differential Revision:  https://reviews.freebsd.org/D53252

When copying the data in the first mbuf to get rid of the UDP
header, use the correct length. It was copying too much (8 bytes,
the length of the UDP header).
This only applies to handling TCP over UDP packets. The support for
TCP over UDP is disabled by default.

Reported by:            jtl
Reviewed by:            Peter Lei
MFC after:              3 days
Sponsored by:           Netflix, Inc.

ipf_nat_getent() allocates a variable-sized nat_save_t buffer with
KMALLOCS() (which does not zero memory) and then copies only a subset
of fields into it before returning the object to userland using
ipf_outobjsz(). Because the structure is not fully initialized on all
paths, uninitialized kernel heap bytes can be copied back to user space,
resulting in an information leak.

We fix this by zeroing out the data structure immediately after
allocation.

Reported by:            Ilja Van Sprundel <ivansprundel@ioactive.com>
Reviewed by:            emaste
MFC after:              3 days
Differential revision:  https://reviews.freebsd.org/D53274

ipf_htable_stats_get() constructs an iphtstat_t on the stack and only
initializes select fields before copying the entire structure to
userland. The trailing padding array iphs_pad[16] is never initialized,
so ~128 bytes of uninitialized kernel stack memory can be leaked to user
space on each call. This is a classic information disclosure
vulnerability that can reveal pointers and other sensitive data.

We fix this by zeroing out the data structure prior to use.

Reported by:            Ilja Van Sprundel <ivansprundel@ioactive.com>
Reviewed by:            emaste
MFC after:              3 days
Differential revision:  https://reviews.freebsd.org/D53275

The TCP_SAD_DETECTION code was removed. Remove the remaining
sysctl-variables and counters.

Reviewed by:    tuexen
MFC after:      3 days
Sponsored by:   Netflix, Inc.

TCP stats are currently incremented for the persist and progress
timeout conditions, but only the persist cause was saved in the
connection end info status, which in turn is logged in the
blackbox "connection end" event.

Reviewed by:    tuexen
MFC after:      3 days
Sponsored by:   Netflix, Inc.

It has been reported as PR 290478.  In the meantime, just sweep under
the carpet.

It is worth noting that neither commit:
2347ca21d657 ("blocklist-helper: Silence a bogus pf warning")
nor this one will be upstreamed, as this is a FreeBSD-specific issue.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290478
MFC after:      2 days

Honor the IPPROTO_IPV6-level socket option IPV6_TCLASS when sending
an UDP/IPv4 packet on an AF_INET6 socket.

Reviewed by:            bz, glebius
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53346

Honor the IPPROTO_IPV6-level cmsg of type IPV6_TCLASS when sending
an UDP/IPv4 packet on an AF_INET6 socket.

Reviewed by:            bz
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53347

Signed-off-by: Quentin Thébault <quentin.thebault@defenso.fr>

Sponsored by:   Defenso
Reviewed by:    markj
MFC after:      1 month
Differential Revision:  https://reviews.freebsd.org/D52541
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1880

The handlers were not checking that the group names are nul-terminated.
Add checks for this.

Reported by:    Ilja Van Sprundel <ivansprundel@ioactive.com>
Reviewed by:    zlei
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53344

These structures are copied out to userspace, and it's possible to leak
uninitialized stack bytes since these routines and their callers weren't
careful to clear them first.  Add memsets to avoid this.

Reported by:    Ilja Van Sprundel <ivansprundel@ioactive.com>
Reviewed by:    kp, emaste
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53342

MFC after:    1 week

The current IPFW version 3 dates to 2010 (commit cc4d3c30ea28, "Bring in
the most recent version of ipfw and dummynet, developed").

The compat code for FreeBSD 8 and earlier has a number of issues and is
no longer needed, so remove it.

Reported by:    Ilja Van Sprundel <ivansprundel@ioactive.com>
Reviewed by:    ae, glebius
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53343

When adding a syncache entry, take a reference count of the
credentials while the inp is still locked.
Thanks to markj@ for providing a hint regarding the root cause.

Reported by:            David Marker
Reviewed by:            glebius
Tested by:              David Marker
Fixes:                  https://cgit.freebsd.org/src/commit/?id=cbc9438f0505 ("tcp: improve ref count handling when processing SYN")
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53380

Unterminated strings in the anchor or name could cause crashes.
Validate them, and add a test case.

Reported by:    Ilja Van Sprundel <ivansprundel@ioactive.com>
MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")

Both for the DIOCADDSTATE ioctl and for states imported through pfsync packets.
Add a test case to exercise this code path.

Reported by:    Ilja Van Sprundel <ivansprundel@ioactive.com>
MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")

Returning an error causes premature termination of if_foreach_sleep()
loop over the interfaces.  Whatever problem we have with the specific
interface trying to install an element, should not prevent an attempt to
install the same element into all other interfaces.

Noted by:       Ariel Ehrenberg
Sponsored by:   NVidia networking
MFC after:      1 week

New-style address translation is done by nat-to and rdr-to actions on
normal match and pass rules. Those rules, when used without address
translation, can be specified without direction. But that allows users
to specify pre-routing nat and post-routing rdr. This case is not
handled properly and causes pre-routing nat to modify destination
address, as if it was a rdr rule, and post-routing rdr to modify source
address, as if it was a nat rule.

Ensure that nat-to action modifies source address and rdr-to destination
address no matter in which direction the rule is applied. The man page
for pf.conf already specifies that nat-to and rdr-to rules should be
limited to respective directions.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288577
Reviewed by:    kp
MFC after:      3 days
Sponsored by:   InnoGames GmbH
Differential Revision:  https://reviews.freebsd.org/D53216

Source nodes redirect (nat-to, rdr-to, route-to) all further connections
matching the rule which has created the source node. The source node is
valid as long as there are states resulting from the rule or until the
source node lifetime expires. When the rule's redirection pool is
modified (e.g. table contents are changed) the source node is still
valid and it will redirect new connections to invalid target (e.g. a
dead next-hop).

When performing source tracking after finding a source node check if the
redirection address still exists in pool of the rule which has created
this node. If not, delete the source node. This will result in finding a
new redirection address and creation of a new source node.

Reviewed by:    kp
Obtained from:  OpenBSD
Sponsored by:   InnoGames GmbH
Differential Revision:  https://reviews.freebsd.org/D53231

Reviewed by:  tuexen
MFC after:      3 days
Sponsored by:   Netflix, Inc.

The list of addresses is potentially very large. Larger than we can fit in a
single netlink request, so we indicate via the PFR_FLAG_START/PFR_FLAG_DONE
flags when we start and finish, so the kernel can work out which addresses need
to be removed.

Sponsored by:   Rubicon Communications, LLC ("Netgate")

Apply openssh-portable commit 8b6c1f402feb by deraadt@openbsd.org

Obtained from:  openssh-portable
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288773
Reported by:    wosch
Sponsored by:   The FreeBSD Foundation

Add four missing flags (INP_BINDANY, INP_INHASHLIST, INP_RESERVED_0,
INP_BOUNDFIB) used in inp_flags and remove one flag (INP_ORIGDSTADDR),
which is actually a flag used in inp_flags2 and not in inp_flags.

Reviewed by:            markj
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53498

ddb: optionally print inp when printing tcpcb

Add /i option to the ddb commands show tcpcb and show all tcpcbs,
which enables the printing of the t_inpcb.

Reviewed by:            markj
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53497

ddb: fix compilation

Fixes:          https://cgit.freebsd.org/src/commit/?id=9aa5a79e2af9 ("ddb: optionally print inp when printing tcpcb")
Sponsored by:   Netflix, Inc.

m_pullup() here will have freed the mbuf chain, but we pass back an
IP_FW_DENY without any signal that the outer loop should finish.  Thus,
rule processing continues without an mbuf and there's a chance that we
conclude that the packet may pass (but there's no mbuf remaining)
depending on the rules that follow it.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284606
Reviewed by:    ae
MFC after:      1 week

Add "-F" parameter that, when specified, instructs sockstat(1) to
only display sockets for username/UID specified.

For consistency with "-j", the last occurence of "-F" is used.

Reviewed by:            asomers
Approved by:            asomers
Differential Revision:  https://reviews.freebsd.org/D53458

After commit 530c2c30b0c7 we need to set flags to ensure that hop-by-hop
and hop limit options are included.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290407
Reviewed by:    zlei, markj
MFC after:      3 days
Fixes:          https://cgit.freebsd.org/src/commit/?id=530c2c30b0c7 ("ip6_output: Reduce cache misses on pktopts")

This is much more compact. Thanks to markj@ for suggesting the change.

Reviewed by:            markj
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53507

This is much more compact. Thanks to markj@ for suggesting the change.

Reviewed by:            markj, Peter Lei, imp, Nick Banks
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53510

* shuffle around the inp_label to give inp_flags more space since it
  can become long.
* fix the indentation of in6p_icmp6filt, in6p_cksum, and in6p_hops.

Reviewed by:            Peter Lei
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53541

When a SYN ACK is received for a listening socket, just drop it
instead of killing the SYN-cache entry and send a RST.
This closes the possibility to kill a TCP connection during its
handling in the SYN-cache.

Reviewed by:            Nick Banks, Peter Lei
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53540

Reviewed by:          markj, Peter Lei
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53542

in the ipsec_accel_sa_newkey_cb() when the SA offload is only enabled
on a specific different interface, not the current one.

Also remove no longer relevant XXX comment.

Noted and reviewed by:  slavash
Sponsored by:   NVidia networking
MFC after:      1 week

We're in the dtor, so we can't destroy it now without deadlocking after
recent changes to make destroy_dev() provide a barrier.  However, we
know there isn't any other dtor to run, so we can go ahead and clean up
our state and just prevent a use-after-free if someone races to open
the device while we're trying to destroy it.  tunopen() now uses the
net epoch to protect against softc release by a concurrent
tun_destroy().

While we're here, allow a destroy operation to proceed if we caught a
signal in cv_wait_sig() but tun_busy dropped to 0 while we were waiting
to acquire the lock.

This was more of an inherent design flaw, rather than a bug in the
below-refed commit.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290575
Fixes:  https://cgit.freebsd.org/src/commit/?id=4dbe6628179d ("devfs: make destroy_dev() a release [...]")
Reviewed by:    kib, markj
Differential Revision:  https://reviews.freebsd.org/D53438

Sponsored by: Rubicon Communications, LLC ("Netgate")

ipfilter: Add htable (hash table) tunable

This is in preparation for addition of a hash table max size.

Reviewed by:            markj
MFC after:              1 week
Differential revision:  https://reviews.freebsd.org/D53283

ipfilter: Add an htable max size tuneable.

Add an ipfilter runtime option (ipf -T) to adjust the default
maximum hash table size. Default it to 1024 entries. It will be
used by a subsequent commit to limit any damage due to excessively
large hash table input by the user.

Reviewed by:            markj
MFC after:              1 week
Differential revision:  https://reviews.freebsd.org/D53284

ipfilter: Don't trust userland supplied iph_size

ipf_htable_create() trusts a user-supplied iph_size from iphtable_t
and computes the allocation size as iph->iph_size * sizeof(*iph->iph_table)
without checking for integer overflow. A sufficiently large iph_size
causes the multiplication to wrap, resulting in an under-sized allocation
for the table pointer array. Subsequent code (e.g., in ipf_htent_insert())
can then write past the end of the allocated buffer, corrupting kernel
memory and causing DoS or potential privilege escalation.

This is not typically a problem when using the ipfilter provided
userland tools as calculate the correct lengths. This mitigates a
rogue actor calling ipfilter ioctls directly.

Reported by:            Ilja Van Sprundel <ivansprundel@ioactive.com>
Reviewed by:            markj
MFC after:              1 week
Differential revision:  https://reviews.freebsd.org/D53286

ipfilter: Add ipf_check_names_string()

ipf_check_names_string will verify userland inputs in names strings
(fr.fr_names, in.in_names) for correctness.

Original concept of ipf_check_names_string() instead of macros by
markj.

Reviewed by:            markj
MFC after:              1 week
Differential revision:  https://reviews.freebsd.org/D53843

ipfilter: Verify frentry on entry into kernel

The frentry struct is built by ipf(8), specifically ipf_y.y when parsing
the ipfilter configuration file (typically ipf.conf). frentry contains
a variable length string field at the end of the struct. This data field,
called fr_names, may contain various text strings such as NIC names,
destination list (dstlist) names, and filter rule comments.  The length
field specifies the length of fr_names within the frentry structure and
fr_size specifies the size of the frentry structure itself.

The upper bound limit to the length of strings field is controlled by the
fr_max_namelen sysctl/kenv or the max_namelen ipfilter tuneable.

The initial concepts were discussed with emaste and jrm.

Reported by:            Ilja Van Sprundel <ivansprundel@ioactive.com>
Reviewed by:            markj
MFC after:              1 week
Differential revision:  https://reviews.freebsd.org/D53843

ipfilter: Verify ipnat on entry into kernel

The ipnat struct is built by ipnat(8), specifically ipnat_y.y when
parsing the ipnat configuration file (typically ipnat.conf). ipnat
contains a variable length string field at the end of the struct. This
data field, called in_names, may contain various text strings such as
NIC names. There is no upper bound limit to the length of strings as
long as the in_namelen length field specifies the length of in_names
within the ipnat structure and in_size specifies the size of the ipnat
structure itself.

Reported by:            Ilja Van Sprundel <ivansprundel@ioactive.com>
Reviewed by:            markj
MFC after:              1 week
Differential revision:  https://reviews.freebsd.org/D53843

ipfilter: Remove unused variable

Reported by:    jlduran
Fixes:          https://cgit.freebsd.org/src/commit/?id=eda1756d0454, https://cgit.freebsd.org/src/commit/?id=821774dfbdaa
MFC after:      1 week
X-MFC with:     eda1756d0454, 821774dfbdaa

ipfilter: Restore used variable

One of the "unused" i variables is actually used.

Fixes:          https://cgit.freebsd.org/src/commit/?id=20c48f090b27

ipfilter: fix broken build

Every commit earns me a dozen emails that LINT is broken. This should
stop that.

Fixes: https://cgit.freebsd.org/src/commit/?id=eda1756d0454f ipfilter: Verify frentry on entry into kernel
Sponsored by: Netflix

Add a comment explaining why syncache entries are dropped and fix a
typo in a comment.

Reviewed by:            rrs, glebius
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D53564

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290893

Add some accessors to the key data, key length and MIC data.
Document exactly what these mean.

There's at least a couple of drivers that access the key data field
directly and assume that the TX/RX MIC is available directly after the
data pointer, which bakes in the "key size is 128 bits" in subtle ways.

The goal here is to migrate the drivers and net80211 code to use
these methods rather than accessing wk_key directly and making assumptions
about wk_key and the copied key length (which the ioctl path definitely
does.)

Once that's done, it should be a lot easier to change the key API for
larger keys.

Differential Revision:  https://reviews.freebsd.org/D52711
Reviewed by:    thj

Remove prefetching from the transmit path of iflib in the interest of
increased performance and reduced complexity. Details regarding the
performance penalties of prefetching can be found in the differential
review.

Note this prefetching was only done on link speeds of 10Gb/s and
above, so the change is a no-op (or perhaps slight performance
improvement simply due to the code simplification) for slower
interfaces.

Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D53674
Reviewed by: kbowling, markj, mjg

if_media.h: Add 400GBase-SR8 and 400GBase-CR8

Reviewed by:    bz (network)
MFC after:      1 week
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D53387

Fix typo in recently added 400G media

Reported by:    glebius
Fixes:  https://cgit.freebsd.org/src/commit/?id=2d608a4cebbd if_media.h: Add 400GBase-SR8 and 400GBase-CR8
MFC after:      1 week
Sponsored by:   Chelsio Communications

In a divert setup pf_test_state() may return PF_PASS, but not set the state
pointer. We didn't handle that, and as a result crashed immediately afterwards
trying to dereference that NULL state pointer.

Add a test case to provoke the problem.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260867
MFC after:      2 weeks
Submitted by:   Phil Budne <phil.budne@gmail.com>
Sponsored by:   Rubicon Communications, LLC ("Netgate")

The register address of link length of copper or active cable is 146 as
per the SFF-8436 specification [1].

[1] 7.6.2 Upper Memory Map Page 00h SFF-8436 Specification (pdf): https://members.snia.org/document/dl/25896

Reviewed by:    imp, zlei
MFC after:      1 week
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1885
Closes:         https://github.com/freebsd/freebsd-src/pull/1885

If we fail to obtain a new source port (pf_get_sport()) while we've
created a udp_mapping (for 'endpoint independent nat') we must free the
udp_mapping in pf_get_sport(). Otherwise the calling function will call
pf_udp_mapping_release(). This will then attempt to remove the udp_mapping from
a list it's not in, and crash.

Actually free the udp_mapping in all failure cases. While here sprinkle in a few
more assertions to ensure we don't forget leak udp_mappings and add a test case
to provoke this problem.

Reviewed by:    thj
MFC after:      1 week
See also:       https://redmine.pfsense.org/issues/16517
Sponsored by:   Rubicon Communications, LLC ("Netgate")
Differential Revision:  https://reviews.freebsd.org/D53737

IFT_ENC has special behaviour in pf we don't desire, and this also ensures that
for all interface types there is N:1:1 correspondence between if_type:dlt:header len.

Requested by:   glebius
MFC after:      1 week

Opcode handling should not fall through to the LOOKUP_DSCP type.

Reviewed by:    melifaro
Obtained from:  Yandex LLC
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53775

Recent changes to HPTS have broken an API that was somehow removed (used by user space programs for
time calculations). This commit will add back the inline function that was removed.

Differential Revision:<https://reviews.freebsd.org/D53225>

Use the same check as iflib_if_transmit() to detect when the
interface is down and return the proper error code, and also
free the mbuf.

This fixes an mbuf leak when a member of a lagg is brought
down (and probably many other scenarios).

Sponsored by: Netflix

When iterating over known addresses for the requested target host name,
skip those that are not supported by the running kernel.

MFC after:      1 week
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195231
Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D53588

No functional change intended, suggested by glebius.

Reviewed by:            rscheff, zlei, tuexen
Differential Revision:  https://reviews.freebsd.org/D53739

In c12013f5bb38 we fixed udp_mapping cleanup issues in pf_get_sport(), but
missed the static-port case (i.e. low == 0 && high == 0). We could still exit
pf_get_sport() without either inserting the udp_mapping or freeing it.

Address this and add a test case to provoke the problem.

Reviewed by:    thj
MFC after:      1 week
Sponsored by:   Rubicon Communications, LLC ("Netgate")
Differential Revision:  https://reviews.freebsd.org/D53856

This allows to immediately dereference ipfw_insn member.

bpf: remove dead code

Should have gone together with 9738277b5c66.

bpf: refactor buffer pre-allocation for BIOCSETIF

This basically refactors 4f42daa4a326f to use less indentation and
variables.  The code is still not race proof.

bpf: leave only locked version of bpf_detachd()

The unlocked one is used only once.  No functional change.

bpf: remove DDB code

With modern debugging tools it isn't useful at all and is just a
maintenance burden.

bpf: retire struct bpf_if_ext

The struct was used for bpf_if to bif_dlist masking, that is used to
optimize bpf_peers_present() call.  The only functional change here is
that bif_dlist and bif_next swap their places in the structure.  Both
belong to the first cache line anyway.

Reviewed by:            markj
Differential Revision:  https://reviews.freebsd.org/D53867

bpf: calculate net.bpf.stats buffer size dynamically

This removed the global counter, that was updated in a racy manner.

Reviewed by:            markj
Differential Revision:  https://reviews.freebsd.org/D53868

bpf: global bpf list doesn't need CK

All accesses to this list are done with the global lock held.  The
CK connotation is just confusing the reader.

Fixes:                  https://cgit.freebsd.org/src/commit/?id=699281b545a8a3fc5109b5f2db62d261b65b588b
Reviewed by:            markj
Differential Revision:  https://reviews.freebsd.org/D53869

We use the fact that all NICs that support hashing are using the
same hash algorithm and hash key to enable symmetic hashing in
TCP, where a software version of the same hash is used to
establish hashes on outgoing connections.

Sponsored by: Netflix
Reviewed by: adrian, zlei (both early version)
Differential Revision:  https://reviews.freebsd.org/D53089

Now that we can trust NICs to supply an identical hash result
to software, we can setup the inpcb hash on outgoing connections.
This gives us symmetric hashing, meaning packets should enter
and leave on the same NIC queue.

Differential Revision:  https://reviews.freebsd.org/D53104
Reviewed by: adrian, cc, kbowling, tuexen, zlei
Sponsored by: Netflix

Clear the RSS hash on transmit, now that RSS hashing is enabled
unconditionally, and the network stack may want to trust that
it is getting the correct hash on input.

Differential Revision:  https://reviews.freebsd.org/D53090
Reviewed by: zlei
Sponsored by: Netflix

Prior to commit 0c511bafdd5b309505c13c8dc7c6816686d1e103, each time
snl_realloc_msg_buffer was called, it called snl_allocz to request a
new buffer.  If an existing linear buffer was used, then after the
call, the linear buffer effectively contained the old buffer contents
followed by the new buffer (so there was definitely wasted memory),
but the linear buffer state was consistent (lb->offset correctly
accounted for both copies).  For example, if the initial linear buffer
was 256 bytes in size, lb->size would be 256.  Using 16 bytes followed
by 32 bytes would first set lb->offset to 16, then the second realloc
would allocate 48 bytes (16 + 32) setting lb->offset to 64 (16 + 48).

Commit 0c511bafdd5b309505c13c8dc7c6816686d1e103 aimed to avoid this
memory waste by resetting the base pointer to the start of the
existing linear buffer if the new allocation was later in the same
linear buffer.  This avoided some of the waste, but broke the
accounting.  Using the same example above, the second realloc would
reuse the pointer at an offset of 0, but the linear buffer would still
claim that 64 bytes was allocated via lb->offset rather than the true
allocation of 48 bytes.

One approach to fix this would be to "extend" the allocation of an
existing linear buffer where a realloc would try to increase
lb->offset without setting a new base pointer so long as there was
still room remaining in the linear buffer for the new request.

However, this change takes a simpler approach.  If snl_allocz()
returned an allocation from a new linear buffer, just claim the entire
linear buffer for use by the snl_writer ensuring the accounting is
correct in both the linear buffer and the snl writer.  With this
approach, the initial snl_writer size would be 256 bytes for a 256
byte linear buffer and would only grow if it needs to allocate an
entirely new linear buffer.

Reviewed by:    igoro
Fixes:          https://cgit.freebsd.org/src/commit/?id=0c511bafdd5b ("netlink: fix snl_writer and linear_buffer re-allocation logic")
Sponsored by:   AFRL, DARPA
Differential Revision:  https://reviews.freebsd.org/D53697

pf was too strict when validating SCTP tags. When a server receives a
retransmitted INIT it will reply with a random initiate tag every time.
However, pf saves the first initiate tag and expects every subsequent INIT_ACK
retransmission to have the same tag. This is not the case, leading to endless
INIT/INIT_ACK cycles.

Allow the tag to be updated as long as we've not gone past COOKIE_WAIT.

Add a test case to verify this.

MFC after:      2 weeks
See also:       https://redmine.pfsense.org/issues/16516
Sponsored by:   Rubicon Communications, LLC ("Netgate")

We're updating 16-bits checksums here, so should use a 16-bit integer,
not a 32-bit one.
No functional change.

Sponsored by:   Rubicon Communications, LLC ("Netgate")

During pfsync_clone_destroy() we clean up pending packets. This
may involve calling pfsync_undefer() or callout_drain(). We may not
hold the bucket lock during callout_drain(), but must hold it during
pfsync_undefer().

We incorrectly always released the lock, leading to assertion failures
during cleanup if there were pending deferred packets.

MFC after:      1 week
Sponsored by:   Orange Business Services

These were for $FreeBSD$ that was removed a while ago, but these
includes didn't get swept up in that. Remove them all now.

Sponsored by:           Netflix
MFC After:              2 weeks

The hash table is accessed in ip_divert_packet(), and there the accesses
are synchronized only by the net epoch, so plain SLIST is not safe.

Reviewed by:    ae
MFC after:      1 week
Sponsored by:   OPNsense
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D54011

tcp: store flowid info in syncache

Now retransmissions by syncache would use correct flowid, same as
synchronous responds.

Reviewed by:            tuexen, gallatin
Differential Revision:  https://reviews.freebsd.org/D51792

tcp: fix build with RSS

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291439
Fixes:  https://cgit.freebsd.org/src/commit/?id=73fe85e486d297c9c976095854c1c84007e543f0

With dd0e6bb996dc setting it always on connect(2) and syncache always
picking up the flowid from the incoming packet, any ESTABLISHED connection
shall have the flowid already set.

Reviewed by:            tuexen, gallatin
Differential Revision:  https://reviews.freebsd.org/D53886

Otherwise you just can't include pfvar.h without compiling pf in.

Reviewed by:            kp
Differential Revision:  https://reviews.freebsd.org/D54064

Sponsored by: Rubicon Communications, LLC ("Netgate")

Depreciation notice for net.inet.tcp.newsack is in 15.0.
Remove this tunable for HEAD, streamlining the code slightly.

Reviewed by:    tuexen, cc, nickbanks_netflix.com, #transport
Sponsored by:   NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D54072

It is not clear what exactly this function is locking against.  Seems
like just use some generic interface lock.  The IF_AFDATA_LOCK goes
away soon together with if_afdata[], so put at least something in its
place.

It is not clear what exactly this function is locking against.  Seems
like just use some generic interface lock.  The IF_AFDATA_LOCK goes
away soon together with if_afdata[], so put at least something in its
place.  Note that this code is dead anyway (#ifdef EXPERIMENTAL).

Reviewed by:  kp
Reported by:    Kevin Day <kevin@your.org>
MFC after:      1 week
Fixes:          https://cgit.freebsd.org/src/commit/?id=a7191e5d7b62 ("pf: add a way to list creator ids")
Differential Revision:  https://reviews.freebsd.org/D54083

- pfr_table_count() can return an error.
- We must check for failure from mallocarray(M_NOWAIT).

Fixes:          https://cgit.freebsd.org/src/commit/?id=9e8d2962aad3 ("pf: convert DIOCRGETTSTATS to netlink")
Reported by:    Kevin Day <kevin@your.org>
Reviewed by:    kp
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D54094

Add a sysctl/tunable (net.inet.ipf.jail_allowed) to control whether a
jail can manage its own ipfilter rules, pools, and settings. A jail's
control over its own ipfilter rules and settings may not be desireable.
The default is jail access to ipfilter is denied.

The host system can stil manage a jail's rules by attaching the rules,
using the on keyword, limiting the rule to the jail's interface. Or
the sysctl/tunable can be enabled to allow a jail control over its own
ipfilter rules and settings.

Implementation note: Rather than store the jail_allowed variable,
referenced by sysctl(9), in a global area, storing the variable in the
ipfilter softc is consistent with ipfilter's use of its softc.

Discussed with:         emaste, jrm
MFC after:              1 week
Differential revision:  https://reviews.freebsd.org/D53623

At the moment ipfs(8) is a tool that can be easily abused. Though the
concept is sound the implementation needs some work.

ipfs(8) should be considered experimental at the moment.

This commit also makes ipfs support in the kernel optional.

Reviewed by:            emaste, glebius
MFC after:              1 week
Differential revision:  https://reviews.freebsd.org/D53787

Add struct mtx to struct lltable and stop using IF_AFDATA_LOCK, that
was created for a completely different purpose.  No functional change
intended.

Reviewed by:            zlei, melifaro
Differential Revision:  https://reviews.freebsd.org/D54086

Avoid a possible use-after-free in the rx path.
ovpn_decrypt_rx_cb() calls ovpn_finish_rx() which releases the lock,
but continues to use the peer.
Ensure that the peer cannot be freed until we're sure all potential
users have stopped using it (i.e. have left net_epoch).

Reported by:    Kevin Day <kevin@your.org>
MFC after:      1 week
Sponsored by:   Rubicon Communications, LLC ("Netgate")

First, a bit of background on some of the data structures netlink uses
to manage data associated with a netlink connection.

- struct linear_buffer contains a single virtually-contiguous buffer
  of bytes.  Regions of this buffer are suballocated via lb_allocz()
  which uses a simple "bump" where the buffer is split into an
  allocated region at the start and a free region at the end.  Each
  allocation "bumps" the boundary (lb->offset) forward by the
  allocation size.

  Individual allocations are not freed.  Instead, the entire buffer is
  freed once all of the allocations are no longer in use.

  Linear buffers also contain an embedded link to permit chaining
  buffers together.

- snl_state contains various state for a netlink connection including
  a chain of linear buffers.  This chain of linear buffers can contain
  allocations for netlink messages as well as other ancillary data
  buffers such as socket address structures.  The chain of linear
  buffers are freed once the connection is torn down.

- snl_writer is used to construct a message written on a netlink
  connection.  It contains a single virtually-contiguous buffer
  (nw->base) allocated from the associated snl_state's linear buffer
  chain.  The buffer distinguishes between the amount of space
  reserved from the underlying allocator (nw->size) and the current
  message length actually written (nw->offset).  As new chunks of data
  (e.g. netlink attributes) are added to the write buffer, the buffer
  is grown by snl_realloc_msg_buffer by reallocating a larger buffer
  from the associated snl_state and copying over the current message
  data to the new buffer.

Commit 0c511bafdd5b309505c13c8dc7c6816686d1e103 aimed to fix two bugs
in snl_realloc_msg_buffer.

The first bug is that snl_realloc_msg_buffer originally failed to
update nw->size after growing the buffer which could result in
spurious re-allocations when growing in the future.  It also probably
could eventually lead to overflowing the buffer since each
reallocation request was just adding the new bytes needed for a chunk
to the original 'nw->size' while 'nw->offset' kept growing.
Eventually the new 'nw->offset' would be larger than 'nw->size + sz'
causing routines like snl_reserve_msg_data_raw() to return an
out-of-bounds pointer.

The second change in this commit I think was trying to fix the buffer
overflows due to 'nw->size' being wrong, but instead introduced a new
set of bugs.  The second change ignored the returned pointer from
snl_allocz() and instead assumed it could use all of the
currently-allocated data in the current linear buffer.  This is only
ok if the only data in the linear buffer chain for the associated
snl_state is the snl_writer's message buffer.  If there is any other
data allocated from the snl_state, it could be earlier in the current
linear buffer, so resetting new_base to nw->ss->lb->base can result in
overwriting that other data.  The second change was also
over-allocating storage from the underlying chain of linear buffers
(e.g. a writer allocation of 256 followed by 512 would end up using
the first 512 bytes, but 768 bytes would be reserved in the underlying
linear buffer).

To fix, revert the second change keeping only the fix for 'nw->size'
being wrong.

Reviewed by:    igoro, markj
Fixes:          https://cgit.freebsd.org/src/commit/?id=0c511bafdd5b ("netlink: fix snl_writer and linear_buffer re-allocation logic")
Sponsored by:   AFRL, DARPA
Differential Revision:  https://reviews.freebsd.org/D54148

If the TTL (or hop limit) expires during nat64 translation we may
need to send the error message in the original address family (i.e.
pre-translation).
We'd usually handle this in pf_route()/pf_route6(), but at that point we
have already translated the packet, making it difficult to include it in
the generated ICMP message.

Check for this case in pf_translate_af() and send icmp errors directly
from it.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291527
MFC after:      2 weeks
Sponsored by:   Rubicon Communications, LLC ("Netgate")
Differential Revision:  https://reviews.freebsd.org/D54166

Submitted by: lampa@fit.vutbr.cz
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291565
MFC after:      1 day

See c3fc0db3bc50df18a724e6e6b12ea4e060fd9255 for details.

This shrinks the structure a bit.  Should be no functional change.

Differential Revision:  https://reviews.freebsd.org/D53870

pfsync_state_export() takes a pointer to a union that is in reality a
pointer to one of the three state formats (1301, 1400, 1500), and zeros
the union.  The three formats do not have the same size, so zeroing is
wrong when the format isn't that which has the largest size.

Refactor a bit so that the zeroing happens at the layer where we know
which format we're dealing with.

Reported by:    CHERI
Reviewed by:    kp
MFC after:      1 week
Sponsored by:   CHERI Research Centre (EPSRC grant UKRI3001)
Differential Revision:  https://reviews.freebsd.org/D54163

If we have both af-to and min-ttl or set-tos on a single rule we didn't
apply the new ttl or tos.

That's because the scrub code still applied the change, but we
subsequently create a new header for the new address family. That's done
based on the ttl/tos saved in the struct pf_pdesc, which are the values
from the incoming packet, before the scrub modification(s).

Also update the struct pf_pdesc values when we update packets.

Reported by:    Marek Zarychta
Sponsored by:   Rubicon Communications, LLC ("Netgate")

Reviewed by:          glebius
Differential Revision:  https://reviews.freebsd.org/D54190

This makes it easier to reason about system topology, and to
potentially map applications to NIC queues by (ab)using the
mbuf flowid to select egress NIC and queue in a predictable fashion.

Differential Revision: https://reviews.freebsd.org/D54053
Reviewed by: glebius, kbowling
Sponsored by: Netflix

Commit 561dc357c2f5 changed the way we handle components in the prompt,
and accidentally resulted in the kernel-dbg component not being listed
since we now hide all components ending in "-dbg".

Add an exception for kernel-dbg to bring it back.

Fixes:  https://cgit.freebsd.org/src/commit/?id=561dc357c2f5 ("bsdinstall: Use package sets for pkgbase install")
MFC after:      3 seconds
Reviewed by:    emaste
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52826

rc: Teach netwait to wait for DAD

In some configurations, especially in jails, it is possible for the
system to boot so fast that we end up launching daemons while duplicate
address detection is still ongoing.  If that happens, said daemons may
fail to bind to IPv6 addresses, as they are still tentative.  Teach the
netwait service to wait (up to 10 seconds, by default) for the tentative
flag to vanish.

MFC after:      1 week
Reviewed by:    olce
Differential Revision:  https://reviews.freebsd.org/D51889

rc: Improve netwait DAD logic

Disable if IPv6 is not supported, and instead of 10 seconds, default to
one more than the value of net.inet6.ip6.dad_count.

Fixes:          https://cgit.freebsd.org/src/commit/?id=5ead817c3b7a ("rc: Teach netwait to wait for DAD")
Reviewed by:    bz
Differential Revision:  https://reviews.freebsd.org/D52905

List deleted entries prefixed by "#". This is consistent with other
ippool list functions.

Fixes:          https://cgit.freebsd.org/src/commit/?id=7531c434a593
MFC after:      1 week

To maintain consistency with ippool list functions, prefix deleted
entries with "#".

MFC after:      1 week

As with 7531c434a593, which dumped ippool table data in the "new"
format, print hash data in the "new" format.

MFC after:      1 week

As with 7531c434a593, which dumped ippool table data in the "new"
format, print dstlist data in the "new" format.

MFC after:      1 week

Add a new --jail option to the pkgbase script which installs
jail-specific set variants if they exist:

* "minimal" is replaced with "minimal-jail"

* A kernel is not installed.

* For sets shown in the component selection dialogue, only show the
  appropriate variant (jail or non-jail) for the target.

Modify the jail script to pass --jail to the pkgbase script.

Remove the redundant --no-kernel option, which was added in 15.0 and
was only used to install jails.

MFC after:      3000ms
Reviewed by:    ifreund_freebsdfoundation.org
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52829

Reviewed by:  kib

This version builds every module into the flua binary itself, since all
of the bootstrap tools are built -DNO_SHARED.  As a result, we also
cannot dlsym(), so we can't really discover the names of our newly
builtin modules.  Instead, just build out a linker set with all of our
luaopen_*() functions to register everything up-front.

Building in all of the modules isn't strictly necessary, but it means
that we have an example of how to add a bootstrap module everywhere you
go and one doesn't need to consider whether bootstrap flua can use a
module when writing scripts.  On my build machine, the consequence on
our binary size is an increase from around 1.6M -> 1.9M, which isn't
really that bad.

.lua modules can install into their usual path below $WORLDTMP/legacy
and we'll pick them up automagically by way of the ctor that sets up
LUA_PATH early on.

This re-lands bootstrap module support with a more sensible subset, and
after having verified that it cross-builds fine on macOS and Linux -- we
cannot do libfreebsd on !FreeBSD because it's more system header
dependant.  We also need to bootstrap libmd to bring in libhash, and
libucl + libyaml.

Reviewed by:    bapt, emaste (both previous version)
Differential Revision:  https://reviews.freebsd.org/D51890

flua: kick out the remaining builtin modules

Bootstrap flua has some magic now to handle modules by building them in
and discovering them via linker sets.  This is slightly cleaner than
always building them in and baking them into loadedlibs for both
bootstrap and system flua.

Adjust the stand build now that these three libs have their own new
homes.

Reviewed by:    bapt, emaste
Differential Revision:  https://reviews.freebsd.org/D51891

flua: move lposix back into flua for now

The real luaposix is structured differently, and our builtin version
tends to model that in its own special way.  Build it back in until we
get the shlib model just right to unbreak nuageinit, among other things.

This is a partial revert of the below-referenced commit; the other two
modules are simple, though, and were accurately split out.

Reported by:    markj
Fixes:  https://cgit.freebsd.org/src/commit/?id=b11a5709ec2b6 ("flua: kick out the remaining builtin modules")

nuageinit: require lfs where it's needed

nuageinit largely already did this, but one spot was missed -- add the
necessary require() in to get the module loaded.

Fixes:  https://cgit.freebsd.org/src/commit/?id=b11a5709ec2b6 ("flua: kick out the remaining builtin modules")

flua: unbreak the build

Local tree pollution let this escape.  *sigh*.

Pointy hat:     kevans
Pointy hat:     kevans
Pointy hat:     kevans
Fixes:  https://cgit.freebsd.org/src/commit/?id=9c7db0931d486ce ("flua: move lposix back into flua for now")

heimdal-kadmin: Add support for the -f dump option

The "-f" dump option allows a dump of the Heimdal
KDC in a format that the MIT kdb5_util command can
load into a MIT KDC's database.
This makes transitioning from the Heimdal KDC to
the current MIT one feasible without having to
re-create the KDC database from scratch.

glebius@ did the initial work, cherry picking these
commits from the Heimdal sources on github and then doing
extensive merge conflict resolution and other fixes so
that it would build.
Heimdal commit fca5399 authored by Nico Williams:
Initial commit for second approach for multiple kvno.  NOT TESTED!

Heimdal commit 57f1545 authored by Nico Williams:
Add support for writing to KDB and dumping HDB to MIT KDB dump format
    Before this change Heimdal could read KDBs.  Now it can write to
    them too.

    Heimdal can now also dump HDBs (including KDBs) in MIT format,
    which can then be imported with kdb5_util load.

    This is intended to help in migrations from MIT to Heimdal by
    allowing migrations from Heimdal to MIT so that it is possible
    to rollback from Heimdal to MIT should there be any issues.  The
    idea is to allow a) running Heimdal kdc/kadmind with a KDB, or
    b) running Heimdal with an HDB converted from a KDB and then
    rollback by dumping the HDB and loading a KDB.

    Note that not all TL data types are supported, only two: last
    password change and modify-by.  This is the minimum necessary.
    PKINIT users may need to add support for KRB5_TL_USER_CERTIFICATE,
    and for databases with K/M history we may need to add KRB5_TL_MKVNO
    support.

This resulted in a Heimdal kadmin that would dump
the KDC database in MIT format.  However, there
were issues when this dump was loaded into the
current MIT KDC in FreeBSD current/15.0.

The changes I did to make the dump more useful are listed below:
When "-f MIT" is used for "kadmin -l dump" it writes
the dump out in MIT format.  This dump format is understood
by the MIT kdb5_util command.  The patch modifies the above
so that the MIT KDC's master key keytab file can be provided
as the argument to "-f" so that the principals are re-encrypted in
it. This allows any principal with at least one strong encryption
type key to work without needing a change_password.
The strong encryption types supported by the Heimdal KDC are:
aes256-cts-hmac-sha1-96
aes128-cts-hmac-sha1-96

The issues my changes address are:
- If there are weak encryption keys in a principal's entry,
  MIT's kadmin.local will report that the principcal's entry
  is incomplete or corrupted.
- The keys are encrypted in Heimdal's master key.  The
  "-d" option can be used on the "kadmin -l dump" to
  de-encrypt them, but the passwords will not work on the
  current MIT KDC.

To try and deal with the above issues, this patch modied the above to:
- Does not dump the weak keys.
- Re-encrypts the strong keys in MIT's master key if the argument
  to "-f" is actually a filename which holds the MIT KDC's
  master key keytab and not "MIT".
- For principals that only have weak keys, it generates
  a fake strong key. This key will not work on the MIT
  KDC, but the principal entry will work once a
  change_password is done to it.
- It always generates a "modified_by" entry, faking one if
  not already present in the Heimdal KDC database.
  This was necessary, since the MIT kadmin will
  report that the principal entry is "incomplete or
  corrupted" without one.

It also fixed a problem where "get principal" no longer
worked after the initial patch was applied.

A man page update will be done as a separate commit.

I believe this commit is acceptable since the Heimdal
sources are now essentially deprecated in favor of the
MIT sources and that this new "-f" patch simplifies
the transition to the MIT KDC.

Discussed with: glebius, cy
MFC after:      3 days

kadmin.8: Document the new dump -f flag

Commit 5000d023a446 added a new flag to the dump option.

This patch documents this new flag.

This is a content change.

MFC after: 3 days
Fixes:  https://cgit.freebsd.org/src/commit/?id=5000d023a446 ("heimdal-kadmin: Add support for the -f dump option")

When loading a new rule only persist the ticket if we're actually looking at a
filter rule. We need that ticket type later if we have to create tables, but we
need the ticket for the correct ruleset.

Fixes:  https://cgit.freebsd.org/src/commit/?id=9dfc5e03da50 ("pfctl: allow tables to be defined inside anchors")
Reported by:    Florian Smeets <flo@smeets.xyz>
MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289994
Sponsored by:   Rubicon Communications, LLC ("Netgate")

What we really want here is to know if pointers can refer to 64-bit
addresses, regardless of whether they also hold other information (such
as capabilities in CHERI).  __SIZEOF_SIZE_T__ is probably the closest
indication to that piece of information, so let's use it.  __ILP32__
wasn't wrong in practice though, as we don't support 32-bit CHERI
hardware (and likely never will).

Consistently with this change, test whether we can actually address the
64-bit SMBIOS's structure table by converting the end address to
'size_t' and checking whether its value is preserved.

Suggested by:   jhb (for the __ILP32__ => __SIZEOF_SIZE_T__ part)
Reviewed by:    jhb, imp
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D49318

krb5: create the KDC database directory

Reviewed by:            rmacklem, cy
Differential Revision:  https://reviews.freebsd.org/D52970

etc/mtree: Add package tags for Kerberos directories

Fixes:          https://cgit.freebsd.org/src/commit/?id=e7e7bf757ace ("krb5: create the KDC database directory")
MFC after:      3 seconds
Reviewed by:    cy
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52975

This fixes some missing directories, notably /boot/modules.  Other
directories are not missing because they contain other files, but
they should still have their own METALOG entries and be placed in
the correct package.

MFC after:      3 days
Reported by:    bdrewery
Reviewed by:    cperciva, imp
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52958

MFC after:    1 week
Reviewed by:    ae
Differential Revision:  https://reviews.freebsd.org/D52951

MFC after:    1 week
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.

After commit 900bc0206348, zpool depends on mountcritlocal.  zpoolreguid
and zpoolupgrade depend on zpool and want to run before mountcritcycle,
so we have a pair of cycles.

Update zpoolreguid and zpoolupgrade to avoid this.

Reviewed by:    des
MFC after:      3 days
Fixes:  https://cgit.freebsd.org/src/commit/?id=900bc0206348 ("rc.d/zpool: change mountcritlocal dep from BEFORE to REQUIRE")
Differential Revision:  https://reviews.freebsd.org/D52953

Reviewed by:  des
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D52954

nfsuserd: Fix OOB access on membership of too many groups

getgrouplist() sets the variable containing the allocated length in
input to the full effective group list length, not the number of slots
that were actually filled in case the passed array is too small to
contain it.

While here, on this condition, improve the error message by outputting
the corresponding user name.

MFC after:      1 hour
Fixes:          https://cgit.freebsd.org/src/commit/?id=e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.")
Sponsored by:   The FreeBSD Foundation

nfsuserd: Fix OOB access on membership of too many groups, take 2

Forgot to reset 'ngroup' after one of the calls to getgrouplist() in the
previous commit with same title (referenced also below).

MFC after:      1 hour
Fixes:          https://cgit.freebsd.org/src/commit/?id=e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.")
Fixes:          https://cgit.freebsd.org/src/commit/?id=bb339adfb2a2 ("nfsuserd: Fix OOB access on membership of too many groups")
Sponsored by:   The FreeBSD Foundation

Appease GCC.

Reviewed by:    kib
Differential Revision:  https://reviews.freebsd.org/D52941

sndiod is part of audio/sndio, so we should avoid referencing a port
utility from base.

We should also require NETWORKING for the service to start, since
virtual_oss can be configured to send audio through the network.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 day
Reviewed by:    des, markj, emaste
Differential Revision:  https://reviews.freebsd.org/D53019

PR#289734 reports a crash in tcp_use_close() when the rpc.tlsservd
daemon is being used.  Although I have no, as yet, had time to track
down/fix the race, it turns out setting rpctls_maxthreads to 1
avoids the problem.

This patch pins rpctls_maxthreads to 1 to avoid the problem,
until there is a proper fix.

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289734
MFC after:      3 days

Have the button labels refer to the artifact type directly (distribution
sets / packages), and use "Tech Preview" as packaged base is no longer
experimental.

Reviewed by:    ivy, cperciva
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52999

The port is called wifi-firmware-mt76-kmod not "mediatek" in the
moddle.

Reported by:    Lars Tunkrans (drsnx60 gmail.com)
MFC after:      3 days
Reviewed by:    emaste, jrm, imp
Differential Revision: https://reviews.freebsd.org/D53067

Submitted-by: Johan Söllvander
MFC-after:    1 week
Differential Revision: https://reviews.freebsd.org/D37615

table_do_modify_record() already uses errno value on error.
Also this fixes problem when `ipfw table add` returns ENOTTY that
is unrelated to operation.

Tested by:      dhw
Fixes:          https://cgit.freebsd.org/src/commit/?id=09025a714708
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53050

calcsb is unused since the logic moved to sbsearch / ffs_sbsearch in
e68866164212 ("Move the ability to search for alternate UFS superblocks
from fsck_ffs(8) into ffs_sbsearch() to allow use by other parts of the
system.")

Reviewed by:    mckusick
Differential Revision:  https://reviews.freebsd.org/D53038

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251993
Reviewed by:    cperciva
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53106

PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290232
Reported by:    David Marker <dave@freedave.net>
Fixes:          https://cgit.freebsd.org/src/commit/?id=aa34b1d20e44 ("vmrun.sh: Add arm64 support")
MFC after:      3 days

Reviewed by:  emaste
MFC after:      1 hour
Differential Revision:  https://reviews.freebsd.org/D34598

Tests that fail are in
/root/.kyua/store/results.usr_tests_sys_geom_class_multipath.20251015-085403-959737.db

Submitted-by: Johan Söllvander
MFC-after:    1 week
Differential Revision: https://reviews.freebsd.org/D53110

The old rtsock implementation used in-kernel workaround to do so.
When route to specified destination address used P2P interface, the
kernel did the search with ifa_ifwithnet() for most suitable network
and then add proxy entry to this interface.

Use similar approach with netlink implementation. We already have
get_ether_addr() function that does almost the same thing as
ifa_ifwithnet(). Use it when we find that destination route uses
P2P interface and then try to guess suitable interface. This should
fix the use of netlink-based arp(8) in mpd5.

Rename get_ether_addr() to get_ifinfo(), since now it is used to find
only ifindex in case when hwaddr is specified by user.
Also make set_nl() and delete_nl() prototype similar to rtsock.
And allow '-i' to be used with '-S', since we already allow the same
for '-s'.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290221
Reported by:    eugen
Reviewed by:    eugen
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53113

quot: Fix benign buffer overflow

If it encounters an inode whose owner does not have a pw entry, quot
allocates a 7-byte buffer (8 in practice, since that is the minimum
allocation size) and uses it to store the numeric uid preceded by a
hash character.  This will overflow the allocated buffer if the UID
exceeds 6 decimal digits.  Avoid this by using asprintf() instead.

While here, simplify the common case as well using strdup().

Reported by:    Igor Gabriel Sousa e Souza <igor@bsdtrust.com>
MFC after:      3 days
Reviewed by:    obiwac, emaste
Differential Revision:  https://reviews.freebsd.org/D53129

quot: Clean up

* Fix numerous style violations.
* Modernize somewhat.
* Don't bother examining errno after calling get_inode(), as it always
  exits on error.
* Fix confusing wording in the manual page.

The code remains somewhat idiosyncratic, e.g. in its insistance on
counting down rather than up in simple for loops, but in the absence
of comprehensive automated tests, the risk of introducing bugs exceeds
the benefit of rewriting these into more idiomatic forms.

Reviewed by:    obiwac
Differential Revision:  https://reviews.freebsd.org/D53130

quot: Drop the COMPAT version

We've had this code for 30 years, but there has never been a way to
build it.  We have no idea if it still works, or if it ever worked.

Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D53131

quot: Drop the -h option

There was probably a time, more than 30 years ago, when the actual
size of a file had to be calculated and this option saved time, but
all it does today is give incorrect results for no benefit.

Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D53132

Sponsored by: The FreeBSD Foundation
MFC after:      1 day
Differential Revision:  https://reviews.freebsd.org/D53175

Sponsored by: The FreeBSD Foundation
MFC after:      1 day
Reviewed by:    emaste
Differential Revision:  https://reviews.freebsd.org/D53174

Allow umask to be configurable.

Being able to set the umask via an rc variable is useful when setting:

    security.bsd.unprivileged_read_msgbuf=0

As it allows a user to configure:

    dmesg_umask="066"

Without modifying the rc script, and preventing the contents of the
$dmesg_file (/var/run/dmesg.boot) from being publicly readable.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272552
Reviewed by:    netchild
MFC after:      2 days
Differential Revision:  https://reviews.freebsd.org/D53169

Also fix some typos and move a couple NULL checks earlier.

Reviewed by:    mckusick, Johan Söllvander, markj, kevans, adrian
Fixes:          https://cgit.freebsd.org/src/commit/?id=0d4642a67e59f8da5e00a05001c342bdad2a806f
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D53180

Fixes:                https://cgit.freebsd.org/src/commit/?id=195b00ec45e5 ("quot: Clean up")
Reviewed by:    rlibby
Differential Revision:  https://reviews.freebsd.org/D53224

bfb202c4554a addresses the CTRL-EVENT-SCAN-FAILED. Upstream d807e289d
caused FreeBSD regression in driver_bsd.c, which this rc.d patch
worked around. As of bfb202c4554a this workaround is no longer needed.

052211e08c0e implemented this change for wpa_supplicant but not for
hostapd.

Reported by:    avg
MFC after:      3 days

Currently mod_play_vchans() and mod_rec_vchans() run unconditionally,
even if the direction (playback, recording) is not supported by the
device. This results in the "autoconv" (see mod_autoconv()) control
failing when run on simplex devices, because we'll be trying to modify
vchans on an unsupported direction.

Test whether the direction is supported and silently move on if it
isn't.

Sponsored by:   The FreeBSD Foundation
MFC after:      4 days
Differential Revision:  https://reviews.freebsd.org/D53233

The menu was incorrectly using the fourth column (distname) instead of
the first (dist) of the MANIFEST.

The actual file name is on the first column of the MANIFEST file.
Remove the .txz part of the name to build the menu options.

Reviewed by:    jamie
MFC after:      5 days
Differential Revision:  https://reviews.freebsd.org/D53177

Dummynet v3 switched to IP_DUMMYNET3 but did not update these
warnings/errors.

Fixes: https://cgit.freebsd.org/src/commit/?id=cc4d3c30ea28 ("Bring in the most recent version of ipfw and dummynet, developed")
Sponsored by:   The FreeBSD Foundation
Differential Revision: sbin/ipfw/ipfw2.c

IP_DUMMYNET_GET is no longer used in ipfw(1).

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53348

Signed-off-by: Quentin Thébault <quentin.thebault@defenso.fr>

Reviewed by:    markj
MFC after:      1 month
Sponsored by:   Defenso
Differential Revision:  https://reviews.freebsd.org/D52542
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1880

The failed allocation in the error pertains to IP_FW_XADD, not
IP_FW_ADD.

Reviewed by:    ae
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53359

The blocklist daemon depends on a packet filter in order to block.

Add all supported packet filters to the REQUIRE line, not just pf, to
indicate rcorder(8) that it should start after the packet filter service
has started.

While here, change the mode of the rc file to include the executable
bit, just like the rest of the files in the rc.d source directory.

Reviewed by:    0mp
MFC after:      2 days
Differential Revision:  https://reviews.freebsd.org/D53364

All of the do_cmd() calls are in dummynet.c and specify the socket
option at compile time; none of these removed cases are used in ipfw
after the v3 work.

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53378

Avoid emitting a warning if there is no Ethernet anchor.  If the anchor
--regardless of its type-- is nonexistent, should be caught earlier.

This can be misleading when there is a layer 3 anchor but not an
Ethernet anchor, giving the user the impression that there is no layer 3
anchor with that name.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280516
Approved by:    kp
MFC after:      2 days
Differential Revision:  https://reviews.freebsd.org/D53360

Instead of sleeping after pwait returns, use its new -p option to
obtain the list of processes that still have not terminated.

MFC after:      3 days
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290357
Fixes:          https://cgit.freebsd.org/src/commit/?id=5953e7c98427 ("rc.subr: Move the sleep in wait_for_pids")
Reviewed by:    0mp, markj
Differential Revision:  https://reviews.freebsd.org/D53294

It is deprecated but was not removed prior to 15.0.

Sponsored by:   The FreeBSD Foundation

Commit 53d0b9e438bc ("pmc: Provide full path to modules from kernel
linker") made pmcstat's -k option have no effect, but the option was
retained for backwards compatibility (while emitting a warning that
-k is not in FreeBSD 15).

Reviewed by:    jrtc27
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53397

Arm restore atexit(3) handler if and only if the pf(4)
limits are being changed to prevent bogus error messages
on stderr.

OK @bluhm

Obtained from:  OpenBSD, sashan <sashan@openbsd.org>, 67a69daaf0
Sponsored by:   Rubicon Communications, LLC ("Netgate")

Files read by '.' cannot workout for themselves where they are
or what they are called, so set dot_dir and dot_file to pass
this information to them.

Reviewed by:    obrien, stevek
Differential Revision:  https://reviews.freebsd.org/D53476

Apply OpenBSD env.c,v 1.24 and 1.25, which replaces manual size
calculations with reallocarray() to prevent possible integer
overflow.

MFC after:      3 days

Changes based on comments in D53110: tags should be lowercase; rename a
few containers so that the JSON/XML output says "DISK" or "MULTIPATH"
(depending on class) instead of a generic "Geom"; adds {t:} to trim
extra whitespaces that sometimes appeared in the value fields of
JSON/XML output.

Submitted-by: Johan Söllvander
MFC-after:    1 week
Differential Revision: https://reviews.freebsd.org/D53313

parse_vlans() does 's = strdup(str)', then calls strsep(&s, ...), then
attempts to free(s) at the end of the function.  For the success case,
this is fine (s is NULL, so it's a trivial memory leak), but in the
error case, we will attempt to free an invalid pointer.

Fix this by storing the original return value from strdup() and freeing
that instead.

MFC after:      3 seconds
Reported by:    David Gwynne <dlg@openbsd.org>
Reviewed by:    zlei, kevans
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53545

etc/mtree: Add package tags for /usr/include

Set the default package to clibs-dev, since that's where the vast
majority of include files comes from.  Add explicit package tags
for the directories which are installed in their own package.

MFC after:      1 day
Reviewed by:    emaste
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53577

etc/mtree/BSD.include.dist: Remove libipt-dev

This package only exists on amd64, which means on other platforms we
produce an empty package containing nothing but this directory, and
without a base package (libipt) that package fails to install due to
a missing dependency.

For now, fix this by removing the libipt-dev package tag, which moves
this directory to clibs.

Fixes: https://cgit.freebsd.org/src/commit/?id=436618a427b4 ("etc/mtree: Add package tags for /usr/include")
Reported by:    cperciva
MFC after:      3 seconds

It serves no purpose to manually manage the IPF_NUM_ERRORS count.
Calculate it instead.

Reviewed by:            emaste, markj
MFC after:              1 week
Differential revision:  https://reviews.freebsd.org/D53308

There is a pool feature, dynamic_gang_header, that is enabled by default
in new pools.  When this feature is active, gang headers may be larger
than 512 bytes.  The loader needs to be taught to cope with that.

Try using the vdev ashift to pick the gang block header size.  If the
checksum fails, fall back to the old gang block header size.

This is based on a patch by Paul Dagnelie, with testing, bug-fixing and
some simplifications from me.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289690
Co-authored by: Paul Dagnelie <paul.dagnelie@klarasystems.com>
Reviewed by:    imp
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D53578

Unbootstrapped pkg will ignore -N if -r is specified first.  Flip the
order.

Prior to commit 66c75fa63aff this worked by accident.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290393
Reported by:    olgeni
MFC after:      3 days
Fixes:          https://cgit.freebsd.org/src/commit/?id=66c75fa63aff ("freebsd-update: Fix the pkgbase check")