FreeBSD git weekly: 2026-08-24 to 2026-08-30

Introduction

This is a display of mostly-automatically-classified git commits from 2026-08-24 to 2026-08-30.

This report is still in progress.

Table of contents and commits per category:

Highlighted commits Expand section Collapse section

For extra visibility, these are copies of commits found in other sections. Most (if not all) come from the commit message containing "Relnotes:", or commits modifying UPDATING.

-- no commits in this category this week --

Userland programs Expand section Collapse section

Commits about commands found in man section 1 (other than networking).

-- no commits in this category this week --

Documentation Expand section Collapse section

Man pages, release notes, etc.

-- no commits in this category this week --

Hardware support Expand section Collapse section

Hardware drivers and architecture-specific code.

-- no commits in this category this week --

Networking Expand section Collapse section

Network-related commands, library, and kernel.

-- no commits in this category this week --

System administration Expand section Collapse section

Stuff in man section 8 (other than networking).

-- no commits in this category this week --

Libraries Expand section Collapse section

libusb_hotplug_register_callback() runs the newly registered callback
over the already-enumerated device list when LIBUSB_HOTPLUG_ENUMERATE
is set.  A hotplug callback returning non-zero means "deregister me",
and the enumerate loop honours that by freeing the handle and setting
it to NULL.

Since commit 6bda9f26d2ed changed libusb_hotplug_callback_handle from a
pointer to an int, the tail of the function unconditionally dereferences
that handle, so any caller that passes LIBUSB_HOTPLUG_ENUMERATE, a
non-NULL handle pointer, and a callback that returns non-zero on a
matching device crashes inside libusb.  This is a normal usage pattern
and it was safe before the conversion, when the equivalent line simply
stored NULL.

Report the reserved id 0 instead.  The allocator hands out ids starting
at 1, and libusb_hotplug_deregister_callback() already ignores 0, so
this restores the pre-conversion behaviour.

Signed-off-by: yuvrajnode <yuvrajsinghrock1221@gmail.com>
Reviewed by:    aokblast
Fixes:  https://cgit.freebsd.org/src/commit/?id=6bda9f26d2ed ("libusb: change callback register handler to int")
Pull Request:   https://github.com/freebsd/freebsd-src/pull/2383
Closes:         https://github.com/freebsd/freebsd-src/pull/2383

libusb_hotplug_register_callback() resolves its context with
GET_CONTEXT() and then immediately reads ctx->no_discovery and
ctx->usb_event_mode, but only checks "ctx == NULL" afterwards.

GET_CONTEXT() falls back to usbi_default_context, which is NULL before
libusb_init() and is reset to NULL by libusb_exit().  An application
that calls libusb_hotplug_register_callback(NULL, ...) without an
initialised default context therefore crashes on the ctx->no_discovery
read, instead of getting the LIBUSB_ERROR_INVALID_PARAM the existing
guard was clearly written to return.

Move the argument validation ahead of the first dereference.  None of
the validated arguments depend on the context, so no other ordering
constraint is affected.

Signed-off-by: yuvrajnode <yuvrajsinghrock1221@gmail.com>
Reviewed by:    aokblast
MFC after:      2 weeks
Pull Request:   https://github.com/freebsd/freebsd-src/pull/2384
Closes:         https://github.com/freebsd/freebsd-src/pull/2384

Filesystems Expand section Collapse section

-- no commits in this category this week --

Kernel Expand section Collapse section

Kernel stuff (other than networking, filesystems, and drivers).

-- no commits in this category this week --

Build system Expand section Collapse section

-- no commits in this category this week --

Internal organizational stuff Expand section Collapse section

-- no commits in this category this week --

Testing Expand section Collapse section

-- no commits in this category this week --

Style, typos, and comments Expand section Collapse section

These could go in other categories, but it's more clear if they're here instead.

-- no commits in this category this week --

Contrib code Expand section Collapse section

-- no commits in this category this week --

Reverted commits Expand section Collapse section

-- no commits in this category this week --

Unclassified commits Expand section Collapse section

Not classified automatically, and waiting for manual attention.

-- no commits in this category this week --

Technical notes

Dates:

• The dates are "approximate" because git has no record of exactly when each commit was added. The "author date" and "commit date" are text fields controlled by each committer, not the actual date the commit reaches cgit.freebsd.org/src. Git accurately records the order of commits, but not their dates.

Automatic grouping:

• "Commit & revert pair" groups were automatically grouped when a commit's (full) message contained

  This reverts commit \\b([0-9a-fA-F]{40})\\b

  and the hash was found in this week's commits.
• "Commit group #" groups were automatically grouped when 3 or more consecutive commits by the same author had the same category and summary prefix.

Automatic categories:

• Commits were (mostly) automatically classified based on regex pattern-matching on the commit's modified files, summary, or the whole commit message. The goal is to have the system automatically classify 95% of the commits, with 95% accuracy; then we'll manually check the results and fix the incorrectly-classified and unclassified commits.

Source code:

• https://github.com/Tarsnap/freebsd-git-weekly