This is a display of mostly-automatically-classified git commits from 2026-11-16 to 2026-11-22.
This report is still in progress.
DEBUG: This version of the report is primarily for checking the classifiers, and therefore contains extra information (in this colour).
Table of contents and commits per category:
| (0) | Highlighted commits (these are copies, not in stats) | |
| 4 | 13.8% | Userland programs |
| 1 | 3.4% | Documentation |
| 4 | 13.8% | Hardware support |
| 5 | 17.2% | Networking |
| 4 | 13.8% | System administration |
| 2 | 6.9% | Libraries |
| 0 | 0.0% | Filesystems |
| 4 | 13.8% | Kernel |
| 1 | 3.4% | Build system |
| 0 | 0.0% | Internal organizational stuff |
| 3 | 10.3% | Testing |
| 1 | 3.4% | Style, typos, and comments |
| 0 | 0.0% | Contrib code |
| 0 | 0.0% | Reverted commits |
| 0 | 0.0% | Unclassified commits |
| 29 | 100% | total |
| Technical notes about this page |
debug: info about the automatic classification
| num | % | num changed | stage |
|---|---|---|---|
| 1 | 3.4% | 0 | 01-style |
| 2 | 6.9% | 0 | 02-filenames_wildcards |
| 3 | 10.3% | 0 | 02b-filenames_wildcards2 |
| 12 | 41.4% | 0 | 03-filenames_plain1 |
| 11 | 37.9% | 0 | 04-filenames_plain2 |
| 0 | 0.0% | 0 | Manually-classified commits |
| 0 | 0.0% | 0 | Unclassified commits |
debug: more stats
| num | % | stage |
|---|---|---|
| 0 | 0.0% | Misclassified commits |
| 29 | 100.0% | Classified commits, no corrections |
debug: groups
| 0 | 0.0% | num in revert |
| 0 | 0.0% | num in fixes |
| 0 | 0.0% | num in consecutive |
| 0 | 0.0% | Commits in groups |
For extra visibility, these are copies of commits found in
other sections. Most (if not all) come from the commit message
containing "Relnotes:", or commits modifying
UPDATING.
-- no commits in this category this week --
Commits about commands found in man section 1 (other than networking).
There is a heap overflow for screenbuf originating from the top import to the tree. The i_process()/u_process() functions write a terminating NUL one byte past each screenbuf line slot when the line fills the slot, which is a 1-byte heap overflow on the last slot. The display_resize() function allocates screen_width bytes per line. i_process() and u_process() cut lines to screen_width characters and then stpcpy() them into the slot, which writes screen_width + 1 bytes. line_update() can do the same with *old = ch. For inner slots, the NUL lands in byte 0 of the next slot. This can corrupt the saved contents used when updating the next line. For the last slot, it writes one byte past the end of screenbuf. Fix by allocating (screen_width + 1) bytes per line and updating the line offsets to fit the terminating NUL. Reviewed by: kib Reported by: llm-postcr MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D61593
debug: classified in
04-filenames_plain2 by
'usr.bin/'
powerpc64 is getting the same PROC_LA_CTL interface as amd64, but calls the full address space la52 instead of la57. Take the mode name and the constants from whichever one machine/procctl.h defines. Reviewed by: kib MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D61331
debug: classified in
04-filenames_plain2 by
'usr.bin/'
The 0x40 feature bit is la57 on amd64 and la52 on powerpc64. Tag each feature with the machine it belongs to and only accept and show the names that match the file's e_machine, so la57 is only known for amd64 files and la52 only for powerpc64 ones. Reviewed by: kib MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D61331
debug: classified in
04-filenames_plain2 by
'usr.bin/'
Use copy_file_range(2) instead of our own inefficient and unreliable attempt at detecting holes. If copy_file_range(2) is not available, which in theory should be never, we fall back to a simple read(2) / write(2) loop which makes no attempt to copy holes. This should speed up pax copy mode and cpio passthrough mode significantly. This includes refactoring much of the existing I/O code to use the size_t and ssize_t instead of int where appropriate. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: obiwac Differential Revision: https://reviews.freebsd.org/D58470
debug: classified in
03-filenames_plain1 by 'bin/'
Man pages, release notes, etc.
The default indent did not serve well. No content change. MFC after: 3 days
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Hardware drivers and architecture-specific code.
If the mps/mpr(4) device has corrupted or missing firmware then it will fail to attach. Add an interface to use firmware(9) to load the firmware at boot. Loosely based on https://github.com/marcan/lsirec/ Assisted-by: Claude Code (Opus 5) Reviewed by: imp Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D59854
debug: classified in
03-filenames_plain1 by
'sys/dev/'
midi(4) stopped being a module in 45bb10e0ed5a ("sound: Stop building
midi as a module"), so snd_cmi(4) and snd_emu10k1(4) fail to load
because they still depend on it.
Fixes: https://cgit.freebsd.org/src/commit/?id=45bb10e0ed5a ("sound: Stop building midi as a module")
Sponsored by: The FreeBSD Foundation
MFC after: 1 day
debug: classified in
03-filenames_plain1 by
'sys/dev/'
The error path of the SNAPSHOT_*_OR_LEAVE() macros jumped past VRTC_UNLOCK() and returned with the vrtc lock held. Signed-off-by: Wanpeng Qian <wanpengqian@gmail.com> Reviewed by: bnovkov, markj, jhb Sponsored by: keelos.dev Differential Revision: https://reviews.freebsd.org/D60232
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
The callout of the periodic interrupt was rearmed from its handler with a timeout of one period from the time the handler ran. Each period was longer than programmed by the latency of the callout, so the interrupt came at a lower rate than the guest asked for. A guest that counts these interrupts to keep its time runs slow. Give the callout absolute deadlines one period apart, as vatpit does. If a deadline has already passed when it is computed, for instance after the VM was paused, start again from the current time. Signed-off-by: Wanpeng Qian <wanpengqian@gmail.com> Reviewed by: jhb Sponsored by: keelos.dev Differential Revision: https://reviews.freebsd.org/D60233
debug: classified in
03-filenames_plain1 by
'sys/amd64/'
Network-related commands, library, and kernel.
Outbound IPsec packets retain the flow ID of the inner traffic. Multi-queue
interfaces use this ID to select a transmit queue (iflib's QIDX()) or a member
port (lagg(4) with use_flowid). Consequently, packets belonging to the same
security association (SA) can be distributed across independently draining
queues.
ESP and AH sequence numbers are assigned before encryption, but the packets
can be transmitted out of order when different queues drain at different
rates. This can cause legitimate packets to fall outside the receiver's
anti-replay window and be dropped as possible replays. RFC 4303, Section
3.4.3, makes 32 packets the smallest window a receiver must support, and
strongSwan installs that minimum by default.
Assign each SA a flow ID derived from a Jenkins hash of its SPI, computed once
when the SA is created, from the SPI in host byte order so that the value is
the same on every architecture. Set this ID on outbound packets in
ipsec{4,6}_perform_request(), with M_HASHTYPE_OPAQUE_HASH, once the SA is
known and before ipsec_accel_output(): it then applies whether the SA is
processed in software (ESP, AH, and IPCOMP) or by a network interface that
implements it, since the offload path keeps the packet header and hands the
packet to the interface's own transmit queue selection, and in a bundle the
last SA decides. Whether the flow ID selects the queue is up to the consumer:
a driver with its own selection (iflib's isc_txq_select) may ignore it.
Hashing the SPI distributes SAs across transmit queues regardless of whether
the queue-selection mechanism uses low-order bits (iflib) or shifted
high-order bits (lagg(4) with flowid_shift). It also avoids the poor
distribution that consecutive manually assigned SPIs would produce if used
directly.
All packets belonging to an SA now select the same transmit queue,
eliminating reordering caused by independently draining queues. Reordering
before enqueue, including skew in asynchronous crypto completion, remains
possible and is addressed separately.
Binding an SA to one transmit queue also binds it to one port or path when
using lagg(4) with use_flowid or flow-ID-based multipath routing. This trades
parallelism within an SA for packet ordering. Scaling a tunnel across
multiple queues is instead possible with multiple SAs, each with its own
sequence-number space, as supported by RFC 9611's per-resource Child SAs or
by separate policies or interfaces.
The net.inet.ipsec.sa_flowid sysctl restores the previous inner-flow-based
selection.
Reviewed by: kib, ae
MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D61194
debug: classified in
03-filenames_plain1 by
'sys/netipsec/'
ipsec4_perform_request() maps unmapped (M_EXTPG) mbufs before the software transforms run. mb_unmapped_to_ext() frees the chain when it fails, and the error return then kept both the SA reference taken by ipsec4_allocsa() and the SP reference that this function must release. The SA, its crypto session and the SP were never freed after they were deleted. The conversion fails with ENOMEM when an mbuf allocation fails, for example for sendfile(2) data sent through a software IPv4 SA, and with EINVAL for every packet of a NIC kTLS connection that matches an IPsec policy. Take the common error path instead; it skips m_freem() when the mbuf pointer is NULL. IPv6 is not affected: ipsec6_perform_request() does not call mb_unmapped_to_ext(). Reported by: llm-postcr Fixes: https://cgit.freebsd.org/src/commit/?id=0ff2d00d2aa3 ("ipsec: allow it to work with unmapped mbufs") MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by
'sys/netipsec/'
When checking for a full sized segment, take all TCP options that will be included into account. This fixes a bug which can trigger the "sent too much" KASSERT related to limited transmit. Reported by: olivier Reviewed by: rscheff, Peter Lei MFC after: 3 days MFC to: stable/15 MFC to: stable/14 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D61605
debug: classified in
03-filenames_plain1 by
'sys/netinet/'
When a crypto driver unregisters, a request on one of its sessions completes with EAGAIN. The ESP, AH and IPComp callbacks then move the SA to the new session and pass the same request to crypto_dispatch() again, with crp_etype still set to EAGAIN. crypto_dispatch() requires a request without an error. A kernel with INVARIANTS panics there with "incoming crp with error". The other consumers that dispatch a request again after EAGAIN clear the field first. The six callbacks prepare the request for the retry with the same code. Move that code to a new function, ipsec_crypto_retry(), and clear the error there. ipsec_updateid() has no other callers and becomes static. The callbacks still dispatch the request themselves, because the input callbacks have to release the sahtree lock first. Reviewed by: markj, kib Fixes: https://cgit.freebsd.org/src/commit/?id=c03414326909 ("Refactor driver and consumer...") MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D61515
debug: classified in
03-filenames_plain1 by
'sys/netipsec/'
nat44_get_log() compared the user buffer length against the request
header plus another ipfw_obj_header instead of the request header plus
the log buffer. A buffer that passed this check but was shorter than
the full reply left too little room in the sockopt window, so
ipfw_get_sopt_space() returned NULL and the following memcpy() of the
log wrote through a NULL pointer, panicking the kernel.
The handler was cloned from nat44_get_cfg() in the commit below, under
the convention of that time where ucfg->size held the payload only and
the ipfw_obj_header was added back in the length check. 9f925e8a920e
("Fix IP_FW_NAT44_LIST_NAT size calculation.") later switched
nat44_get_cfg() to count the header in ucfg->size and reduced its check
to "valsize < size", but nat44_get_log() was not updated. It kept the
stale idiom, whose check counts the header twice, and by coincidence of
the struct sizes that never leaves room for the log.
Compare against the full reply length and check the result of
ipfw_get_sopt_space(). Also report the full reply length, including
the ipfw_obj_header, in the size field returned with ENOMEM, as
nat44_get_cfg() now does: ipfw(8) retries with that value, and the old
one was itself too short to pass the check.
Add tests:
getlog_short_buffer - every buffer shorter than the reply gets ENOMEM
and the reply length; the reply length works.
getlog_retry - a retry with the length reported along with
ENOMEM succeeds.
Without the fix, getlog_short_buffer panics the kernel and getlog_retry
fails.
Reviewed by: ae
Fixes: https://cgit.freebsd.org/src/commit/?id=d6164b77f8b7 ("Make ipfw_nat module use IP_FW3 codes.")
Co-Authored-By: Claude Opus 4.8
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D61587
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
Stuff in man section 8 (other than networking).
Commit d9fa6016011e ("nuageinit; Skip SSH keys and doas/sudo if adduser
fails") handled nil return from a failing adduser when adding secondary
users, but the same issue also existed in the default user handling.
Reported by: llm-postcr
Reviewed by: dtxdf
Supported by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D61511
debug: classified in
03-filenames_plain1 by
'libexec/'
Prepare for future OpenSSL API changes. OpenSSL 4.1 deprecates ASN1_STRING_set. Move to ASN1_STRING_set0 which requires the DER buffer to be allocated with OPENSSL_zalloc so ownership can be assumed by the string. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D61532
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
A write to IMC only cleared the bits in the mask. If the device was asserting INTx for a cause that the write masked, the line stayed up until the guest cleared the cause in ICR. The hardware deasserts INTx as soon as no unmasked cause is left, and a guest may rely on that: Windows masks all causes and unloads its driver when it shuts down, and then spends its time in the handlers of whatever shares the interrupt. Do what the comment in the code asked for. Signed-off-by: Wanpeng Qian <wanpengqian@gmail.com> Reviewed by: jhb Sponsored by: keelos.dev Differential Revision: https://reviews.freebsd.org/D60230
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
Add a test too. Reviewed by: ae Fixes: https://cgit.freebsd.org/src/commit/?id=d6164b77f8b7 ("Make ipfw_nat module use IP_FW3 codes.") Found with: Claude Opus 4.8 MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D61588
debug: classified in
03-filenames_plain1 by 'sbin/'
C23 adds iseqsig(), the signaling counterpart of ==, which raises FE_INVALID on any NaN rather than only on signaling ones (as per §7.12.17.7). The helpers raise it explicitly instead of relying on relational operators, which the compiler may emit as quiet comparisons, and the macro dispatches on float_t so that wider-evaluated arguments are not narrowed (§F.10.14.1). Reviewed by: kargl, fuz Approved by: fuz (mentor) MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D60642
debug: classified in
04-filenames_plain2 by 'lib/'
In the case were N was not a valid bit width, we were taking the wrong error path. Fixes: https://cgit.freebsd.org/src/commit/?id=5e809bf1c93f ("stdio: Fix positional %wN / %wfN conversion")
debug: classified in
04-filenames_plain2 by 'lib/'
-- no commits in this category this week --
Kernel stuff (other than networking, filesystems, and drivers).
kern_swapon looks up the proposed swap path and aquires a vnode which is held (unlocked) throughout the life of the swap device. In the device case (swapgeom) it was never released in the swapoff path. Remove an incorrect comment about swapgeom_close being called from biodone. It is only called directly via swapoff(2) or at the end of the shutdown path. Reviewed by: kib, markj Reported by: llm-postcr MFC after: 3 days Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D61465
debug: classified in
04-filenames_plain2 by 'sys/'
Since ASLR got enabled for ELFv2, the random bases for the heap, the dynamic linker and PIE binaries can land anywhere in the 52-bit address space radix gives us. A lot of userland doesn't like that: SpiderMonkey, JavaScriptCore, QV4 and friends pack pointers into 47 or 48 bits and crash on startup (gjs, cjs, qml, ...). Do what amd64 does on LA57 hardware: keep the full range in the kernel and give processes a smaller map by default through a second set of sysvecs. The default is 48 bits (256 TiB), the same as arm64. One caveat for 48 bits: SpiderMonkey's GC allocator has no fallback there and relies on mmap(2) hints staying 1 MiB-aligned, which ASLR on FreeBSD breaks (hinted mappings move in 4 KiB steps, 64 KiB on arm64). The versions in ports need Mozilla's bug 1876632 (MAP_ALIGNED on FreeBSD, in Firefox 143) to be reliable; with it gjs runs clean. The full 52 bits stay available per process through the la52 feature control note (elfctl(1)) and PROC_LA_CTL (proccontrol(1)), and vm.pmap.prefer_uva_la48 flips the default. la52 is the powerpc64 name for the note bit amd64 calls la57, the procctl(2) values are the same. Fixes: https://cgit.freebsd.org/src/commit/?id=30ed27ff2556 ("sys/powerpc/powerpc/elf64_machdep.c: enable ASLR on ELFv2") Reviewed by: kib MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D61331
debug: classified in
04-filenames_plain2 by 'sys/'
In mac_get_prison(), mac.m_string points to a user address; the string is copied in by mac_label_copyin_string(). If an error occurs before that copyin, we end up freeing a user-controlled pointer. In mac_set_prison_prepare(), the string is leaked. Fix both problems. While here, make free_copied_label() a bit more robust to bugs in callers. Fixes: https://cgit.freebsd.org/src/commit/?id=bd55cbb50c58 ("kern: add a mac.label jail parameter") Reviewed by: olce, kevans Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D61596
debug: classified in
04-filenames_plain2 by 'sys/'
linux_clone_thread() and kthread_add() did not call the PMC_FN_THR_CREATE hook. Their new threads had no hwpmc thread descriptor. If the process had a sampling PMC, the first switch-in of such a thread hit KASSERT(pt != NULL) in pmc_process_csw_in(). An unprivileged user could panic an INVARIANTS kernel with "pmcstat -P" on a threaded Linux program. Call the hook in both functions, as thread_create() does. kern_kthread.c did not include opt_hwpmc_hooks.h, so its hwpmc code never compiled. Include it, and use newtd in kthread_add1(). Remove the exit log call from kthread_exit(), because thread_exit() already logs the exit. Reported by: llm-postcr Reviewed by: kib, mhorne Fixes: https://cgit.freebsd.org/src/commit/?id=6161b98c9935 ("hwpmc: Implement per-thread counters for PMC sampling") Differential Revision: https://reviews.freebsd.org/D61524
debug: classified in
04-filenames_plain2 by 'sys/'
Reviewed by: ivy, bdrewery, lwhsu Differential Revision: https://reviews.freebsd.org/D60440
debug: classified in
02-filenames_wildcards by
'.*Makefile'
-- no commits in this category this week --
Add tests exercising pax copy mode, cpio passthrough mode, the ability to extract pax, cpio, and tar archives, and the ability to parse pax, cpio, and tar command lines. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: obiwac Differential Revision: https://reviews.freebsd.org/D58469
debug: classified in
02b-filenames_wildcards2 by
'bin/.*/tests/.*'
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
- pmc_perf_test: the pmc.perf(3) class (MPERF, APERF, IRPERF). - pmc_rdpmc_test: pmc_get_msr() and RDPMC. - pmc_row_test: row disposition per mode; system sampling needs a log. - pmc_ss_test: system sampling into a log, and its interrupt accounting. - pmc_unload_test: unloading hwpmc.ko leaks no memory. Reviewed by: mhorne Sponsored by: Advanced Micro Devices, Inc. Signed-off-by: Osvaldo Janeri Filho <ojanerif@amd.com> Signed-off-by: Davi C.A <davi.chavesazevedo@amd.com> Differential Revision: https://reviews.freebsd.org/D61062
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
These could go in other categories, but it's more clear if they're here instead.
Reported by: kib Fixes: https://cgit.freebsd.org/src/commit/?id=538c48bf6247 ("sched_ule: Fix rare deadlock on stealing a migrated lock-blocked thread") Sponsored by: The FreeBSD Foundation
debug: classified in 01-style
by '[tT]ypo'
-- no commits in this category this week --
-- no commits in this category this week --
Not classified automatically, and waiting for manual attention.
-- no commits in this category this week --
Dates:
cgit.freebsd.org/src. Git accurately records the
order of commits, but not their dates.Automatic grouping:
This reverts commit \\b([0-9a-fA-F]{40})\\b
and the hash was found in this week's commits.
Automatic categories:
Source code:
Generated with commits-periodical 0.21 at 2026-11-16 20:33:59+00:00.
This work is supported by Tarsnap Backup Inc.
Alternate version: 2026-11-16 (release)