This is a display of mostly-automatically-classified git commits from 2025-10-06 to 2025-10-12.
In the future, these reports might include summaries or additional information, but for now our focus is figuring out what type of classification would be most useful.
DEBUG: This version of the report is primarily for checking the classifiers, and therefore contains extra information (in this colour).
DEBUG: In addition, debug pages for the latest week are often produced by a daily or hourly cronjob, and thus might not have any human review. Don't worry if you see commits in the wrong section; I'll check and fix them.
Table of contents and commits per category:
| (1) | Highlighted commits (these are copies, not in stats) | |
| 2 | 1.3% | Userland programs |
| 21 | 13.7% | Documentation |
| 18 | 11.8% | Hardware support |
| 11 | 7.2% | Networking |
| 16 | 10.5% | System administration |
| 5 | 3.3% | Libraries |
| 7 | 4.6% | Filesystems |
| 9 | 5.9% | Kernel |
| 33 | 21.6% | Build system |
| 0 | 0.0% | Internal organizational stuff |
| 14 | 9.2% | Testing |
| 5 | 3.3% | Style, typos, and comments |
| 9 | 5.9% | Contrib code |
| 3 | 2.0% | Reverted commits |
| 0 | 0.0% | Unclassified commits |
| 153 | 100% | total |
| Technical notes about this page |
debug: info about the automatic classification
| num | % | num changed | stage |
|---|---|---|---|
| 3 | 2.0% | 0 | 00-reverts |
| 5 | 3.3% | 0 | 01-style |
| 49 | 32.0% | 0 | 02-filenames_wildcards |
| 13 | 8.5% | 0 | 02b-filenames_wildcards2 |
| 55 | 35.9% | 0 | 03-filenames_plain1 |
| 23 | 15.0% | 0 | 04-filenames_plain2 |
| 2 | 1.3% | 0 | 05-summary-prefix |
| 3 | 2.0% | 0 | Manually-classified commits |
| 0 | 0.0% | 0 | Unclassified commits |
debug: more stats
| num | % | stage |
|---|---|---|
| 0 | 0.0% | Misclassified commits |
| 150 | 98.0% | Classified commits, no corrections |
debug: groups
| 2 | 1.3% | num in revert |
| 1 | 0.7% | num in fixes |
| 16 | 10.5% | num in consecutive |
| 19 | 12.4% | Commits in groups |
For extra visibility, these are copies of commits found in
other sections. Most (if not all) come from the commit message
containing "Relnotes:", or commits modifying
UPDATING.
Follow up upstream rename from blacklist to blocklist. - Old names and rc scripts are still valid, but emitting an ugly warning - Old firewall rules and anchor names should work, but emitting an ugly warning - Old MK_BLACKLIST* knobs are wired to the new ones Although care has been taken not to break current configurations, this is a large patch containing mostly duplicated code. If issues arise, it will be swiftly reverted. Reviewed by: ivy (pkgbase) Approved by: emaste (mentor) MFC after: 2 days Relnotes: yes
debug: Commit manually moved from "unknown" to "contrib".
Commits about commands found in man section 1 (other than networking).
Signed-off-by: Faraz Vahedi <kfv@kfv.io> Reviewed by: asomers, markj Pull Request: https://github.com/freebsd/freebsd-src/pull/1498
debug: classified in
04-filenames_plain2 by
'usr.bin/'
Reviewed by: alc, kib MFC after: 1 week Sponsored by: Modirum MDPay Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D53008
debug: classified in
04-filenames_plain2 by
'usr.bin/'
Man pages, release notes, etc.
MFC after: 3 days
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Remove prose from synopsis, adding sysctls and tunables. MFC after: 3 days Reviewed by: kbowling Differential Revision: https://reviews.freebsd.org/D52913
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Suggested by: cyric@mm.st
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Adjust the BNF, and don't claim it is optional in the text. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290059 MFC after: 3 days Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
* Add subsections for the three functions that didn't already have one. * Add a RETURN VALUES section. * Improve the grammar somewhat. * Clarify that fts_read() will not set errno to 0 if called again after having already returned NULL. Sponsored by: Klara, Inc. Reviewed by: bcr, markj Differential Revision: https://reviews.freebsd.org/D52925
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
The .Fl macro implicitly adds a '-', so only use a single '-' in the --jail option. Fixes: https://cgit.freebsd.org/src/commit/?id=8d0a90512ee3 ("bsdinstall: Improve pkgbase handling for jails") MFC after: 1 day Reported by: Mark Millard <marklmi@yahoo.com> Sponsored by: https://www.patreon.com/bsdivy
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
With CHERI there now more options than __ILP32__ and __LP64__ so lack of one does not imply the other. Encourage the use of __SIZEOF_*__ macro tests in their place. Effort: CHERI upstreaming Reviewed by: kib, markj, emaste Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D52820
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Don't claim void* or (u)intptr_t are the same size as long. This isn't true for CHERI. Effort: CHERI upstream Reviewed by: kib, markj, jhb, emaste Sponsored by: Innovate UK, DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D52821
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Effort: CHERI upstreaming Co-authored-by: Brooks Davis <brooks@FreeBSD.org> Reviewed by: kib, markj, jhb, emaste Sponsored by: Innovate UK, DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D52822
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
The vnet.interface parameter allows defining multiple interfaces, separated by commas. Mention this in the man page. While here, fix some other style nits that mandoc complained about. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206353 Approved by: ziaee Differential Revision: https://reviews.freebsd.org/D52965
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
To improve HW relnotes MFC after: 3 days
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
The document description previously just stated the name of the driver. Replace this with the name of the controller families and specs that it supports, in a similar fashion to other RAID drivers. MFC after: 3 days
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Emphasize the peculiar treatment of 'ngroups', through which the
effective group list's size is returned, even if the passed allocated
size is not big enough, in which case the output 'groups' array is
completely filled with the effective group list's first elements.
Use the precise POSIX term for the group associated to the user in the
password database ("initial numerical group ID"), consistently with what
was done in initgroups.3.
Use "length" instead of "size" to refer to the number of elements of an
array (in contrast with its actual size in bytes).
Perform some minor simplifications on top of the last rework.
MFC after: 1 hour
Sponsored by: The FreeBSD Foundation
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
The current phrasing could be interpreted as meaning that initgroups(3)
could return ENOMEM instead of -1, which it actually did until I fixed
it in commit 0b018cfd81d8 ("initgroups(3): Fix return value on
allocation failure").
While here, mention setgroups(2) as a system call rather than a library
function.
MFC with: 0b018cfd81d8 ("initgroups(3): Fix return value on allocation failure")
Sponsored by: The FreeBSD Foundation
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Be explicit that newaliases for sendmail (Upstream sendmail.org commit 3084151d898) PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289259 MFC after: 1 hour
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
+ consolidate kernel configuration in SYNOPSIS + explain driver autoloading in DESCRIPTION + s/port/interface/ because of internal USBs + fix flow of remaining example MFC after: 1 day
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Reflow comments in literal text blocks so this manual is legible at MANWIDTH 78. MFC after: 1 day
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D52983
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
In the STANDARDS section, stop mentioning behavior that is not
prescribed by POSIX and make sure to specify which alternative we
implement (as POSIX allows to return or not the effective group ID).
Say more clearly that programs treating specially the first slot of the
returned array must be modified.
Consistently use "group ID" instead of "GID".
These changes are going to be MFCed into stable/14 as part of MFCing
commit 4be38acc826f ("getgroups.2: Clarify, mention ascending order, add
SECURITY CONSIDERATIONS"), so the current commit will be MFCed to
stable/15 only.
MFC after: 1 hour
MFC to: stable/15
Sponsored by: The FreeBSD Foundation
debug: classified in
02-filenames_wildcards by
'.*\.[1-9]'
debug: classified in
03-filenames_plain1 by
'RELNOTES'
debug: classified in
03-filenames_plain1 by
'RELNOTES'
Hardware drivers and architecture-specific code.
Currently, the CMCI handler checks the cold variable to determine whether it can schedule a task. The task queue is setup as part of the mca_startup() function, which is run well after the configure_final() function sets the cold variable to 0. Therefore, if an MCA arrives in the window between configure_final() and mca_startup() running, the code could try to schedule a task on an unintitalized task queue. Close the race by specifically checking whether the mca_startup() function has run. Reviewed by: markj MFC after: 1 week Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D12276
debug: classified in
03-filenames_plain1 by
'sys/x86/'
When processing recoverable MCA events in a hardware interrupt context, defer logging the messages to a task queue. Reviewed by: markj MFC after: 2 weeks Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D12275
debug: classified in
03-filenames_plain1 by
'sys/x86/'
Reported by: avg Reviewed by: avg, imp Differential Revision: https://reviews.freebsd.org/D52888
debug: classified in
03-filenames_plain1 by
'sys/dev/'
If the MSI-X table and/or PBA live in separate BAR(s) and those BAR(s) cannot be allocated, fall back to using MSI or INTx instead of failing attach. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289748 Reported by: Vitalij Satanivskij <satan@Ukr.net> Reviewed by: avg, imp Differential Revision: https://reviews.freebsd.org/D52889
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D52930
debug: classified in
03-filenames_plain1 by
'sys/arm64/'
This is enough to boot FreeBSD again. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290044 Reported by: Siva Mahadevan <me@svmhdvn.name> Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D52931
debug: classified in
03-filenames_plain1 by
'sys/arm64/'
The MCA spin lock is acquired in the hardware interrupt context to record MCA messages. It is also acquired by a task handler to emit those messages. Reduce the amount of time the task handler holds the lock to reduce the maximum amount of time the hardware interrupt handler may need to spin on the lock. Reviewed by: glebius, markj MFC after: 2 weeks Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D52938
debug: classified in
03-filenames_plain1 by
'sys/x86/'
Reviewed by: glebius Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D52942
debug: classified in
03-filenames_plain1 by
'sys/x86/'
* Rename delta_t to avoid misleading simplistic syntax highlighters * Simplify the increment calculation Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D52973
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Always print the first 50 messages of each type. After that, optionally rate-limit the messages. This provides a way to limit the overhead of processing excessive messages without suppressing the first few of any type. As part of this change, we are switching from direct printf() calls to collecting data in an sbuf(9). In POLLED mode (run from a task queue), we dynamically allocate the buffer. In the other modes (which are likely called from a hardware interrupt), we use a buffer allocated from the BSS segment and guarded by a lock. In normal operation, most calls to mca_log() should come from the POLLED mode, so there should be no contention for the new lock. If there is an interrupt storm which exceeds the capacity of the free list, there will be new contention for this lock; however, overall lock contention should still be lower than it was prior to e770e32aa3a0, when the mca_lock was almost always held for the entirety of the mca_log() call. This commit is partly based on a patch proposed by Loic Prylli <lprylli@netflix.com>. Reviewed by: markj, glebius (previous version) MFC after: 2 weeks Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D52946
debug: classified in
03-filenames_plain1 by
'sys/x86/'
Currently, all MCA messages are logged to the console. However, this can have performance implications which can turn a storm of correctable errors into a disruptive event. Provide an option to direct non-fatal messages to syslog. Note that we will always log to the console for fatal errors. Reviewed by: markj MFC after: 2 weeks Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D12278
debug: classified in
03-filenames_plain1 by
'sys/x86/'
Older versions of the standard were limited to 16, but the actual limit is 64. Bump the limit to 64. This should be a #define, but there's no good standardized name, so I'm punting on that. All the places that use it, apart from the byte swapping code, do the right thing and use the nlbaf field to limit what to access. Sponsored by: Netflix
debug: classified in
03-filenames_plain1 by
'sys/dev/'
This is part 2 of the support for the new Intel Ethernet E610 family of devices. Intel E610 Ethernet Controller devices feature a debug dump capability that allows you to capture runtime register values directly from the hardware, with assistance from the firmware. These registers are organized into clusters based on their function, enabling targeted debugging. This information is consolidated into a single dump file, facilitating the debugging of complex issues encountered in the field. The debug dump provides a snapshot of the device's current hardware configuration, including switch tables, transmit scheduler tables, and other relevant data. It captures the state of specified clusters and serves as a stateless snapshot of the entire device. This update introduces ioctl and sysctl support for the debug dump feature. Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com Co-developed-by: Krzysztof Galazka krzysztof.galazka@intel.com Approved by: kbowling (mentor), erj (mentor) Tested by: gowtham.kumar.ks_intel.com Sponsored by: Intel Corporation MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D50934
debug: classified in
03-filenames_plain1 by
'sys/dev/'
Add device IDs and branding strings for E835 adapters. This is a follow up for E830 adapters with Security Protocol and Data Model (SPDM) support and RDMA support available on 100 and 200Gbps links. Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com> Approved by: kbowling (mentor), erj (mentor) Sponsored by: Intel Corporation MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D52782
debug: classified in
03-filenames_plain1 by
'sys/dev/'
vmm: Unify implementations of vcpu_cleanup() Different vmm implementations were freeing the per-vCPU structure in different places. Make the implementations consistent. No functional change intended. Reviewed by: corvink MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D53010
debug: classified in
03-filenames_plain1 by '['sys/arm64/',
'sys/riscv/']'
vmm: Make vmmops declarations more consistent - On amd64, make vmmops_* functions globally visible, as some will be called from machine-independent code in the future. - On arm64 and riscv, move declarations to vmm.h, since they're supposed to be generic across different VMM backends (only amd64 has more than one backend). - Make the declaration macros consistent with each other. - On amd64, make the function typedef names consistent with the corresponding ifunc names. No functional change intended. Reviewed by: corvink MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D53011
debug: classified in
03-filenames_plain1 by '['sys/amd64/',
'sys/arm64/', 'sys/riscv/']'
vmm: Move the guest vmspace into the generic vm_mem structure This further consolidates handling of guest memory into MI code in sys/dev/vmm. No functional change intended. Reviewed by: corvink MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D53012
debug: classified in
03-filenames_plain1 by '['sys/amd64/',
'sys/arm64/', 'sys/dev/', 'sys/riscv/']'
vmm: Remove some unused macros No functional change intended. Reviewed by: corvink MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D53013
debug: classified in
03-filenames_plain1 by '['sys/arm64/',
'sys/riscv/']'
Network-related commands, library, and kernel.
According to the fifth step in SEGMENT ARRIVES, send a RST segment in response to an ACK segment which fails the SEG.ACK check, but leave the endpoint state unchanged. FreeBSD handles this correctly when entering the SYN-RECEIVED state via the SYN-SENT state, but not in the SYN-cache code, which handles the SYN-RECEIVED state via the LISTEN state. This also fixes a panic reported by Alexander Leidinger. Reviewed by: jtl, glebius MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52934
debug: classified in
03-filenames_plain1 by
'sys/netinet/'
debug: classified in
03-filenames_plain1 by
'sys/netlink/'
Save prefix length in unused field in6_ifaddr->ia_plen, then on remove check if an address has 128 prefix length, and if so, we don't need to complain that there is none of related prefixes. Reviewed by: kp Obtained from: Yandex LLC MFC after: 1 week Sponsored by: Yandex LLC Differential Revision: https://reviews.freebsd.org/D52952
debug: classified in
03-filenames_plain1 by
'sys/netinet6/'
Add a -b option to print the BBLog state for TCP sockets. Reviewed by: jtl, rrs MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52944
debug: classified in
03-filenames_plain1 by
'usr.bin/sockstat/'
This documents the following functions: * ieee80211_is_key_global() * ieee80211_is_key_unicast() * ieee80211_crypto_get_key_wepidx() * ieee80211_crypto_get_keyid() * ieee80211_crypto_get_txkey() * ieee80211_crypto_encap() * ieee80211_crypto_decap() Differential Revision: https://reviews.freebsd.org/D52649
debug: classified in
03-filenames_plain1 by
'sys/net80211/'
No functional changes intended. MFC after: 3 days Sponsored by: Netflix, Inc.
debug: classified in
03-filenames_plain1 by
'usr.bin/sockstat/'
When a packet is provided to LRO using tcp_lro_queue_mbuf(), a sequence number is computed based on the m_pkthdr.flowid provided by he driver. The implicit assumption is that the m_pkthdr.flowid has hash properties. The recent use of tcp_lro_queue_mbuf() in iflib exposed a bug in at least one driver (igc) , which * reports always that is uses M_HASHTYPE_OPAQUE. * sets in some cases m_pkthdr.flowid not consistently for packets belonging to the same TCP connection. This results in severe performance problems for the base TCP stack, since it handles the packets in the wrong sequence, although they were received in the correct sequence. To protect against such misbehaving drivers, just take the m_pkthdr.flowid only into account, if it has hash properties. The performance problems were observed by gallatin@ and analyzed together with rrs@. Reviewed by: gallatin Tested by: gallatin MFC after: 5 Minutes Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52989
debug: classified in
03-filenames_plain1 by
'sys/netinet/'
Fix the format when the output for a socket spans multiple lines. Reviewed by: rrs MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52984
debug: classified in
03-filenames_plain1 by
'usr.bin/sockstat/'
Showing the path state column is only useful, if there is at least one SCTP endpoint shown, which is not in the state CLOSED or LISTEN. Don't show it when it is not useful. Reviewed by: rrs MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52986
debug: classified in
03-filenames_plain1 by
'usr.bin/sockstat/'
Wait until all of the configuration has been parsed before creating associations for NVMe portals. This ensures that any options specified in a transport group are honored when creating associations. To enable this, add a new virtual method portal::prepare invoked when applying a configuration prior to opening a socket (or reusing an existing socket) for a portal. Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D52844
debug: classified in
03-filenames_plain1 by
'usr.sbin/ctld/'
Add static probe points to track where we increment io_pkt_drop. This is
intended to assist in debugging dummynet, allowing us to work out when and
hopefully why packets get dropped.
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by
'sys/netpfil/'
Stuff in man section 8 (other than networking).
When loading a new rule only persist the ticket if we're actually looking at a filter rule. We need that ticket type later if we have to create tables, but we need the ticket for the correct ruleset. Fixes: https://cgit.freebsd.org/src/commit/?id=9dfc5e03da50 ("pfctl: allow tables to be defined inside anchors") Reported by: Florian Smeets <flo@smeets.xyz> MFC after: 3 days Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by 'sbin/'
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289994 Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
03-filenames_plain1 by 'sbin/'
What we really want here is to know if pointers can refer to 64-bit addresses, regardless of whether they also hold other information (such as capabilities in CHERI). __SIZEOF_SIZE_T__ is probably the closest indication to that piece of information, so let's use it. __ILP32__ wasn't wrong in practice though, as we don't support 32-bit CHERI hardware (and likely never will). Consistently with this change, test whether we can actually address the 64-bit SMBIOS's structure table by converting the end address to 'size_t' and checking whether its value is preserved. Suggested by: jhb (for the __ILP32__ => __SIZEOF_SIZE_T__ part) Reviewed by: jhb, imp MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49318
debug: classified in
03-filenames_plain1 by 'stand/'
krb5: create the KDC database directory Reviewed by: rmacklem, cy Differential Revision: https://reviews.freebsd.org/D52970
debug: classified in
03-filenames_plain1 by 'etc/'
etc/mtree: Add package tags for Kerberos directories Fixes: https://cgit.freebsd.org/src/commit/?id=e7e7bf757ace ("krb5: create the KDC database directory") MFC after: 3 seconds Reviewed by: cy Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D52975
debug: classified in
03-filenames_plain1 by 'etc/'
This fixes some missing directories, notably /boot/modules. Other directories are not missing because they contain other files, but they should still have their own METALOG entries and be placed in the correct package. MFC after: 3 days Reported by: bdrewery Reviewed by: cperciva, imp Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D52958
debug: classified in
03-filenames_plain1 by 'etc/'
MFC after: 1 week Reviewed by: ae Differential Revision: https://reviews.freebsd.org/D52951
debug: classified in
03-filenames_plain1 by 'sbin/'
MFC after: 1 week Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc.
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
After commit 900bc0206348, zpool depends on mountcritlocal. zpoolreguid and zpoolupgrade depend on zpool and want to run before mountcritcycle, so we have a pair of cycles. Update zpoolreguid and zpoolupgrade to avoid this. Reviewed by: des MFC after: 3 days Fixes: https://cgit.freebsd.org/src/commit/?id=900bc0206348 ("rc.d/zpool: change mountcritlocal dep from BEFORE to REQUIRE") Differential Revision: https://reviews.freebsd.org/D52953
debug: classified in
03-filenames_plain1 by
'libexec/'
Reviewed by: des MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D52954
debug: classified in
03-filenames_plain1 by
'libexec/'
nfsuserd: Fix OOB access on membership of too many groups getgrouplist() sets the variable containing the allocated length in input to the full effective group list length, not the number of slots that were actually filled in case the passed array is too small to contain it. While here, on this condition, improve the error message by outputting the corresponding user name. MFC after: 1 hour Fixes: https://cgit.freebsd.org/src/commit/?id=e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.") Sponsored by: The FreeBSD Foundation
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
nfsuserd: Fix OOB access on membership of too many groups, take 2 Forgot to reset 'ngroup' after one of the calls to getgrouplist() in the previous commit with same title (referenced also below). MFC after: 1 hour Fixes: https://cgit.freebsd.org/src/commit/?id=e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.") Fixes: https://cgit.freebsd.org/src/commit/?id=bb339adfb2a2 ("nfsuserd: Fix OOB access on membership of too many groups") Sponsored by: The FreeBSD Foundation
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
Appease GCC. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D52941
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
sndiod is part of audio/sndio, so we should avoid referencing a port utility from base. We should also require NETWORKING for the service to start, since virtual_oss can be configured to send audio through the network. Sponsored by: The FreeBSD Foundation MFC after: 1 day Reviewed by: des, markj, emaste Differential Revision: https://reviews.freebsd.org/D53019
debug: classified in
03-filenames_plain1 by
'libexec/'
PR#289734 reports a crash in tcp_use_close() when the rpc.tlsservd daemon is being used. Although I have no, as yet, had time to track down/fix the race, it turns out setting rpctls_maxthreads to 1 avoids the problem. This patch pins rpctls_maxthreads to 1 to avoid the problem, until there is a proper fix. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289734 MFC after: 3 days
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
Have the button labels refer to the artifact type directly (distribution sets / packages), and use "Tech Preview" as packaged base is no longer experimental. Reviewed by: ivy, cperciva Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52999
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
Rather than implementing the recurrence using 3 16-bit integers, as was done in _dorand48() before this patch, provide an equivalent implementation using 64-bit integers. For drand48() and erand48(), replace the use of ldexp() with bit-twiddling assuming IEEE 754 double-precision float layout. This implementation is significantly faster and requires less code, while producing identical outputs on supported platforms. While here, add a STANDARDS section to rand48.3. Obtained from: https://github.com/apple-oss-distributions/libc MFC after: 3 weeks Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D52429
debug: classified in
04-filenames_plain2 by 'lib/'
Sponsored by: Klara, Inc. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D52924
debug: classified in
04-filenames_plain2 by 'lib/'
The implicit cast is incompatible with standard compiler options in a C++ project, making the library difficult to use. Signed-off-by: Quentin Thébault <quentin.thebault@defenso.fr> Sponsored by: Defenso MFC after: 3 days Discussed with: kevans Reviewed by: emaste, vexeduxr Pull request: https://github.com/freebsd/freebsd-src/pull/1857
debug: classified in
04-filenames_plain2 by 'lib/'
Add generation of a bzip2.pc file for use with pkg-config and create
a basic template as bzip2.pc.in.
This allows other software to easily locate and link against libbz2
using standard pkg-config mechanisms instead of manual compiler and
linker flags.
The version number is extracted automatically from bzlib.h to keep
it consistent with the library sources.
Tested: pkg-config --exists --print-errors "bzip2 >= 1.0.9" (fail, expected)
pkg-config --exists --print-errors "bzip2 >= 1.0" (succeeded)
pkg-config --libs bzip2 (-lbz2)
pkg-config --cflags bzip2 ()
MFC after: 3 days
debug: classified in
04-filenames_plain2 by 'lib/'
Make sure the entirety of x is zero before flipping the sign bit. Otherwise the sign would be wrong for small values of x when x is negative and |n*y| > |x| Reported by: alfredo PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251091 Reviewed by: kargl MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D53023
debug: classified in
04-filenames_plain2 by 'lib/'
In null_lock_prep_with_smr(), initialize 'lvp' outside of the
SMR-protected section.
In null_lock(), if after locking the lower vnode we notice that we have
been reclaimed, we have to unlock the lower vnode and then relock our
own now that the lock isn't shared anymore. Call VOP_UNLOCK() on the
lower vnode as soon as this condition is known.
This applies comments from D38761, one of which was missed and the other
added too late.
Reviewed by: kib
MFC with: 641a58239520 ("nullfs: avoid the interlock in null_lock with smr")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52935
debug: classified in
03-filenames_plain1 by
'sys/fs/'
debug: classified in
03-filenames_plain1 by
'sys/fs/'
debug: classified in
03-filenames_plain1 by
'sys/fs/'
Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D52983
debug: classified in
03-filenames_plain1 by
'sys/fs/'
Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D52983
debug: classified in
03-filenames_plain1 by
'sys/fs/'
Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D52983
debug: classified in
03-filenames_plain1 by
'sys/fs/'
The option, when set, disables bypassing the unix socket vnode down to the lower mp, effectively preventing connection to nullfs unix socket from being acceptable from the lower mp (and vice versa). This is done by providing a vop vector that stops bypass for unp-related VOPs. I believe that VFS_VOP_VECTOR_REGISTER() does the right thing there regardless of the order of initialization. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D52983
debug: classified in
03-filenames_plain1 by
'sys/fs/'
Kernel stuff (other than networking, filesystems, and drivers).
Using the word "contested" for the case where there are threads blocked
on the lock is misleading at best (the lock is already contested if it
is being held by one thread and wanted by another). It also diverges
from naming used in other primitives (which refer to them as "waiters").
Rename it for some consistency.
There were uses of the flag outside of mutex code itself.
This is an abuse of the interface. The netgraph thing looks suspicious
at best, the sctp thing is fundamentally wrong. Fixing those up is left
as an exercise for the reader.
While here touch up stale commentary.
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
04-filenames_plain2 by 'sys/'
When re-assigning p_reapsubtree value, we must check if the result of obliterating the old value would free the corresponding pid in the proc_id_reap bitmap, and indeed free it when needed. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289917 Reported by: avg Reviewed by: avg, markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D52814
debug: classified in
04-filenames_plain2 by 'sys/'
Add enum sleep_type stype parameter in power_suspend/resume event handlers, as with the introduction of s2idle there are more than one type of suspend. Reviewed by: bz Approved by: bz Sponsored by: The FreeBSD Foundation
debug: classified in
04-filenames_plain2 by 'sys/'
When going to s2idle, set Linux' pm_suspend_target_state to PM_SUSPEND_TO_IDLE instead of setting PM_SUSPEND_MEM (for S3) in all cases. This is necessary because more recent versions of the amdgpu DRM drivers have different paths for when entering s2idle & S0ix is supported than S3. Reviewed by: bz Approved by: bz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D51591
debug: classified in
04-filenames_plain2 by 'sys/'
Commit 8b987a77691d ("Use per-domain keg locks.") removed the need to
lock the keg entirely, replacing it with per-domain keg locks. In
particular, it removed the need to hold a lock over waiting for a domain
to grow free memory.
Simplify the code of keg_fetch_slab() and uma_prealloc() by removing the
M_WAITOK -> M_NOWAIT downgrade and the local call to vm_wait_doms()
(which used to necessitate temporary dropping the keg lock) which the
iterator machinery already handles on M_WAITOK (and compatibly with
vm_domainset_iter_ignore() at that, although that does not matter now).
Reviewed by: bnovkov, markj
Tested by: bnovkov
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52441
debug: classified in
04-filenames_plain2 by 'sys/'
Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D52907
debug: classified in
04-filenames_plain2 by 'sys/'
Instead, replace it with bsd.init.mk and remove old comments about FreeBSD 10.x compat. We used to need bsd.own.mk, but now can suffice with bsd.init.mk since kern.opts.mk doesn't included that in too many places. Sponsored by: Netflix
debug: classified in
04-filenames_plain2 by 'sys/'
Otherwise we print a bogus path for anonymous objects. Reviewed by: kib MFC after: 1 week Sponsored by: Modirum MDPay Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D52997
debug: classified in
04-filenames_plain2 by 'sys/'
Reviewed by: alc, kib MFC after: 1 week Sponsored by: Modirum MDPay Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D53008
debug: classified in
04-filenames_plain2 by 'sys/'
Otherwise pkg complains about unexpected ownership of the root directory. MFC after: 1 day Fixes: https://cgit.freebsd.org/src/commit/?id=86221f965c06 ("vmimage.subr: Fix NO_ROOT build in ..._rmcache")
debug: classified in
02-filenames_wildcards by
'release/.*'
Reported by: ivy Approved by: emaste (mentor) MFC after: 1 hour Differential Revision: https://reviews.freebsd.org/D52917
debug: classified in
02-filenames_wildcards by
'release/.*'
The general problem is that we might have a somewhat complicated dependency tree depending on bootstrap version requirements. We could document when multiple bootstrap tools might have a shared dependency and be careful to add them only once to the list, but that is a little more fragile- particularly if we purge some bootstrap tools and need to re-work the logic a little bit. Just avoid redefining the build commands as we're iterating over the list so that we can keep the actual requirements intact. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289997 Reported by: dhw, others Reviewed by: imp Fixes: https://cgit.freebsd.org/src/commit/?id=151bd3516b5 ("flua: support our flua modules in [...]") Differential Revision: https://reviews.freebsd.org/D52904
debug: classified in
02-filenames_wildcards by
'.*Makefile'
I excluded lldb from the "small" and "builder" flavours of EC2 AMIs because on FreeBSD 14.x the lldb binary was 100 MB, as a result of statically linking in lots of LLVM code; but we now have libprivatellvm as a shared library and lldb is much smaller so there's no significant benefit to excluding it. Reviewed by: ivy MFC after: 3 days Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D52921
debug: classified in
02-filenames_wildcards by
'release/.*'
release: Rework VM package selection using sets
Filtering the list of packages broke with the introduction of package
sets, since we excluded FreeBSD-src.* but still included
FreeBSD-set-src, which transitively included the FreeBSD-src and
FreeBSD-src-sys packages. This could be fixed by excluding package
sets, but that would be fragile, potentially breaking upgrades if
new packages are introduced.
Instead, start with an explicit set of package sets:
base, base-dbg
lib32, lib32-dbg
kernels, kernels-dbg
tests
and filter the package sets; the EC2 "small" and "builder" AMIs
filter out everything except "base" and "kernels".
Note that using FreeBSD-set-kernels may pose a problem in the future
if we start shipping packages for multiple differently-configured
kernels. That will be addressed if and when that problem arises.
Reviewed by: ivy
MFC after: 3 days
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D52922
debug: classified in
02-filenames_wildcards by
'release/.*'
release: Don't install missing lib32 into VMs There is no FreeBSD-set-lib32 on riscv64 or powerpc64le. Reviewed by: ivy, emaste Fixes: https://cgit.freebsd.org/src/commit/?id=2d184465e8bb ("release: Rework VM package selection using sets") MFC after: 6 hours Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D52987
debug: classified in
02-filenames_wildcards by
'release/.*'
These need to have names like FreeBSD-15.0-ALPHA5-amd64-pkgbase-repo.tar not just "pkgbase-repo.tar". Fixes: https://cgit.freebsd.org/src/commit/?id=d0ff67db2908 ("release: Publish pkgbase-repo.tar") MFC after: 3 days Sponsored by: https://www.patreon.com/cperciva
debug: classified in
02-filenames_wildcards by
'.*Makefile'
MFC after: 1 day Reviewed by: bapt Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D52950
debug: classified in
02-filenames_wildcards by
'release/.*'
The make(1) variable DISTDIR is used by both ports and src with a different meaning. Some users may set DISTDIR in /etc/make.conf for ports, which previously worked fine when building src since the src targets which used this variable were not very commonly used (mainly, make distributeworld). Unfortunately, with pkgbase becoming the default, this is no longer true since make (update-)packages invokes make stageworld, which is sensitive to DISTDIR, and these users find that their build now fails. A correct fix for this probably requires renaming one or both of the DISTDIR variables, but for now, work around the problem by setting DISTDIR=/ for the user-facing pkgbase targets, packages and update-package. Since setting DISTDIR doesn't work for these targets anyway, this should not break any existing configurations. MFC after: 1 week PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290010 Reported by: Oleh Vinichenko <moonlapse81@gmail.com> Reviewed by: imp, bapt Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D52929
debug: classified in
02-filenames_wildcards by
'.*Makefile'
This incorporates pkg(8) commit a31c8c3682a3 for consistency. https://github.com/freebsd/pkg/commit/a31c8c3682a3 MFC after: 1 day Reviewed by: kevans Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D52920
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Commit 822fd5606748 changed the origin of packages from "base" to "base/<package name>", but the old origin was still used for dependencies. Aside from being wrong, this confuses pkg <= 2.3.1 and causes "pkg info -d" to show the dependencies as "<pkgname>-(null)" instead of the correct version string. Remove the explicit origin from dependencies in the UCL files, and instead populate this during the build in generate-ucl.lua. In the (very unlikely) case that an explicit origin is still needed, don't overwrite one if it's already present. MFC after: 1 day Fixes: https://cgit.freebsd.org/src/commit/?id=822fd5606748 ("pkgbase: set origin for each packages as base/FreeBSD-*") Reported by: bapt Reviewed by: cperciva, bapt Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D52892
debug: classified in
02-filenames_wildcards by
'release/.*'
Add a standard BSD license with a copyright claim for everyone who has modified this file since it was added, excluding users who explicitly declined attribution. MFC after: 3 days Reviewed by: ifreund_freebsdfoundation.org, imp, bapt, markj, emaste Differential Revision: https://reviews.freebsd.org/D52881
debug: classified in
02-filenames_wildcards by
'release/.*'
The 'make release' command triggers some sub-builds, in particular
'real-release' (which builds install images) and 'vm-release' (which
builds VM images). These both now depend on pkgbase-repo.
Unfortunately for historical reasons 'make real-release' has used a
recursive make instead of proper make dependencies; this results in
the pkgbase-repo target being invoked twice since the recursive make
does not have any awareness of the targets being run by the parent
make command. Since the pkgbase-repo target starts by creating the
pkgbase-repo directory, the second make command incorrectly assumes
that target has already been built; this showed up in 15.0-ALPHA5
builds with pkgbase-repo.tar being empty as it was created after the
pkgbase-repo directory was created by before that directory had been
populated.
Change
real-release:
make obj
make ${RELEASE_TARGETS}
to a single line
real-release: obj .WAIT ${RELEASE_TARGETS}
in order to handle dependency deduplication properly while keeping
the intended behaviour that "obj" completes before ${RELEASE_TARGETS}.
Diagnosed by: jrtc27, emaste
Reviewed by: emaste
MFC after: 1 day
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D52972
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Align CONFGROUPS with other options like SUBDIRS and FILESGROUPS by
supporting the CONFGROUPS.yes option. This means logic like this:
.if ${MK_FOO} != "no"
CONFGROUPS+= FOO
.endif
can be replaced by:
CONFGROUPS.${MK_FOO}+= FOO
MFC after: 1 week
Reviewed by: imp
Sponsored by: https://www.patreon.com/bsdivy
Differential Revision: https://reviews.freebsd.org/D52923
debug: classified in
03-filenames_plain1 by
'share/mk/'
Replace .if statements with CONFGROUPS.${MK_FOO} where possible,
and also sort and re-indent the file for readability.
A couple of more complicated sections don't work with CONFGROUPS.yes
yet, so leave those as they are for now.
MFC after: 1 week
Reviewed by: imp
Sponsored by: https://www.patreon.com/bsdivy
Differential Revision: https://reviews.freebsd.org/D52974
debug: classified in
02-filenames_wildcards by
'.*Makefile'
This file was derived from generate-ucl.lua, so copy the existing header. MFC after: 3 days
debug: classified in
02-filenames_wildcards by
'release/.*'
This is needed when bootstrapping libc, reallocarray.c and recallocarray.c include stdckdint.h now. Reviewed by: emaste Fixes: https://cgit.freebsd.org/src/commit/?id=7233893e9496 ("lib{c,openbsd}: use ckd_mul() for overflow checking in re(c)allocarray") Differential Revision: https://reviews.freebsd.org/D52932
debug: classified in
02-filenames_wildcards by
'.*Makefile'
This is required when including stdckdint.h and doesn't seem to be provided by older clang. Reviewed by: emaste Fixes: https://cgit.freebsd.org/src/commit/?id=7233893e9496 ("lib{c,openbsd}: use ckd_mul() for overflow checking in re(c)allocarray") Differential Revision: https://reviews.freebsd.org/D52933
debug: classified in
03-filenames_plain1 by
'tools/build/'
This also installs the pkg key from the current source tree instead of using the one currently installed on the host. Reviewed by: dch MFC after: 1 day Differential Revision: https://reviews.freebsd.org/D52615
debug: classified in
02-filenames_wildcards by
'release/.*'
Enable Pi 02W support on the release SD card images by including the device tree. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278816 MFC after: 3 days Approved by: cperciva (re)
debug: classified in
02-filenames_wildcards by
'release/.*'
We don't need kern.opts.mk in any of these places. None of these Makefiles reference any MK_ options. Some don't even need SYSDIR, but leave that defined in the ones that do. Sponsored by: Netflix
debug: classified in
02-filenames_wildcards by
'.*Makefile'
When we only use SYSDIR once or twice, expand it and don't define it. Minor other consistency changes. Sponsored by: Netflix
debug: classified in
02-filenames_wildcards by
'.*Makefile'
use minimal-jail in no-toolchain MFC after: 1 hour Reviewed by: ivy Sponsored by: SkunkWerks, GmbH Differential Revision: https://reviews.freebsd.org/D53014
debug: classified in
02-filenames_wildcards by
'release/.*'
dtb.plist is generated by mtree-to-plist when it processes the kernel metalog, so we shouldn't try to create dtb packages until that's been done. Add another level of indirection to the create-kernel-packages target to organize all of the kernel flavors under a single target that is ordered before the create-dtb-packages target. Note that we may later refine these targets after further pkgbase review; this is simply a maybe-final stop-gap that's been tested to fix a known problem. MFC after: 37 seconds (pkgbase fix for 15.0 builds) Reviewed and tested by: cperciva Differential Revision: https://reviews.freebsd.org/D53017
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Both usr.bin/sockstat and usr.bin/sockstat/tests build the file src/usr.bin/sockstat/sockstat.c. Unfortunately, they place the resulting object file in the same place, but produce different files due to paths appearing in the .debug files; this results in different binaries depending on how the race between the two builds ends. Use .PATH to tell make to find sockstat.c in the parent directory but place the object file in the current object directory, rather than placing '..' into the name of the source file. Suggested by: bdrewery, emaste, jrtc27 MFC after: 5 minutes (15.0 build fix) Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D53032
debug: classified in
02-filenames_wildcards by
'.*Makefile'
The files /etc/login.conf.db, /etc/passwd, /etc/pwd.db, /etc/spwd.db, and /var/db/services.db are generated at install time. When VM images are built using installworld, there is Makefile code which emits the necessary METALOG lines; but the pkgbase triggers do not do this. This resulted in VM images which lacked these essential database files. VM images are currently the only place where this matters, since this issue is specific to non-root image builds uusing pkgbase. (In some point in the future we will start building release ISO iamges from pkgbase, at which point it will be a problem there as well.) The long-term solution for this is probably to teach the relevant database-creating tools to emit METALOG lines; but for now, just log the necessary files from vmimage.subr. Reviewed by: dch MFC after: 5 minutes Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D53034
debug: classified in
02-filenames_wildcards by
'release/.*'
EC2: metalog_add missing files from packages
The files
/usr/local/etc/dhclient.conf
/usr/local/etc/ssl/cert.pem
are created in EC2 images by installed packages, but are not being
registered in METALOG. The reason for this is not immediately clear,
but may be related to the handling of "sample" files.
Reviewed by: dch
MFC after: 5 minutes
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D53035
debug: classified in
02-filenames_wildcards by
'release/.*'
EC2: Fix additional files on small+builder AMIs The file /usr/local/etc/ssl/cert.pem is not present on "small" and "builder" AMIs, so we don't need to add it to METALOG. Fixes: https://cgit.freebsd.org/src/commit/?id=2b0ffc0ee48c ("EC2: metalog_add missing files from packages") MFC after: 3 days Sponsored by: https://www.patreon.com/cperciva
debug: classified in
02-filenames_wildcards by
'release/.*'
This didn't show up in testing on main or stable/15 because it only applies for "release" (BETA and onwards) builds. Fixes: https://cgit.freebsd.org/src/commit/?id=afdc022deb91 ("release: Publish pkgbase-repo.tar") MFC after: 30 seconds Sponsored by: https://www.patreon.com/cperciva
debug: classified in
02-filenames_wildcards by
'.*Makefile'
Fixes the ports that prefer static linking: https://reviews.freebsd.org/D49277 Reviewed by: ivy, dch, cy Sponsored by: SkunkWerks, GmbH Differential Revision: https://reviews.freebsd.org/D52910
debug: Commit manually moved from "unknown" to "build".
Move the library, but not any of the runtime. This allows executables to link against libbluetooth without having to pull in the entire BT stack. MFC after: 3 days Reviewed by: dch, emaste Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D53016
debug: classified in
02-filenames_wildcards by
'.*Makefile'
This is the correct place for them, and also issues an incorrect dependency from utilities to sound. Fixes: https://cgit.freebsd.org/src/commit/?id=1b806e607f52 ("packages: Add a sound package") MFC after: 3 days Reviewed by: christos, dch Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D53015
debug: classified in
02-filenames_wildcards by
'.*Makefile'
When creating VM images from pkgbase, the METALOG may not be in order; in particular, files may be listed before the directories which contain them. This causes makefs to create directories with 000 permissions. Interestingly, such VM images boot just fine, since root ignores those permissions; the first sign of trouble was sshd refusing logins with an error message which said absolutely nothing about /etc/ having incorrect permissions or being unable to read files inside it. Immediately prior to running makefs, sort the METALOG file. While we're here, uniquify as well; this does not guarantee that we do not have duplicate paths, but if there are duplicate paths with different settings something else has gone wrong and we don't really have any good way of solving the problem anyway. Reviewed by: ivy Hint from: imp MFC after: 3 days Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D53046
debug: classified in
02-filenames_wildcards by
'release/.*'
-- no commits in this category this week --
Add a brief sleep to give tail time to start following the file before we rename it. MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D52887
debug: classified in
02b-filenames_wildcards2 by
'usr.bin/.*/tests/.*'
Sponsored by: Klara, Inc. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D52926
debug: classified in
02b-filenames_wildcards2 by
'bin/.*/tests/.*'
Sponsored by: Klara, Inc. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D52927
debug: classified in
02b-filenames_wildcards2 by
'bin/.*/tests/.*'
Sponsored by: Klara, Inc. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D52928
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
Stop the threads before exiting test body. Otherwise there is a chance threads would use the softc that is stored on the main thread stack after it is destroyed and the test would fail. Stop the threads in the reverse order, so that listener is stopped after all connectors are stopped. Tested by: olivier
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
Fix a test failure that occurs when max_buf_aio exceeds 31, as the calculated buffer size exceeds the 16 KB memory disk device. Increase the MD device size to 1 MB to prevent truncation. Rename MD_LEN to DEVICE_IO_LEN for clarity and add a more descriptive error message. Reviewed by: asomers Approved by: asomers Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D52914
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
While here, use 'required_kmods' instead of ad-hoc checks. Signed-off-by: Siva Mahadevan <me@svmhdvn.name> Reviewed by: markj MFC after: 3 days Sponsored by: The FreeBSD Foundation Pull Request: https://github.com/freebsd/freebsd-src/pull/1855
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
While here, use 'required_kmods' instead of ad-hoc checks. Signed-off-by: Siva Mahadevan <me@svmhdvn.name> Reviewed by: markj MFC after: 3 days Sponsored by: The FreeBSD Foundation Pull request: https://github.com/freebsd/freebsd-src/pull/1856
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
- Fail loudly if we can't change the kern.crypto.allow_soft sysctl. - Add more drivers to the list. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D52490
debug: classified in
03-filenames_plain1 by
'tools/tools/crypto/cryptocheck.c'
pf tests: make syncookie:loopback more robust
Give the background nc process a bit of time to start before we attempt to
connect to it.
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
pf tests: give inetd some time to start
Give inetd time to start rather than immediately trying to connect to it.
Make the tests a little more robust.
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
pf tests: give rules_counter:4G more time
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
The lack of these lines means we don't call the cleanup function.
That's not as bad as it could be, because these tests are nested in a jail by
Kyua, so most of the cleanup work (destroying jails and interfaces) is done when
the parent jail goes away, but it's still better to have these lines.
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
Disable epair's checksum offload on one interface in a nat test, to ensure
that pf does the right thing in scenarios where one interface offloads checksum
handling and one does not.
We trust the TCP (or ICMP) checksum verification code to drop the packet if pf
does it wrong, which will cause the test case to fail.
Suggested by: tuexen
Sponsored by: Rubicon Communications, LLC ("Netgate")
debug: classified in
02b-filenames_wildcards2 by
'tests\/.*'
These could go in other categories, but it's more clear if they're here instead.
Reviewed by: des Approved by: emaste (mentor) Fixes: https://cgit.freebsd.org/src/commit/?id=6c5cdba1bafe ("Add nss_tacplus, a TACACS+ NSS module.") MFC after: 1 day Differential Revision: https://reviews.freebsd.org/D52882
debug: classified in 01-style
by '[tT]ypo'
No functional change intended. MFC after: 3 days Sponsored by: Netflix, Inc.
debug: classified in 01-style
by '[rR]emove stray'
In 'nullfs_subr.c':
- Sort the headers.
- Use '__func__' in preference to the function's name in an assertion.
This applies comments from D38761, one of which was missed and the other
added too late.
Reviewed by: kib
MFC with: 249ec85352b5 ("nullfs: smr-protected hash lookup")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52935
debug: classified in 01-style
by '[sS]tyle'
MFC after: 3 days Sponsored by: Netflix, Inc.
debug: classified in 01-style
by '[rR]emove stray'
MFC after: 3 days Sponsored by: https://www.patreon.com/bsdivy
debug: classified in 01-style
by '[tT]ypo'
unbound: Vendor import 1.24.0
Release notes at
https://nlnetlabs.nl/news/2025/Sep/18/unbound-1.24.0-released/
MFC after: 1 week
Merge commit '0064eb9cf1c8d526e87d3149249445d4bc8d0248'
debug: classified in
05-summary-prefix by 'unbound:'
local-unbound-setup: Set so-sndbuf to 0 Without this setting, Unbound 1.24.0 and newer will attempt to set the socket buffer size to 4 MB to mitigate issues that mostly affect servers with large numbers of clients on local networks, which is not a scenario local-unbound is intended for. This is not only a waste of resources, it can also fail, resulting in a warning message on daemon startup. Fixes: https://cgit.freebsd.org/src/commit/?id=b2efd602aea8 ("unbound: Vendor import 1.24.0") Reviewed by: jlduran, cy Differential Revision: https://reviews.freebsd.org/D52977
debug: classified in
04-filenames_plain2 by
'usr.sbin/'
debug: moved to contrib because
'Need to be grouped with
b2efd602aea8b3cbc3fb215b9611946d04fceb10'
MFC with: 046c625e9382 Fixes: https://cgit.freebsd.org/src/commit/?id=046c625e9382 ("crypto/openssl: update to 3.5.4") Reported by: Herbert J. Skuhra <herbert@gojira.at>
debug: classified in
05-summary-prefix by
'crypto/openssl:'
Version for change and feature requests. * Improve documentation for --alternate-screen and --normal-screen. Request: https://bugs.freebsd.org/285459. (This PR is not about bsddialog itself but is used as an example for an official FreeBSD documentation request.) * Reduce the number of screen refreshes to improve performance over a 115200 UART connection. Request: https://gitlab.com/alfix/bsddialog/-/issues/8. * Change textbox buttons to return distinct values (previously always returned OK). Request: https://reviews.freebsd.org/D48668; already committed in contrib/ 96a241a35905078bdc5d20bf25943cdb67758dea * Change forms navigation key behavior for ENTER and TAB. Request: https://bugs.freebsd.org/287592. Refer to /usr/src/contrib/bsddialog/CHANGELOG to know more. PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287592 Reported by: adrian Sponsored by: The FreeBSD Foundation Merge commit '653f765f05b8c7e3908ae92e9bf61522a50cefc9' into YYY
debug: classified in
03-filenames_plain1 by
'contrib/'
Reviewed by: ngie MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D51136
debug: classified in
03-filenames_plain1 by
'contrib/'
Merge commit '70f30afd4e9af5a51ee324d97e4d8c5f2124ec15'
Breaking changes:
- Upstream commit 24932b6 ("blocklistd: log the conf file line number
with bad protocol errors") breaks backward database compatibility.
An error will be displayed:
Key size mismatch 296 != 288
A new and compatible database, with the new name, will be created when the
service starts (committed separately).
- Upstream commit ddf6d71 ("implement BLOCKLIST_BAD_USER as a
"one-count" failure") introduced BLOCKLIST_BAD_USER with a one-count
failure mechanism. BLOCKLIST_AUTH_FAIL was implemented with a
two-count failure mechanism. Since we utilize BLOCKLIST_AUTH_FAIL, the
number of failed attempts now doubles towards the maximum limit
(nfails). This commit will be reverted separately.
Changes:
https://github.com/zoulasc/blocklist/compare/7093cd9...8aa81bf
Approved by: emaste (mentor)
MFC after: 2 days
Differential Revision: https://reviews.freebsd.org/D52869
debug: classified in
03-filenames_plain1 by
'contrib/'
Upstream commit ddf6d71 ("implement BLOCKLIST_BAD_USER as a "one-count"
failure") introduced BLOCKLIST_BAD_USER with a one-count failure
mechanism. BLOCKLIST_AUTH_FAIL was implemented with a two-count failure
mechanism. Since we have been utilizing BLOCKLIST_AUTH_FAIL, the number
of failed attempts now doubles towards the maximum limit (nfails),
giving system administrators the impression that the number of failed
authentication attempts is inaccurate.
Revert this commit until a consensus has been reached. We do not want
to introduce yet another breaking change with the renaming of the
library.
Approved by: emaste (mentor)
MFC after: 2 days
debug: classified in
03-filenames_plain1 by
'contrib/'
Follow up upstream rename from blacklist to blocklist. - Old names and rc scripts are still valid, but emitting an ugly warning - Old firewall rules and anchor names should work, but emitting an ugly warning - Old MK_BLACKLIST* knobs are wired to the new ones Although care has been taken not to break current configurations, this is a large patch containing mostly duplicated code. If issues arise, it will be swiftly reverted. Reviewed by: ivy (pkgbase) Approved by: emaste (mentor) MFC after: 2 days Relnotes: yes
debug: Commit manually moved from "unknown" to "contrib".
Silence a bogus warning about (an ethernet) anchor not being found. It has been reported as PR 280516. In the meantime, just sweep under the carpet. Approved by: emaste (mentor) MFC after: 2 days
debug: Commit manually moved from "unknown" to "contrib".
cam/iosched: Initialize max_lat Sponsored by: Netflix
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
Revert "cam/iosched: Initialize max_lat" This reverts commit ce89c8f47a91f76b2fdeb1fdb504fd637ce93047. There's other parts to this, and GENERIC doesn't include iosched so I missed that. Back out while I gather them together. Sponsored by: Netflix
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
As of commit 87a7b35f04b6 ("bsdinstall: fix vfs.zfs.vdev.min_auto_ashift
oid") the installer uses the current vfs.zfs.vdev.min_auto_ashift sysctl
name, but there are many systems with configurations referring to the
legacy vfs.zfs.min_auto_ashift sysctl. For now, restore the aliases.
This reverts commit ced72fdd69f27b54cf592351a36660cd9fd7dbd3.
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266374
Reviewed by: mm
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52660
debug: classified in 00-reverts
by 'This reverts commit
\b([0-9a-fA-F]{40})\b'
Not classified automatically, and waiting for manual attention.
-- no commits in this category this week --
Dates:
Automatic grouping:
This reverts commit \\b([0-9a-fA-F]{40})\\b
and the hash was found in this week's commits.
Automatic categories:
Source code:
Generated with commits-periodical 0.18 at 2025-10-20 20:27:07+00:00.
This work is supported by Tarsnap Backup Inc.
Alternate version: 2025-10-06 (release)