FreeBSD git weekly: 2025-10-06 to 2025-10-12

Introduction

This is a display of mostly-automatically-classified git commits from 2025-10-06 to 2025-10-12.

In the future, these reports might include summaries or additional information, but for now our focus is figuring out what type of classification would be most useful.

Table of contents and commits per category:

(1) Highlighted commits (these are copies, not in stats)
2 1.3% Userland programs
21 13.7% Documentation
18 11.8% Hardware support
11 7.2% Networking
16 10.5% System administration
5 3.3% Libraries
7 4.6% Filesystems
9 5.9% Kernel
33 21.6% Build system
0 0.0% Internal organizational stuff
14 9.2% Testing
5 3.3% Style, typos, and comments
9 5.9% Contrib code
3 2.0% Reverted commits
0 0.0% Unclassified commits
153 100% total
Technical notes about this page

Highlighted commits

For extra visibility, these are copies of commits found in other sections. Most (if not all) come from the commit message containing "Relnotes:", or commits modifying UPDATING.

blocklist: Rename blacklist to blocklist
Follow up upstream rename from blacklist to blocklist.

- Old names and rc scripts are still valid, but emitting an ugly warning
- Old firewall rules and anchor names should work, but emitting an ugly
  warning
- Old MK_BLACKLIST* knobs are wired to the new ones

Although care has been taken not to break current configurations, this
is a large patch containing mostly duplicated code.  If issues arise, it
will be swiftly reverted.

Reviewed by:    ivy (pkgbase)
Approved by:    emaste (mentor)
MFC after:      2 days
Relnotes:       yes
7238317403b95a8e35cf0bc7cd66fbd78ecbe521 Jose Luis Duran 2025-10-12 17:14:27

Userland programs

Commits about commands found in man section 1 (other than networking).

lsvfs(1): Capsicumise
Signed-off-by: Faraz Vahedi <kfv@kfv.io>

Reviewed by:    asomers, markj
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1498
a0c709ab5af4e87ce4579404c4ffbd4295ad12c5 Faraz Vahedi 2025-08-11 17:53:55
vmstat: Print the number of wired pages in each object
Reviewed by:  alc, kib
MFC after:      1 week
Sponsored by:   Modirum MDPay
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53008
f66bb825f5895eed98c959cd2b612453b4d1aa6c Mark Johnston 2025-10-10 13:28:01

Documentation

Man pages, release notes, etc.

iovctl.8: Fix missing xref section number
MFC after:    3 days
17085d8eb1207aa925ca5eeda1d5ba132f1dd163 Alexander Ziaee 2025-10-06 18:48:06
ice.4: Improve SYNOPSIS
Remove prose from synopsis, adding sysctls and tunables.

MFC after:              3 days
Reviewed by:            kbowling
Differential Revision:  https://reviews.freebsd.org/D52913
45f8336f3a3128c4c935a192e621c4882d6499be Alexander Ziaee 2025-10-06 18:48:50
snl.3: use \e esc sequence for \ as per mandoc_char(7)
Suggested by: cyric@mm.st
dcb5ee48960a3c1d0120be0524d4c81f831d23a3 Maxim Konovalov 2025-10-06 21:10:26
pf.conf.5: 'address' is mandatory with route-to
Adjust the BNF, and don't claim it is optional in the text.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290059
MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")
306f29475fcefcca0a32d1cd764eabf7b2e441f8 Kristof Provost 2025-10-07 08:13:23
fts: Further improve the manual page
* Add subsections for the three functions that didn't already have one.
* Add a RETURN VALUES section.
* Improve the grammar somewhat.
* Clarify that fts_read() will not set errno to 0 if called again after
  having already returned NULL.

Sponsored by:   Klara, Inc.
Reviewed by:    bcr, markj
Differential Revision:  https://reviews.freebsd.org/D52925
a802334d86c7173ddd7776a20065bd5682f25f67 Dag-Erling Smørgrav 2025-10-07 16:23:33
bsdinstall.8: Fix '---jail' option in manpage
The .Fl macro implicitly adds a '-', so only use a single '-' in the
--jail option.

Fixes:  https://cgit.freebsd.org/src/commit/?id=8d0a90512ee3 ("bsdinstall: Improve pkgbase handling for jails")
MFC after:      1 day
Reported by:    Mark Millard <marklmi@yahoo.com>
Sponsored by:   https://www.patreon.com/bsdivy
ed5023c96c6e0228d4c38d89b86809c713ed3d68 Lexi Winter 2025-10-08 09:28:03
arch.7: deprecate __ILP32__ and __LP64__ macros
With CHERI there now more options than __ILP32__ and __LP64__ so lack of
one does not imply the other.  Encourage the use of __SIZEOF_*__ macro
tests in their place.

Effort:         CHERI upstreaming
Reviewed by:    kib, markj, emaste
Sponsored by:   Innovate UK
Differential Revision:  https://reviews.freebsd.org/D52820
9e7eb261e6f965f121515cc52db96ea879b8b384 Brooks Davis 2025-10-08 09:30:34
arch.7: decouple long and pointer sizes
Don't claim void* or (u)intptr_t are the same size as long.  This isn't
true for CHERI.

Effort:         CHERI upstream
Reviewed by:    kib, markj, jhb, emaste
Sponsored by:   Innovate UK, DARPA, AFRL
Differential Revision:  https://reviews.freebsd.org/D52821
2fe28202aaac4735f4982e7b79997a0dbc66e588 John Baldwin 2025-10-08 09:31:17
arch.7: Add CHERI architectures
Effort:               CHERI upstreaming
Co-authored-by: Brooks Davis <brooks@FreeBSD.org>
Reviewed by:    kib, markj, jhb, emaste
Sponsored by:   Innovate UK, DARPA, AFRL
Differential Revision:  https://reviews.freebsd.org/D52822
fd895b4f0423e430e311f5ee340b21458dc46b47 John Baldwin 2025-10-08 09:31:41
jail.8: Mention that vnet.interface can have multiple addresses
The vnet.interface parameter allows defining multiple interfaces,
separated by commas. Mention this in the man page.
While here, fix some other style nits that mandoc complained about.

PR:                     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206353
Approved by:            ziaee
Differential Revision:  https://reviews.freebsd.org/D52965
ab0329e6eb457590e55d54267ef67453e11bc7cd Paul Armstrong 2025-10-08 16:15:26
aacraid.4: Improve HARDWARE introductory sentance
To improve HW relnotes

MFC after:      3 days
20a8d06034791c8bb2cc733e4fe4fa1bc60273ec Alexander Ziaee 2025-10-08 16:45:33
aacraid.4: Fix document description + tag SPDX
The document description previously just stated the name of the driver.
Replace this with the name of the controller families and specs that
it supports, in a similar fashion to other RAID drivers.

MFC after:      3 days
d5d1e05efbedf67f1ef8e8428f9107401e369a0b Alexander Ziaee 2025-10-08 16:48:19
getgrouplist.3: Insist on the value returned in 'ngroups'; Minor changes
Emphasize the peculiar treatment of 'ngroups', through which the
effective group list's size is returned, even if the passed allocated
size is not big enough, in which case the output 'groups' array is
completely filled with the effective group list's first elements.

Use the precise POSIX term for the group associated to the user in the
password database ("initial numerical group ID"), consistently with what
was done in initgroups.3.

Use "length" instead of "size" to refer to the number of elements of an
array (in contrast with its actual size in bytes).

Perform some minor simplifications on top of the last rework.

MFC after:      1 hour
Sponsored by:   The FreeBSD Foundation
f5544556754ec6b33c1d13c7648a354fef645b2f Olivier Certner 2025-10-08 10:06:02
initgroups.3: Clarify that ENOMEM is a possible value for 'errno'
The current phrasing could be interpreted as meaning that initgroups(3)
could return ENOMEM instead of -1, which it actually did until I fixed
it in commit 0b018cfd81d8 ("initgroups(3): Fix return value on
allocation failure").

While here, mention setgroups(2) as a system call rather than a library
function.

MFC with:       0b018cfd81d8 ("initgroups(3): Fix return value on allocation failure")
Sponsored by:   The FreeBSD Foundation
c36a44e1cdab1c67a98132676818f473cc4e5c03 Olivier Certner 2025-10-09 14:04:44
Merge commit '1fdae2e33fdc751bc2ec74c81fcde14323e4e965'
Be explicit that newaliases for sendmail
(Upstream sendmail.org commit 3084151d898)

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289259
MFC after:      1 hour
e9f7c3de111b9dda23e1763e030688d78a71d8ff Gregory Neil Shapiro 2025-10-09 18:03:43
umass.4: Modernize driver loading instructions
+ consolidate kernel configuration in SYNOPSIS
+ explain driver autoloading in DESCRIPTION
+ s/port/interface/ because of internal USBs
+ fix flow of remaining example

MFC after:      1 day
d8a4843cb76ec1b7da8d5defafb7eef9a6cc1c21 Alexander Ziaee 2025-10-09 14:55:14
cli.lua.8: Reflow literal comments
Reflow comments in literal text blocks
so this manual is legible at MANWIDTH 78.

MFC after:      1 day
de36d0dbaeaf05e9bf949fdf22b560c34b2c0d74 Alexander Ziaee 2025-10-09 21:13:54
mount_nullfs.8: document unixbypass and nounixbypass
Reviewed by:  markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52983
033587a985a46e9d45fc3fb48a78754d81f0d50d Konstantin Belousov 2025-10-09 20:55:01
getgroups.2: Simplifications; Be clearer on programs to be modified
In the STANDARDS section, stop mentioning behavior that is not
prescribed by POSIX and make sure to specify which alternative we
implement (as POSIX allows to return or not the effective group ID).

Say more clearly that programs treating specially the first slot of the
returned array must be modified.

Consistently use "group ID" instead of "GID".

These changes are going to be MFCed into stable/14 as part of MFCing
commit 4be38acc826f ("getgroups.2: Clarify, mention ascending order, add
SECURITY CONSIDERATIONS"), so the current commit will be MFCed to
stable/15 only.

MFC after:      1 hour
MFC to:         stable/15
Sponsored by:   The FreeBSD Foundation
c363dcbe75b2c7171611815daec82d263607ee37 Olivier Certner 2025-10-10 15:49:47
RELNOTES: Add an entry for commit 5000d023a446
9504e956c50875b2325f62c2d658509fa10d489d Rick Macklem 2025-10-12 00:35:04
RELNOTES: Fix up the entry for 5000d023a446
1129bf441e99b9ced3fe448e19cbb15b64b9b3f1 Rick Macklem 2025-10-12 00:43:10

Hardware support

Hardware drivers and architecture-specific code.

x86: Close race condition on MCA task queues at startup
Currently, the CMCI handler checks the cold variable to determine
whether it can schedule a task. The task queue is setup as part of the
mca_startup() function, which is run well after the configure_final()
function sets the cold variable to 0. Therefore, if an MCA arrives
in the window between configure_final() and mca_startup() running,
the code could try to schedule a task on an unintitalized task queue.

Close the race by specifically checking whether the mca_startup()
function has run.

Reviewed by:    markj
MFC after:      1 week
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D12276
4a5d8670a7d58b04913fd90aae85a1e35236ca3d Jonathan T. Looney 2025-10-03 16:23:07
x86: Defer non-fatal MCA message output from the HW interrupt context
When processing recoverable MCA events in a hardware interrupt context,
defer logging the messages to a task queue.

Reviewed by:    markj
MFC after:      2 weeks
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D12275
5e1611a37a02076180ccea1506713b8c9628779e Jonathan T. Looney 2025-10-03 18:26:37
ahci: Use pci_msix_*_bar instead of reading config registers directly
Reported by:  avg
Reviewed by:    avg, imp
Differential Revision:  https://reviews.freebsd.org/D52888
762f1c7c6cded9242956c2c35c772dff9b5d155b John Baldwin 2025-10-06 17:56:47
ahci: Don't fail attach if the MSI-X BARs cannot be allocated
If the MSI-X table and/or PBA live in separate BAR(s) and those BAR(s)
cannot be allocated, fall back to using MSI or INTx instead of failing
attach.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289748
Reported by:    Vitalij Satanivskij <satan@Ukr.net>
Reviewed by:    avg, imp
Differential Revision:  https://reviews.freebsd.org/D52889
b658158e9396848d3963e9555d356d0f4ca6900a John Baldwin 2025-10-06 17:56:47
arm64: Add Debug OS Lock fields
Sponsored by: Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52930
fa975e2a5bb221e2e15305c4c54162f7b9ec062a Andrew Turner 2025-10-07 08:25:25
arm64/vmm: Handle debug exits
This is enough to boot FreeBSD again.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290044
Reported by:    Siva Mahadevan <me@svmhdvn.name>
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D52931
534aec00976c18c4c4b485b2fade9d5f33de89c8 Andrew Turner 2025-10-07 08:26:00
x86: Reduce amount of time the MCA lock is held while emitting records
The MCA spin lock is acquired in the hardware interrupt context to
record MCA messages. It is also acquired by a task handler to emit
those messages.

Reduce the amount of time the task handler holds the lock to reduce
the maximum amount of time the hardware interrupt handler may need to
spin on the lock.

Reviewed by:    glebius, markj
MFC after:      2 weeks
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D52938
e770e32aa3a017b35fcf24e7c6f14fc2a209bad5 Jonathan T. Looney 2025-10-06 15:07:33
x86: Add a way to inject artificial MCA events for testing
Reviewed by:  glebius
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D52942
1c2fc62e4a9689961169be7836038acd5f757be1 Loic Prylli 2025-10-06 17:59:41
nvme: Tweak completion timeout loop
* Rename delta_t to avoid misleading simplistic syntax highlighters
* Simplify the increment calculation

Sponsored by:   Klara, Inc.
Sponsored by:   NetApp, Inc.
Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D52973
4070ae0e9a60715199f83004e7ebdfb169fc8cfc Dag-Erling Smørgrav 2025-10-08 10:07:13
x86: Allow MCA messages to be rate-limited
Always print the first 50 messages of each type. After that, optionally
rate-limit the messages. This provides a way to limit the overhead of
processing excessive messages without suppressing the first few of any
type.

As part of this change, we are switching from direct printf() calls to
collecting data in an sbuf(9). In POLLED mode (run from a task queue),
we dynamically allocate the buffer. In the other modes (which are
likely called from a hardware interrupt), we use a buffer allocated
from the BSS segment and guarded by a lock. In normal operation,
most calls to mca_log() should come from the POLLED mode, so there
should be no contention for the new lock. If there is an interrupt
storm which exceeds the capacity of the free list, there will be new
contention for this lock; however, overall lock contention should
still be lower than it was prior to e770e32aa3a0, when the mca_lock
was almost always held for the entirety of the mca_log() call.

This commit is partly based on a patch proposed by Loic Prylli
<lprylli@netflix.com>.

Reviewed by:    markj, glebius (previous version)
MFC after:      2 weeks
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D52946
0d14826de7d9d72e91f1d396120f1456102bccf4 Jonathan T. Looney 2025-10-06 20:39:51
x86: support sending non-fatal MCA messages to syslog
Currently, all MCA messages are logged to the console. However, this
can have performance implications which can turn a storm of correctable
errors into a disruptive event.

Provide an option to direct non-fatal messages to syslog. Note that
we will always log to the console for fatal errors.

Reviewed by:    markj
MFC after:      2 weeks
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D12278
55c28005f544282b984ae0e15dacd0c108d8ab12 Jonathan T. Looney 2025-10-07 12:58:05
nvme: There's 64 LBAF descriptors, not 16
Older versions of the standard were limited to 16, but the actual limit
is 64. Bump the limit to 64. This should be a #define, but there's no
good standardized name, so I'm punting on that. All the places that use
it, apart from the byte swapping code, do the right thing and use the
nlbaf field to limit what to access.

Sponsored by:           Netflix
53825afc5dd13f3d16c3db6727260d7184bcd581 Warner Losh 2025-10-10 00:16:47
ix(4): Add support for debug dump for E610 adapters
This is part 2 of the support for the new Intel Ethernet E610 family of devices.

Intel E610 Ethernet Controller devices feature a debug dump capability
that allows you to capture runtime register values directly from the
hardware, with assistance from the firmware. These registers are
organized into clusters based on their function, enabling targeted
debugging. This information is consolidated into a single dump file,
facilitating the debugging of complex issues encountered in the field.
The debug dump provides a snapshot of the device's current hardware
configuration, including switch tables, transmit scheduler tables, and
other relevant data. It captures the state of specified clusters and
serves as a stateless snapshot of the entire device.

This update introduces ioctl and sysctl support for the debug dump feature.

Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com
Co-developed-by: Krzysztof Galazka krzysztof.galazka@intel.com

Approved by:    kbowling (mentor), erj (mentor)
Tested by:      gowtham.kumar.ks_intel.com
Sponsored by:   Intel Corporation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D50934
2170400142b99c0eb604403b74ebd88c05dd7ed4 Bhosale, Yogesh 2025-10-10 09:39:16
ice(4): Add PCI IDs for E835 devices
Add device IDs and branding strings for E835 adapters.
This is a follow up for E830 adapters with Security Protocol
and Data Model (SPDM) support and RDMA support available
on 100 and 200Gbps links.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Approved by:    kbowling (mentor), erj (mentor)
Sponsored by:   Intel Corporation
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D52782
b202176dc76d862f886778439b96dd1243d8b999 Krzysztof Galazka 2025-10-10 12:04:00
Commit group #0: vmm
vmm: Unify implementations of vcpu_cleanup()

Different vmm implementations were freeing the per-vCPU structure in
different places.  Make the implementations consistent.  No functional
change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53010
756fa1c09673ba555f603574af5943f455daff90 Mark Johnston 2025-10-10 13:16:45

vmm: Make vmmops declarations more consistent

- On amd64, make vmmops_* functions globally visible, as some will be
  called from machine-independent code in the future.
- On arm64 and riscv, move declarations to vmm.h, since they're supposed
  to be generic across different VMM backends (only amd64 has more than
  one backend).
- Make the declaration macros consistent with each other.
- On amd64, make the function typedef names consistent with the
  corresponding ifunc names.

No functional change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53011
e9182981f7feeb97ee440bb9c1db9a1bc5309b92 Mark Johnston 2025-10-10 13:19:57

vmm: Move the guest vmspace into the generic vm_mem structure

This further consolidates handling of guest memory into MI code in
sys/dev/vmm.

No functional change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53012
059b0b7046639121f3dca48f5de051e019f9d57c Mark Johnston 2025-10-10 13:20:12

vmm: Remove some unused macros

No functional change intended.

Reviewed by:    corvink
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53013
642c763a9ad14cbe70596cabc16f73b9ca99de57 Mark Johnston 2025-10-10 13:22:16

Networking

Network-related commands, library, and kernel.

tcp: improve SEG.ACK validation in SYN-RECEIVED
According to the fifth step in SEGMENT ARRIVES, send a RST segment in
response to an ACK segment which fails the SEG.ACK check, but leave
the endpoint state unchanged.
FreeBSD handles this correctly when entering the SYN-RECEIVED state via
the SYN-SENT state, but not in the SYN-cache code, which handles the
SYN-RECEIVED state via the LISTEN state.

This also fixes a panic reported by Alexander Leidinger.

Reviewed by:            jtl, glebius
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52934
8af2f06a99b10c0d3ab9021949e750852662672a Michael Tuexen 2025-10-06 20:39:31
netlink: in snl_init_writer() don't overwrite error in case of failure
488718ff42346888243496c00cbeb42ba004171e Bruno Silvestre 2025-10-07 05:48:28
ipv6: don't complain when deleting an address with prefix length of 128
Save prefix length in unused field in6_ifaddr->ia_plen, then on remove
check if an address has 128 prefix length, and if so, we don't need to
complain that there is none of related prefixes.

Reviewed by:    kp
Obtained from:  Yandex LLC
MFC after:      1 week
Sponsored by:   Yandex LLC
Differential Revision:  https://reviews.freebsd.org/D52952
c4cce0a3e94e3b22f874508d1a9cd81442648238 Andrey V. Elsukov 2025-10-07 13:08:15
sockstat: support reporting of BBLog state
Add a -b option to print the BBLog state for TCP sockets.

Reviewed by:            jtl, rrs
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52944
d801cc2d8542854a5dee9bfb25a15af6fa1dafad Michael Tuexen 2025-10-06 23:24:43
net80211: document some of the crypto/key functions
This documents the following functions:

* ieee80211_is_key_global()
* ieee80211_is_key_unicast()
* ieee80211_crypto_get_key_wepidx()
* ieee80211_crypto_get_keyid()
* ieee80211_crypto_get_txkey()
* ieee80211_crypto_encap()
* ieee80211_crypto_decap()

Differential Revision:  https://reviews.freebsd.org/D52649
1f76551e1a5e98673f31043d11366ca41d4f56fe Adrian Chadd 2025-09-20 21:30:42
sockstat: improve indentation
No functional changes intended.

MFC after:      3 days
Sponsored by:   Netflix, Inc.
ab837a2eed6d7562d538ac5f90b3b2776a9f0f5f Michael Tuexen 2025-10-07 02:04:35
tcp lro: use theflowid only when it has hash properties
When a packet is provided to LRO using tcp_lro_queue_mbuf(), a
sequence number is computed based on the m_pkthdr.flowid provided
by he driver. The implicit assumption is that the m_pkthdr.flowid
has hash properties.
The recent use of tcp_lro_queue_mbuf() in iflib exposed a bug in at
least one driver (igc) , which
* reports always that is uses M_HASHTYPE_OPAQUE.
* sets in some cases m_pkthdr.flowid not consistently for packets
  belonging to the same TCP connection.
This results in severe performance problems for the base TCP stack,
since it handles the packets in the wrong sequence, although they were
received in the correct sequence.
To protect against such misbehaving drivers, just take the
m_pkthdr.flowid only into account, if it has hash properties.
The performance problems were observed by gallatin@ and analyzed
together with rrs@.

Reviewed by:            gallatin
Tested by:              gallatin
MFC after:              5 Minutes
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52989
73f56fa542ecf6ea6819c9e17fc60962eeb726d8 Michael Tuexen 2025-10-09 12:37:11
sockstat: improve output formatting
Fix the format when the output for a socket spans multiple lines.

Reviewed by:            rrs
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52984
98b2a2265f5ee47bd932347699e6117df2f41488 Michael Tuexen 2025-10-09 19:10:53
sockstat: show path state column only when useful
Showing the path state column is only useful, if there is at least one
SCTP endpoint shown, which is not in the state CLOSED or LISTEN.
Don't show it when it is not useful.

Reviewed by:            rrs
MFC after:              3 days
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D52986
746eadecaa7dc8913721cbaa9be4e603bd36ea49 Michael Tuexen 2025-10-09 19:16:38
ctld: Defer initialization of NVMeoF associations
Wait until all of the configuration has been parsed before creating
associations for NVMe portals.  This ensures that any options
specified in a transport group are honored when creating associations.

To enable this, add a new virtual method portal::prepare invoked when
applying a configuration prior to opening a socket (or reusing an
existing socket) for a portal.

Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D52844
1435a9b293e21f8fca1f654420c5075ea7434e8f John Baldwin 2025-10-09 19:24:27
dummynet: SDT probe dropped packets
Add static probe points to track where we increment io_pkt_drop. This is
intended to assist in debugging dummynet, allowing us to work out when and
hopefully why packets get dropped.

Sponsored by:   Rubicon Communications, LLC ("Netgate")
02923dd9b0de050b989b5a4103e402055cb7f61a Kristof Provost 2025-10-10 10:06:21

System administration

Stuff in man section 8 (other than networking).

pfctl: store correct ticket type
When loading a new rule only persist the ticket if we're actually looking at a
filter rule. We need that ticket type later if we have to create tables, but we
need the ticket for the correct ruleset.

Fixes:  https://cgit.freebsd.org/src/commit/?id=9dfc5e03da50 ("pfctl: allow tables to be defined inside anchors")
Reported by:    Florian Smeets <flo@smeets.xyz>
MFC after:      3 days
Sponsored by:   Rubicon Communications, LLC ("Netgate")
8fecb09bc58ea39833b57c88637036124d71e0ce Kristof Provost 2025-10-06 09:45:59
pfctl: check if the anchor exists before we attempt to flush anything from it
PR:           https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289994
Sponsored by:   Rubicon Communications, LLC ("Netgate")
b476593519e98c11752a207e7cb121fba5c1961b Kristof Provost 2025-10-06 15:57:44
libsa: smbios: Detect less-than-64-bit platforms via __SIZEOF_SIZE_T__
What we really want here is to know if pointers can refer to 64-bit
addresses, regardless of whether they also hold other information (such
as capabilities in CHERI).  __SIZEOF_SIZE_T__ is probably the closest
indication to that piece of information, so let's use it.  __ILP32__
wasn't wrong in practice though, as we don't support 32-bit CHERI
hardware (and likely never will).

Consistently with this change, test whether we can actually address the
64-bit SMBIOS's structure table by converting the end address to
'size_t' and checking whether its value is preserved.

Suggested by:   jhb (for the __ILP32__ => __SIZEOF_SIZE_T__ part)
Reviewed by:    jhb, imp
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D49318
d3bfcd66409befc2d545e5449963b41c25c369a9 Olivier Certner 2025-03-11 16:56:20
Commit group #1: krb5: create the KDC database directory
krb5: create the KDC database directory

Reviewed by:            rmacklem, cy
Differential Revision:  https://reviews.freebsd.org/D52970
e7e7bf757acef3d4e41a6e22f7d04b3df08834cc Gleb Smirnoff 2025-10-07 21:50:07

etc/mtree: Add package tags for Kerberos directories

Fixes:          https://cgit.freebsd.org/src/commit/?id=e7e7bf757ace ("krb5: create the KDC database directory")
MFC after:      3 seconds
Reviewed by:    cy
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52975
6235ee2848df583d600a7b5d7cc284a5b32c7be7 Lexi Winter 2025-10-10 05:28:14
BSD.root.dist: Add package tag for all directories
This fixes some missing directories, notably /boot/modules.  Other
directories are not missing because they contain other files, but
they should still have their own METALOG entries and be placed in
the correct package.

MFC after:      3 days
Reported by:    bdrewery
Reviewed by:    cperciva, imp
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52958
fa6d67cd16b50a7a0be1f003cf1aa1f4064fc2c9 Lexi Winter 2025-10-08 05:49:47
rcorder: Fix grammar in warning about loops
MFC after:    1 week
Reviewed by:    ae
Differential Revision:  https://reviews.freebsd.org/D52951
d96f9a4688668ececc09c61dcf6b539a55112cc0 Dag-Erling Smørgrav 2025-10-08 10:07:01
pw: pw_mkdb(3) does not set errno
MFC after:    1 week
Sponsored by:   The FreeBSD Foundation
Sponsored by:   Klara, Inc.
b464c7a75e30e6149906458075b7eaf0841c7222 Mark Johnston 2025-10-08 12:47:15
rc: Update dependencies for zpool scripts
After commit 900bc0206348, zpool depends on mountcritlocal.  zpoolreguid
and zpoolupgrade depend on zpool and want to run before mountcritcycle,
so we have a pair of cycles.

Update zpoolreguid and zpoolupgrade to avoid this.

Reviewed by:    des
MFC after:      3 days
Fixes:  https://cgit.freebsd.org/src/commit/?id=900bc0206348 ("rc.d/zpool: change mountcritlocal dep from BEFORE to REQUIRE")
Differential Revision:  https://reviews.freebsd.org/D52953
ae6db60ff56de5b93de9f6fee6116cbc2d4b498e Mark Johnston 2025-10-08 12:50:54
rc tests: Add a test to check for warnings from rcorder
Reviewed by:  des
MFC after:      2 weeks
Differential Revision:  https://reviews.freebsd.org/D52954
04d47c7cde54cc325cca3f47113976f5500dc58f Mark Johnston 2025-10-08 12:51:16
Commit group #2: nfsuserd: Fix OOB access on membership of too many groups
nfsuserd: Fix OOB access on membership of too many groups

getgrouplist() sets the variable containing the allocated length in
input to the full effective group list length, not the number of slots
that were actually filled in case the passed array is too small to
contain it.

While here, on this condition, improve the error message by outputting
the corresponding user name.

MFC after:      1 hour
Fixes:          https://cgit.freebsd.org/src/commit/?id=e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.")
Sponsored by:   The FreeBSD Foundation
bb339adfb2a26c5bb71cd4275dff80f615534ab6 Olivier Certner 2025-10-09 09:19:37

nfsuserd: Fix OOB access on membership of too many groups, take 2

Forgot to reset 'ngroup' after one of the calls to getgrouplist() in the
previous commit with same title (referenced also below).

MFC after:      1 hour
Fixes:          https://cgit.freebsd.org/src/commit/?id=e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.")
Fixes:          https://cgit.freebsd.org/src/commit/?id=bb339adfb2a2 ("nfsuserd: Fix OOB access on membership of too many groups")
Sponsored by:   The FreeBSD Foundation
75eb6846269bb9bec1eaf4f0ad93d7525715b550 Olivier Certner 2025-10-09 17:03:11
acpidump: quiet gcc -Wstrict-aliasing
Appease GCC.

Reviewed by:    kib
Differential Revision:  https://reviews.freebsd.org/D52941
e474fdfde604372000fc6bc4f7197b1e7c904597 Ryan Libby 2025-10-09 19:29:37
virtual_oss: Clean up rcorder
sndiod is part of audio/sndio, so we should avoid referencing a port
utility from base.

We should also require NETWORKING for the service to start, since
virtual_oss can be configured to send audio through the network.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 day
Reviewed by:    des, markj, emaste
Differential Revision:  https://reviews.freebsd.org/D53019
188ddc15e5460b3abfb2ad5492557911465bedc1 Christos Margiolis 2025-10-10 13:07:23
rpc.tlsservd.c: Pin max threads at 1 for now
PR#289734 reports a crash in tcp_use_close() when the rpc.tlsservd
daemon is being used.  Although I have no, as yet, had time to track
down/fix the race, it turns out setting rpctls_maxthreads to 1
avoids the problem.

This patch pins rpctls_maxthreads to 1 to avoid the problem,
until there is a proper fix.

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289734
MFC after:      3 days
7a289fe3cd5c6de7ddbe394b7700b20b0bafdb3e Rick Macklem 2025-10-10 23:29:25
bsdinstall: Tweak pkgbase/dist set labels
Have the button labels refer to the artifact type directly (distribution
sets / packages), and use "Tech Preview" as packaged base is no longer
experimental.

Reviewed by:    ivy, cperciva
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52999
abd9424590ba37ac10e92723ad6428f0448024c1 Ed Maste 2025-10-09 17:01:36

Libraries

libc: Reimplement the *rand48 family of functions
Rather than implementing the recurrence using 3 16-bit integers, as was
done in _dorand48() before this patch, provide an equivalent
implementation using 64-bit integers.

For drand48() and erand48(), replace the use of ldexp() with
bit-twiddling assuming IEEE 754 double-precision float layout.

This implementation is significantly faster and requires less code,
while producing identical outputs on supported platforms.

While here, add a STANDARDS section to rand48.3.

Obtained from:  https://github.com/apple-oss-distributions/libc
MFC after:      3 weeks
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D52429
2ba20004ef7649db7654520e8376927c4410d9c3 Mark Johnston 2025-09-04 19:34:17
fts: Remove a few stray blank lines
Sponsored by: Klara, Inc.
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D52924
31db1582c883cbdd151ffacb22829027f23ead40 Dag-Erling Smørgrav 2025-10-07 16:23:24
libcasper: explicit cast in cap_fileargs header
The implicit cast is incompatible with standard compiler options in a
C++ project, making the library difficult to use.

Signed-off-by: Quentin Thébault <quentin.thebault@defenso.fr>
Sponsored by: Defenso
MFC after: 3 days
Discussed with: kevans
Reviewed by: emaste, vexeduxr
Pull request: https://github.com/freebsd/freebsd-src/pull/1857
349da4dbff722a58affd13d84729b1d399b41fb3 Quentin Thébault 2025-09-26 02:04:07
libbz2: add pkg-config file (bzip2.pc)
Add generation of a bzip2.pc file for use with pkg-config and create
a basic template as bzip2.pc.in.

This allows other software to easily locate and link against libbz2
using standard pkg-config mechanisms instead of manual compiler and
linker flags.

The version number is extracted automatically from bzlib.h to keep
it consistent with the library sources.

Tested: pkg-config --exists --print-errors "bzip2 >= 1.0.9" (fail, expected)
        pkg-config --exists --print-errors "bzip2 >= 1.0" (succeeded)
        pkg-config --libs bzip2 (-lbz2)
        pkg-config --cflags bzip2 ()

MFC after:      3 days
586319793368cbc664b48187bda60d27e171753a Xin LI 2025-10-10 05:35:54
libm: remainder: make sure x is zero
Make sure the entirety of x is zero before flipping the sign bit.
Otherwise the sign would be wrong for small values of x when x is
negative and |n*y| > |x|

Reported by:    alfredo
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251091
Reviewed by:    kargl
MFC after:      3 days
Differential Revision: https://reviews.freebsd.org/D53023
25cca51ed294890d20a3c0290814cd26875db686 Ahmad Khalifa 2025-10-10 09:30:52

Filesystems

nullfs: Slightly reduce contention by reducing concurrent sections
In null_lock_prep_with_smr(), initialize 'lvp' outside of the
SMR-protected section.

In null_lock(), if after locking the lower vnode we notice that we have
been reclaimed, we have to unlock the lower vnode and then relock our
own now that the lock isn't shared anymore.  Call VOP_UNLOCK() on the
lower vnode as soon as this condition is known.

This applies comments from D38761, one of which was missed and the other
added too late.

Reviewed by:    kib
MFC with:       641a58239520 ("nullfs: avoid the interlock in null_lock with smr")
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52935
09f925b57aeb171318a9d54df500bf22b4cdd986 Olivier Certner 2025-10-06 13:22:13
nullfs: shrink null_node to 32 bytes
84f981ba57e77bd3c3d0fbf1469ce51bfd132a6b Mateusz Guzik 2025-10-06 17:59:17
nullfs: fix up build with INVARIANTS after previous
0ecbc335daa8caac8b5952d83e821533c99de6ea Mateusz Guzik 2025-10-06 19:21:38
fs/nullfs/null.h: put first definition after headers include
Reviewed by:  markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52983
035f1971ade4396d6f5d5b48f353030f559a0a5f Konstantin Belousov 2025-10-08 15:48:17
nullfs: add a helper for testing if vnode belongs to a nullfs mount
Reviewed by:  markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52983
419f2fe6b70b1a409bf7eca7020d7c745558690f Konstantin Belousov 2025-10-08 15:42:27
nullfs_mount: use symbols instead of string literals for cache mount options
Reviewed by:  markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52983
8e6f6a5fbde78bd8d19445ee6ebaf00b8f4f5aa9 Konstantin Belousov 2025-10-08 15:44:59
nullfs: add nounixbypass mount option
The option, when set, disables bypassing the unix socket vnode down
to the lower mp, effectively preventing connection to nullfs unix
socket from being acceptable from the lower mp (and vice versa).

This is done by providing a vop vector that stops bypass for unp-related
VOPs.  I believe that VFS_VOP_VECTOR_REGISTER() does the right thing
there regardless of the order of initialization.

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52983
6fa205a6233fea7c41ba0306c778bc5cab37ce7d Konstantin Belousov 2025-10-08 15:47:15

Kernel

Kernel stuff (other than networking, filesystems, and drivers).

mtx: rename MTX_CONTESTED to MTX_WAITERS
Using the word "contested" for the case where there are threads blocked
on the lock is misleading at best (the lock is already contested if it
is being held by one thread and wanted by another). It also diverges
from naming used in other primitives (which refer to them as "waiters").

Rename it for some consistency.

There were uses of the flag outside of mutex code itself.

This is an abuse of the interface. The netgraph thing looks suspicious
at best, the sctp thing is fundamentally wrong. Fixing those up is left
as an exercise for the reader.

While here touch up stale commentary.

Sponsored by:   Rubicon Communications, LLC ("Netgate")
e0b571d77364d0dcae5492d9f3b901d01d3e13ca Mateusz Guzik 2025-10-06 02:00:50
kern_exit.c: do not leak reaper bitmap busy bits
When re-assigning p_reapsubtree value, we must check if the result of
obliterating the old value would free the corresponding pid in the
proc_id_reap bitmap, and indeed free it when needed.

PR:     https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289917
Reported by:    avg
Reviewed by:    avg, markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D52814
f19ef352ec63f9fcc10076a263b8ce402ba31379 Konstantin Belousov 2025-10-01 03:17:31
power: Add stype parameter in power_suspend/resume eventhandlers
Add enum sleep_type stype parameter in power_suspend/resume event
handlers, as with the introduction of s2idle there are more than one
type of suspend.

Reviewed by:    bz
Approved by:    bz
Sponsored by:   The FreeBSD Foundation
fc2ed9d9680461937c7ffa4cc77fa38e656deb8b Aymeric Wibo 2025-10-06 21:30:54
linuxkpi: Support s2idle in `pm_suspend_target_state`
When going to s2idle, set Linux' pm_suspend_target_state to
PM_SUSPEND_TO_IDLE instead of setting PM_SUSPEND_MEM (for S3) in all
cases.

This is necessary because more recent versions of the amdgpu DRM drivers
have different paths for when entering s2idle & S0ix is supported than
S3.

Reviewed by:    bz
Approved by:    bz
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D51591
a25cfcab9a9d2c7d733b85bf04b504369623de1c Aymeric Wibo 2025-10-06 21:38:58
uma_core: Rely on domainset iterator to wait on M_WAITOK
Commit 8b987a77691d ("Use per-domain keg locks.") removed the need to
lock the keg entirely, replacing it with per-domain keg locks.  In
particular, it removed the need to hold a lock over waiting for a domain
to grow free memory.

Simplify the code of keg_fetch_slab() and uma_prealloc() by removing the
M_WAITOK -> M_NOWAIT downgrade and the local call to vm_wait_doms()
(which used to necessitate temporary dropping the keg lock) which the
iterator machinery already handles on M_WAITOK (and compatibly with
vm_domainset_iter_ignore() at that, although that does not matter now).

Reviewed by:    bnovkov, markj
Tested by:      bnovkov
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52441
781802df7a2bfe224ef17596d56cf83c49517655 Olivier Certner 2025-09-08 17:37:35
g_part: Replace some spaces with tabs to match the rest of this struct
Reviewed by:  imp
Differential Revision: https://reviews.freebsd.org/D52907
a7d9c69fa903ad880f9dd36505f9d824f668283e Brad Davis 2025-10-04 20:38:57
kern: Don't need bsd.own.mk
Instead, replace it with bsd.init.mk and remove old comments about
FreeBSD 10.x compat. We used to need bsd.own.mk, but now can suffice
with bsd.init.mk since kern.opts.mk doesn't included that in too many
places.

Sponsored by:           Netflix
3faa5bfece73c62c2a3939e9b60365a899d16940 Warner Losh 2025-10-08 04:18:24
vm_object: Reset kvo_path on each iteration in vm_object_list_handler()
Otherwise we print a bogus path for anonymous objects.

Reviewed by:    kib
MFC after:      1 week
Sponsored by:   Modirum MDPay
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D52997
13d866b314f87df901c0a1cbbbc56d56ee0d7b7c Mark Johnston 2025-10-10 13:26:29
vm_object: Export the number of wired pages in vm_object_list_handler()
Reviewed by:  alc, kib
MFC after:      1 week
Sponsored by:   Modirum MDPay
Sponsored by:   Klara, Inc.
Differential Revision:  https://reviews.freebsd.org/D53008
ffca0c44ffe84352f6fdd24862c070d348d783d4 Mark Johnston 2025-10-10 13:26:50

Build system

release: Set INSTALL_AS_USER=yes when running pkg clean in NO_ROOT mode
Otherwise pkg complains about unexpected ownership of the root
directory.

MFC after:      1 day
Fixes:          https://cgit.freebsd.org/src/commit/?id=86221f965c06 ("vmimage.subr: Fix NO_ROOT build in ..._rmcache")
5fda4690b4a1b471331ff819c372ac2476b60ab2 Mark Johnston 2025-10-04 12:48:46
release: packages: Fix grammar in pkg description
Reported by:  ivy
Approved by:    emaste (mentor)
MFC after:      1 hour
Differential Revision:  https://reviews.freebsd.org/D52917
893c3b857e6059f25865fefab93b323c8e345877 Jose Luis Duran 2025-10-06 12:48:00
build: don't create duplicate bootstrap-tools targets
The general problem is that we might have a somewhat complicated
dependency tree depending on bootstrap version requirements.  We could
document when multiple bootstrap tools might have a shared dependency
and be careful to add them only once to the list, but that is a little
more fragile- particularly if we purge some bootstrap tools and need to
re-work the logic a little bit.

Just avoid redefining the build commands as we're iterating over the
list so that we can keep the actual requirements intact.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289997
Reported by:    dhw, others
Reviewed by:    imp
Fixes:  https://cgit.freebsd.org/src/commit/?id=151bd3516b5 ("flua: support our flua modules in [...]")
Differential Revision:  https://reviews.freebsd.org/D52904
ab492c08fc3cbf4fb5d569663c0751bc2a41cb1f Kyle Evans 2025-10-06 17:50:22
EC2: Include LLDB in small and builder AMIs
I excluded lldb from the "small" and "builder" flavours of EC2 AMIs
because on FreeBSD 14.x the lldb binary was 100 MB, as a result of
statically linking in lots of LLVM code; but we now have libprivatellvm
as a shared library and lldb is much smaller so there's no significant
benefit to excluding it.

Reviewed by:    ivy
MFC after:      3 days
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D52921
2b6c5f041f29523acd34c2a107772f04e3d1f6b3 Colin Percival 2025-10-06 05:11:34
Commit group #3: release: Rework VM package selection using sets
release: Rework VM package selection using sets

Filtering the list of packages broke with the introduction of package
sets, since we excluded FreeBSD-src.* but still included
FreeBSD-set-src, which transitively included the FreeBSD-src and
FreeBSD-src-sys packages.  This could be fixed by excluding package
sets, but that would be fragile, potentially breaking upgrades if
new packages are introduced.

Instead, start with an explicit set of package sets:
        base, base-dbg
        lib32, lib32-dbg
        kernels, kernels-dbg
        tests
and filter the package sets; the EC2 "small" and "builder" AMIs
filter out everything except "base" and "kernels".

Note that using FreeBSD-set-kernels may pose a problem in the future
if we start shipping packages for multiple differently-configured
kernels.  That will be addressed if and when that problem arises.

Reviewed by:    ivy
MFC after:      3 days
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D52922
2d184465e8bb77d4620f509b04f19ea22656f28e Colin Percival 2025-10-06 05:25:08

release: Don't install missing lib32 into VMs

There is no FreeBSD-set-lib32 on riscv64 or powerpc64le.

Reviewed by:    ivy, emaste
Fixes: https://cgit.freebsd.org/src/commit/?id=2d184465e8bb ("release: Rework VM package selection using sets")
MFC after:      6 hours
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D52987
0dc634d48fcca9e88c3fb12cdffab4ddbc657f99 Colin Percival 2025-10-09 06:13:03
release: Fix pkgbase tarball names on FTP site
These need to have names like
  FreeBSD-15.0-ALPHA5-amd64-pkgbase-repo.tar
not just "pkgbase-repo.tar".

Fixes: https://cgit.freebsd.org/src/commit/?id=d0ff67db2908 ("release: Publish pkgbase-repo.tar")
MFC after:      3 days
Sponsored by:   https://www.patreon.com/cperciva
c943e6ff9ab0ce823e8ac51a6a17789a1945925f Colin Percival 2025-10-06 21:33:06
ncurses: Move to the minimal set
MFC after:    1 day
Reviewed by:    bapt
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52950
ecaf90ee03bccc14f7628c1e87ac18e29064c079 Lexi Winter 2025-10-08 03:21:25
Makefile: Force DISTDIR=/ for (update-)packages
The make(1) variable DISTDIR is used by both ports and src with a
different meaning.  Some users may set DISTDIR in /etc/make.conf
for ports, which previously worked fine when building src since
the src targets which used this variable were not very commonly
used (mainly, make distributeworld).

Unfortunately, with pkgbase becoming the default, this is no longer
true since make (update-)packages invokes make stageworld, which is
sensitive to DISTDIR, and these users find that their build now fails.

A correct fix for this probably requires renaming one or both of
the DISTDIR variables, but for now, work around the problem by
setting DISTDIR=/ for the user-facing pkgbase targets, packages
and update-package.  Since setting DISTDIR doesn't work for these
targets anyway, this should not break any existing configurations.

MFC after:      1 week
PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290010
Reported by:    Oleh Vinichenko <moonlapse81@gmail.com>
Reviewed by:    imp, bapt
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52929
f7dc7d7af3683836fcca68018a678b242d2e2620 Lexi Winter 2025-10-08 03:22:32
libpkgecc: Remove -ffreestanding
This incorporates pkg(8) commit a31c8c3682a3 for consistency.

https://github.com/freebsd/pkg/commit/a31c8c3682a3

MFC after:      1 day
Reviewed by:    kevans
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52920
349f4fd3827e085c1aa8572e7e5276a642077c48 Lexi Winter 2025-10-08 03:23:32
packages: Set dependency origin in generate-ucl.lua
Commit 822fd5606748 changed the origin of packages from "base"
to "base/<package name>", but the old origin was still used for
dependencies.

Aside from being wrong, this confuses pkg <= 2.3.1 and causes
"pkg info -d" to show the dependencies as "<pkgname>-(null)"
instead of the correct version string.

Remove the explicit origin from dependencies in the UCL files,
and instead populate this during the build in generate-ucl.lua.
In the (very unlikely) case that an explicit origin is still
needed, don't overwrite one if it's already present.

MFC after:      1 day
Fixes: https://cgit.freebsd.org/src/commit/?id=822fd5606748 ("pkgbase: set origin for each packages as base/FreeBSD-*")
Reported by:    bapt
Reviewed by:    cperciva, bapt
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52892
a507a7026c402a4c10902f3aadb3c6a70c442964 Lexi Winter 2025-10-08 03:24:25
generate-ucl.lua: Add missing copyright header
Add a standard BSD license with a copyright claim for everyone who has
modified this file since it was added, excluding users who explicitly
declined attribution.

MFC after:      3 days
Reviewed by:    ifreund_freebsdfoundation.org, imp, bapt, markj, emaste
Differential Revision:  https://reviews.freebsd.org/D52881
a6ac2c98c9cb22a4a2efc12cafce2d2ba82b3fdc Lexi Winter 2025-10-08 03:25:24
release: Fix dependency ordering
The 'make release' command triggers some sub-builds, in particular
'real-release' (which builds install images) and 'vm-release' (which
builds VM images).  These both now depend on pkgbase-repo.

Unfortunately for historical reasons 'make real-release' has used a
recursive make instead of proper make dependencies; this results in
the pkgbase-repo target being invoked twice since the recursive make
does not have any awareness of the targets being run by the parent
make command.  Since the pkgbase-repo target starts by creating the
pkgbase-repo directory, the second make command incorrectly assumes
that target has already been built; this showed up in 15.0-ALPHA5
builds with pkgbase-repo.tar being empty as it was created after the
pkgbase-repo directory was created by before that directory had been
populated.

Change
real-release:
        make obj
        make ${RELEASE_TARGETS}
to a single line
real-release: obj .WAIT ${RELEASE_TARGETS}
in order to handle dependency deduplication properly while keeping
the intended behaviour that "obj" completes before ${RELEASE_TARGETS}.

Diagnosed by:   jrtc27, emaste
Reviewed by:    emaste
MFC after:      1 day
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D52972
b6f69c39999bfb85af262363b4fe22edc80027d7 Colin Percival 2025-10-07 20:48:06
bsd.confs.mk: Support CONFGROUPS.yes
Align CONFGROUPS with other options like SUBDIRS and FILESGROUPS by
supporting the CONFGROUPS.yes option.  This means logic like this:

.if ${MK_FOO} != "no"
CONFGROUPS+= FOO
.endif

can be replaced by:

CONFGROUPS.${MK_FOO}+= FOO

MFC after:      1 week
Reviewed by:    imp
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52923
0f5ed3c427fff845797c2af2aeceb5855f32a4f4 Lexi Winter 2025-10-08 06:07:10
libexec/rc/rc.d/Makefile: Use CONFGROUPS.yes
Replace .if statements with CONFGROUPS.${MK_FOO} where possible,
and also sort and re-indent the file for readability.

A couple of more complicated sections don't work with CONFGROUPS.yes
yet, so leave those as they are for now.

MFC after:      1 week
Reviewed by:    imp
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D52974
56f9879c3dd8fb9cd82fb7bc33e1acf5f8b578ff Lexi Winter 2025-10-08 06:08:31
generate-set-ucl.lua: Add missing copyright header
This file was derived from generate-ucl.lua, so copy the existing
header.

MFC after:      3 days
c8f9a9abd8000a8514e0beee99ffcf48d05ce47b Lexi Winter 2025-10-08 06:50:03
tools/build: Bring in stdckdint.h if needed
This is needed when bootstrapping libc, reallocarray.c and
recallocarray.c include stdckdint.h now.

Reviewed by:    emaste
Fixes:  https://cgit.freebsd.org/src/commit/?id=7233893e9496 ("lib{c,openbsd}: use ckd_mul() for overflow checking in re(c)allocarray")
Differential Revision:  https://reviews.freebsd.org/D52932
687cb66411c7bc220ccb90cedc2f7486567d55b6 Mark Johnston 2025-10-07 13:53:54
cross-build: Define __GNUC_PREREQ__ in cdefs.h
This is required when including stdckdint.h and doesn't seem to be
provided by older clang.

Reviewed by:    emaste
Fixes:  https://cgit.freebsd.org/src/commit/?id=7233893e9496 ("lib{c,openbsd}: use ckd_mul() for overflow checking in re(c)allocarray")
Differential Revision:  https://reviews.freebsd.org/D52933
53ab85a55408562690f58788ea8d01c18b79ef5d Mark Johnston 2025-10-08 12:49:28
release: Avoid generating .pkgsave files in OCI images
This also installs the pkg key from the current source tree instead of
using the one currently installed on the host.

Reviewed by:            dch
MFC after:              1 day
Differential Revision:  https://reviews.freebsd.org/D52615
e21e6e96b662dcbb2f0e37ab356c9dded62a586e Doug Rabson 2025-05-28 13:32:36
release/RPI: Add RPI Zero 2W device tree blob dtb
Enable Pi 02W support on the release SD card images by including the
device tree.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278816
MFC after:      3 days
Approved by:    cperciva (re)
e41e099ef199de096abd9a93289bdacfd83a5f48 Yoshiro MIHIRA 2025-10-06 07:54:08
kern: Remove needless kern.opts.mk
We don't need kern.opts.mk in any of these places. None of these
Makefiles reference any MK_ options. Some don't even need SYSDIR,
but leave that defined in the ones that do.

Sponsored by:           Netflix
8e985774117d49eb968789aba8550c2a92992a9a Warner Losh 2025-10-08 04:17:18
modules: Simplify some expressions
When we only use SYSDIR once or twice, expand it and don't define
it. Minor other consistency changes.

Sponsored by:           Netflix
498368529011086067ed48e40cbfd46a4d5ef2ca Warner Losh 2025-10-08 04:41:03
release: switch OCI containers to use pkg sets
use minimal-jail in no-toolchain

MFC after:      1 hour

Reviewed by:    ivy
Sponsored by:   SkunkWerks, GmbH
Differential Revision:  https://reviews.freebsd.org/D53014
a5b19a0cb9c4321ef45f920a6fc0394449e64779 Dave Cottlehuber 2025-10-10 15:51:20
build: fix ordering of pkgbase targets to get a dtb package reliably
dtb.plist is generated by mtree-to-plist when it processes the kernel
metalog, so we shouldn't try to create dtb packages until that's been
done.  Add another level of indirection to the create-kernel-packages
target to organize all of the kernel flavors under a single target that
is ordered before the create-dtb-packages target.

Note that we may later refine these targets after further pkgbase
review; this is simply a maybe-final stop-gap that's been tested to
fix a known problem.

MFC after:      37 seconds (pkgbase fix for 15.0 builds)
Reviewed and tested by: cperciva
Differential Revision:  https://reviews.freebsd.org/D53017
a29cf898b09c4d4906f92fd2982410c9f5935f6c Kyle Evans 2025-10-10 17:37:51
sockstat: Fix build reproducibility
Both usr.bin/sockstat and usr.bin/sockstat/tests build the file
src/usr.bin/sockstat/sockstat.c.  Unfortunately, they place the
resulting object file in the same place, but produce different
files due to paths appearing in the .debug files; this results
in different binaries depending on how the race between the two
builds ends.

Use .PATH to tell make to find sockstat.c in the parent directory
but place the object file in the current object directory, rather
than placing '..' into the name of the source file.

Suggested by:   bdrewery, emaste, jrtc27
MFC after:      5 minutes (15.0 build fix)
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D53032
9934558460e4e73e5b55648c4b13a702f4f019d7 Colin Percival 2025-10-10 20:13:58
vmimage.subr: metalog_add generated databases
The files /etc/login.conf.db, /etc/passwd, /etc/pwd.db, /etc/spwd.db,
and /var/db/services.db are generated at install time.  When VM images
are built using installworld, there is Makefile code which emits the
necessary METALOG lines; but the pkgbase triggers do not do this.  This
resulted in VM images which lacked these essential database files.

VM images are currently the only place where this matters, since this
issue is specific to non-root image builds uusing pkgbase.  (In some
point in the future we will start building release ISO iamges from
pkgbase, at which point it will be a problem there as well.)

The long-term solution for this is probably to teach the relevant
database-creating tools to emit METALOG lines; but for now, just log
the necessary files from vmimage.subr.

Reviewed by:    dch
MFC after:      5 minutes
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D53034
6081365c27e68707ad25c98159e364ee90fcf5db Colin Percival 2025-10-10 22:01:38
Commit group #4: EC2: metalog_add missing files from packages
EC2: metalog_add missing files from packages

The files
        /usr/local/etc/dhclient.conf
        /usr/local/etc/ssl/cert.pem
are created in EC2 images by installed packages, but are not being
registered in METALOG.  The reason for this is not immediately clear,
but may be related to the handling of "sample" files.

Reviewed by:    dch
MFC after:      5 minutes
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D53035
2b0ffc0ee48cf6c70506dc479e0fd2166f9de1ab Colin Percival 2025-10-10 22:08:32

EC2: Fix additional files on small+builder AMIs

The file /usr/local/etc/ssl/cert.pem is not present on "small" and
"builder" AMIs, so we don't need to add it to METALOG.

Fixes:  https://cgit.freebsd.org/src/commit/?id=2b0ffc0ee48c ("EC2: metalog_add missing files from packages")
MFC after:      3 days
Sponsored by:   https://www.patreon.com/cperciva
8a7ac88aa3991e8c2c19007ac0c36a92fc94bc2d Colin Percival 2025-10-11 17:35:51
release: Remove errant .endfor
This didn't show up in testing on main or stable/15 because it only
applies for "release" (BETA and onwards) builds.

Fixes:  https://cgit.freebsd.org/src/commit/?id=afdc022deb91 ("release: Publish pkgbase-repo.tar")
MFC after:      30 seconds
Sponsored by:   https://www.patreon.com/cperciva
474ae083b1e19588c1bc2974082d2810ef9dc7f9 Colin Percival 2025-10-11 04:10:08
mit-krb5.pc: Add missing -lkrb5profile
Fixes the ports that prefer static linking:
https://reviews.freebsd.org/D49277

Reviewed by:    ivy, dch, cy
Sponsored by:   SkunkWerks, GmbH
Differential Revision:  https://reviews.freebsd.org/D52910
2d9fd2c573c318754e3f36d2549e0e57ce199d60 Igor Ostapenko 2025-10-11 10:20:44
libbluetooth: Move to the bluetooth-lib package
Move the library, but not any of the runtime.  This allows executables
to link against libbluetooth without having to pull in the entire BT
stack.

MFC after:      3 days
Reviewed by:    dch, emaste
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53016
426891e0f8f1cfae0263ba81ea55f46c547d7762 Lexi Winter 2025-10-12 15:28:20
virtual_oss: Move plugins to the sound package
This is the correct place for them, and also issues an incorrect
dependency from utilities to sound.

Fixes:  https://cgit.freebsd.org/src/commit/?id=1b806e607f52 ("packages: Add a sound package")
MFC after:      3 days
Reviewed by:    christos, dch
Sponsored by:   https://www.patreon.com/bsdivy
Differential Revision:  https://reviews.freebsd.org/D53015
419dcdc2c981306b0ded44580977d2e053719b14 Lexi Winter 2025-10-12 15:29:17
vmimage.subr: Sort METALOG before running makefs
When creating VM images from pkgbase, the METALOG may not be in order;
in particular, files may be listed before the directories which contain
them.  This causes makefs to create directories with 000 permissions.

Interestingly, such VM images boot just fine, since root ignores those
permissions; the first sign of trouble was sshd refusing logins with an
error message which said absolutely nothing about /etc/ having
incorrect permissions or being unable to read files inside it.

Immediately prior to running makefs, sort the METALOG file.  While
we're here, uniquify as well; this does not guarantee that we do not
have duplicate paths, but if there are duplicate paths with different
settings something else has gone wrong and we don't really have any
good way of solving the problem anyway.

Reviewed by:    ivy
Hint from:      imp
MFC after:      3 days
Sponsored by:   https://www.patreon.com/cperciva
Differential Revision:  https://reviews.freebsd.org/D53046
0cc81b375ea43c7e853b109d00c72c8c3b3df993 Colin Percival 2025-10-12 04:32:29

Internal organizational stuff

-- no commits in this category this week --

Testing

tail: Tweak follow_rename test case
Add a brief sleep to give tail time to start following the file before
we rename it.

MFC after:      1 week
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D52887
a9c72543d287afa8dd30bec0f49873e88057c192 Dag-Erling Smørgrav 2025-10-07 16:23:18
cp: Simplify sameness checks
Sponsored by: Klara, Inc.
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D52926
95de78614a57733807c28c05125ed0636309d88b Dag-Erling Smørgrav 2025-10-07 16:23:39
ln: Simplify sameness checks
Sponsored by: Klara, Inc.
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D52927
18997fb9eca651a7ef13e6755a4d2cdd3ddede10 Dag-Erling Smørgrav 2025-10-07 16:23:43
tarfs: Simplify sameness checks
Sponsored by: Klara, Inc.
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D52928
1b0fce2944e3ff570b11de05c6a03977ee5b95e6 Dag-Erling Smørgrav 2025-10-07 16:23:48
tests/netinet: fix so_reuseport_lb_test flakyness
Stop the threads before exiting test body.  Otherwise there is a chance
threads would use the softc that is stored on the main thread stack after
it is destroyed and the test would fail.  Stop the threads in the reverse
order, so that listener is stopped after all connectors are stopped.

Tested by:      olivier
d9c94e5eefc0d1ed772cc3af15d92f1960ba73a6 Gleb Smirnoff 2025-10-07 21:02:29
tests/aio: Add support for larger max_buf_aio to vectored_big_iovcnt test
Fix a test failure that occurs when max_buf_aio exceeds 31, as the
calculated buffer size exceeds the 16 KB memory disk device. Increase
the MD device size to 1 MB to prevent truncation.

Rename MD_LEN to DEVICE_IO_LEN for clarity and add a more
descriptive error message.

Reviewed by:    asomers
Approved by:    asomers
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D52914
2e09ec72417c6c2927185f4d63faea9ac7926c2b Olivier Cochard 2025-10-07 21:45:35
tests/mac_portacl: restore sysctls after modification
While here, use 'required_kmods' instead of ad-hoc
checks.

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>

Reviewed by:    markj
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1855
170aac93479467334062813c1175a80200400b79 Siva Mahadevan 2025-07-15 16:45:24
tests/mac_ipacl: restore sysctls after modification
While here, use 'required_kmods' instead of ad-hoc
checks.

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>

Reviewed by:    markj
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull request:   https://github.com/freebsd/freebsd-src/pull/1856
79042fd7ed4187d2a74e37618f6fd77f448ca353 Siva Mahadevan 2025-07-15 16:45:24
cryptocheck: Be friendlier when testing software crypto backends
- Fail loudly if we can't change the kern.crypto.allow_soft sysctl.
- Add more drivers to the list.

MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D52490
e63bf6aa523eb9a865b7ce34d01e75a13818b367 Mark Johnston 2025-10-08 15:24:12
Commit group #5: pf tests
pf tests: make syncookie:loopback more robust

Give the background nc process a bit of time to start before we attempt to
connect to it.

Sponsored by:   Rubicon Communications, LLC ("Netgate")
98c1bf371c5dd613646f53fdc4796c366104f844 Kristof Provost 2025-10-08 07:56:24

pf tests: give inetd some time to start

Give inetd time to start rather than immediately trying to connect to it.
Make the tests a little more robust.

Sponsored by:   Rubicon Communications, LLC ("Netgate")
c700393934285ea84696a17bd951b20e439edfc3 Kristof Provost 2025-10-09 07:28:28

pf tests: give rules_counter:4G more time

Sponsored by:   Rubicon Communications, LLC ("Netgate")
8217075f9ecb12fa9a4cf746541b9d3e1dc57e79 Kristof Provost 2025-10-09 07:29:14
pf tests: add missing atf_test_case lines for nat tests
The lack of these lines means we don't call the cleanup function.
That's not as bad as it could be, because these tests are nested in a jail by
Kyua, so most of the cleanup work (destroying jails and interfaces) is done when
the parent jail goes away, but it's still better to have these lines.

Sponsored by:   Rubicon Communications, LLC ("Netgate")
8a6bfa0455bfd4b77cb71d229b9dfca031b6703f Kristof Provost 2025-10-10 15:12:36
pf tests: verify checksum offload handling
Disable epair's checksum offload on one interface in a nat test, to ensure
that pf does the right thing in scenarios where one interface offloads checksum
handling and one does not.

We trust the TCP (or ICMP) checksum verification code to drop the packet if pf
does it wrong, which will cause the test case to fail.

Suggested by:   tuexen
Sponsored by:   Rubicon Communications, LLC ("Netgate")
1735d66a9c5b08b59a0323d3825d2e7dacd13064 Kristof Provost 2025-10-10 15:43:28

Style, typos, and comments

These could go in other categories, but it's more clear if they're here instead.

nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB
Reviewed by:  des
Approved by:    emaste (mentor)
Fixes:  https://cgit.freebsd.org/src/commit/?id=6c5cdba1bafe ("Add nss_tacplus, a TACACS+ NSS module.")
MFC after:      1 day
Differential Revision:  https://reviews.freebsd.org/D52882
75f7e003b79d4a1d1cad77cc7bbe2ccb96435cd5 Jose Luis Duran 2025-10-06 12:54:05
tcp: remove stray ;
No functional change intended.

MFC after:              3 days
Sponsored by:           Netflix, Inc.
941b8ecdc08749eeec1b88aac0442dad8cb8fb09 Michael Tuexen 2025-10-06 14:32:08
nullfs: Fix some style after recent changes
In 'nullfs_subr.c':
- Sort the headers.
- Use '__func__' in preference to the function's name in an assertion.

This applies comments from D38761, one of which was missed and the other
added too late.

Reviewed by:    kib
MFC with:       249ec85352b5 ("nullfs: smr-protected hash lookup")
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D52935
c8141e273a3eaf2f3fa05e9e5c2407c9538dd8f8 Olivier Certner 2025-10-06 12:48:24
tcp: remove stray ;
MFC after:    3 days
Sponsored by:   Netflix, Inc.
0faa9ca827a5e91273ba757bd87bd9e8179a0862 Michael Tuexen 2025-10-06 21:34:38
release/packages/ucl: Fix typos
MFC after:    3 days
Sponsored by:   https://www.patreon.com/bsdivy
039eba16f969a3ebc6c169fa61880a33d2a95090 Lexi Winter 2025-10-12 15:53:43

Contrib code

Commit group #6: unbound: Vendor import 1.24.0
unbound: Vendor import 1.24.0

Release notes at
        https://nlnetlabs.nl/news/2025/Sep/18/unbound-1.24.0-released/

MFC after:      1 week

Merge commit '0064eb9cf1c8d526e87d3149249445d4bc8d0248'
b2efd602aea8b3cbc3fb215b9611946d04fceb10 Cy Schubert 2025-10-07 13:58:59

local-unbound-setup: Set so-sndbuf to 0

Without this setting, Unbound 1.24.0 and newer will attempt to set the
socket buffer size to 4 MB to mitigate issues that mostly affect servers
with large numbers of clients on local networks, which is not a scenario
local-unbound is intended for.  This is not only a waste of resources,
it can also fail, resulting in a warning message on daemon startup.

Fixes:          https://cgit.freebsd.org/src/commit/?id=b2efd602aea8 ("unbound: Vendor import 1.24.0")
Reviewed by:    jlduran, cy
Differential Revision:  https://reviews.freebsd.org/D52977
de3faa85d8f99d260cbfa6242dd8e4ece693e4f8 Dag-Erling Smørgrav 2025-10-08 16:45:02
crypto/openssl: update generated files to match 3.5.4 artifacts
MFC with:     046c625e9382
Fixes:          https://cgit.freebsd.org/src/commit/?id=046c625e9382 ("crypto/openssl: update to 3.5.4")
Reported by:    Herbert J. Skuhra <herbert@gojira.at>
d4033e6d37747f5213bb245c8e605406703a8766 Enji Cooper 2025-10-07 23:14:13
contrib/bsddialog: Import version 1.0.5
Version for change and feature requests.

* Improve documentation for --alternate-screen and --normal-screen.
  Request: https://bugs.freebsd.org/285459. (This PR is not about
  bsddialog itself but is used as an example for an official FreeBSD
  documentation request.)

* Reduce the number of screen refreshes to improve performance over a
  115200 UART connection.
  Request: https://gitlab.com/alfix/bsddialog/-/issues/8.

* Change textbox buttons to return distinct values (previously always
  returned OK).
  Request: https://reviews.freebsd.org/D48668; already committed in
  contrib/ 96a241a35905078bdc5d20bf25943cdb67758dea

* Change forms navigation key behavior for ENTER and TAB.
  Request: https://bugs.freebsd.org/287592.

Refer to /usr/src/contrib/bsddialog/CHANGELOG to know more.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287592
Reported by:    adrian
Sponsored by:   The FreeBSD Foundation

Merge commit '653f765f05b8c7e3908ae92e9bf61522a50cefc9' into YYY
3e42d7194bdcd4fbfd781518258f919d6ac803d3 Alfonso S. Siciliano 2025-10-09 15:39:10
kyua: Make "test" command actually report about workdir cleanup issues
Reviewed by:  ngie
MFC after:      1 month
Differential Revision:  https://reviews.freebsd.org/D51136
21716b6c3ed6e28fe5cc14ee3ffe93f44c458b09 Igor Ostapenko 2025-10-11 13:14:16
MFV: Import blocklist 2025-04-28 (8aa81bf)
Merge commit '70f30afd4e9af5a51ee324d97e4d8c5f2124ec15'

Breaking changes:

- Upstream commit 24932b6 ("blocklistd: log the conf file line number
  with bad protocol errors") breaks backward database compatibility.
  An error will be displayed:
      Key size mismatch 296 != 288
  A new and compatible database, with the new name, will be created when the
  service starts (committed separately).

- Upstream commit ddf6d71 ("implement BLOCKLIST_BAD_USER as a
  "one-count" failure") introduced BLOCKLIST_BAD_USER with a one-count
  failure mechanism.  BLOCKLIST_AUTH_FAIL was implemented with a
  two-count failure mechanism.  Since we utilize BLOCKLIST_AUTH_FAIL, the
  number of failed attempts now doubles towards the maximum limit
  (nfails).  This commit will be reverted separately.

Changes:

https://github.com/zoulasc/blocklist/compare/7093cd9...8aa81bf

Approved by:    emaste (mentor)
MFC after:      2 days
Differential Revision:  https://reviews.freebsd.org/D52869
48e64ca13d4f36795ac718911b805e3e9a726f1b Jose Luis Duran 2025-10-12 17:01:03
blocklist: Revert upstream commit ddf6d71
Upstream commit ddf6d71 ("implement BLOCKLIST_BAD_USER as a "one-count"
failure") introduced BLOCKLIST_BAD_USER with a one-count failure
mechanism.  BLOCKLIST_AUTH_FAIL was implemented with a two-count failure
mechanism.  Since we have been utilizing BLOCKLIST_AUTH_FAIL, the number
of failed attempts now doubles towards the maximum limit (nfails),
giving system administrators the impression that the number of failed
authentication attempts is inaccurate.

Revert this commit until a consensus has been reached.  We do not want
to introduce yet another breaking change with the renaming of the
library.

Approved by:    emaste (mentor)
MFC after:      2 days
4d56eb007b18881becb2107f87bd2a7edca3e6bf Jose Luis Duran 2025-10-11 14:15:03
blocklist: Rename blacklist to blocklist
Follow up upstream rename from blacklist to blocklist.

- Old names and rc scripts are still valid, but emitting an ugly warning
- Old firewall rules and anchor names should work, but emitting an ugly
  warning
- Old MK_BLACKLIST* knobs are wired to the new ones

Although care has been taken not to break current configurations, this
is a large patch containing mostly duplicated code.  If issues arise, it
will be swiftly reverted.

Reviewed by:    ivy (pkgbase)
Approved by:    emaste (mentor)
MFC after:      2 days
Relnotes:       yes
7238317403b95a8e35cf0bc7cd66fbd78ecbe521 Jose Luis Duran 2025-10-12 17:14:27
blocklist-helper: Silence a bogus pf warning
Silence a bogus warning about (an ethernet) anchor not being found.

It has been reported as PR 280516.  In the meantime, just sweep under
the carpet.

Approved by:    emaste (mentor)
MFC after:      2 days
2347ca21d657121670e6e7246c6ac32efc996cac Jose Luis Duran 2025-10-12 17:16:12

Reverted commits

Commit & revert pair: cam/iosched: Initialize max_lat
cam/iosched: Initialize max_lat

Sponsored by:           Netflix
ce89c8f47a91f76b2fdeb1fdb504fd637ce93047 Warner Losh 2025-10-07 22:20:14

Revert "cam/iosched: Initialize max_lat"

This reverts commit ce89c8f47a91f76b2fdeb1fdb504fd637ce93047.

There's other parts to this, and GENERIC doesn't include iosched so
I missed that. Back out while I gather them together.

Sponsored by:           Netflix
86becbd8c1ce4393f4e35a9fa6b0e8308f500396 Warner Losh 2025-10-07 23:57:21
zfs: Revert "tunables: remove legacy FreeBSD aliases"
As of commit 87a7b35f04b6 ("bsdinstall: fix vfs.zfs.vdev.min_auto_ashift
oid") the installer uses the current vfs.zfs.vdev.min_auto_ashift sysctl
name, but there are many systems with configurations referring to the
legacy vfs.zfs.min_auto_ashift sysctl.  For now, restore the aliases.

This reverts commit ced72fdd69f27b54cf592351a36660cd9fd7dbd3.

PR:             https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266374
Reviewed by:    mm
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52660
a28b44ddc3484fcf02420543a223053404a2bfce Ed Maste 2025-09-21 14:46:22

Unclassified commits

Not classified automatically, and waiting for manual attention.

-- no commits in this category this week --

Technical notes

Dates:

Automatic grouping:

Automatic categories:

Source code:


Generated with commits-periodical 0.18 at 2025-10-20 20:27:07+00:00.

This work is supported by Tarsnap Backup Inc.

Alternate version: 2025-10-06 (debug) (contains info about the classification)